- 12 Jan, 2021 40 commits
-
-
Matt Falkenhagen authored
Bug: 1138155 Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842305}
-
Austin Tankiang authored
Bug: 1160998 Change-Id: Ib08b57c71eb7e36517cd4e8e8c22877256ddd3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620924Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#842304}
-
Jarryd authored
* Implement new testing actions: - |add_policy_app_internal_tabbed| - |remove_policy_app| - |list_apps_internal| - |assert_app_not_in_list| * Reorder testing action implementations lexicographically * Rename ExecutePwaInstallIcon() to InstallOmniboxOrMenu() Change-Id: I167b4b00b4028f31702813a611d5616f7bc6c040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598638 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#842303}
-
Meilin Wang authored
Introduces |ConversationController| (and its proxy) as a sub controller responsible for handling conversations between our Assistant service and Libassistant. Adds its first mojom API |SendTextQuery()| which sends a text query to Libassistant upon called. Bug: b/171748795 Change-Id: I9b86f9323c4e34ebce6fe78bfda487ad81d1f87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545648 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#842302}
-
Michael Crouse authored
BUG: 1165517 Change-Id: I878bad081f44e7c258e009357aabe0d09df046fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623528 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842301}
-
Yoichi Osato authored
This reverts commit 9a33bf90. Reason for revert: IOS build failure https://ci.chromium.org/ui/p/chromium/builders/ci/ios-simulator/61201/overview Original change's description: > Componentize OptimizationHintsComponentInstaller for reuse on iOS > > This also makes the component available on incognito (which was an > oversight in previous support to have optimization hints be in incognito) > > Bug: 1154790 > Change-Id: I97a427d5af0f94fa0b5282032b8cef6ce754c81d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617866 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842267} TBR=sky@chromium.org,waffles@chromium.org,sophiechang@chromium.org,robertogden@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iedea25977fe6265e6141dbdd198efa39f7943694 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623349Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842300}
-
James Cook authored
This reverts commit 93b71b38. Reason for revert: Broke linux-lacros-tester-rel https://bugs.chromium.org/p/chromium/issues/detail?id=1165468 [destroyed object]: error 1: popup parent not constructed [18388:18388:0111/155132.274317:FATAL:chrome_browser_main_extra_parts_ozone.cc(38)] Wayland protocol error. Original change's description: > lacros: Re-enable most ContextMenuBrowserTest tests > > Only two fail. The failures are related to multiple profiles, not > context menus in general. > > Bug: 1150200 > Change-Id: I40c9fa722d3e888d77a31e0155afdaf6c4154369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622574 > Auto-Submit: James Cook <jamescook@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842179} TBR=jamescook@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0923409686a5595c0bfe7125f7dab82e24a5f632 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623425Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#842299}
-
Alex Newcomer authored
PM wants these to measure usefulness of clipboard history. More consecutive copies or pastes should mean users are using multipaste more. Bug: 1145445 Change-Id: I4d6cecb618e8e95f9438a44e8824aa23fbc5e89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613350 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842298}
-
Tarun Bansal authored
This experiment is no longer being worked on. See http://shortn/_YTSn6Rpl6W for more details. Change-Id: I0fd921cc62b518f6a142402389a6b8b9748b2fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611836Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842297}
-
Nancy Wang authored
in CL:2556904, OnWindowDestroying is used by the WM to save the window info. So FullRestoreSaveHandler should not use OnWindowDestroying to delete the window from the restore data. So modify the interface to use OnWindowDestroyed to delete the window from the restore data. BUG=1146900 Change-Id: I824e216a898c6c28bf6cdae044e0a8fba7079a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622354Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842296}
-
Rahul Arakeri authored
This CL fixes a CHECK failure with a base::Optional type. After the CL crrev.com/c/2553869 was landed, it exposed a pre-existing product bug (crbug.com/1164008) and that led to an increase in crashes in cc::ScrollOffsetAnimationCurve::UpdateTarget. Problem: In ScrollOffsetAnimationCurve::EaseInOutBoundedSegmentDuration the variable duration_behavior_ gets referenced. This variable did not have any value assigned to it and hence causes the crash. Why it did not fail before: Before the CL 2553869 landed, the logical flow was different. As in, if the animation_type_ (in UpdateTarget) was kEaseInOut, the new_duration would've been calculated by calling EaseInOutBoundedSegmentDuration. This is the only function that references the base::Optional value (duration_behavior_). All other animation types (kImpulse and kLinear) would've led to the function ImpulseSegmentDuration being called where duration_behavior_ was not referenced. In the crash dump, I observed that the animation_type_ was kLinear. This type does *not* have duration_behavior_ defined and UpdateTarget does *not* support kLinear animation_type_ and hence the crash. So in fact, UpdateTarget being called for a linear animation is the real issue here (and this issue is a pre-existing bug in the product). The CL 2553869 merely exposed it. Fix: I've added a bandaid solution where UpdateTarget simply returns if the animation_type_ is kLinear. Even after multiple tries, I was never able to repro the original bug (where UpdateTarget is called on linear animations). The original bug is tracked via crbug.com/1164008. Bug: 1158655 Change-Id: I0aca4870e8578de7690a6c4f8ee91f6786da1f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613934Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842295}
-
Robert Ogden authored
This is important for the text capture effort. Change-Id: I8eb15afe1bd18690dc61ed340e14ade0e42c26c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622810 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842294}
-
Sophie Chang authored
I'm also not entirely sure if DownloadService is available on iOS but a lot of the code is still reusable for iOS (CRX verification and what not) for it to move into components. Not moving PredictionModelDownloadClient for now since that is more Chrome-specific since it references the OptimizationGuideKeyedService directly and is registered with the Chrome- side DownloadServiceFactory Bug: 1154790 Change-Id: Ide3e38c63e92eec8a87ce92899d3e8c3d7f94161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617124Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842293}
-
minch authored
Bug: 1164980 Change-Id: Iadde28d35b316f811b2d60637dd27addc4525132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621747Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#842292}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/722b81ef1350..82b992a1656d 2021-01-11 ehmaldonado@google.com owners: Initialize db lazily. 2021-01-11 yuanjunh@google.com [cipd] Roll Led to a newer version 2021-01-11 chanli@chromium.org [dirmd] Roll dirmd to e338559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103287,chromium:1145959 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I262891861ebefff2c13033d61573ef89dc77625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842291}
-
Sergey Ulanov authored
Direct image compositing causes excessive memory usage. This change disabled the feature on low-end devices to save memory. Currently it's limited to OS_FUCHSIA to disable potential performance impact on other platforms. Bug: 1161327 Change-Id: I709895c6564aba79cfeb762e8fd6d698bde7795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601638Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842290}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4384.0-r1 to 89-4374.0-1610361443-benchmark-89.0.4385.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic007ce3725e52a65dcd442379db8ef699ef0fcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623249Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4384.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4385.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I02d1e0f12ef2e7a035030eadfbc0e5807b65c8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623472Reviewed-by:
-
Hiroshige Hayashizaki authored
- wpt/html/semantics/forms/the-input-element/selection-pointer test no longer exists. - virtual/web-components-v0-disabled/* was removed by https://chromium-review.googlesource.com/c/chromium/src/+/2454693. Bug: 1164553, 937746 Change-Id: I29bed2f3e8eb4da05e7d94e5059036a712ac4e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621957Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#842287}
-
rbpotter authored
This allows bundling of extension URL hosts by passing: chrome-extension://extensionid/ as the host to fully work (e.g., excluding local files from the bundle). Bug: 1163956 Change-Id: Ib467c61c1bb507872292376b3508a10f72d8f076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618561Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#842286}
-
Kenton Lam authored
On click, the group is set as active (with blue colour) and the emoji picker is scrolled to that group. Currently, the active group binding is only one way (i.e. scrolling the list of emoji manually will not change the active group button). Bug: 1152237 Change-Id: I9e847c541ceb3b2f32b9649dce2cd8bed30e7994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596733Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#842285}
-
Nancy Wang authored
BUG=1146900 Change-Id: I54b5bde1b7077d9137478a6f081a876fbd4baa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620350Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#842284}
-
Findit authored
This reverts commit d82af7a9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 842133 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q4MmFmN2E5ZWVmYzI1ZGRmMTI0ZmMxMjg0YTM3NmVkYzdmZGNmNWMM Sample Failed Build: https://ci.chromium.org/b/8858364635543817904 Sample Failed Step: ash_unittests Original change's description: > ambient: construct photo_controller on enabled > > AmbientPhotoController and AmbientPhotoCache are only necessary > when a user is logged in and ambient mode is enabled. Construct them > at that time, and destruct them if ambient mode is disabled. > > Schedule fetching backup images when AmbientPhotoController is > constructed, rather than in OnFirstSessionStarted. > > BUG=b:176094707 > TEST=ash_unittests --gtest_filter="AmbientControllerTest.*" > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Id87bb16e6d4cc14074dd9bdb352fb5795d0f8915 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605744 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842133} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=b:176094707 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ieccf27239a7fb618deb72fe6ebe9519462df7add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623527 Cr-Commit-Position: refs/heads/master@{#842283}
-
Toni Barzic authored
Handling button press may delete the button view, so referecing the hover button after button press callback is called is not safe. BUG=1142568 Change-Id: I4b062cfc1ca632bf590df7892b58592680a38ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618577 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#842282}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/79f0fe5f0ec1..b2230ba88f16 2021-01-11 heiserya@google.com Update mojo_connection_lacros_launcher.py path to reflect installed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: sadrul@google.com Change-Id: I8b9ec8df0b4ced04deb60390940d9ae04ad131ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623239Reviewed-by:
-
Victor Fei authored
Before this change, if we set modal="true" and role="dialog" for an AccessibleNode, the corresponding AXNode always has state modal="false". This CL fixes the above issue, by moving the logic of AXNodeObject::IsModal to AXObject so that AXVirtualObject can properly calculate dialog modal status. With this change if we set AccessibleNodes to be role="dialog" and modal="true", it now properly shows modal=true in the AXTree for the corresponding node. AX-Relnotes: n/a. Change-Id: I35e802887b7153b7d619718dc39f79a15d4cb809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619903 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842280}
-
Sara Kato authored
Bug: crbug.com/1159562 Change-Id: I6a7cf914b2f2b5c35afc5d4a48025a2aaef033c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612673Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842279}
-
Khushal authored
This was added for Pixel 4 rollout, to have a kill switch in case rendering at higher rates has any issues. The flag is not necessary anymore. R=boliu@chromium.org Change-Id: I4dc804fee6ab162cd7dd0f5186c7f7faef41ed3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622520 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842278}
-
ssid authored
Change-Id: I160ed2450bdc3b99e1ac7047a75e69928b8f679a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622893 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#842277}
-
Yuichiro Hanada authored
This is a reland of e73788df The original change was reverted due to the input lag. The root cause was fixed in Android side. Please also refer to go/cros-postmortem-input-lag Original change's description: > Enable ArcPreImeKeyEventSupport by default. > > Bug: b:148193316 > Test: tast run arc.PreImeKeyEvent > Change-Id: I8ba1437e5a94f3a251d9a7e658df2d995ddd3dec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391184 > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804664} Bug: b:148193316, b:174430314, chromium:1153410 Change-Id: Ic23006790fd4d5a26324acf4263616a55f383e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599683 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#842276}
-
Alan Ding authored
Provide chrome switch to disable GMS scheduling of MediaStore periodic indexing and corpora maintenance tasks. Used in performance tast to prevent running service during testing which can cause unstable results or CPU not idle pre-test failures. BUG=b:173906243 BUG=b:170071013 BUG=b:172010486 BUG=b:153866893 TEST=Used local build with https://crrev.com/c/2596242 to verify using 'getprop' that boot property is only available if chrome switch is set. Change-Id: I72704a9814061af172e5f9a892513e0f414d31a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597193 Commit-Queue: Alan Ding <alanding@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842275}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 2021-01-11 treehugger-gerrit@google.com Merge "tp: Add drop if exists for all metric table/views" 2021-01-11 lalitm@google.com tp: bump versions of trace processor and traceconv If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I08608f7dcb10f9e5272867d3fa1a536f9a54f4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623237Reviewed-by:
-
Pawel Pluciennik authored
Target "//content/shell:content_shell" added to deps blocked compiling content_browsertests sources. Bug: chromium:1164349 Change-Id: Id87106b2d3197c04d66fcb06e55d3421022249fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616226Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842273}
-
Dirk Pranke authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/0d67e272..595e3be7 595e3be7 Find python/python3 from dotfile entries Bug: chromium:1112471 Change-Id: Iaa80f88464845094a73f4e312b445dc32b963caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622896Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#842272}
-
Kenton Lam authored
A basic emoji_ordering.json was used for testing while we were waiting for emoji-metadata to be imported into third_party. Now that that is done, we can directly use the emoji ordering from there. Bug: 1152237 Change-Id: I70b58f2b6ebe712b3fad0fdb7a2a5ee2af466779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617409Reviewed-by:
-
Akihiro Ota authored
Consider the following scenario: Voice1.lang = "en-us" (all lower case) Voice2.lang = "en-US" (country code is upper case) Utterance.lang = "en-us" (all lower case) The user has set Voice2 as their preferred voice for English. The old code would choose voice1 as the best voice for the utterance because voice1.lang == utterance.lang. voice2.lang != utterance.lang because of the difference in casing. This was leading to issues in ChromeVox's voice switching behavior, where eSpeak was sometimes being used, even if the user had set Chrome OS US English as their preferred voice. The tangible effect of this change is that ChromeVox voice switching will respect the user's preferred voices. voices. --gtest_filter="TtsControllerTest.TestGetMatchingVoice"'. Also manually verify the bug no longer repros after the fix. Fixed: 1121592 AX-Relnotes: ChromeVox voice switching now respects the user's preferred Test: 'out/cros/content_unittests Change-Id: I0588b50fbbc4ee7f0b71741b2bb312c9d6d5b14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617511 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842270}
-
Phillis Tang authored
Remove |FeaturePromoBubbleView::GetBubbleBounds| override as it's not needed anymore. Change-Id: I0c8ebd04982889842494c7a85b68f902a0832b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622733 Commit-Queue: Phillis Tang <phillis@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#842269}
-
Elly Fong-Jones authored
This change has RootView::AnnounceText (which is what the other Views methods to announce text use) call the platform API on Mac, via AXPlatformNode. To test this, build `views_examples_with_content` and press the button on the "Accessibility Features" page - you should hear and see VoiceOver announce "Button pressed". Bug: 1157157 Change-Id: Ia0845e29b86eb66411cd45399ba0ef340537b92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618620 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#842268}
-
Sophie Chang authored
This also makes the component available on incognito (which was an oversight in previous support to have optimization hints be in incognito) Bug: 1154790 Change-Id: I97a427d5af0f94fa0b5282032b8cef6ce754c81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617866Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1163455 Change-Id: I48a495ef9d0cca362df9518ae952be7e80b14ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622892 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
