- 04 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23909d8cfc57..a6842d3aa4de 2020-09-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89c190de93eebe3eff2bef4484d4731e28b52b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393656Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804538}
-
Alexey Baskakov authored
Background: WebAppMigrationManager uses BookmarkAppRegistrar::GetAppUserDisplayMode() getter to obtain user_display_mode field. user_display_mode is a user-controllable field which we sync across all user's devices. user_display_mode shouldn't depend on anything else (like manifest display mode or any other web app field) The call path: BookmarkAppRegistrar::GetAppUserDisplayMode() -> extensions::GetLaunchContainer() -> extensions::GetLaunchType() -> extensions::GetLaunchTypePrefValue(). The problem: While extensions::GetLaunchTypePrefValue() returns a raw launch_type that we are really interested in, extensions::GetLaunchType() resets launch_type to "run as a tab" if the bookmark app is not locally installed (Background: we sync bookmark apps as non-locally installed on all OSes except ChromeOS): LaunchType GetLaunchType(const ExtensionPrefs* prefs, const Extension* extension) { ... // Force hosted apps that are not locally installed to open in tabs. if (extension->is_hosted_app() && !BookmarkAppIsLocallyInstalled(prefs, extension)) { result = LAUNCH_TYPE_REGULAR; } else ... } This is the place where we were loosing information. If local migration happens first on a device with non-locally installed app, this preference gets uploaded to the sync server as the source of truth. As a result, all secondary installs treat this "run as a tab" value as a user choice. Solution: Our ideal raw GetAppUserDisplayModeForMigration() getter must not "Force hosted apps that are not locally installed to open in tabs". We need to convert a raw value from prefs extensions::GetLaunchTypePrefValue() using a switch statement with all cases covered. This is a P0 bug. This CL will be merged into M85 branch ASAP. TBR=mgiuca@chromium.org Bug: 1125020 Change-Id: Ie68aa8a86a2a052456fa66349bbd86758aaa56db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392168 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804537}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599177512-b01388e3af00195f29af1f849ccfb9a29d0804ad.profdata to chrome-mac-master-1599198987-d991dddb2c00d3ed866518be68c89430502fa377.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icb8f46f44e2abc74261ef75708bdf593974719da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393655Reviewed-by:
-
My Nguyen authored
As part of moving spell check settings to OS settings in Chrome OS, updating spelling service pref when spell check pref changed is identified to be better dealt with in spellcheck_service. Related CL: https://crrev.com/c/2360093 Bug: 1113439 Change-Id: I0532d28d92912e5437ef729bd84b4916ffc55af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387912Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804535}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84902ce006f0..d91cd6b5ee2b 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 210fb6b5 to 7a93e029 (467 revisions) 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 75690ce7ef4a to e63aa953ddfd (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ib6485c6ae29d552007899fc264237a93a5377273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391874Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_PrintingFailed message to PrintingFailed() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I9fa3b5d5ca1db492aeaa23cc3a13f467d3149c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377264 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804533}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bef95be956d4..23909d8cfc57 2020-09-04 chrche@microsoft.com [Loc] Presubmit performance improvement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116989 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8e69839832a7ecb7638e1f132899d3132a6a8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391872Reviewed-by:
-
Victor Fei authored
AXPosition::AtEndOfTextSpan relies on CreateParentPosition to determine if an inline text box marks the end of text span. Since CreateParentPosition calls into AtStartOfLine which calls AtEndOfTextSpan so we end up with an infinite loop and stack overflow. https://crrev.com/c/2245611 fixed most cases with this infinite loop of AtStartOfLine/CreateParentPosition/AtEndOfTextSpan by checking for AtEndOfAnchor first before calling AtEndOfTextSpan. However consider the following example: <style> .required-label::after { content: " *"; } </style> <label class="required-label">Required </label> labelText #1 ++staticText name='Required ' nextOnLineId=inlineTextBox #2 ++++inlineTextBox name='Required ' nextOnLineId=inlineTextBox #3 ++staticText name=' *' previousOnLineId=inlineTextBox #4 ++++inlineTextBox name='*' previousOnLineId=inlineTextBox #5 AtEndOfAnchor check would not prevent this infinite loop, if AtStartOfLine is called on staticText #4 name=' *' as the max text offsets differ between staticText #4 and its inlineText #5. This CL fixes the above issue by making AtEndOfTextSpan not to call CreateParentPosition. Instead it determines end of text span by directly looking at the current position's parent role and its index among its siblings. AX-Relnotes: Fixes hangs in certain accessibility scenarios. Bug: 1120636 Change-Id: Ic99c27b069f220f26da736b3946560ef23d6b622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369681 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#804531}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9eb24f89..5966c3d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia75618a5a90d9e1b35edd894b9343ea612fba1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391985Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804530}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1877f680e3b2..1e7df19a137f 2020-09-04 thestig@chromium.org Revert "Optimize a tight loop in FX_Number." 2020-09-04 tsepez@chromium.org Remove CFGAS_FontMgr::EnumFontFromFiles. 2020-09-03 nigi@chromium.org Enable FPDFFlattenEmbedderTest.BUG_889099 for Skia/SkiaPaths. 2020-09-03 tsepez@chromium.org Fix some layering between fpdfsdk and fxbarcode. 2020-09-03 tsepez@chromium.org Initialize CPPGC heap with kNoConservativeStack. 2020-09-03 tsepez@chromium.org Tidy CFX_Font If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124998 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Icad9dc4826d872eb2bdb59afd73b9773d240e005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393386Reviewed-by:
-
Sadrul Habib Chowdhury authored
If the main-thread is blocked until a vsync's deadline, then the reporter is cloned, submitted, and marked as having 'partial update'. However, it is possible for the main-thread to respond, after the deadline, with 'no updates' (or 'no damage'). In such cases, the frame that was submitted did not really have a 'partial update' So reset the flag that was set, so that the metrics are reported correctly. To do this: . When a reporter is cloned, track the link between the original reporter and the cloned reporter. . When the original reporter is no longer blocked, check if the frame ended with 'no updates'. If it did, then unset the 'partial update' flag from the cloned reporter. . The cloned reporter can be displayed before the original reporter has a response from the main-thread. In such cases, keep the cloned reporter alive until the original reporter receives the main-thread response, so that the 'partial update' flag can be unset if necessary. BUG=1115376 Change-Id: Ib2e8b0bc1fc924e7442625c4cb82dfa5a88ced95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385929 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#804528}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6763a713f957..84902ce006f0 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0c25fbe3e3ed to 4a41204d8175 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1117433 Tbr: michaelludwig@google.com Test: Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/* Change-Id: I1753145eed6bdad2da2693d745d58c5bfcd484db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393385Reviewed-by:
-
David Black authored
MenuItemView supports being a thin wrapper around a sole child view but the child view isn't notified of changes to the parent's selected state. This means the child view doesn't know to update itself if it has some state specific characteristics. This CL makes selected state a subscribe-able property so that changes can be observed and reacted to. Bug: 1112888 Change-Id: I305eb1dd8cdb735d1bb14bd0f7c86ce8193b3670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393261Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#804526}
-
Dmitry Titov authored
We still need some NewTabPage.ContentSuggestions histograms since Zine and Jardin are still in Stable. Bug: NONE Change-Id: I731f8734513df84fbc25bffffaaac3c2d5b1069f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393240 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804525}
-
Jenny Zhang authored
Enable ash to read and send lacros user log in the feedback report. This helps to collect lacros log in case lacros crashes or being terminated for some reason. User can still send feedback via ash-chrome ui or "alt-shift-i". TBR=afakhry@chromium.org Bug: 1119925 Change-Id: I1274f09f75b885627bd97ef165d55861bb7ead5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393235 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#804524}
-
Regan Hsu authored
The test was previously failing because it was using Time::Now() as a reference, instead of a fake clock as it does now. Fixed: 1122584 Change-Id: I04cbb723dabc38fa1aad391d1a601150ec43c0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392984 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Richard Li authored
We need to pass HDRMetadata to SwapChainPresenter which needs proper metadata to set video processor. Moving media::HDRMetadata to ui/gl/ is a prepared work for that. This CL also move media::DisplayHelper to ui/gl/. Since it only provide functions related with HDRMetadata, this CL renames it to HDRMetadataHelper. Bug: 1122910 Change-Id: I0670c210cd0c194bf0ec1872cb5442d1f6a9b324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387620 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#804522}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_ShowInvalidPrinterSettingsError message to ShowInvalidPrinterSettingsError() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I711f255d964ef3089de1b55e08b0b0bde38f9e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374929Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36b884e6ace1..4a41204d8175 2020-09-04 ianelliott@google.com Vulkan: Improve invalidate for depth/stencil If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/* Change-Id: I3804c01b56d2a361ec0f683b5f2ce127d31ea171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393382Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2cdb9f1ed183..62442aceb0fb 2020-09-04 jiawei.shao@intel.com D3D12: Combine all the barriers before dispatch() in one call If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie646b3ed3420084fb65d9da85c56787385f75c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393576Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2c5b4455854d..e63aa953ddfd 2020-09-04 capn@google.com Don't assert on component swizzle matching identity If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0e4893180d7394c0b18684c44bb1cd8035be274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393383Reviewed-by:
-
Yuly Novikov authored
This is 2nd CL out of 3 moving SwANGLE GCEs into chromium.tests.gpu pool. 1. https://chrome-internal-review.googlesource.com/c/infradata/config/+/3251996 Allocate GCEs in chromium.tests.gpu pool and increase chrome-gpu quota 2. This CL Switch SwANGLE bots to trigger tests in chromium.tests.gpu pool 3. https://chrome-internal-review.googlesource.com/c/infradata/config/+/3251999 Remove GCEs from chromium.tests pool and decrease chrome-desktop quota Note that there is no need to restrict other builders to chromium.tests, so that they won't target SwANGLE GCEs, because it is the default. Bug: 1123215 Change-Id: I2f146467f118c23b38d4f15a1fea868fac8ecfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392952 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#804517}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66d4faca55b5..bef95be956d4 2020-09-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fa575852a99ee3e63c82f0e05db09f52b784a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393134Reviewed-by:
-
Hazem Ashmawy authored
Add basic UI espresso tests to make sure the correct UI elements and info are shown for different crash reports status. Fixed: 1106312 Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: Idf16e513133db7592887f2b881b1ffefe3792b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376805 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804515}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599134104-920143836f5d72550f74eec8979ce216d37b0d87.profdata to chrome-win64-master-1599155892-1c7afa3c86090c53f24aedb3e14a5f3170b93aea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I5d9cba8e96801402738e1d72ab23bcecc1325b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393139Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I2f067b3b5ca733b26ea355cad8ae110e28e9f705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393516Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53c397b6..9eb24f89 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bb0ccced79f343a1b247b3942a9bc8a48f22353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391983Reviewed-by:
-
Angela Yoeurng authored
Previously, stepping backwards into keyword mode was not supported. This meant that we were always on the "correct" suggestion before trying to enter keyword mode. This crash happens when we try to enter keyword mode before updating the selected line, so there would be no keyword associated with the selected line, causing a segfault or a check to fail. Changing the accept/clear/setselection order fixed the crash, but revealed some problems with the KEYWORD_MODE/FOCUSED_BUTTON_KEYWORD focus distinctions. These were combined into a singular KEYWORD_MODE state. Bug: 1122158 Change-Id: Ib346087e2ebe333c352de6c901ba8662597c849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389160Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#804511}
-
Mike Dougherty authored
Navigator.share should not be added if the browser doesn't support it. Bug: 1122059 Change-Id: I1f768ca5013bed212d6f24afdab44926f3e3042e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391653 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#804510}
-
Matt Wolenetz authored
Before this change, the MSE SourceBuffer's coded frame eviction algorithm (run during the synchronous portion of appendBuffer() as part of the Prepare Append Algorithm) returned early without evicting anything if the media element had not yet reached HAVE_METADATA. In MSE, the only way for the media element to have reached HAVE_METADATA (at least in Chromium) is for all of the SourceBuffers currently in the MediaSource to have all had enough data appended to each of them such that at least one initialization segment each has been successfully processed. This has two problems: 1) It relies upon external state unnecessarily: the SourceBuffer knows if it has potentially buffered media frames already beyond the first init segment if its |first_initialization_segment_received_| flag is true. A (good) side effect of switching to using this flag instead of consulting the media element is a simplification of the dependency upon media element state in the current MSE-in-Workers feature work that is clarifying such dependencies into the MediaSourceAttachment interface. 2) Making eviction a noop when there is at least one other SourceBuffer that has not yet received an initialization segment lets an app append potentially too much without having to handle the pushback of a quota-exceeded-error earlier, limiting the effectiveness of MSE's automatic garbage collection of coded frames, especially when device memory is constrained. This change switches from using MediaElement.readyState < HAVE_METADATA to instead using !first_initialization_segment_received_ as the condition which would allow skipping coded frame eviction during an appendBuffer(). Note: This condition was always intended as a runtime performance optimization, and is part of the implementation area that is allowed flexibility by the MSE specification. BUG=878133 Change-Id: I1173fbdf8aec5e4521b0f73049aeeb7c56ab7ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393356Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804509}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599155892-629b4d0dfe6acef6eef58d4607669a58bfb33fb6.profdata to chrome-mac-master-1599177512-b01388e3af00195f29af1f849ccfb9a29d0804ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic4ff23a7d189c89961ca39da86377c91d4eb0a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393378Reviewed-by:
-
Daniel Hosseinian authored
FPDF_GetPageSizeByIndexF() is encouraged over the older FPDF_GetPageSizeByIndex(), which is will be deprecated in the future. Meanwhile, clean some surrounding code. Change-Id: Id315c67bec5361f23225e49a0fd1438fbcb92428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392947 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Charlene Yan authored
Horizontal Scroll bar visibility is currently coupled with its functionality. Bug: 1122214 Change-Id: I9a0c3ffb0e7128c4444b175631b7cbaf2411f7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393257 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804506}
-
Evan Stade authored
The ui_utils_java target is not a suitable place for this code because it needs to use WindowAndroid instead of Context (for WebLayer's sake), and ui_utils_java can't depend on WindowAndroid. This glue code is moved to org.chromium.content_public.browser. Bug: 1117536,1016938 Change-Id: Ic18275e2f0eca0739b850418af6c71d2079c6da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380343Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#804505}
-
Devlin Cronin authored
Introduce a LegacyExtensionMessageBubbleViewBrowserTest class that disables the Extensions Menu UI. This allows us to migrate these tests to the new UI in a piecemeal fashion. This CL only introduces the class and makes all existing tests use it; follow-ups will migrate specific tests to run with the new UI. Bug: 1100412 Change-Id: I180ac73740a3576b467521d4b40d9ab4ec0cb9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392748 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
FPDF_GetPage[Width|Height]F() are encouraged over FPDF_GetPage[Width|Height](), which will be deprecated in the future. Change-Id: I0445d7cb0a36249fc52d4ff60751543b787b2531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393246Reviewed-by:
-
Hung Vu authored
Bug: 1118207 Change-Id: Ia6930c99bf0dac607450ddf97ee57cd3e09b9c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391507Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hung Vu <vuhung@google.com> Cr-Commit-Position: refs/heads/master@{#804502}
-
Matthew Mourgos authored
This change adds a syncable pref for app notification badging that can be toggled in the notification quick settings. When the pref is changed, all app badges in the shelf and app list are updated. The badges are hidden when the pref is disabled. Bug: 1080827, 1122723 Change-Id: Icd3ff5562e768cfc8e07c9173263c326f1e66d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366295 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804501}
-
Devlin Cronin authored
The file contains a single test, InvokeUi_ExtensionBlockedActionsBubble, which exercised showing the blocked action bubble with the legacy toolbar UI. The new UI is tested in ExtensionsMenuViewBrowserTest.InvokeUi_ReloadPageBubble. Remove the file. Bug: 1100412 Change-Id: I72ba7ac8caa9923fe44305b05bc0d6f9ed823858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390868 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7592f9326fc9..5dba9c97fbc3 2020-09-03 sanfin@chromium.org Pass large -j value to ninja when use_rbe = true If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Test: Test: run on an out/ directory with use_rbe enabled Change-Id: I07b1081f9ad0c554b5942ef3c01b6a15fa247b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393137Reviewed-by:
-
