GitLab

Now that the QUnit-based unit tests are running on the bots, we can retire gtestjs unit tests.

This CL
1. Modifies remoting_webapp_unittest to include all files that are formerly covered by all_js_load.gtestjs.
2. Removes all the gtestjs files under remoting.
3. Moves run_all_remoting_unittests.cc back into the remoting directory as we no longer depends on chrome_paths.h.

Review URL: https://codereview.chromium.org/394023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283941 0039d316-1c4b-4281-b951-d872f2087c98

On ash, toplevel window (which is a widget) is already aligned so the RWHV should be aligned to the toplevel window intead of RootWindow.

This depends on the following CL:
https://codereview.chromium.org/375693006/
https://codereview.chromium.org/357063002/
BUG=391822

Review URL: https://codereview.chromium.org/379483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283940 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/398163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283935 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/390393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283933 0039d316-1c4b-4281-b951-d872f2087c98

The bounds of the ExtensionToolbarMenuView were different than that of the
contained BrowserActionsContainer, so part of the BrowserActionsContainer was
cut off. Fix this by setting the bounds of the MenuView to match those of the
Container.

Before: http://imgur.com/15oiD3G,04VAifx#0
After: http://imgur.com/15oiD3G,04VAifx#1

Blue is the ExtensionToolbarMenuView, Red is the BrowserActionsContainer.
In the before, note that Browser Action VIII is missing (cut off).

BUG=391280

Review URL: https://codereview.chromium.org/400693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283932 0039d316-1c4b-4281-b951-d872f2087c98

R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/397803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283931 0039d316-1c4b-4281-b951-d872f2087c98

error: narrowing conversion of ‘(keysym & 65535ul)’ from ‘KeySym {aka long unsigned int}’ to
‘uint16 {aka short unsigned int}’ inside { } is ill-formed in C++11

error: narrowing conversion of ‘xkey.XKeyEvent::keycode’ from ‘unsigned int’ to ‘uint8 {aka
unsigned char}’

Fixed by using the underlaying type instead, KeySym and unsigned.

BUG=394636
TEST=Passed try bots.

Review URL: https://codereview.chromium.org/398203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283930 0039d316-1c4b-4281-b951-d872f2087c98

The 'audio/mpeg; codecs="mp3"' mimetype is not RFC 3003 compliant, but a
bunch of sites apparently use it. This change restores the behavior that
was in M35 and earlier and returns "probably" for this mimetype.

The changes are intentionally kept small so they can be easily be merged
to the M36 & M37 branches.

BUG=393720,386073
TEST=MediaCanPlayTypeTest.CodecSupportTest_mp3

Review URL: https://codereview.chromium.org/400023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283929 0039d316-1c4b-4281-b951-d872f2087c98

We're going to remove WebNode::getElementsByTagName.

BUG=394234

Review URL: https://codereview.chromium.org/393873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283928 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283927 0039d316-1c4b-4281-b951-d872f2087c98

This roll updates the arm64 and x86_64 ABIS to include changes in NDK r10b-rc1.
This also removes android_tools/ndk_experimental and moves all 64 bit targets
over to using android_tools/ndk instead.

BUG=393903

Review URL: https://codereview.chromium.org/404553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283926 0039d316-1c4b-4281-b951-d872f2087c98

Normally fake interface implementations use Fake prefix, but there
were some with Fake suffix, namely SignalStrategyFake and
HostStatusMonitorFake. Renamed them to use Fake prefix.

R=rmsousa@chromium.org

Review URL: https://codereview.chromium.org/393703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283925 0039d316-1c4b-4281-b951-d872f2087c98

Messages which track the progress of discovery are VLOG(2) and unusual events are VLOG(1).

We can use this to diagnose failures in test automation with release builds.

BUG=394082

Review URL: https://codereview.chromium.org/394383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394836
NOTRY=true

Review URL: https://codereview.chromium.org/400803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283912 0039d316-1c4b-4281-b951-d872f2087c98

This change implements a high priority packet list in PacedSender. In
practice the order of packet priority is:
1. RTCP
2. Audio
3. Video

The reason for doing this such that audio packets can interleave between
video packets even if the audio packets has a greater value of
timestamp. This characteristic of interleaving packets will facilitate
better bandwidth estimation by looking at audio send and ACK pairs.

cast_simulator shows no ill effect but a slight improvement:
Before
Audio frame count received: 17978
Video frame count received: 5169

After
Audio frame count received: 17989
Video frame count received: 5174

BUG=394191

Review URL: https://codereview.chromium.org/399743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283911 0039d316-1c4b-4281-b951-d872f2087c98

have been used.

This will be used as part of a resource/permission manager which will allow users to more easily see and modify which permissions are being granted to which websites.

Design Doc: https://docs.google.com/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit?usp=sharing

BUG=372607

Review URL: https://codereview.chromium.org/356543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283909 0039d316-1c4b-4281-b951-d872f2087c98

Private function HasAttachmentNotOnServer is now tested (albeit
indirectly) by directory_commit_contribution_unittest.cc via
DirectoryCommitContribution::Build.

When displayed in about:sync, SyncEntity instances will now show any
attachment ids they contain.

This CL depends on issue 395913003.

BUG=356266,394023

Review URL: https://codereview.chromium.org/393083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283908 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346956
TEST=tools/telemetry/run_tests && tools/perf/run_tests && content/test/gpu/run_unittests
R=kbr@chromium.org, nednguyen@google.com, tonyg@chromium.org

Review URL: https://codereview.chromium.org/382433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran egltest on X11
NOTRY=true

Review URL: https://codereview.chromium.org/387943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283906 0039d316-1c4b-4281-b951-d872f2087c98

When this field trial is enabled and the data reduction proxy is
enabled, all UI elements will indicate that the proxy is enabled,
but the proxy will not be used.

BUG=357793, 394541

Review URL: https://codereview.chromium.org/388663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283905 0039d316-1c4b-4281-b951-d872f2087c98

This isn't necessary because the test environment set up includes Blink
creating an isolate holder.

Review URL: https://codereview.chromium.org/402553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394186

Review URL: https://codereview.chromium.org/396063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392319
NOTRY=True

Review URL: https://codereview.chromium.org/386443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283899 0039d316-1c4b-4281-b951-d872f2087c98

Finally enabling Clang requires openssl and hunspell rolls. This should
fix everything else.

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/402683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283894 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283892 0039d316-1c4b-4281-b951-d872f2087c98

This will mark hunspell as not chromium code to make Clang happy.

R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/402703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283891 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise if the devices are gone lots of tests will just fail.

Already fixed this for recipe based builders in crbug.com/393681

I don't know how to test this, but happy to write one if shown.

BUG=393681
NOTRY=True

Review URL: https://codereview.chromium.org/390993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283890 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be ocassionally crashing when accessing the mapped PBO
on at least certain Adreno 330 w/Android 4.2.2 configs.

BUG=394510

Review URL: https://codereview.chromium.org/397353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283889 0039d316-1c4b-4281-b951-d872f2087c98

The new comments specify requirements instead of defining behavior
operationally using a particular implementation (and isn't consistent
with, e.g., the standalone implementation, which uses
mojo/public/cpp/utility/run_loop.*).

Note that this doesn't actually fix bugs or make things conform to these
requirements. See crbug.com/394884, crbug.com/394883, crbug.com/394886.

R=darin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/405513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394898
NOTRY=true
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/397363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349211
TEST=Existing tests pass.

Review URL: https://codereview.chromium.org/397953007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283886 0039d316-1c4b-4281-b951-d872f2087c98

Consolidating all the mocked components in DriWrapper for easier
testability of the DRI platform. This should also simplify unittesting
since there won't be a need for interfaces and factories for the sake of
testing.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/402773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/399133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283884 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/405433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283881 0039d316-1c4b-4281-b951-d872f2087c98

This allows other clients to use the external serialization utils.

R=bsimonnet@chromium.org,isherman@chromium.org,asvitkine@chromium.org
BUG=343624

Review URL: https://codereview.chromium.org/394093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283880 0039d316-1c4b-4281-b951-d872f2087c98

Because we listen to XInput2 events on AllDevices, we receive an event from
the slave device, followed by an event from the master device. It is not
necessary to process the events from the slave device, so ignore them.

BUG=368750
R=kpschoedel@chromium.org

Review URL: https://codereview.chromium.org/402763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283879 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283878 0039d316-1c4b-4281-b951-d872f2087c98

This includes the following changes:
a1851e8  Fixes for re-enabling more MSVC level 4 warnings: angle/ edition
6518fe2  Moved TextureStorage and Image into d3d
d4cfa57  Move more draw call validation to the API.
f6d38b0  Fix CollectVariablesTest GCC/Clang compile errors.
4e1fd41  Store a map of interface block registers.
829e89e  Add a default constructor to sh::ShaderVariable.
d5512cd  Collect shader outputs and interface block information.
0b7e5d8  Fix 64-bit warnings.
c0b9ef4  Split Caps into Caps, Extensions and TextureFormatCaps.
57f9b6d  Clean up generatemip.h.
86846e2  Clean up the functions in loadimage.h/cpp.
2a6564e  Fix build errors in validationES.cpp.
e92a354  Remove redundant FBO query methods.
55ec3b1  Refactor common attachment validation to base method.
23a8a43b  Store compact and expanded shader variables.
aae65a4  Add caps for texture size limits and other caps in the 6.28 table.
77f7485  Add a GetVariableInfo helper method.
93455eb  Add missing limits include to angleutils.h
4667c45  Refactor style in VariableInfo.cpp.
53cb14d  Share ArrayString and Str helper methods.
b23375f  Fixed an issue with Streaming Vertex data overflowing it's buffer.
aa7e166  Improve the const correctness.
b447227  Add a ValidateAttachmentTarget helper method.
570f7c8  Add helper methods for FBO attachment validation.
a328d56  Removed sampler state getters and setters from gl::Texture

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/399733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283877 0039d316-1c4b-4281-b951-d872f2087c98

A test window is just a path to write an image file to. Each window has
a unique image path.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran test platform
NOTRY=true

depends on https://codereview.chromium.org/375053002/

Review URL: https://codereview.chromium.org/377973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283875 0039d316-1c4b-4281-b951-d872f2087c98