- 27 Mar, 2019 1 commit
-
-
Peter Kasting authored
Bug: 945846 TBR: noel Change-Id: I9b62ee039e537cc6485514d7e744b6a702b2bb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539212Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644602}
-
- 26 Mar, 2019 39 commits
-
-
Tom Anderson authored
Rolling for [1] to fix bug 944391. [1] https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/955113db37563c8632e31ddcff2047845553d7ff https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/4daecde1d737..955113db3756 $ git log 4daecde1d..955113db3 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 thomasanderson [libc++] Fix return value of snprintf_l() on Windows when buffer is too small 2019-03-26 modocache Revert "[coroutines] Add std::experimental::task<T> type" 2019-03-26 modocache [coroutines] Add std::experimental::task<T> type 2019-03-25 mclow.lists Cleaup of requirements for optional. While researching LWG3196, I realized that optional did not reject 'const in_place_t' like it should. Added a test as well, and a check for arrays (which were already disallowed, but now we get a better error message). Should not affect anyone's code. 2019-03-25 ldionne [libc++][CMake] Allow merging libc++abi.a into libc++ even on Apple platforms 2019-03-22 mclow.lists Fix a minor bug with std::next and prev not and negative numbers. In particular, std::prev cannot require Bidirectional Iterators, because you might 'go back' -1 places, which goes forward. Thanks to Ville and Jonathan for the bug report. 2019-03-22 ldionne [libc++] Update the list of symbols exported from libc++abi for new/delete 2019-03-22 ldionne [libc++] Re-export the sjlj ABI v2 for ARM architectures 2019-03-22 mclow.lists Fix a vector test to not use a local type as a template parameter. This causes a warning on C++03. NFC 2019-03-21 ldionne [libc++] Remove too-stringent XFAILs for file_clock tests 2019-03-21 ldionne [NFC][libc++] Reindent #ifdefs 2019-03-21 ldionne [libc++] Re-document how to use <filesystem> with various versions of libc++ 2019-03-21 sbenza Add relational benchmark against a string constant. 2019-03-21 ldionne [libc++] Mark bad_any_cast tests as unsupported when the dylib doesn't support bad_any_cast Created with: roll-dep src/buildtools/third_party/libc++/trunk BUG=944391 R=thakis Change-Id: Ib0c7ec64c706afe31c46feed581577d4b8f7c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540288 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcf82c47e836..ed0cd5dc2078 Created with: gclient setdep -r src-internal@ed0cd5dc2078 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I230620a573ebd4725683167152e7d68ffedc23b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540460Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644600}
-
Michael Thiessen authored
This implements the ability for embedders to provide a context menu for media controls, drawn in the browser process. Also, some text track code was refactored to make it reusable by both normal and non-touch media controls. #Looks like an issue with per-file BUILD.gn=* not interacting well with #noparent. NOPRESUBMIT=true Bug: 942577 Change-Id: Ifa929a8cef7b6a2b1ee0b1bf2c5be02015119993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532742 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#644599}
-
Sinan Sahin authored
Bug: 944299 Change-Id: I632927307175fcb0c5a6096a58b372d190d8da6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538859Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#644598}
-
Peter Kasting authored
Bug: 856601 TBR: noel Change-Id: I0692727596c621df1c580588d7f9f4fcda681bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540363Reviewed-by:
-
Caleb Rouleau authored
This reverts commit 0f4fde42. Reason for revert: crbug.com/940075 is fixed now. R=jbudorick@chromium.org Original change's description: > [Perf Waterfall] Disable reference builds on Mac > > TBR=jbudorick@chromium.org > > Bug: 940075 > Change-Id: Ibb863ac8c33d0f4057e0df78819893d8c0668d22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531106 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642094} TBR=crouleau@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 940075 Change-Id: I8ce4e3a6b867f6b8bf4d9dc0d4bc2c07e123c791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540311Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#644596}
-
Alexander Alekseev authored
This reverts commit bb805dc9. Reason for revert: Renderer crash on OOBE https://crbug.com/946161 Bug: 946161,944907 Original change's description: > DevTools: move info label and contrast info processing further into the highlight. > > Change-Id: I6edb5685493e91c5d6ff4ae078f40764dffc7d93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535431 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643515} TBR=dgozman@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If07938780cbfd34b21b7ecaea4c0fa828abe0462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540416Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#644595}
-
Gayane Petrosyan authored
COLOR_CONTROL_BACKGROUND always defaults to white and doesn't have calculated value based on other theme properties. Therefore it shouldn't be part of the theme properties. This change removes COLOR_CONTROL_BACKGROUND from theme properties and its only call in browser_view as it has no effect. Change-Id: I0a0db0c2e00831d6136c9f1d780823fb8d4cc661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534483Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#644594}
-
Robert Liao authored
There are no references to disabled_combobox_ after construction. BUG=897377 TBR=sky@chromium.org Change-Id: I418211e76bbe19a851490e4c6338726559b2e40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540579Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#644593}
-
Siye Liu authored
Some JPN IMEs such as CorvusSKK or SKK日本語FEP behave differently when using TSF on Windows. The root cause is that uses may commit existing composition and start new composition in the same edit session with same composition text. Bug: 944452 Change-Id: Ife8032742afd1cf2be372f015fdc2cb77f73a59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532911 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#644592}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cc6473f7d80d..e747b3c3c9d9 git log cc6473f7d80d..e747b3c3c9d9 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 bclayton@google.com SpirvShader: Implement loops Created with: gclient setdep -r src/third_party/swiftshader@e747b3c3c9d9 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I72180c050cd02ec20e9d7c0dba23e1fce199d9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644591}
-
James Darpinian authored
WebGL conformance test deqp/functional/gles3/shaderbuiltinvar.html is flaky on Android Qualcomm. TBR: kbr@chromium.org Bug: 946177 Change-Id: I436fc390bf1e41614385cb5882e7436f2f3245b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539127Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#644590}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ce9a7af967cb..45d5f702133e git log ce9a7af967cb..45d5f702133e --date=short --no-merges --format='%ad %ae %s' 2019-03-26 rmistry@google.com Fix RecreateSKPs bot page sets II 2019-03-26 csmartdalton@google.com Add MSAA and non-aa modes to GrFillRRect Op 2019-03-26 fmalita@chromium.org [skottie] Relocate text shaping utils to separate compilation unit 2019-03-26 mtklein@google.com quiet down SkFontHost_FreeType debug logs Created with: gclient setdep -r src/third_party/skia@45d5f702133e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ied3b8a1790f9f01ff4da78ef52adfdd91bff26ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540423Reviewed-by:
-
Xianzhu Wang authored
For now we create both effect and filter nodes when there is any type of effect animation. Previously we created render surface for both nodes, causing memory and CPU regressions. Now don't create render surface for the extra nodes. Bug: 943826 Change-Id: Id26088b1cd58d95f44b040b099f56bd2fb1c335e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536706Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644588}
-
Shakti Sahu authored
This reverts commit d6a0a21a. Reason for revert: As per the discussion in the bug, it was decided to not set the accessibility focus on the highlighted menu item after opening the app menu. Original change's description: > IPH : Set focus to highlighted menu item after opening app menu > > This CL adds the following: > 1 - After opening chrome menu, if there is a highlighted menu item due > to IPH (both for circle and rectangle), accessibility focus will be set > to the highlighted view. It still needs a delay of about 1 second after > the menu opens, without which focus is not set to the correct view. > > Bug: 767075 > Change-Id: I5f4418537e8922189a5fe9f19bfcc70eadcaa000 > Reviewed-on: https://chromium-review.googlesource.com/c/1404566 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622565} TBR=dtrainor@chromium.org,shaktisahu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767075 Change-Id: I2cf4a9d3a5c7e0d7aef2881030ca242512357470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540267 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#644587}
-
Shakti Sahu authored
This is a reland of b01ba24c Original change's description: > Converted AllDownloadItemNotifier to a KeyedService > > Converted AllDownloadItemNotifier to be a KeyedService so that it will be > a per profile instance. Added multiple observer support to it, so that > ADIN won't be instantiated multiple times. This will save a lot of memory > because each ADIN instance contains a full set of all download item pointers. > > Bug: 942773 > Change-Id: I4e0e88aceb3e97ef7f98d5a94fab4a34c8abd791 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526792 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Nicolas Zea <zea@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643272} TBR : zea@chromium.org Bug: 942773 Change-Id: I0a493be8bc8d6bf6c9e7bf1d0e613a5149578e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536155 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644586}
-
Robert Liao authored
BoolToOnOff isn't generally useful to all examples. BUG=897377 TBR=sky@chromium.org Change-Id: Ic3738b32db1cd4f06651e5609f664b8aaa52943d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540365Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c8e39ebcf304..db55340a2b03 git log c8e39ebcf304..db55340a2b03 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 evanhernandez@chromium.org service: Implement SetBinhost. 2019-03-26 evanhernandez@chromium.org constants: Add binhost conf dirs. Created with: gclient setdep -r src/third_party/chromite@db55340a2b03 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If06305a90b628bb05569b102ae7bee8f7f762da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538750Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/db121ec5abd6..de253137e334 git log db121ec5abd6..de253137e334 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::GetOneChildNamed() a member of CXFA_Node. 2019-03-26 thestig@chromium.org Simplify GetTransparentParent(). 2019-03-26 tsepez@chromium.org Avoid undefined negation in CFGAS_Decimal.FromInt32. Created with: gclient setdep -r src/third_party/pdfium@de253137e334 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5869d5dd7e46102ad7611cf4b0fa828014fdd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540422Reviewed-by:
-
Justin Cohen authored
Both -updateNavigationEdgeSwipeForWebState and GetBackwardItems can return nil NavigationItems, so check in the UseNativeSwipe helper for completeness. Bug: 945989 Change-Id: Ie8ad8a425722e699372013d8c31db039e91ca32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539121 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644582}
-
Adam Ettenberger authored
1. Add condition for when IValueProvider is available 2. Share logic between IAccessible::get_accValue and IValueProvider::get_Value 3. IValueProvider::SetValue should respect the restriction state and return UIA_E_ELEMENTNOTENABLED when disabled / readonly. 4. IValueProvider::get_IsReadOnly should consider both disabled and readonly 5. Move IsRangeValueSupported out of AXPlatformNodeBase 6. Add IsRangeValueSupported and IsReadOnlySupported to ax_role_properties.{h|cc}. This logic is needed for both ax_platform_node_win.cc and in a following change browser_accessibility_manager_win.cc 7. Update AXPlatformNodeWinTest.TestGetPatternProviderSupportedPatterns now that not all elements expose UIA_ValuePatternId, adding a case for Grid vs Table, since Table does not support Value, but Grid does. 8. Add unit tests for IValueProvider Bug: 844149 Change-Id: I24a3e61ece40bbf5753b44f3a77e14f3069dac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534302 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644581}
-
Sahel Sharify authored
TBR: pkasting@chromium.org,andruud@chromium.org Bug: 945845 Change-Id: Id61b420405c046095c0a06bda8c78b5663f1dc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540282Reviewed-by:
-
BUG=762641 TBR=malaykeshav@google.com Change-Id: I7f9baab30fbbf45e9297693f3b9511d65a19cfc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538255Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#644579}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48193b065ac6..2547d2cf2b12 git log 48193b065ac6..2547d2cf2b12 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e1296370..ff1de589 (644325:644450) 2019-03-26 mbonadei@webrtc.org Revert "Disable TestVp9ImplProfile2.EncodeDecode on iOS." 2019-03-26 amithi@webrtc.org Revert "in WebrtcVoiceEngine allow to set TaskQueueFactory" 2019-03-26 danilchap@webrtc.org in WebrtcVoiceEngine allow to set TaskQueueFactory Created with: gclient setdep -r src/third_party/webrtc@2547d2cf2b12 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd11b090a155f1deeb8c5f03b4733ad50a69beed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540376Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e9845b09..8244b454 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idfcffb1035705e6989ab4ac3d9402a88b3cb5d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540272Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644577}
-
Eric Stevenson authored
This reverts commit 85b741f2. Reason for revert: Broke downstream system stub APK generation. Original change's description: > Android: Update bundletool version to 0.9.0. > > Release notes: https://github.com/google/bundletool/releases/tag/0.9.0. > > Primary motivation is to better support locale specific system APKs > for http://crbug.com/945418. > > Note: Flag --universal is no longer supported. > > Bug: 945418 > Change-Id: I93c367dcd593d05ce8132e4dfb1223fa16a68d20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539781 > Reviewed-by: David Turner <digit@chromium.org> > Commit-Queue: David Turner <digit@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644357} TBR=digit@chromium.org,estevenson@chromium.org Change-Id: I6540b508f19ee11cfbcb6ee30957753127ba8066 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 945418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540367Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#644576}
-
Pedro Amaral authored
Added: MobileBottomToolbarHomeButton MobileBottomToolbarShareButton MobileBottomToolbarStackViewButton MobileBottomToolbarStackViewNewTab MobileMenuShowFromBottom MobileMenuShowFromTop MobileToolbarHomeButton MobileToolbarStackViewButtonInBrowsingView - Bug: 936529 Change-Id: I7b5611bec57ccf8b6e85f893f654f99af1e0402b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521818 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#644575}
-
Joel Hockey authored
Bug: 945959 Change-Id: Ia611b7edcf3c123b0885e8ea4a69d72e035acfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539629 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#644574}
-
chrome://ukmRobert Kaplow authored
This is pretty minor to start, but at least show status. Ideally it would show information per-event. Did some refactoring of sampling from UkmRecorder. Should be noop but please check Bug: 820592 Change-Id: I993146ec4b92fc801b001a265f31ba54f82e7cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524644Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#644573}
-
Ilia Samsonov authored
Added simple test for TestResultsTracker json output file. The test goes through the necessary steps to generate the resulting JSON file. Additional tests will include several iterations, results aggregator, and iteration summury calls. Added the TestResultsTracker unit tests to base_unittests R=erikchen@google.com Bug: 936244 Change-Id: I65e20d858fefa18b3cc58af0845940a3ed8bd9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529884 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644572}
-
Julie Jeongeun Kim authored
This CL moves document_metadata from public/platform/modules to public/mojom to gather mojom files to mojom folder and updates paths for copyless_paste.mojom.mojom. Bug: 919393 Change-Id: I7b37ec38c24ae09f86106e75a3b920836688d78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535689 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#644571}
-
Patrick Monette authored
Bug: 943303 Change-Id: Ibd8fdd0760e7b63b48e1de7ec8ab8edbc56d1fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531086 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Matt Menke authored
Previously, it was only using TransportClientSocketPools. This change will let WebsocketTransportSocketPool stop inheriting from TransportSocketPool. Bug: 944097 Change-Id: I5935d909db9dbe831fef5dbe1cad28cd96f27ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532985Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#644569}
-
Mounir Lamouri authored
Bug: 924249 Change-Id: Id91994c87910d19884222a7060ecca28d0894bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1427599 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644568}
-
Esmael El-Moslimany authored
Bug: 945793 Change-Id: If766a68f71ce7d9d1068cc30b12a2c1191a966af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540066Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#644567}
-
Min Qin authored
For resumed download, we should extend the expiration date. Or otherwise, large downloads may not complete on slow networks BUG=938978 Change-Id: Ib57c5915a4caa1305e7b9ba6ec7c2abc1f30f3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538453Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
- Update DesktopFocusRules so that only toplevel window is allowed to be activated in minimized state. Otherwise, a child window could be activated and cause DesktopNativeWidgetAura not getting activation change which in turn causes more problems down the road. - Fix DesktopNativeWidgetAura so that RestoreFocusedView happens for a minimized widget Bug: 942787 Change-Id: I0e3d35f342fca16cc78e451d6bf7fe32ac2dc337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536554 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#644565}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b12fa2c0ae1..c8bd9e358dfd git log 1b12fa2c0ae1..c8bd9e358dfd --date=short --no-merges --format='%ad %ae %s' 2019-03-26 benjhayden@chromium.org Support bug_id=* in Anomaly.QueryAsync() 2019-03-26 benjhayden@chromium.org Support count_limit in /api/alerts Created with: gclient setdep -r src/third_party/catapult@c8bd9e358dfd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:918193 TBR=sadrul@chromium.org Change-Id: I2cd8460dbca2d95dce85aeb2ca73b9444ef6680f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539075Reviewed-by:
-
Nikunj Bhagat authored
Bug: 945174 Change-Id: Ia1d99f70eb43f3ffb6545b18a3c922d638096dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540315Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#644563}
-
