- 30 Jul, 2020 40 commits
-
-
Alexander Dunaev authored
This is a reland of df7ff136. The previous version caused flakiness in interactive_ui_tests, namely BookmarkBarViewTest22.CloseSourceBrowserDuringDrag. That test checks that closing the source window of the drag doesn't cause a crash. The issue was that the window (which implements WmDragHandler) is sometimes destroyed before the DnD client, while the latter had a raw pointer to the former to call its WmDragHandler implementation. Here I propose a safe way for the DnD client to call the WmDragHandler implementation. The interface now has a weak factory so callers that do not own the instance of the implementation are encouraged to hold the weak pointer. Also, the test itself has issues; it seems to be flaky by design (the order in which the window and the DnD client are destroyed is not guaranteed). I have filed an issue [1] for that. [1] https://crbug.com/1106379 Bug: 990756 Change-Id: I50517fb5e0d7fbb8f3863029d5296837dcd6bf05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299339 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#793029}
-
Ian Kilpatrick authored
In order to determine the correct size to resolve %-based relative top offsets against we need to determine if the available-size given to a flex-item is definite. Previously this worked as there was a bit on the LayoutBox which captured this information. This patch for NG flex-items allows for looking at the previous constraint space while outside of layout. Bug: 1108508 Change-Id: I3104b7afd4d96b707a8110eb2ed5d59d17129580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327838 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793028}
-
Joel Hockey authored
Linux files root does not currently show 'Open' in the action bar, or allow open-with for terminal since it is a VolumeEntry and is filtered out by util.isNativeEntry from being passed to getFileTakss. Using util.isFakeEntry now since VolumeEntry is ok to pass to getFileTasks. Bug: 1097715 Change-Id: Ib995fda32b9baa1cf2b79ac67ffd613d6da44aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327092 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#793027}
-
sauski authored
The security_page_tests currently test the page navigated to by the security_keys subpage. The target of this navigation is constant and similar behaviors are not tested elsewhere in settings. This CL changes the test to test the visibility of the link row, which does change depending on platform and flag state and has significant testing precedent. Bug: 1111027 Change-Id: I37814b531e4f174c8a9d46ec72f1c920b358d545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321413 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#793026}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595851043-c14119a80137ce7090e196461287429806779e74.profdata to chrome-win32-master-1596049147-04f4413ea8a529a37f9708a4b92ad78989005413.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic2204f40b447a1e2d8b9684a1001ed00c6d137a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793025}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc846039201d..1c1c6b4e3892 2020-07-29 ianelliott@google.com Vulkan: Cache/re-use vkImageView's per max level 2020-07-29 penghuang@chromium.org Add extension EGL_ANGLE_display_semaphore_share_group 2020-07-29 cnorthrop@google.com Tests: Update gfxbench traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Test: Test: NBA 2K20Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_texture_mipmap_*_max_level_* --use-angle=vulkanTest: Test: run_angle_perftests --gtest_filter="*Trace*" Change-Id: I7f6fb8d3a2d18499f928902641c931ad8ff807a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327801Reviewed-by:
-
Justin Cohen authored
Bug: 1111183 TBR: gambard@chromium.org Change-Id: I3ce374e434325b2be057511713db56b6ded676a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328213 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793023}
-
Lan Wei authored
We have already removed all the transferring user activation code, and this CL removes experimental flag UserActivationPostMessageTransfer. Bug: 1067307 Change-Id: Ib444f2ce158a19c1d60f971e461c4a4e59c41a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291353Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#793022}
-
Avi Drissman authored
OS_MACOSX will still work for code already in the tree, but warn to prevent new instances from landing. Bug: 1105907 Change-Id: Ia811e352ab7ec688bad5e8e7b31868777dd75c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328330 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#793021}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I2f68efa0536460fc31c764174efb9a0f23e53668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324213Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793020}
-
Melissa Zhang authored
Bug: 1097623 Change-Id: Iafdd79b44aa39829b310536b404822f921ce34e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326851 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#793019}
-
Alex Gough authored
My understanding is that the refcount should not be higher than the number of dispatchers which should be tied to the lifetimes of process hosts. A 32 bit refcount should be safe in this case, but a size_t refcount is more obviously safe. Bug: 1101547 Change-Id: Icd52147b48c87df609dd43716f710a8decdc2c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289371Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#793018}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I1a7246c8e426d1076b80ba765da68c67da735e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327849 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#793017}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/395d1d531f44..667e15d86eec 2020-07-30 fancl@chromium.org Reland "auto-triage: Revision range url support non-chromium revision" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: eseckler@google.com Change-Id: I66a211e9991f8e8ebc47c8fd9f5e2f5d26862c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327804Reviewed-by:
-
Kyle Horimoto authored
This includes: (1) Adding Proto values for CryptAuth. (2) Adding Mojo values in multidevice_types.mojom. (3) Integrating these types with existing DeviceSync code. (4) Enrolling with PHONE_HUB_CLIENT when the flag is enabled. CryptAuth autopush. Test: Phone Hub flag off hitting CryptAuth prod and flag on hitting Bug: 1106937 Change-Id: I7616759535b84bb5a19a4249b1cca6aadbfb04be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317773 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Josh Nohle <nohle@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#793015}
-
Zhaoliang Ma authored
Bug: None Change-Id: I78040887be4cb5d1509479f38259a6b9c4b79447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324184Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#793014}
-
Robin Lewis authored
Bug: 1102868 Change-Id: I7c5fa7fc62bdf1b7a9cf38cccc751ec2cc2c97c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308829 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#793013}
-
Peter Kotwicz authored
This CL adds the following strict mode exemptions: - Strict mode violations originating from packages other than org.chromium.content on non-Nexus non-Pixel devices - Strict mode violations from SharedPreferences - Strict mode violations due to xposed Design doc= https://docs.google.com/document/d/10IxBTVTIDXj9KP6kIct1hLkKcbjrAQPWK9-HHG8D_34/edit?usp=sharing BUG=1109678 Change-Id: Ib6c6116dceb02b7db0bdde06ee4d983c2a9e2f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327468Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793012}
-
Thomas Lukaszewicz authored
Add default constructability and a BrowserContext setter to the WebView class. Bug: 1108460 Change-Id: I07f358fa5bc05594d672c2c6586cfd41ce524c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314031Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#793011}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9e9f991b34840e41b89c6346aa4d011f39711cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328053Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793010}
-
Jason Lin authored
WebDialogDelegate has two methods which can block the dialog from being closed: CanCloseDialog() and OnDialogCloseRequested(). CanCloseDialog() is a const method and the name suggests that it should simply be a predicate without side effect. OnDialogCloseRequested(), before this cl, is called too late in the closing process, so you will end up with a half-broken dialog when you return false in it to block closing because the web contents would have been closed. This CL consolidates the two by 1) removing CanCloseDialog(); 2) Call OnDialogCloseRequested() in WebDialogView::OnWindowCloseRequested(), which makes OnDialogCloseRequested() actually useful. Now we are able to move logic in Crostini{Installer,Upgrader}Dialog::CanCloseDialog(), which requests the web page to conduct closing logic, to OnDialogCloseRequested(). login_screen_extension_ui::DialogDelegate::CanCloseDialog() and AddSupervisionDialog::CanCloseDialog() are also moved to the corresponding OnDialogCloseRequested() methods. In addition, the old AddSupervisionDialog::OnDialogCloseRequested() is moved to DeprecatedOnDialogCloseRequested(). It seems that in the old implementation, OnDialogCloseRequested() was not called when the user signed out with the dialog open, and AddSupervisionDialog was relying on this behaivor. So a new function DeprecatedOnDialogCloseRequested() is added for now to maintain the behavior. Bug: 970196 Change-Id: I4e552ed02d2db96886b87534ad7f187844ed04e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278793 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#793009}
-
Fergus Dall authored
In the unstable protocol, the anchor and gravity fields are bitfields and we have code to check that the combination of values makes sense. In the stable version this has been changed to an enum so invalid combinations are no longer possible, and the code that checks for them becomes incorrect. Bug: 1110101 Bug: 1022716 Change-Id: I8f81a0b3f0e76a11fc0bc096724b8b3766cab399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326853 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#793008}
-
Frank Liberato authored
Previously, as an experiment, the `use_single_video_texture` gpu workaround was modified to prevent sharing video decoder textures. Since it worked, this flag has now been merged into `disable_dxgi_zero_copy_video`, which does the same thing. As part of this, D3D11VideoDecoder now respects the latter, which it was supposed to do before. Unfortunately, it ignored it. Also adds tests to make sure bind / copy is obeying the flags. Bug: 971952 Change-Id: I09bbc5d853d7ebbe2d9ff9ef82276422b8fe2b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327133 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#793007}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I0ace11a629d0347041f7233476a8e4d9a12174d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325093Reviewed-by:
-
Toni Baržić authored
This reverts commit f300ac05. Reason for revert: Breaking chrome OS build: https://crbug.com/1111185 BUG=1111185 Original change's description: > GMC: Add IPC for switching the audio output device > > This change adds methods used by the global media controls ui for > switching the audio output device used by a page. > > MediaController::SetAudioSinkId was created allowing the > MediaNotificationService to route the audio output of a > MediaNotificationSession to a specified audio device. > > Mojo interfaces were expanded to allow for this IPC between the > controller and session. > > Bug: 1096243 > Change-Id: Icd0ad17d6ef88ec297444b8b2cbc7ddda6c2c4c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295799 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Auto-Submit: Noah Rose Ledesma <noahrose@google.com> > Cr-Commit-Position: refs/heads/master@{#792935} TBR=dcheng@chromium.org,rijubrata.bhaumik@intel.com,sergeyu@chromium.org,seantopping@chromium.org,beccahughes@chromium.org,steimel@chromium.org,noahrose@google.com Change-Id: I526e44f992450f4bfff9b7eebd85e6b8380df812 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327805Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#793005}
-
Dale Curtis authored
This is only used for hardware decoding, but to avoid some future traveller having to debug why images are corrupted, implement the appropriate ImageDecoder method. R=pkasting Bug: 915972 Change-Id: I39529c8a1f1d66e7c11a7c5537b2e5e1af0de5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327461 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/994ce8cf2300..398c654ce7be 2020-07-29 johnstiles@google.com Enable ClangTidy 'undelegated constructor' warning. 2020-07-29 johnstiles@google.com Fix DebugCanvas(SkIRect) constructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I7476be79e8efe85a95c6d781238e1e8b3f3a3669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327748Reviewed-by:
-
Toshiki Kikuchi authored
This CL allows AutoSnapController to check if DragWindowFromShelfController is restoring windows after dragging. AutoSnapController uses kAnimationsDisabledKey to skip auto snapping after transient hide & show operations by DragWindowFromShelfController. But kAnimationsDisabledKey may be used in other locations so we should not rely on it. This CL also cleans up auto snapping trigger conditions. BUG=chromium:1107306 TEST=DragWindowFromShelfControllerTest.HideWindowDuringWindowDragging* TEST=SplitViewControllerTest.AutoSnapFromMinimizedState Change-Id: Ibc4f72558db3cf0efa070a77e44d3247b79d9ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303337 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#793002}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596045560-aec562928bab06d0692bf930829a43aa15a04f06.profdata to chrome-mac-master-1596066946-9bc35ac8d47ba630ab3266f0e7f4e21ad19fc745.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Idf892429f8ac623b41e06c796670855378a06229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328133Reviewed-by:
-
Alexander Surkov authored
Bug: 1100991 AX-Relnotes: n/a Change-Id: I89ecbf3b950c9d70bf9a579bfe4b9b02da6b83dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323503 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793000}
-
Toni Baržić authored
This reverts commit e3564580. Reason for revert: The issue that was causing crashes during the test seems to be resolved. Original change's description: > Sheriff: Disable GestureNavigationScreenTest.FlowTest on MSAN > > Bug: 1109714 > Change-Id: If2ed226e624c78a97c8a7fe5434520464295eba9 > No-Try: True > Tbr: achuith@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320129 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791900} TBR=achuith@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109714 Change-Id: I652c676041a8f25635dec7b9b7cf0995f6ffbd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327318Reviewed-by:
-
Andrew Moylan authored
This adds a short note to show how methods should be 'deleted' while still keeping interface ordinals in the range [0, N-1]: Interfaces should use placeholder method names. Change-Id: I8bfb2ba589c194d0b7603727c392b2b32a9ce6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242691 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
This is a reland of ffc377fd Revert CL : https://chromium-review.googlesource.com/c/chromium/src/+/2321113 Reason for revert : expected-uia-win7.txt files were incorrect for - All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxNext/uia - All/DumpAccessibilityEventsTest.AccessibilityEventsListboxNext/uia See: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/69290 Updated win7 baseline files : - content/test/data/accessibility/event/aria-combo-box-next-expected-uia-win7.txt - content/test/data/accessibility/event/listbox-next-expected-uia-win7.txt - content/test/data/accessibility/event/menulist-collapse-next-expected-uia-win7.txt Original change's description: > Fire UIA SelectionItem events on aria-checked changes for radio buttons > > According to the following spec radio and menuitemradio should expose > UIA SelectedItem.IsSelected when aria-checked is set : > https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table > > This CL ensures that radio / menuitemradio fire appropriate > SelectionItem events, and whenever a SelectionItem changes its > selection state that we also fire a Property Changed event for > SelectionItem.IsSelected. > > AX-Relnotes: Fire missing events for ARIA radio/menuitemradio when aria-checked changes. Narrator will now announce selected state changes for this scenario. > Bug: 1102580 > Change-Id: I72f479e25f61b0ddffc28f73d4a9c34e8dc4ecb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212982 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791802} Bug: 1102580 Change-Id: Icb6e2f6fb10a1b752a03f470fc158ac3da56fb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321053Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792997}
-
James Vecore authored
Nearby watchlist had a trailing '|' which was causing problems. Change-Id: I497bcd8af9f51144638f54642722bd4ba1425f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328016 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792996}
-
Bo Liu authored
If nothing ever called GetJavaObject, then don't bother creating the java object from the destructor. In practice though this should never happen, but just to be safe. Change-Id: I396569e5a7df380a6cbf49417972442710ea4e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327188Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792995}
-
Joel Hockey authored
Windows files gets a few system files/folders created, and we want them to be hidden by default. Bug: b/161766694 Change-Id: I4694cca3abe081da0f2b4d0fa941ace0d4448c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321986Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21b6343f..d640d034 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibcaa4b9bf75bb6b3b2afec562a13f80113a76bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327572Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792993}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The files LacrosManager, LacrosLoader, etc. were confusing developers since the word "lacros" is only supposed to be used by the lacros-chrome browser. This CL renames the files to avoid this confusion. In order to avoid confusion in ash-chrome, the classes have been moved to the namespace crosapi. Change-Id: I148c3fe107ce3eaadeab13a569c6921746ffd71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325087 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792992}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I08d2ef403596089f4ce890ea4c6fe638246d71ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325100Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792991}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Ib35f5ba08945da527a2a9374b9f11bc221bf393e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325099Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792990}
-
