- 24 May, 2018 40 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1a5e452d31e..af2ffd933d0e $ git log b1a5e452d..af2ffd933 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 agable Remove cq_client from depot_tools Created with: roll-dep src/third_party/depot_tools BUG=chromium:770408 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibd05c61891c11981e0aa3546b2aed95be31d6916 Reviewed-on: https://chromium-review.googlesource.com/1072687Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561693}
-
David Jacobo authored
Constructing a basic default Referrer for ArcExternalProtocolDialog based on the last committed url. Bug: None Test: Build. Change-Id: I6aeb677d57632198b69c7cc229f92a2571526a0c Reviewed-on: https://chromium-review.googlesource.com/1072513Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561692}
-
Hector Carmona authored
This affects both chrome://settings and chrome://extensions. Bug: 840633 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5e69e542a9c08fd35c2f6b02a8277d7ee87998fe Reviewed-on: https://chromium-review.googlesource.com/1068114 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561691}
-
Brandon Jones authored
If GVR reports a floor offset from the current tracking origin the floor grid will be adjusted to render at the same offset. This should help user comfort when using standalone devices. Bug: 845225 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I08bd081087f4f6528ec8200ee424d08f9bf9f059 Reviewed-on: https://chromium-review.googlesource.com/1067541 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561690}
-
Ben Pastene authored
Similar to https://chromium-review.googlesource.com/1069867, but for the ios-simulator CQ bot. Bug: 846443 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2377312b47e029bc1804a8ad94a95f595deab4a Reviewed-on: https://chromium-review.googlesource.com/1072733Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#561689}
-
David Bertoni authored
The chrome:// scheme is sensitive enough that any extension that can have permission to run on a chrome:// page should have to specially request access to that page. Prevent <all_urls> from implicitly matching the chrome:// scheme. Bug: 821858 Change-Id: Ie321749cd93ee4b51e89f501a9a25088d3df84c4 Reviewed-on: https://chromium-review.googlesource.com/993753 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561688}
-
Mark Pilgrim authored
Bug: 844920 Change-Id: Iabbe4f3367ca8ade1afa09d595bc05483f0e1d49 TBR: pkasting@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1070328 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#561687}
-
Felicia Lim authored
The license header has been added to third_party/opus/src/autogen.sh upstream and updated here R=thestig@chromium.org Change-Id: I8e1adf14995d6d184edf4e77a77e0991516df7d1 Reviewed-on: https://chromium-review.googlesource.com/1062068Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561686}
-
Sarah Chan authored
Currently the Virtual Keyboard is difficult to use when the Fullscreen Magnifier is enabled Improvements include: - Keeping the Virtual Keyboard in the same size and position when Fullscreen Magnifier is enabled. This is done by applying the magnifier's inverse transform on the Virtual Keyboard's container. - Reduce the bottom margin to pan down the magnifier so that you can interact with the keyboard without panning. This CL disables keyboard overscroll when the fullscreen magnifier is enabled since overscroll would cause layout issues. Screenshot: https://screenshot.googleplex.com/BXnT2RG4A7h Testing: ash_unittests - MagnificationControllerTest.TextfieldFocusedWithKeyboard - MagnificationControllerTest.KeyboardOverscrollDisabled Bug: 347252 Change-Id: Ibcdd43573b211d6bad21b60bb19f427a58490c3f Reviewed-on: https://chromium-review.googlesource.com/1009269 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#561685}
-
Joel Einbinder authored
This lets you scroll the text prompt horizontally by selecting text with the mouse. Bug: 800038 Change-Id: I6e6970a6998530d3355c458d826923b471616e4a Reviewed-on: https://chromium-review.googlesource.com/1072417Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561684}
-
John Rummell authored
If Widevine comes with an improperly formatted manifest file, don't register the CDM and indicate the failure to the component updater so that Widevine doesn't show up in chrome://components. As the latest version of Widevine is bundled with Chrome, any invalid manifests should be caught by the Chrome waterfall. BUG=837840,841988 TEST=tested locally with incorrect manifest Change-Id: I51993f4748c23436cddcc2dd35c33333d2ad27e8 Reviewed-on: https://chromium-review.googlesource.com/1056202Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#561683}
-
Marijn Kruisselbrink authored
The use counter is showing pretty much zero usage of this API, so as a first step towards removing the implementation of DownloadToFile, this changes the exposed API to always fail when attempting to use it. Bug: 823522 Change-Id: Ic82280d3d203684467fa4845b255cff9a02e1e12 Reviewed-on: https://chromium-review.googlesource.com/1062705Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#561682}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0f8aab8b5421..ba1627086779 $ git log 0f8aab8b5..ba1627086 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 brandon1.jones Fix entry point generation on non-Windows 2018-05-21 tobine Enable sysroot install on x86 & x64 based-systems 2018-05-17 jmadill dEQP: Abort gtest run on exception. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I0880eb7566b1db48481f1c2b6596bf379d124441 Reviewed-on: https://chromium-review.googlesource.com/1072425 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561681}
-
David Jacobo authored
This CL allows ArcExternalProtocolDialog to use omnibox's IntentPickerView icon as an anchor for the picker UI. For that we had to plumb a new flag to ShowIntentPickerView, notice that IntentPickerBubbleView::ShowBubble() already expects this flag so it was only plumbing. Make sure omnibox's icon is not visible after the user takes a decision in the picker UI, at the moment the way IntentPickerView queries for apps is not compatible with a persistent non-http(s) url. Bug: b/67653046 Test: Try Change-Id: I0d0457ecbbebc2e6556db0bb54e394038c7f6cdf Reviewed-on: https://chromium-review.googlesource.com/1069597 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#561680}
-
Erik Staab authored
Bug: 731967,790413 Change-Id: I3b6043efbad9d35a86b19c7b40970ee8df29df4c Reviewed-on: https://chromium-review.googlesource.com/1072799Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561679}
-
Philip Rogers authored
This patch removes the !RLS codepaths in PaintLayerCompositor (PLC) because PLC does not create layers with Root Layer Scrolling (RLS). Now RLS has launched, we can remove this obsolete technology. Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I999a7239c88acd48ba781ff5bcdcd6079994daaa Reviewed-on: https://chromium-review.googlesource.com/1072487 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#561678}
-
Oskar Sundbom authored
CL 5 of 5 to plumb echo canceller output device information from the renderer into native AEC implementations. For a full outline of the changes, see: https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I945a8e30fbf1410a00167c2a50930639c20835be Bug: 837661 Reviewed-on: https://chromium-review.googlesource.com/1032594Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#561677}
-
Chris Harrelson authored
Previously, we used the bounds of the containing block. This can be very inefficient in cases such as long paragraphs of text within a single block, leading to excessive numbers of column fragments. Bug:797591 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I455ef37cad4d97f8069aa37dc3542e290b6aeab6 Reviewed-on: https://chromium-review.googlesource.com/1070562 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561676}
-
Andrey Kosyakov authored
This introduces additional methods in headless::Request so that we can stop exposing GetURLRequest(). The end goal is to be able to have different Request implementations not backed by a URLRequest. TBR: eseckler@chromium.org, alexclarke@chromium.org Change-Id: Ibdf18d28851e69c986b22f441692e94cb017d50d Reviewed-on: https://chromium-review.googlesource.com/1072230Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561675}
-
Philip Rogers authored
This patch removes the !RLS codepaths in paint layer clipper and root scroller controller. Now that Root Layer Scrolling (RLS) is enabled by default, this code is no longer needed. Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I55e925d572dfbcee2cb4db53c73ca9f841a4d01b Reviewed-on: https://chromium-review.googlesource.com/1072632Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561674}
-
Andrey Kosyakov authored
Drive-by: merge entries for timeline-recalculate-styles.js TBR: alph@chromium.org, jam@chromium.org Bug: 823837 Change-Id: I8d29104d3784747bfb5260c8349d409dc7d016f5 Reviewed-on: https://chromium-review.googlesource.com/1072413 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#561673}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/833f5ebf894b..34f5f28603eb $ git log 833f5ebf8..34f5f2860 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 maruel [client] trim old named caches and CIPD. 2018-05-16 sergeyberezin [swarming.py] Allow description in query-list to be optional. 2018-05-14 maruel [client] stop mocking the file system in some unit test 2018-05-14 maruel [client] fix isolateserver client file mode handling with tarred filed 2018-05-14 maruel [client] better handle tarfile created on other OSes 2018-05-04 maruel [swarming] Add new task result state NO_RESOURCE Created with: roll-dep src/tools/swarming_client Change-Id: I58e9bde586483a74c9ce4d7130f40aed04b2a869 Reviewed-on: https://chromium-review.googlesource.com/1065469Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561672}
-
https://www.google.de/search?q=v8Camillo Bruni authored
Bug: chromium:829504 Change-Id: I9360d8e3d7fd50289a0b59771447ec9bdc16a2ad Reviewed-on: https://chromium-review.googlesource.com/1013489 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#561671}
-
Marijn Kruisselbrink authored
This changes two more IPCs to resolve blob URLs in blink before sending the request to the browser, hopefully covering all cases. Still only works with the network service enabled (and that's probably not going to change), but at least fixes ordering issues the network service had between resolving and revoking blob URLs. Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv Bug: 800901 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iad88fc87264b248d15b03bdad2c24d2c5a46d9df Reviewed-on: https://chromium-review.googlesource.com/899508Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#561670}
-
Jennifer Apacible authored
Currently, the window is only resizeable from the top right corner. The resizing hit points were removed on a previous change. This re-enables resizing from all sides and corners of the window. BUG: 845765 Change-Id: I04fb4dcfa5c05aa1112d13fa3d49edb37c0b054b Reviewed-on: https://chromium-review.googlesource.com/1069930Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#561669}
-
sunxd authored
Elements inside an out-of-process iframe should inherit the effective touch action of the parent frame, this CL propagates the computed touch action to all of the element's OOPIF children. Bug: 759042 Change-Id: I2ddfbd0a75ad7166a6ec94a44e039ea7384c7947 Reviewed-on: https://chromium-review.googlesource.com/982154Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#561668}
-
Joe Mason authored
Bug: 846055 Change-Id: Ibe860e7e25fb4396af0e48d34b04542673ae4f85 Reviewed-on: https://chromium-review.googlesource.com/1070552Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#561667}
-
Gabriel Charette authored
Ruling out https://crbug.com/826408#c17 as the source of the issue. R=thestig@chromium.org Bug: 826408 Change-Id: I00396084d674fa2f700eb917300280b6eed1684d Reviewed-on: https://chromium-review.googlesource.com/1072030 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561666}
-
Kyle Horimoto authored
Now, when a FakeMultiplexedChannel is disconnected, it notifies its delegate. Bug: 824568, 752273 Change-Id: I52a5368b374c7633a09a5c154a37f972d7a207c7 Reviewed-on: https://chromium-review.googlesource.com/1072729Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561665}
-
Christian Biesinger authored
This allows us to get "correct" sizing of orthogonal children when computing min/max content sizes. I have not verified if this behavior is 100% correct per the spec, but it certainly gets us much closer and allows us to pass a number of additional tests. This is done by adding a writing_mode parameter to NGLayoutInputNode::ComputeMinMaxSize, and the block node is then responsible for producing right value for that writing mode. If orthogonal, it does layout with the given constraint space, if any. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5cf30a91b9548a3894c2bee483ec3245fec962e6 Reviewed-on: https://chromium-review.googlesource.com/1069848 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561664}
-
Tom Anderson authored
R=dpranke Change-Id: I469e7e478141e7c389f7a16a5e860122785bab44 Reviewed-on: https://chromium-review.googlesource.com/1072740Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561663}
-
kristipark authored
Bug: 837798 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaf540c17a0c45da7b4197f4c8e80f0d8c1b8c10c Reviewed-on: https://chromium-review.googlesource.com/1069967 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#561662}
-
David Grogan authored
It previously inherited from LayoutNGBlockFlow, which, aside from violating is-a, prevented inline flex children from being blockified -- LayoutNGBlockFlow::AddChild does not call LayoutBlock::AddChild, which is where the blockification happens. Considered inheriting from LayoutFlexibleBox to get better baseline and intrinsic size support, but those will have to be reimplemented in LayoutNG anyway. With this change, IsLayoutNGMixin() is even further insufficient to check if a LayoutObject is implemented in NG. I modified some of the checks to include IsLayoutNGFlexibleBox, but am not sure about the accuracy. mac-specific css3/flexbox/button-expected.png is because the underline in the link is 1 pixel shorter. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I42811edeb53e8e2a80a64d5b30bf6627e0957b7d Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/1062499 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561661}
-
Xi Cheng authored
... as this is unnecessary. Bug: 734095 Change-Id: I1fc028c91ecf5c282f72b749cdd6283ed8e19e86 Reviewed-on: https://chromium-review.googlesource.com/1070624Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#561660}
-
arthursonzogni authored
I am working on https://crbug.com/831155. Some tests that are relying on how things are scheduled in Blink are failing. There was a race condition in this test. The iframe "#fr2" was asked to navigate to a first URL, but soon after, a javascript function modifies the iframe.src to navigate elsewhere. What happened when it didn't work? 1) The first navigation starts. 2) The second navigation is scheduled (See blink's NavigationScheduler) 3) The first navigation commits. FrameLoader::CommitProvisionalLoad() executes: frame_->GetNavigationScheduler().Cancel(). It cancels the second navigation. This CL fixes the race condition. Bug: 831155 Change-Id: I2dd951140b4c5a671c749348ca0247f1901d8b77 Reviewed-on: https://chromium-review.googlesource.com/1069013 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561659}
-
Xiaohan Wang authored
This CL adds MediaCryptoDeferrer to ensure there will be only one provisioning flow at any time. If NotProvisionedException is thrown when another provisioning flow already started, the MediaCrypto creation process will be deferred and resumed when the previous provisoning process finishes. If creating MediaCrypto doesn't trigger provisioning, it'll not be affected. Note that when we resume the MediaCrypto creation, we may trigger provisioning again, which is also handled in MediaCryptoDeferrer. This could happen when per-origin provisioning is enabled and we have different origin IDs. MediaCryptoDeferrer is only used when mRequiresMediaCrypto is true. Bug: 834965 Change-Id: I4e9ce60acbb6132b8170b9f47bc85ef5fc946f4c Reviewed-on: https://chromium-review.googlesource.com/1071103 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#561658}
-
Sergey Volk authored
I've accidentally copied the values into wrong sections, they need to be swapped. Bug: none Change-Id: I19cb35c593b3e8666371b9d135d54a48e39c1086 Reviewed-on: https://chromium-review.googlesource.com/1072526Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#561657}
-
James Cook authored
Mash services like tap_visualizer are launched as utility processes so Chrome's crash reporting system works fine with them. Using chrome's crash system gives us Chrome's version number for the crashes (which makes sense, since the services are built into the chrome binary), support for chrome-specific crash features like crash-keys, etc. Override the process type with the service name so these crashes show up independently in the crash console, similar to what we do for extension renderers. Bug: 846123 Test: browser_tests, also kill -SEGV the tap_visualizer process and check reports Change-Id: I133aedcf1f263beb2d349e9bc24e5b3624d03ea8 Reviewed-on: https://chromium-review.googlesource.com/1072205Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561656}
-
rbpotter authored
Bug: 844513 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic00f1af465b742a23701a85aad2f0d68d22f8808 Reviewed-on: https://chromium-review.googlesource.com/1071071Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#561655}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7dc0e251e9a9..9a12da75442c $ git log 7dc0e251e..9a12da754 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 wangxianzhu Update reference builds of all channels 2018-05-24 csharrison Fix chown cmd in AndroidPlatformBackend.PushProfile Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia1f0a72544bf46fdf0d3ec443ea6d9959000411b Reviewed-on: https://chromium-review.googlesource.com/1072149Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561654}
-