GitLab

iOS apps are not notified if the user opened a file in Extension via
Open In.. menu. So the old metric name (No action) was not correct,
because this value was reported if the user discarded download or opened
in extension.

This CL renames the enum and histogram values to "No action or opened
via extension".

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6eea112f9016a46a3a91d094e4dd1b1364b20c2e
Reviewed-on: https://chromium-review.googlesource.com/986714
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547523}

In unit tests, this isn't true as the object is a MockResourceContext. For now the quick fix is to check for the safe browsing service being available before trying to add its throttle, as it isn't set in unit tests.

Bug: 828062
Change-Id: Ibb2d65307b72f02fe1e0de27797ca834f01cb184
Reviewed-on: https://chromium-review.googlesource.com/990724Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547522}

- Add libcronet.so to cronet_tests rpath.
- Use trivial ProxyResolutionService to avoid crashes.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3a114b098a4d78e4087be948dfd3ce303d6df737
Bug: 813226
Reviewed-on: https://chromium-review.googlesource.com/987521Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547521}

Also do not override payment app's name and icon if they
are not valid.

Change-Id: Ib2b9f2f4d5adca9c3ae8513c1152f878a53cb723
Reviewed-on: https://chromium-review.googlesource.com/986639Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547520}

We need to clip infobar child elements to the "bar" portion of the infobar.
Previously, this couldn't be done simply by clipping to the infobar bounds,
because the top arrow meant the infobar bounds extended up past the bar.  Now
that arrows are dead, |child_container_| is no longer necessary.

BUG=none
TEST=none

Change-Id: Ib9c2ec62638eff1043d6e7a43bdb6648e0a08289
Reviewed-on: https://chromium-review.googlesource.com/989286
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547519}

The geometry in client controlled uses only for client area, while it is
for the entire widget for other cases. This allows each case to implement
their own logic to compute the widget bounds.

Bug: b/33693796
Test: no functional change.
Change-Id: Ie9bb5272d4c4cbf2b86f8f428a3fa8c774490d67
Reviewed-on: https://chromium-review.googlesource.com/990072
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547518}

Test CustomTypesTest.EasyUnlockProximityRequiredUseAfterInvalidation
crashes after test NativeExtensionBindingsSystemUnittest.InitializeContext:

#
# Fatal error in v8::ToLocalChecked
# Empty MaybeLocal.
#

Received signal 4 ILL_ILLOPN 7f8a3c12c732
...
#4 0x7f8a3c12c732 v8::base::OS::Abort()
#5 0x000006bb0dd2 extensions::V8ValueFromScriptSource()

Change-Id: I802a95a50fb488623c7dab23c416d1c99fc2ec80
Reviewed-on: https://chromium-review.googlesource.com/989733Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547517}

This allows to reland the following WebRTC change that was reverted:
https://webrtc-review.googlesource.com/c/src/+/65700
The tests will be updated once the change is rolled in.

Bug: webrtc:7933
Change-Id: I7e8b3a0b4772d73a7e74a077310a9fa9cda331c2
Reviewed-on: https://chromium-review.googlesource.com/989025
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547516}

Make views::Widget::InitParams::context optional. This cuts some
dependencies between //chrome/browser/ui and //ash, which we need to
do for go/mustash.

Change the default display for windows that supply neither parent nor
context to the "root window for new windows" (i.e. the display where
the user last activated a window). The old behavior was to always use
the primary display. The new behavior is consistent with mash.

Fix a couple cases where windows were defaulting to the primary
display when they should have been using the display for new windows
(e.g. task manager when all browsers are closed).

Bug: 826569
Test: covered by tests
Change-Id: I4571c3c7066b4247559d43e7b1192ef8411f8919
Reviewed-on: https://chromium-review.googlesource.com/988732
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547515}

SearchResult::distance_from_origin_ is generated in ui and used in
chrome only for metrics.

Bug: 733662
Change-Id: I2ecc9d2f666b95fa9f487332b6210a5342850000
Reviewed-on: https://chromium-review.googlesource.com/990199Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#547514}

1) third_party_dlls cleanup on init failure.
2) LogLoadAttempt() arguments now std::strings.
3) IsModuleListed() now takes hashes instead of data. (In practice, the caller needs to
hold the hashes.)
4) Expose GetFingerprintHash() utility function from packed_list_file files, which
takes required data and generates the expected hash string.
5) Drop in an empty shell for the hook files.  Next CL will include the contents.

Bug=769590
Test=chrome_elf_unittests.exe, ThirdParty*

Change-Id: I541e489cf9dc2dd1448b84b283ca96593f025c13
Reviewed-on: https://chromium-review.googlesource.com/982492
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547513}

Bug: 815060
Change-Id: I358fca7bfeb19ef035703f37318f7eb0c90d7015
Reviewed-on: https://chromium-review.googlesource.com/976550Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547512}

Add "Q" to the isAtLeastP implementation in BuildInfo.java

Bug: 828053
Change-Id: Ifabf73529577332c3cf6e889f1f22d70990d1c94
Reviewed-on: https://chromium-review.googlesource.com/990632Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547511}

Change-Id: If0b061398f6f6c3977abf710d45602f2556650c2
Reviewed-on: https://chromium-review.googlesource.com/978942Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547510}

R=abdulsyed@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6da77c5c688df277827c7382eb9d4fd12a2b050b
Reviewed-on: https://chromium-review.googlesource.com/990652Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547509}

EnsureProcessTerminated() is used by a parent process to ensure that a
child process it expects should exit "soon" actually does so. The child
process is asynchronously monitored, and forcibly terminated if it
fails to exit in a timely manner. Under POSIX platforms the child
process Id is also reaped with waitpid(), to release its exited
"zombie" process structure.

We had ended up with separate implementations for each platform, each
with different properties.

This CL makes the following changes:
- Reimplements POSIX EnsureProcessTerminated using base::Process.
- Provides a common implementation for platforms on which there is no
  need to waitpid() to cleanup zombie processes.

The Mac specialization will be replaced with an asynchronous
implementation in a subsequent patch.

Bug: 806451, 750756
Change-Id: If251dc13e7ad0a0cffb4f1921897a89305d6cb21
Reviewed-on: https://chromium-review.googlesource.com/920799
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547508}

A lot of this is NOTIMPLEMENTED(), but it's a start.

BUG=none
TEST=none

Change-Id: Icfad2881a20e6da11efff6d048fe64cad8bf7db7
Reviewed-on: https://chromium-review.googlesource.com/987236
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547507}

This uses the new TextureLayer APIs to register SharedBitmapIds instead
of using ClientSharedBitmapManager, in order to get the registration in
the same IPC channel that the compositor uses for submitting frames
that include the Pepper2d shared memory bitmaps.

The formula used for this change is:
- Change std::unique_ptr<viz::SharedBitmap> to scoped_refptr<cc::CrossThreadSharedBitmap>
- Allocate shm with viz::bitmap_allocation instead of with viz::SharedBitmapManager
- Generate a SharedBitmapId when allocating and register it with SharedBitmapIdRegistrar
- Store ownership of cc::SharedBitmapIdRegistration alongside each cc::CrossThreadSharedBitmap
- Remove forward decls/includes for SharedBitmap and SharedBitmapManager (still need for SharedBitmapId)

R=piman@chromium.org

Bug: 730660
Change-Id: I6018650bde54e966bae07a6621055c9f5eece648
Reviewed-on: https://chromium-review.googlesource.com/986985Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547506}

BUG=b/33693796
TEST=covered by unittest

Change-Id: Ie48bb6e93c3e591fd749b996bd8294f87def0ec6
Reviewed-on: https://chromium-review.googlesource.com/990082Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547505}

This is to gain some more understanding about how request and response
header modifications are used in practice. See bug for more details.

Bug: 827582
Change-Id: I589483173d16988f1c0676cd0a6d768da12e1037
Reviewed-on: https://chromium-review.googlesource.com/988237
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547504}

Chrome uses MediaPlayer to handle HLS videos on Android. Starting from
Android P, the default return value for isCleartextTrafficPermitted() is
changing to false. This breaks MediaPlayer playback. We need to
explicitly set the cleartextTrafficPermitted flag, in order to maintain
the same behavior as O.

Bug: 827265
Change-Id: Id162ff32684ed0caee6e40a071892e883a44ef40
Reviewed-on: https://chromium-review.googlesource.com/988304Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547503}

Change-Id: I7251d6d06c993d241233e27b59ca598594a322a9

NOTRY=true # documentation change CL

Change-Id: I7251d6d06c993d241233e27b59ca598594a322a9
Reviewed-on: https://chromium-review.googlesource.com/990590
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547502}

This uses the new TextureLayer APIs to register SharedBitmapIds instead
of using ClientSharedBitmapManager, in order to get the registration in
the same IPC channel that the compositor uses for submitting frames
that include the TestPlugin's shared memory bitmaps.

The formula used for this change is:
- Change std::unique_ptr<viz::SharedBitmap> to scoped_refptr<cc::CrossThreadSharedBitmap>
- Allocate shm with viz::bitmap_allocation instead of with viz::SharedBitmapManager
- Generate a SharedBitmapId when allocating and register it with SharedBitmapIdRegistrar
- Store ownership of cc::SharedBitmapIdRegistration alongside each cc::CrossThreadSharedBitmap
- Remove forward decls/includes for SharedBitmap and SharedBitmapManager (still need for SharedBitmapId)

However, for TestPlugin a SharedMemory, and thus, a SharedBitmapId, is
only given to the compositor a single time ever, and deleted in the
ReleaseCallback. As well the SharedMemory is allocated earlier than
when it is given to the compositor. So the SharedBitmapId registration
is delated from the allocation step to where the SharedMemory is handed
to the compositor. But since we only use a SharedMemory once, we can
always do the registration there without any conditions.

R=piman@chromium.org

Bug: 730660
Change-Id: Idaf69b854062482f55d359f7542f576be7df1dd4
Reviewed-on: https://chromium-review.googlesource.com/987096
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547501}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I26277bdb085fa06f5e9e6419f379b6f3f085e814
Reviewed-on: https://chromium-review.googlesource.com/986259
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547500}

Added simple BrowserContext, NetLog and UrlRequestContextGetter
implementations for WebRunner on Fuchsia.

Bug: 822474
Change-Id: I15e894b9909253146ab6bb2450ec3ffea2c8ea10
Reviewed-on: https://chromium-review.googlesource.com/988933
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547499}

The link at the top of this README claimed that it was a subset of itself.
Links to the EDK and C system documentation are a little more useful :)

R=rockot@chromium.org

R: rockot@chromium.org
Change-Id: I314fadea0f40e8b999c03b7414862b0e1602ed1e
Reviewed-on: https://chromium-review.googlesource.com/985241
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547498}

The GLDEBUGPROC type was fixed in mesa by https://crrev.com/c/969083 so
we can fix the skia binding code to not require a reinterpret_cast.

Bug: 786591
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4d36d115b1423a353af81c69a18d743007cebd85
Reviewed-on: https://chromium-review.googlesource.com/985801Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547497}

Bug: 805224
Change-Id: I08528e44e79d0a097cfe72ab4949dda538efd098
Reviewed-on: https://chromium-review.googlesource.com/988695Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547496}

This will be used to hold back display of the Emoji menu item until full cross-desktop support is complete.

Bug: 827404
Change-Id: I65e72e8da9ab1864f0773d51fe9facc9c4fc1a44
Reviewed-on: https://chromium-review.googlesource.com/988683
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547495}

Bug: 809261
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idafb2b4cc5da3d6c7a054e479745288cc3b86513
Reviewed-on: https://chromium-review.googlesource.com/984338
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547494}

Bug: 793908, 793907
Change-Id: I28335e470c902c18f9aaed5d2611e1ac090cac53
Reviewed-on: https://chromium-review.googlesource.com/990208Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547493}

This test checks for a specific contentOffset, which is different under the
UIRefresh experiment.

BUG=825431

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibe5e4743eb6471025fde7b27785a4267f42e0e91
Reviewed-on: https://chromium-review.googlesource.com/989250
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547492}

1. Styling was updated for more consistency with the rest of the
   DevTools.
2. Ctrl/Cmd + F on the Network panel will now open network search view.
   Ctrl+Shift+F (Cmd+Opt+F) will open sources search globally.
3. Bugfixes.

R=pfeldman

Change-Id: Icab3bddc60fbcf3a4893171f92f59ff2247d0323
Reviewed-on: https://chromium-review.googlesource.com/988938Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547491}

This reverts commit 579e583e.

Reason for revert: monochrome_apk_checker.py needs to be updated.
crbug/827937

Original change's description:
> Reland "Reland "Enable extracting unwind table on official builds without channel""
> 
> This reverts commit 2298aca2.
> 
> Reason for revert: Remove changes made in monochrome since apk merge script needs to
> be updated first.
> 
> Original change's description:
> > Revert "Reland "Enable extracting unwind table on official builds without channel""
> >
> > This reverts commit 0db71a0d.
> >
> > Reason for revert: Monochrome apk merge is failing because the unwind
> > file for both apk has the same name.
> >
> > Original change's description:
> > > Reland "Enable extracting unwind table on official builds without channel"
> > >
> > > This reverts commit a2474b64.
> > >
> > > Reason for revert: The failure was due to parent CL getting reverted
> > > Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452
> > >
> > > Original change's description:
> > > > Revert "Enable extracting unwind table on official builds without channel"
> > > >
> > > > This reverts commit eb07cea1.
> > > >
> > > > Reason for revert: Windows tryjobs are failing.
> > > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example.
> > > >
> > > > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion.
> > > >     "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table",
> > > >                                 ^------------------------
> > > > "can_unwind_with_cfi_table" is not currently in scope.
> > > > See //BUILD.gn:65:5: which caused the file to be included.
> > > >     "//base:base_perftests",
> > > >     ^----------------------
> > > > GN gen failed: 1
> > > >
> > > > Original change's description:
> > > > > Enable extracting unwind table on official builds without channel
> > > > >
> > > > > This CL enables extraction of unwind tables for chrome when
> > > > > is_official_build is set to true and when android_channel is not set to
> > > > > a release channel. This affects build time only on official builds.
> > > > > Also, Set legacy heap profiler to use unwinder for profiling.
> > > > >
> > > > > TBR=dpranke@chromium.org
> > > > > BUG=819888
> > > > >
> > > > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244
> > > > > Reviewed-on: https://chromium-review.googlesource.com/976944
> > > > > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#546425}
> > > >
> > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> > > >
> > > > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 819888
> > > > Reviewed-on: https://chromium-review.googlesource.com/983893
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: agrieve <agrieve@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#546478}
> > >
> > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> > >
> > > Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 819888
> > > Reviewed-on: https://chromium-review.googlesource.com/985112
> > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#547196}
> >
> > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> >
> > Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 819888
> > Reviewed-on: https://chromium-review.googlesource.com/989153
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547332}
> 
> TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org
> 
> Change-Id: I7750c70e52b55ccfbf1e2457a19fee4852575e59
> Bug: 819888
> Reviewed-on: https://chromium-review.googlesource.com/989192
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547361}

TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 819888
Change-Id: I064a5bdae54fa1552eee14ee72d08f15cf081a63
Reviewed-on: https://chromium-review.googlesource.com/990092Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547490}

BUG=820250

Change-Id: I0bda360c1bf70887a56937ce0fc42f05c9d37083
Reviewed-on: https://chromium-review.googlesource.com/990193Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547489}

This is less likely an issue because I'm no aware of an app that can't
be maximized/snapped in chrome (arc will use different code path)
but this is right thing anyway.

Bug: None
Change-Id: Ia7f49fd99000574b9431218b3be873baed9afdd0
Reviewed-on: https://chromium-review.googlesource.com/987542
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547488}

Changes:

Create docs/speed/benchmark/ folder
Move docs/speed/benchmark_harnesses/telemetry_device_setup.md to docs/speed/benchmark/
Move the rest of the docs in docs/speed/benchmark_harnesses to docs/speed/benchmark/harnesses

Change-Id: Ief809e8bc2da776ece0c595c449fd9b7f676825f

NOTRY=true # This is just documentation change

Change-Id: Ief809e8bc2da776ece0c595c449fd9b7f676825f
Reviewed-on: https://chromium-review.googlesource.com/990579
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547487}

This removes the feature from behind the flag to prepare for launch.

The string change was has been approved by the UI team.

Bug: 801410
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I348caab1905fba8d54f2981bd15e55301f6aad9e
Reviewed-on: https://chromium-review.googlesource.com/981158Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547486}

Just moving the files, no functional changes.

BUG=803135

Change-Id: I4784172d7b41152531ae3cb7e569613b66132cc7
Reviewed-on: https://chromium-review.googlesource.com/988416Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547485}

Creating common UI Element, Root Element, DOM, CSS and Overlay agents
for UI and Viz DevTools to avoid dependencies. CSS agent contains only
common logic, so there won't be ui-specific or viz-specific CSS Agent.

All the ui_devtools/views/ files are built for aura only. Once we add
Viz logic we want it to work in the same manner but with Viz objects. So
Agents' functionality and the structure of the UIElements must be left
as is. But currently all the agents and ui elements in UI DevTools are
the mix of aura-functionality (like DOMAgent::BuildTreeForWindow) and
non aura-functionality (like DOMAgent::GetDocument). If we just move
all these files to components/ui_devtools (assuming they'll be common
for Viz and Aura) Viz will then have to include aura as a dependency.
So I'm just separating aura-specific functionality (and leave it in
ui_devtools/views) from common functionality which I move to components/
ui_devtools.

Bug: 816802
Change-Id: I3fd3eaca1cd2a7cc8528c12d20979cddfaed994e
Reviewed-on: https://chromium-review.googlesource.com/979135Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#547484}