- 31 Oct, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change makes use of NO_UNIQUE_ADDRESS in flat_tree, allowing the removal of an internal class which just existed to make use of the empty base optimization. Bug: 682254 Change-Id: Iabf91d4acee95c7ba4e929d23528d95b0ced1612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509757Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#822948}
-
Ian Kilpatrick authored
Previously we added the LayoutNGWebkitBox flag in: https://chromium-review.googlesource.com/c/chromium/src/+/2451732 and changed the box construction. However we missed the whole subtree de-opt within element.cc. This patch removes that whole subtree de-opt and applies the following fixes: 1) de-opts if we encounter a -webkit-box in a NG fragmentation context. 2) For 'auto' flex-basis, treats them as if they were 'fit-content'. 3) Places any visible overflow to the line-right direction. This also removes: fast/deprecated-flexbox/012.html as it was newly failing as FlexNG calculates the static-position offset slightly differently for -webkit-box. Our behaviour now matches Firefox. Outside of this the test wasn't particularly interesting, and better tests exist in the WPT repository. Bug: 845235 Change-Id: If8e2b0f3fd978afcb65f92a069ad910a7adb86f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490323 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822947}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for project details. Bug: 1080832 Change-Id: I00908679918e2c2316b25d9fd834914e540bd163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512484Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#822946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaa503ed7f5c..356ebc1f11ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1100642 Tbr: Change-Id: I82a8ff96540d5b1d09d961f061e45587c6161703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512705Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822945}
-
Gavin Williams authored
Add a custom title to the select dialog the user opens to choose where to save completed scans. Screenshot: http://screen/dnTcAPoV48BZmDJ Bug: 1059779 Change-Id: Ie3780519977b874b6330f40fdf0074c2dc73e1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508877 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822944}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6bc1c128830e..df2d5dbd0632 2020-10-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie1c52e8c40b1e4bd693413adab393cb8be03ffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822943}
-
Ben Joyce authored
Locally reduces test runtime from 3.5 min to 1.5 min on 4 shards. On bot, seems to reduce it from 4min 36 sec to 2min 10 sec. Shards are set to 1, can introduce shards as higher in recipe or experimentally. Need to land after: https://chromium-review.googlesource.com/c/chromium/src/+/2506172 Bug: 1138506 Change-Id: I936924222991cfc640f611e359148f74f412d78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490847 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#822942}
-
David Black authored
Previously clipping was done while painting. Now, we'll pre-clip the image on image change events. This will reduce the amount of work needing to be done during the paint sequence. Bug: 1142572 Change-Id: I9675afc3ce7f3216cc0d43fbf2d44d8c3e07fc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509947 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822941}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/415d1ec806bb..1443e5ac0acf 2020-10-30 tsepez@chromium.org Remove unused CFWL_Edit::ValidateNumberChar() and DrawTexBK() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2c6ec40c78741c684f995a49d75f4af0289fc12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511905Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa71f05ed064..eaa503ed7f5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141619 Tbr: Change-Id: I4e344ccc17a8e2d9cdd12c8ca8d06bc18129056b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511904Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: Id61bbb285fd938b406c0dd43b6d6ea7b1df2c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505948 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#822938}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df208a341b64..de48febf8bd2 2020-10-31 jmbetancourt@google.com force drawFrame when new surface is created 2020-10-30 reed@google.com do work in onBefore, not in constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I4c5ad59514ee3fc23f1e021d50d732d44df07c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511836Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I4a3a8090b3b03a68c9d214f8ef0b9c26eebe2dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508333 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Michael Thiessen authored
This change may (ironically) make some tests flaky as it speeds up Activity launch during tests, which, prior to this change, masked some conditions tests should have been waiting on but weren't. DeferredStartupHandler only runs when idle, so polling the UI thread for its completion can increase how long it takes to run these tasks. Also, only one task was being run per Idle period, regardless of how long the Idle period was. This change converts it to use a CountdownLatch that can be waited on on the Instrumentation thread without preventing the deferred tasks from running, and re-checks for idleness to be able to run multiple Idle tasks in a single Idle period. It also fixes waiting for tasks to complete for the second and later Activity launch during a test, which didn't work at all. Bug: 1134178 Change-Id: I0215f2e108632b84e3ea1a47b887dc9e4e5836f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491057 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I60979ff0b81bd514c1851aa1f4790cc85473efae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512524Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822934}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cb2f21d0af42..1003fa794677 2020-10-31 alexleung@google.com Update Cast Media Runtime files that were missed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I99e323cb29d860bca8d13ddccd2c15acd27cbd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511832Reviewed-by:
-
Chris Thompson authored
Bumps the flag for the Legacy TLS interstitial (on Desktop) to expire in M-92, which is the release after we plan to remove support in May 2021. Change-Id: I7b3e00c1777b2a9c8a50d4f4c223459729b708b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508634 Auto-Submit: Chris Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#822932}
-
Sven Zheng authored
Bug: 1133499 Change-Id: I868514ca0ef55ce2f9b45b7206283ff477877ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510880Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822931}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604080750-57b938941e5d0fc2e4e9a8db795b6e934af11898.profdata to chrome-mac-master-1604102313-62a5870852d3f270530ddcb01f9462f63d32dd85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If7adc5e2f614eafe6e78fcbf1d00e3638f5fa017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512445Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604080750-96a3ce07c396c7c5f9c28dac9995321371c2c9a1.profdata to chrome-linux-master-1604102313-6511a5d636270bec531104682121d6c64f4f3624.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic6a0f18d9faa2dff4adabb4a8879237dba41cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511902Reviewed-by:
-
Hiroki Nakagawa authored
`PrerenderManager::mode_` is always PRERENEDR_MODE_NOSTATE_PREFETCH in production code. We no longer have to keep the other PRERENDER_MODE_SIMPLE_LOAD_EXPERIMENT mode. Bug: 755921 Change-Id: I3607d878e709484ef3366b73377645365935fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486824Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#822928}
-
Yuly Novikov authored
Disabling test failures found in try runs Bug: 1134735, 1144207, 1144247, 1144258, 1144270 No-try: true Change-Id: I48fc3daa05cc7673de4f820d07ca0b84ea285b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506106 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822927}
-
Gavin Williams authored
This change adds a option to the Scan To dropdown that opens the select dialog and lets the user choose the directory to save completed scans. Screenshot: http://screen/dnTcAPoV48BZmDJ Bug: 1059779 Change-Id: Id35ed06fff8fe1f4ca4c3e0c8c6d5ace852ea750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508151 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#822926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/750109bfd19d..df208a341b64 2020-10-30 tdenniston@google.com [svg] Add several skeleton classes for filters 2020-10-30 tdenniston@google.com [svg] Add 'filter' presentation attribute and parsing 2020-10-30 jmbetancourt@google.com add non-looping option to SkottieViews through xml attributes 2020-10-30 csmartdalton@google.com Fix crash in SampleCCPRGeometry 2020-10-30 johnstiles@google.com Fix unknown-identifier issue discovered by fuzzer. 2020-10-30 tdenniston@google.com [svg] Rename gradient units type to object bounding box units 2020-10-30 johnstiles@google.com Add initializer_list support to SkTArray. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I475a379da4f7a5106f8354a6c179034c483b81b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511196Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cabef8da90bf..fa71f05ed064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059013,chromium:1112471 Tbr: Change-Id: I9ff945fd97f6576800a39c25ecb06a9f5c041590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511898Reviewed-by:
-
Lukasz Anforowicz authored
After pressing ui::VKEY_BROWSER_BACK, the test needs to wait for the navigation to finish + for the load to finish. Both can be accomplished with the help of content::TestNavigationObserver. Fixed: 846623 Change-Id: I1e7ab80ad4caa37b12c2e99a50eba2393b4bc2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511253 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822923}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5a1d786754ad..0a374dce6653 2020-10-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 17e0deaebaa6 to 5bee67fced90 (1 revision) 2020-10-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5d40a5621b7d to 17e0deaebaa6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I706e53408f86c38afd8d5c3d22ae459c8a415713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511895Reviewed-by:
-
Collin Baker authored
This feature is already enabled on non-ChromeOS desktop platforms. It is also enabled at 50% non-stable and 4% stable for ChromeOS, without issue. Fixed: 1069634 Change-Id: Ia510899463ba7b33c48b72d9d67ea4235fca06cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510713Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822921}
-
Anupam Snigdha authored
This patch contains the geometrychange JS event and overlayscontent implementation of the new VirtualKeyboard APIs on Android. This is a new feature that would let web authors to control whether they want the default occlusion of web content and changing of visual /layout viewport in response to VK visibility or not. The explainer has some examples as to where this would be useful and how it would be used by the web authors. Test page: https://bocupp-microsoft.github.io/VirtualKeyboard/geometrychange.html Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardAPI/explainer.md Design Doc: https://docs.google.com/document/d/1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing Check the Android Design section for more info on the proposed design We also discussed in the TAG review about this event and haven't seen any objections yet. https://github.com/w3ctag/design-reviews/issues/498 Bug: 856269 Change-Id: I42a7fa737dec06be04b8b1a59b3f511d3678c791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463811Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822920}
-
Joon Ahn authored
`browser_tests --gtest_filter=DiagnosticsApp*` to run in a single instance. `browser_tests --run-manual --gtest_filter=DiagnosticsApp.MANUAL_*` to run each test on a new instance. Bug: 1125150 Test: Described above. Change-Id: Iebef0469550523c2ef588e6ff6816ee2cc54683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508792 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
-
Peter Kvitek authored
These ifdefs were there since the test was part of Compositor fixture, which is not the case anymore, hence no need to limit testing on platforms that don't support BeginFrame control. Change-Id: I331e656ea64e7f2941a2eb3b7584b98caf21ceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511855Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822918}
-
Miriam Zimmerman authored
The resizeTo function is deprecated, and it set the height of the overall window -- including window chrome. On mac, there are 20px or so of chrome at the top of the window. This resulted in the window being too short. See https://developer.chrome.com/apps/app_window#type-AppWindow TEST=on my personal mac, edit html of feedback page to contain an extra\ line, then edit feedback JS to match this CL and run \ resizeAppWindow(). Verify window size is correct. Fixed: 2461725 Change-Id: I0d75d9e07d25e2a93a9c3fa17c7dbb98913724dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508974 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#822917}
-
Austin Eng authored
This adds webgl_conformance_tests with --enable-unsafe-js-fast-calls to: Optional Win10 x64 Release (NVIDIA) Win10 FYI x64 Release (NVIDIA GeForce GTX 1660) Win10 FYI x64 Release (NVIDIA) Win10 FYI x86 Release (NVIDIA) Win10 FYI x64 Exp Release (NVIDIA) They run on the trybot win_optional_gpu_tests_rel Bug: 1101475 Change-Id: Ic832e9a67528fad38874eefa70962ec70965a043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506519Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Tom Anderson authored
This is a speculative fix for a crash where seccomp blocks lazy library loading, which may occur on certain versions of the Nvidia driver. R=kbr BUG=1137632 Change-Id: I7716739263ffb3b478003ad9eef4ffaa2b6467f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510360 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Michael Hansen authored
Removes the "Contacts" title and updates strings in the description for each visibility mode to match the latest specs. Screenshots: https://screenshot.googleplex.com/An6Ta8EDzfS3KZU.png https://screenshot.googleplex.com/C5WwqifMeCnLhkH.png https://screenshot.googleplex.com/C48HQVfgouJrhHF.png Strings spec: https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag Bug: b:168841167 Change-Id: I5facb117242e22b838266c2fa5e2629b221e6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511852Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#822914}
-
Charlene Yan authored
The ID 2001 was already in use by the SendTabToSelfMenu. Also delete some unused constexprs. Bug: 1141858 Change-Id: I10f04c0eb01f17d26f4962b37789588adde3e079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495713Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- Remove unused ContiguousContainer methods such as Clear(), Swap(), etc. - Replace RemoveLast() with ReplaceLastByMoving(). This removes the logic to deal with removed items, making ContiguousContainer appending only. - Let ContiguousContainer store Buffer directly in the vector instead of through unique_ptr. - Use 'item' instead of 3 different terms 'item', 'element', 'object' in ContiguousContainer - Remove DisplayItem::IsMovedFromCachedSubsequence() because with the new PaintChunkSubset we can use PaintChunk.is_moved_from_cached_subsequence. - etc. Bug: 917911 Change-Id: I8b3004d001ea12a00fed96fc3e031986db1ee005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501064Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822912}
-
Avi Drissman authored
Bug: 1100642 Change-Id: I1e282150bd7c0774aa00f59012a14d1330d43f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511090 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822911}
-
Gordon Seto authored
Add QR code detection logic and styling to cellular esim setup. Screenshots: https://screenshot.googleplex.com/64NSd3tsBZWT2pJ.png https://screenshot.googleplex.com/7ks7FBaXpYFAt6z.png https://screenshot.googleplex.com/86VbgmA3Y2TDFAG.png Bug: 1093185 Change-Id: I9631aeeee9db8fe67a4b18cf48fd7576556b32cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495873 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#822910}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e9a7015ec876..5cbd052dfba9 2020-10-30 apodtele@gmail.com Add preamble. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4f521ab2294810c0c03ac9d3a4dcc4082d860756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509554Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#822909}
-
