- 30 Sep, 2020 40 commits
-
-
Stephen Chenney authored
The feature is ready to ship so enable as many tests as possible. Bug: 785230 Change-Id: I35cc269c6c3dfe6dc0bff211634aa75eeaa11464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438970Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#812374}
-
Oystein Eftevaag authored
base::"MessagePumpForUI::ProcessPumpReplacementMessage PeekMessage" base::ScopedBlockingCall These two trace events are now Perfetto strongly-typed trace events which means they can be sent via the Chrometto pipeline without being stripped. Additionally updated the hardcoded list of TRACE_EVENT_EXECUTION events which get converted into strongly typed events internally within the Perfetto implementation. Change-Id: If90863d59758dec62431771e7603d0dcef77e472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424502Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812373}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ad421a248adb..da5828c06b4c 2020-09-30 rharrison@chromium.org Add Tint SPIRV->SPIRV to fuzzing code path 2020-09-30 cwallez@chromium.org TextureFormatTest: Test components not present in the format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If6bff572d5de7b98048f68ead4ad74a557535b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812372}
-
Istiaque Ahmed authored
This CL adds boolean histogram indicating whether extension's background service worker script registering and starting succeeded or not. This CL also adds timing for those. Bug: None Change-Id: I0fb31609b3c54bf21970b6ea39d7bcd50d369662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437786Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812371}
-
Mike Wittman authored
Extracts the logic for determining process type from command line into a location accessible to all users, and reuses it for all cases where we determine a process type. Bug: 1129939 Change-Id: Ie021aaf7275042d7ae271f3eafa315b1efac0df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427129 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812370}
-
Thomas Guilbert authored
Currently, using the video.requestVideoFrameCallback() API to power immersive XR experiences only outputs 4fps. This is because there is no compositor emitting BeginFrame events. Painting video frames via xrSession.requestAnimationFrame() works fine however, since each call to paint queues an update for the next frame. This is wasteful, since the XR rate if often greater than the video rate (e.g. 90fps > 30fps) and we end up painting duplicate frames. This CL fixes the issue by using the XRFrameProvider's XRFrame updates to drive video frame updates. This queues a similar of frame updates as painting at the XR rate, but allows us to only paint new frames via the video.rVFC API. Bug: 1107578 Change-Id: I8a4984be191adeaaf83d4d4ef4712fe0459d8119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429974Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#812369}
-
David Bokan authored
This test was originally added to fix https://crbug.com/578554 which was that the autoscroll animation when holding down the mouse button over the scrollbar track would overshoot the cursor. The test added there was testing this in a round about way: it would click twice in the same location on the track, assuming that the animation would start but not finish before the second click. In this way, it was checking that the calculation logic was using the final position of the thumb. However, this makes an assumption about frame timing and animations. It likely became flaky in the threaded suite with the introduction of the compositor scrollbar controller, which would try to update the animation in this case. This CL replaces the test with a more direct check for the original bug by holding the mouse button down over the track and waiting for the scrollTop value to settle. Note, the test fails consistently on Mac with compositing enabled. This is due to the Mac-specific expectation for page scrolling. This specific value is implemented only on the main thread so when compositor threaded scrollbars are used, we get the same value as on other platforms. See https://crbug.com/1133538 Bug: 915926,901906,854910 Change-Id: I4e5774a0ee8452ac31b6d199b5d2c68d67feca7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438677Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812368}
-
Daniel Classon authored
Part of the set up for the metrics changes to OS Settings. Creates a wrapper class for the existing User Action Tracker so that it can stay alive outside of user sessions. Bug: 1133553 Change-Id: I9f3db611f893dcfc78638c007b27b1099f63f3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439021 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812367}
-
Ahmed Mehfooz authored
Bug: 1131258 Change-Id: Ic42c6d2765af94b79f79f5f138c7c1691cdedfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436772 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812366}
-
John Chen authored
The chromium.chromedriver builders were retired a long time ago. Clean up config. Change-Id: I77c64a7eda7639aa6d0483ff7cbf2c3738d7d01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441318 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#812365}
-
Mark Schillaci authored
This CL updates the behavior of Checkbox on Android. With this change, the mixed state of a Checkbox will now be announced during swipe navigation or when a node is initially selected. Until now the mixed state has been synonymous with false. We append the state of the Checkbox in the stateDescription element of the node's corresponding AccessibilityNodeInfo object. This CL also updates associated unit test expectations. AX-Relnotes: Checkboxes on Android will now announce "partially checked" when in a mixed state Bug: 1121750 Change-Id: Iec434d20b41ec71b4708b1815c78d3cf7b2497fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432089 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812364}
-
Guillaume Jenkins authored
Add a simple unit test case for BrowserReportGeneratorIOS class. The test generates a basic report and checks that the values in the proto make sense. Bug: 1114853 Change-Id: I18dc1114c5785a4063483614b308b1f327ce1bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439785 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812363}
-
Jordan Oroshiba authored
Instead of opening the full site settings, change the individual setting in a dialog directly and provide the option for removal of the override. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1130668#c1 Bug: 1130668 Change-Id: Ib1a0da6f637288b6a62a6b898de34fe4f647d7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422499 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#812362}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsInternetDetailPage* Change-Id: I4a713bea34443f9a834b79a769b09f67adf0495f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436783 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Copy message about https image compression from old UI to the new UI. We need to improve the design later on. Screenshot: https://crbug.com/1077766#c64 Bug: 1077766, 1101489 Change-Id: I8f68ab51388b1604372dea3815d4d999393d75fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440619 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812360}
-
Stephen Roe authored
as the bugs motivating disabling the tests are fixed. The net_unittests suite is running successfully on other fuchsia FYI and CI builders. Bug: 780652, 877248, 844416 Change-Id: Id7b46e9a450aa937b09309dff972871f359dfb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436700 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812359}
-
Yao Xiao authored
Also removes the base::Feature kInterestCohortAPI, as there's no plan for finch. Bug: 1062736 Change-Id: I19d847b92ed57ae88a4fc99bc56039c7f4feaa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434091 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#812358}
-
Titouan Rigoudy authored
These will be used to determine the path forward to an eventual removal of the feature in the NonSecure case, and a rollout of CORS-RFC1918 in the Secure case. These features are not yet recorded, but we know that the event rate will not exceed 1% of page loads. Indeed these features are finer-grained replacements for the now-obsolete LoopbackEmbeddedIn{Non,}SecureContext feature, which average less than 0.003% combined on Windows Stable. Bug: chromium:1124358 Change-Id: Ie53327654907d4b3ee8d88b91cceb957a8640602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436823Reviewed-by:John Delaney <johnidel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812357}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601451302-0fcd721072a85aa7cd1d6b997a82e6798fe72a84.profdata to chrome-linux-master-1601488745-3c2b7a3f9b9c6b0806062ba2172ccc5544f62b8d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ide1ec116afe1df0f69a5d5fe1488118f45afac48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441176Reviewed-by:
-
Taylor Bergquist authored
BrowserView::IsVisible returns false if the tabstrip is *currently* not visible, but HasVisibleBackgroundTabShapes is really just doing a sanity check that there even is a tabstrip, and doesn't actually care whether the strip is currently visible or not. I audited the other callers to IsTabStripSupported (all to do with immersive mode) and believe they are fine with this change. Also got a little bonus improvement to loading animations! They were previously shown for normal browsers to get around IsTabStripVisible returning false during fullscreen; they now use CanSupportTabStrip. Change-Id: I7823add41f9aa942056acd8b71e98c8f9d7680e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436522 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812355}
-
Dave Tapuska authored
window.open on webviews had their widgets left in half creation state which is unexpected. The Init call is supposed to be called after the Window/Widget is shown. This was not called due to the ShouldResumeRequestsForCreatedWindow callback. The ShouldResumeRequestsForCreatedWindow() is added because we want to wait until the load is complete on the embedder page so it has a chance to execute before the guest contents. Since the RenderWidgetHostImpl::Init was never called it caused an issue when input handler binding was moved to be performed during the Init call. BUG=1132643 Change-Id: If8967d21bdbeb5dd9114eb918af793f88c4fe330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438477 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812354}
-
Muyao Xu authored
Users can start a cast session from the GMC dialog by clicking on the cast sinks in the device selector list. After a new session is started, the local media notification will be hidden, and the cast media notification will show up in the dialog. Bug: b/161610050, 1107162 Change-Id: Ia3ad0634f0a45159ed92581ca2c6f097566c1a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422737Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#812353}
-
Gauthier Ambard authored
Bug: none Change-Id: Ic88c004d28ac7f6eabf2a134b483a33fd3f7a392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438051 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812352}
-
Xing Liu authored
Move ReadingListManagerImpl to its own header, there is no logic change. TBR=wylieb@chromium.org,dtrainor@chromium.org Bug: 1128074 Change-Id: I2e4f3c951e58dc1df0550b9725e8b8b830ee8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441200Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812351}
-
Jun Mukai authored
Bug: 1109851, 1037570 Change-Id: I4ed6ef065c4b731993dc9885935029510d9918ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436703Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Illia Klimov authored
This patch verifies if an origin is on CrowdDenyPreloadData or CrowdDenySafeBrowsing blocking list. If yes, the notifications permission will be revoked. Bug: 1106283 Change-Id: I73e9434d74f67281a99246fee8515a7ca604efa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301969Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#812349}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e816b5197f5e..3773c401fe1a 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I16cebc4cafd7270d29f662afe30a1c0cc876ef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441172Reviewed-by:
-
Sergey Ulanov authored
Previously cast_runner_integration_tests were creating CastRunner instance in-process instead of launching it in a separate component. As result the tests were not executing all parts of CastRunner. Particularly code in main.cc was not tested. Updated the tests to start cast_runner component in a separate process. Also updated cast_runner to allow enabling headless mode with the --headless argument. Bug: 1062351 Change-Id: Id5ea70616e069aa8416855eab613ab791283668b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113513 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812347}
-
Lei Zhang authored
- Sidenav toggle button - Sidenav thumbnails/outline buttons - Display annotations toggle Bug: 1130089 Change-Id: Ic41062ae48936efc94a3614540143ce969e14c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439643 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812346}
-
Klaus Weidner authored
The Blink WebXR code has two parallel classes. XRViewData corresponds to the internal "view" from the spec, and XRView is what is exposed to JS. XRViewData has session lifetime, while XRView is ephemeral and created per frame. This change adds a reference from the XRView to the underlying XRViewData object, as expected by the spec's algorithms. This requires making XRViewData and their containing list garbage-collected objects. Bug: 1133381 Change-Id: I696a1a899ab8fdf27a2107bbadeb61773c4ade84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438690Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812345}
-
Mohamed Adel authored
This CL introduces unittests that test both methods CreateMacNotificationTitle and CreateMacNotificationContext. Bug: None Change-Id: I18da2fee72cf5ae2aa100617fea7e2afcb97b668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438426Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#812344}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009300800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/T6gPp8Ky1tPZf16RQSiLa1YTO1Q2iv-5oa8YHP4nq8YC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/166047521 Tbr: help-app@grotations.appspotmail.com Change-Id: If5dced1f26b6bb024c506951c73fdf892198478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812343}
-
Melissa Zhang authored
This CL adds a callback when the sharesheet closes. Bug:1126788 Change-Id: Ibc5e0a0d3d0f431139af5d0d783ad398646713f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434078 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#812342}
-
Jun Mukai authored
Bug: 1089768, 1089767, 1089854, 1089855 Change-Id: I8d927ca35e82a004c8900930b09c1a9ce250b137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439418Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
mark a. foltz authored
This was to record YouTube-specific use of remote playback, which is no longer supported. Bug: 1088674,1090963 Change-Id: Ib51ce33d59abb26ad29da01d887d923495c9faa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436554Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812340}
-
Elly Fong-Jones authored
There's no particular reason for it to be on DialogDelegate since it applies to all WidgetDelegates. Bug: 1075649 Change-Id: I48da9f88b2c7b9bcc4171091eaa519ff0997bd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440285Reviewed-by:
-
Andre Le authored
This is a reland CL for crrev/c/2419552, which ran into a compilation failure and merge conflict when reland. In this CL: - Create a base class for quick actions controller. - Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states. - Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL. BUG=1106937,1126208 Change-Id: Ie8540bdc29de8b73297dcf5c3f0a0d963f76d63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438590 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
This change introduces an abstract CarouselSuggestion item that features title and configurable RecyclerView component. The content of the RecyclerView component (items) can be easily configured to display any type of elements. Change-Id: Ibdf9505c919c1f47a9cd1af14d538ff2bcbeacb3 Doc: http://doc/1IFsDKYhy_ARMOdT8jd1pMtk497xe03lb3hVnsaY-dOM Slides: http://slides/1c1SzJLzEsTjLmqIVLTomC8l9EgslBgYaBN6I7t8mbDI#slide=id.g8b3736bab3_0_0 Figma: https://www.figma.com/file/h8qjD0s9tezRzHdCMxIhYJ/On-Focus-Suggestions?node-id=290%3A309 Bug: 1106109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427724 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812337}
-
Xiaohui Chen authored
When running ash_unittests on CloudTop instance, many tests would fail with "Maximum number of clients reached" X11 error. This does not repro on physical gLinux workstation though. Adding explicitly -maxclients parameter to make it consistent across platforms. Bug: None Test: Run testing/xvfb.py out/Release/ash_unittests Change-Id: Iac41378470d87df4b5d8140b3ee03a9a93a8c5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438577Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812336}
-
Lei Zhang authored
With the SaveEditedPDFForm feature, users have several new choices for how to save PDFS. Extend the existing PDF.Actions histogram with new ChromePDFViewerActions to cover these scenarios. This will help developers understand how often these new features are being used. Bug: 1130079 Change-Id: Ifb090f74b4f369d5e7c229bdaaf69138f430dc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439553Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
