GitLab

Bug: 731985
Change-Id: I63a1602ce7ab7aea00683df8afdd41d1df4a9e59
Reviewed-on: https://chromium-review.googlesource.com/1069870Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560881}

Ensure focus remains in the textfield after the user enters a new value,
even if this changes the validity of the input.

Bug: 843952
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0fec55a89c10d4b4dcbaff219927ca26fd650594
Reviewed-on: https://chromium-review.googlesource.com/1069254Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560880}

PDF scaling was implemented by scaling the page size, which no longer
works when sending the PDF from print preview. Instead, perform the
scaling in Pdfium engine, like we do for fit to page.

Bug: 835654
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0f2c6cef995b85090a6ea0b540b5c940d7513495
Reviewed-on: https://chromium-review.googlesource.com/1036083
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560879}

TBR=bpastene@chromium.org

Bug: 731985
Change-Id: I701c5a9d2a842bcd128c45f504636fc61a9b3a54
Reviewed-on: https://chromium-review.googlesource.com/1069910Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560878}

BUG=chromium:845532
R=skau@chromium.org

Change-Id: I320f992f3f427d2a2675954eb59fc05e2a5c6a90
Reviewed-on: https://chromium-review.googlesource.com/1069837Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560877}

This reverts commit 1bdfba58.

Reason for revert: broke fuchsia
Original change's description:
> Introduce public PlatformHandle type
> 
> Adds mojo/public/cpp/platform to the public library. This includes
> a new PlatformHandle type, a thin C++ abstraction for platform-specific
> scoped handle values.
> 
> This is a precursor to moving platform channel C++ types out of the EDK
> and into the public library, and ultimately introducing a public C++
> invitation API to replace the EDK invitation API.
> 
> Bug: 844764
> Change-Id: I317decc1deb8cc47eb1000a6a19022465c392d7b
> Reviewed-on: https://chromium-review.googlesource.com/1068688
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560866}

TBR=jcivelli@chromium.org,rockot@chromium.org

Change-Id: If401afe09a2e91d5e2a0035a75db5490a41259ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844764
Reviewed-on: https://chromium-review.googlesource.com/1068219Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560876}

Currently, we have two container behaviors: full width and floating.
In the full width VK, the occluded bounds is the same as the bounds of
the keyboard window. In the floating VK, nothing is occluded.

Thus, with only these two container behaviors, we could get away with
having a single boolean function (BoundsObscureUsableRegion) that
indicates whether the occluded bounds is the bounds of the keyboard
window or the empty rectangle.

However, the new fullscreen VK has an occluded region, but it is not
the same as the keyboard window. Therefore, we need to change the
boolean function into a function that actually returns the occluded
bounds.

We also make some changes to clarify which bounds are being referred to.

Bug: 826617
Change-Id: I928294d81808cb11090f96b6fc81c6a123a2595e
Reviewed-on: https://chromium-review.googlesource.com/1067218
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560875}

This CL replaces the most of ScriptLoader references in
ScriptRunner with PendingScript.

ScriptLoader is still used
- When the script is evaluated,
  because ScriptLoader::Execute() is still in ScriptLoader.
  ScriptLoader is obtained by PendingScript::GetElement()->Loader()
  here, but this will be removed by [1] once
  ScriptLoader::Execute() is removed.
- When the script element is moved between documents, because
  we have to get PendingScript via the
  Element->ScriptLoader->PendingScript path.
  This is done by
  GetPendingScriptIfControlledByScriptRunnerForCrossDocMove()
  in MovePendingScript(), which will be the last use of
  GetPendingScriptIfControlledByScriptRunner()
  that will remain until [2] that is not planned to land soon.

No behavior changes.

[1] https://chromium-review.googlesource.com/1054553
[2] https://chromium-review.googlesource.com/1041143

Bug: 842349
Change-Id: Idc36b00c8c25fe8e24ff60e980608d8b324fec5e
Reviewed-on: https://chromium-review.googlesource.com/1053354
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560874}

- Add Round{Up,Down}ToPageAllocationGranularity.
- Add unittests for rounding.

Change-Id: I131a0b493867fbe54ca2a6d1382fa6176e984162
Reviewed-on: https://chromium-review.googlesource.com/1067524Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560873}

Ensure ARC-related consents are recorded as NOT_GIVEN if the
user cancels during initial setup or during in-session
setup of ARC.

Bug: b:79583966
Test: Cancel ARC opt-in in OOBE and from launcher, unit_tests
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I840f90af86c01f1961918b99fd10acf7ef63a354
Reviewed-on: https://chromium-review.googlesource.com/1062971Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Josh Horwich <jhorwich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560872}

Added a value to allow a resetpose event to be propogated from GVR out
to the javascript.

Bug: 843184
Change-Id: I5433be4f26af21fa09a35b7485d8c7911a5e89c2
Reviewed-on: https://chromium-review.googlesource.com/1063027Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560871}

This CL renames TrayDetailsView to TrayDetailedView, as in other places
it's always called "detailed view" e.g. CreateDetailedView(),
NetworkStateListDetailedView, CastDetailedView,
AccessibilityDetailedView, etc.

TEST=ash_unittests
BUG=none

Change-Id: I84bc2fc7ade4bc71d9907427c35501f21f9da3a6
Reviewed-on: https://chromium-review.googlesource.com/1068888Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560870}

Parse uri verifies that if a port is provided, it has a valid value.
We accept empty paths.  We also validate that there is a valid scheme
value is provided if it is found.  These requirements are now validated
via unit test.

Bug: 844521
Change-Id: I4fb28a5bba8e6bea9ac9a0bb2e6b4de21351d892
Reviewed-on: https://chromium-review.googlesource.com/1066949
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560869}

This CL adds a new UMA to track dropped download

Change-Id: I55120c5227552ac280a768e3bf2d82dd247a5329
Reviewed-on: https://chromium-review.googlesource.com/1066739Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560868}

PageActionIconViews in chrome/browser/ui/views/location_bar will get migrated
to chrome/browser/ui/views/page_action as part of crbug.com/788051.
This CL adds estade, an OWNER of location_bar, to the OWNERS of page_action.
pkasting is not being added because they have higher level OWNERS and
requested not to be added to the new directory.

Change-Id: Ia400f3b74e0cadcb719990a22a542a848d07c999
Reviewed-on: https://chromium-review.googlesource.com/1065410Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560867}

Adds mojo/public/cpp/platform to the public library. This includes
a new PlatformHandle type, a thin C++ abstraction for platform-specific
scoped handle values.

This is a precursor to moving platform channel C++ types out of the EDK
and into the public library, and ultimately introducing a public C++
invitation API to replace the EDK invitation API.

Bug: 844764
Change-Id: I317decc1deb8cc47eb1000a6a19022465c392d7b
Reviewed-on: https://chromium-review.googlesource.com/1068688Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560866}

Bug: 814117
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac4324eb5c8790edf9affec485f5a3a91c985908
Reviewed-on: https://chromium-review.googlesource.com/1068113
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560865}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/398fb44e2866..ebdd0db493b2

$ git log 398fb44e2..ebdd0db49 --date=short --no-merges --format='%ad %ae %s'
2018-05-21 ehmaldonado gclient: Remove URLs from hierarchy.
2018-05-21 ehmaldonado gclient: Refactor PrintRevInfo

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:839925,chromium:839925


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I116c57cdcbf6d9c09c93663777cfd970a1fa9ae6
Reviewed-on: https://chromium-review.googlesource.com/1069596
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560864}

https://chromium.googlesource.com/catapult.git/+log/6cc8fb177b33..12f7d6baa725

$ git log 6cc8fb177..12f7d6baa --date=short --no-merges --format='%ad %ae %s'
2018-05-22 dtu [pinpoint] Use _comparison_mode to determine values type.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I02e98b61229bd50fd7b75b7772c0691cc74ae995
Reviewed-on: https://chromium-review.googlesource.com/1069723Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560863}

This reverts commit a8a4a6f6.

Reason for revert: This change is not needed anymore.

Original change's description:
> Long press shouldn't get suppressed after tap down suppression.
> 
> Bug: 838971
> Change-Id: Ic296d7e5792ed38cc636b1f84d7d3d2e1ac229cb
> Reviewed-on: https://chromium-review.googlesource.com/1037424
> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555536}

TBR=dtapuska@chromium.org,sahel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 838971
Change-Id: I09106b10fcfd2f2568c9716a28f3c620794e2482
Reviewed-on: https://chromium-review.googlesource.com/1062341
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560862}

In order to avoid potential dead-locks with synchronous fetches.

The same can be done for fetches from main threads too, but it's not
really necessary as currently synchronous loads from the main thread
(i.e. sync XHR) don't go through service workers (and also is deprecated).

On workers on the other hand sync XHR is not deprecated (and existing service
worker code supports interception), and importScripts() also need to
go through service workers.

Bug: 843860
Change-Id: I068be4b4bfb7e37cd2b2aabb0be848931ee107c7
Reviewed-on: https://chromium-review.googlesource.com/1065402
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560861}

Also modify it to look like buttons for ChromeVox / Select to Speak

Bug: 842242
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1dfa42917ac35d13f300090e92672f8f62e3d798
Reviewed-on: https://chromium-review.googlesource.com/1055770
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560860}

This was causing window resize jank. This hack was added in r364897, and
it's unclear to me if it's needed on Mac. Removing it seems to work, but
I wish I had more context.

Bug: 682825
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1d9e1224297d78f3c5a08a6774acbe816a6e1c81
Reviewed-on: https://chromium-review.googlesource.com/1069037Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560859}

https://chromium.googlesource.com/angle/angle.git/+log/64ac5d9eb62e..31d3deb41a44

$ git log 64ac5d9eb..31d3deb41 --date=short --no-merges --format='%ad %ae %s'
2018-05-18 jgilbert Add `formatType` arg to computeSkipBytes.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I52f544636cabd066a2ffd42ebe26aff008e14843
Reviewed-on: https://chromium-review.googlesource.com/1069700Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560858}

This change avoids a crash when NodeController::pending_broker_clients_
and NodeController::pending_invitations_ diverge. This might happen with
complex enough node topologies, where there is a node that proxies
invitations to a set of other nodes.

BUG=845709

Change-Id: Ia678f464fafb69628600ec00dac19da3b6868fe0
Reviewed-on: https://chromium-review.googlesource.com/1069728Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560857}

This makes the controls on the Picture-in-Picture window focusable. This
also adds accessible names and tooltip texts for each of the controls.

Since the play/pause button is a ToggleImageButton, when the button is
toggled it will switch between showing play or pause assets / text.

BUG: 836389
Change-Id: Ie95afc1d9096e0860427c2498ddf0d319adb8df8
Reviewed-on: https://chromium-review.googlesource.com/1068125
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560856}

This picks up the upstreamed version of the local changes
we had made, so that we no longer need local changes.
This is a follow-up to crrev.com/c/737397.

Change-Id: I456f6ceda241f6d88be243a0df8d896b7d8d419a
Reviewed-on: https://chromium-review.googlesource.com/1069783Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560855}

Eliminate some useless constructs from the generated JSON before
folding this script into the version in src/testing/buildbot, to
reduce the amount of emulation code needed in order to generate
exactly the same JSON.

1) Stop specifying use_xvfb for gtests. It only applied to non-Swarmed
Linux bots, and at this point all of the GPU bots are Swarmed,
including those on chromium.gpu.fyi.

2) Stop specifying both override_compile_targets and isolate_name.
isolate_name is sufficient to tell the Chromium recipe which target to
build and run.

Bug: 844815
Tbr: ynovikov@chromium.org
Tbr: geofflang@chromium.org
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifaabad82fd83737ee126ec0725692eb3be35b6f4
Reviewed-on: https://chromium-review.googlesource.com/1067088
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560854}

Fixes pylint presubmit errors in the update_flaky_expectations.py
script by adhering to constant styling.

Bug: 730704
Change-Id: I365f2f642b1e64c6b1ee1837be99819a95b1e160
Reviewed-on: https://chromium-review.googlesource.com/1067521Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560853}

Bug: 823359
Change-Id: I9f5bb1ee23b32fb3522eaa4a2de9203fcbc805a6
Reviewed-on: https://chromium-review.googlesource.com/1069711Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560852}

This CL adds both web-platform-tests and conventional layout tests because the
current Chrome implementation is not spec-compatible in terms of service worker
scope matcing with dedicated workers (see https://crbug.com/731599). The layout
tests will be removed after the issue is fixed.

Bug: 680046
Change-Id: If214bd2f647ee5e7257ae134a870cf1e4ddac608
Reviewed-on: https://chromium-review.googlesource.com/1059979
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560851}

Commit 37dac0ef fixed the DCHECK crash
where variations_safe_compressed_seed was not registered, by calling
VariationsService::RegisterPrefs to register it. However, that
conflicted with some other prefs (variations_compressed_seed being the
first to fail) which were already being individually registered by
AwFieldTrialCreator. Registering them again caused a 2nd DCHECK crash.

To fix the 2nd crash, don't register any of those prefs individually;
they're all covered by VariationsService::RegisterPrefs.

Fixing the 2nd crash reveals yet a 3rd DCHECK crash, where FeatureList
is created twice: first in BrowserMainLoop::EarlyInitialization and then
in AwFieldTrialCreator. The second fails in FeatureList::SetInstance,
which requires that there be only one global FeatureList. This bug is
unrelated to the 1st and 2nd crashes; it just didn't appear because the
previous crashes prevented us from getting that far.

Since variations is always enabled in Chrome, Chrome always creates the
FeatureList during field trial setup, and always skips creating it in
BrowserMainLoop::EarlyInitialization. In WebView, variations may or may
not be enabled, so we must create FeatureList in exactly one of those
two places, depending on kEnableWebViewVariations.

BUG=842934

Change-Id: Ia592db3710a1f996729aa318853e7339bb3dff4f
Reviewed-on: https://chromium-review.googlesource.com/1069770
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560850}

This patch moves the NG implementation of PositionForPoint() from
physical fragments to paint fragments as a preparation for
implementing NG hit-testing bidi adjustment (*), which requires
traversal among paint fragments.

(*) crrev.com/c/1064480

Bug: 811502
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I449ac545e5ccefff5c5b6cbe7988b2f3c9280c4a
Reviewed-on: https://chromium-review.googlesource.com/1067699
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560849}

It was broken before because the toast was end aligned to the midpoint
of the anchored view, and if the view is on the very left side of the
screen, the toast can end up in the right side of the screen.

Adding a fix to left aligned the toast if the anchored view is in the
left half of the screen, and right aligned the toast if the anchored
view is on the right half of the screen.

Bug: 813746
Change-Id: I64f7f3c089eaf4665395d5fd56523c2b74206f68
Reviewed-on: https://chromium-review.googlesource.com/1066818Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560848}

ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure fails in the
ChromeOS VM.

BUG=844102
TEST=This is the test
TBR=skuhne@chromium.org

Change-Id: I58cef93ff9df4cd12b103a0bc5f99b576aab542f
Reviewed-on: https://chromium-review.googlesource.com/1066466
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560847}

The flag is present so we can finch this feature on stable to mitigate
risk for first-party customers like Docs Offline.

Bug: 829141
Change-Id: Ibfed20dfe45c4a96445001f721a499e08e2bcb7e
Reviewed-on: https://chromium-review.googlesource.com/1069601Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560846}

Bug: 843775
Change-Id: I3a3f8689369bd9b447e0254396a0326e0d0db88b
Reviewed-on: https://chromium-review.googlesource.com/1069566Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560845}

Chrome places restrictions on the use of aria-activedescandant other
browsers do not have and can sometimes lead to issues unique to Chrome.

In this case, ARIA activedescendant required an ARIA role.

Bug: 845651
Change-Id: I3e5743e253db377e00bd4538ec076c1b907bdce6
Reviewed-on: https://chromium-review.googlesource.com/1069608Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560844}

This removes the system level precondition and will now only run the
test if the file is actually meant to be read-only.

BUG=843211

Change-Id: I55abddd4f250732f815875dd626a80bda999f205
Reviewed-on: https://chromium-review.googlesource.com/1060172
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560843}

The test has an inherent race between triggering the showing of
suggestions and starting the loop to wait for notification that
the suggestions have been shown.

The test was asserting that the loop had been started before
quiting. Removed this (racily invalid) insertion.

Also switched over to use base::RunLoop instead of using
content::MessageLoopRunner (per crbug.com/668707), to remove
additional flakiness.

Bug: 843935, 668707
Change-Id: I3084b64697983b64c34fedd26e690d419807f2a8
Reviewed-on: https://chromium-review.googlesource.com/1069531
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560842}