GitLab

The lifetime of a GL program compile and link can be seen in
GrGLProgramBuilder::PrecompileProgram. The sequence is
- glCreateProgram creates a program object
- GrGLCompileAndAttachShader creates and compiles the vertex, fragment,
  and geometry shaders
- Link status is queried using glGetProgramiv with GL_LINK_STATUS

Create the histogram Gpu.GL.ProgramBuildTime for this entire time.
While this may not capture all of program building, the fact that it goes
through GL_LINK_STATUS ensures that we at least know the source has
been parsed.

Obsolete histograms that we won't be using. In particular
- Using a test shader to disable Metal won't be acceptable, since that
  will break WebGPU unpredicatably.
- Doing several retry attempts isn't going to move the needle on
  stability, so don't even try.

The purpose of all of this is to give us some data comparing OpenGL and
Metal, in the hopes that we won't continue to be told that we're
holding it wrong.

Bug: 974219
Change-Id: Ibed594aeea286344446244d86f7331597d5619ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948265
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721391}

Since AEC2 has been fully replaced by AEC3, these metrics
are now obsolete and should not be looked at any longer.

Bug: None
Change-Id: I72987600e9e17180c2435054c34ea86aa715b4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932368Reviewed-by: Armando Miraglia <armax@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721390}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85bb5de39728..162322e97930


Created with:
  gclient setdep -r src-internal@162322e97930

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I210915a97fc17846cc447cf53316e064d1590703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949421Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721389}

Add timestamp tests for blob-backing files and filesystem files.
This CL makes File::LastModifiedTime public because many tests access
it.

This CL has no behavior changes.

Bug: 1027959
Change-Id: I86ff3788f44edf830b1372bc3b17c3a951a77803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948666
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721388}

Add the checkbox to the new Translate UI's tab view and the source
language view.

Bug: 976352
Change-Id: Ic0e2630b4161dc57f053b625c65cea262476bfc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940496
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721387}

This reverts commit 8b3c757e.

Reason for revert: All dependent reverts relanded, there was nothing broken about this CL specifically.

Original change's description:
> Revert "Delete bind_interface_helpers.h"
> 
> This reverts commit a47f7784.
> 
> Reason for revert: breaks graphics on some Chrome OS devices.
> 
> Original change's description:
> > Delete bind_interface_helpers.h
> >
> > This header provides a bunch of helper functions for Content processes
> > modeled as Service Manager services. Since those are no longer a thing,
> > this no longer needs to be a thing.
> >
> > Bug: 977637
> > Change-Id: Ia1ae177b4a9665b727618b12a35be905d5605ce9
> > Tbr: jam@chromium.org
> > Tbr: erikchen@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929396
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Reviewed-by: Ken Rockot <rockot@google.com>
> > Cr-Commit-Position: refs/heads/master@{#718367}
> 
> Bug: 1028852
> Bug: 977637
> Tbr: rockot@google.com
> Tbr: jam@chromium.org
> Tbr: erikchen@chromium.org
> Change-Id: Ie621804e4a6c03c26bf64130bab49f6a9380dea6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948401
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Commit-Queue: Shuhei Takahashi <nya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720918}

TBR=jam@chromium.org,rockot@google.com,erikchen@chromium.org,nya@chromium.org

Change-Id: I738e84cc2af953c2a03da5c3cf791226ccff7c51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852, 977637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949780Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721386}

ScriptValue was modified to use WorldSafeV8Reference through r701030,
r698399, r694681 but we suspect it may have caused a memory leak.
This change ScriptValue back to use SharedPersistent.
To maintain the same level of security, the world check from
WorldSafeV8Reference has been transplanted into SharedPersistent.

Bug: 1029738
Change-Id: I21ed2929c3e90530a958be0503f153646f85ec7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948671
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721385}

Change-Id: I82111e2602c8d0b6488c1aca2440edafca9cfddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949832
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721384}

This reverts commit bfca6c80.

Reason for revert: Reverting the revert which was only done make reverting an earlier CL possible. Earlier CL has been fixed and relanded.

Original change's description:
> Revert "Move Utility processes off Service Manager"
>
> This reverts commit 0a311ff4.
>
> Reason for revert: breaks graphics on some Chrome OS devices.
>
> Original change's description:
> > Move Utility processes off Service Manager
> >
> > This migrates Utility processes to direct ChildProcess API usage instead
> > of bootstrapping IPC through the Service Manager.
> >
> > As this is the last remaining use of Service Manager IPC to bootstrap
> > Content child processes, this also rips out a bunch of infrastructure
> > that existed only to support that.
> >
> > Bug: 977637
> > Change-Id: I08e542f1d9f294bc1c387ea5845e8ba0d5a7d2b8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919719
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#718352}
>
> NOPRESUBMIT=true
>
> Bug: 1028852
> Bug: 977637
> Tbr: rockot@google.com
> Tbr: avi@chromium.org
> Tbr: rsesek@chromium.org
> Change-Id: I9b2e8ca44f5b6accc2d3718cab3cb547d979c230
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948402
> Commit-Queue: Shuhei Takahashi <nya@chromium.org>
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720938}

TBR=avi@chromium.org,rockot@google.com,nya@chromium.org,rsesek@chromium.org

NOPRESUBMIT=true

Change-Id: I79ea423c97880366125abfb659dae223d0185023
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852, 977637
Tbr: rsesek@chromium.org
Tbr: avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949304
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721383}

This is an attempt to avoid a renderer hang that may be explained by trying to
get an interface via BrowserInterfaceBroker (BIB) and then make synchronous calls
on that interface.

This is an experimental change. It is unfortunate to introduce render_frame_id
parameters here, and my intent is to come back and remove them once I understand
how to do so without the observed hang.

The experiment with this CL is to confirm that the observed hang goes away. If it
does, then it confirms that there is some interaction with BIB that is causing the
issue. If it does not, then we know BIB is off the hook, and we can look elsewhere.

Bug: 1023519
Change-Id: I696b63f057605b3cd5fe7f0c8182b044f2a60578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949036Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721382}

The crash in GetInterpolatedEventForPredictedEvent is due to the initial
value of 'idx' is set to -1, but it's an unsigned type.
This CL makes it initialize to 0.

Bug: 1030386
Change-Id: I44796c1813374f4c192ee3c125c5f957fbe57061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948048Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721381}

It's flaky on win-asan bots.

TBR=dtapuska@chromium.org

No-Try: true
Bug: 1030589
Change-Id: I317d93e60daf8be5d5813307da487f7b58efedc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949836Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721380}

https://skia.googlesource.com/skia.git/+log/32b010baf507..d61f8670f996

git log 32b010baf507..d61f8670f996 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b64fbfec4dcd..bbd0694f9ab2 (3 commits)
2019-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fb40d231c3e2..249cb200173f (15 commits)

Created with:
  gclient setdep -r src/third_party/skia@d61f8670f996

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: I1527e60130ff3b1070340cb477138ffdc7c8f56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721379}

- Move wrapping logic around chrome.send('removeVisits') into
history_list.js instead of browser_service.js
- Convert this call to use cr.sendWithPromise instead of calling JS
directly from C++ after deletion succeeds/fails
- Delete browser service test, since the logic it is testing is no
longer in the browser service. The test is replaced by adding checks
for the arguments passed to removeVisits() in the history list tests.

Bug: 1022212
Change-Id: I7290d97472b34a0a233ac7921c18c2a298481a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947956Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721378}

This reverts commit d10a4fc5.

Reason for revert: Reverting the revert which was only done make reverting an earlier CL possible. Earlier CL has been fixed and relanded.

Original change's description:
> Revert "Reland "Move Renderer processes off Service Manager""
> 
> This reverts commit 881a65d7.
> 
> Reason for revert: breaks graphics on some Chrome OS devices.
> 
> Original change's description:
> > Move Renderer processes off Service Manager
> >
> > Migrates Renderer processes to use the simpler ChildProcess IPC
> > interface in place of deprecated Service Manager IPC.
> >
> > Support for preloaded files in service manifest definitions is
> > effectively removed in favor of explicit parameters on
> > BrowserChildProcessHost and ChildProcessLauncher. The only use case (V8
> > snapshot files) has been migrated from manifest data to a simple map
> > definition, and it's used during renderer and utility process
> > launching.
> >
> > After this CL, only utility processes remain to be moved off of
> > Service
> > Manager IPC.
> >
> > NOPRESUBMIT=true
> >
> > Bug: 977637
> > Change-Id: I1d8205cb73ead904aa21b85d6cbee11cb3fc84f5
> > Tbr: boliu@chromium.org
> > Tbr: yucliu@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918375
> > Reviewed-by: Martin Barbella <mbarbella@chromium.org>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Cr-Commit-Position: refs/heads/master@{#717920}
> 
> NOPRESUBMIT=true
> 
> Bug: 1028852
> Bug: 977637
> Tbr: rockot@google.com
> Tbr: boliu@chromium.org
> Tbr: yucliu@chromium.org
> Tbr: mbarbella@chromium.org
> Tbr: rsesek@chromium.org
> Tbr: avi@chromium.org
> Change-Id: I30a52d825cc156b066d7c2ec455c8fb588a408af
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948663
> Commit-Queue: Shuhei Takahashi <nya@chromium.org>
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720939}

TBR=avi@chromium.org,boliu@chromium.org,rockot@google.com,nya@chromium.org,mbarbella@chromium.org,rsesek@chromium.org,yucliu@chromium.org

Change-Id: I69de741d907abd790bdad3019abeeb9a8ca231aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852, 977637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949778Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721377}

Just letting the fragmentation machinery do what it would do if it gets
to treat column boxes as regular column content was no conscious choice,
and it turns out that setting the column fragments to the actual column
size is better, or we get some trouble with overflow, both when it comes
to painting column rules, and the fact that we get spurious empty column
fragments after unbreakable content (new unit test
NGColumnLayoutAlgorithmTest.TallReplacedContent).

Remove fast/multicol/rule-in-nested-with-too-tall-line.html and replace
it with a valid test (that still fails both in legacy and NG; in NG
because we fail to paint text on a general basis).

Bug: 829028
Change-Id: I3656c299c7a87bea29e1790477cf524b9522fa97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948923Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721376}

This is a preparation CL for stopping creating ServiceWorkerProviderHost for
service worker clients.

This CL renames ServiceWorkerContainerHost::provider_host() to
service_worker_host(), and ensures it's used only for service worker execution
contexts (not for service worker clients).

Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing

Bug: 931087
Change-Id: I6c625c00f00e96c14623a80ced0afd5ba0e0ca49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947510Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721375}

This is a reland of bdc39552

Original change's description:
> Move GPU and Plugin processes off Service Manager
>
> This introduces a new mode for Browser/ChildProcessHost where the
> primordial pipe is a simple content.mojom.ChildProcess pipe. This will
> become the new default mode of operation for child processes, and
> eventually will be the only mode of operation once NaCl processes are
> gone.
>
> GPU and plugin processes are ported to this mode here since both
> require only minimal changes. This means that "content_gpu" and
> "content_plugin" services no longer exist.
>
> Bug: 977637
> Change-Id: I39c5d2284bd84246663d5f0eb4cbab3b3483d798
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918326
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#717857}

NOPRESUBMIT=true

Bug: 977637
Change-Id: Iaefab7950d7f0437b05417a34ff2b1db73576f0b
Tbr: avi@chromium.org
Tbr: rsesek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948907Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721374}

Before this the SessionRestore policy wasn't prioritizing the tabs
that haven't been observed by the LocalDB for a long enough period
of time. This could create some issues as not reloading these tabs
will not let the local DB observe them and so this could lead to
some missed events.

Change-Id: I7d74a6c300d42d207bd9b02f5a19aa22894f4037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943531
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721373}

Use front buffer textures directly for snapshots with swap chain
resources instead of a copy via skia.

R=sunnyps@chromium.org

Bug: 962630
Change-Id: I88f6e5b098b060325cff06cd3a140d85146f60b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949663
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721372}

Currently, CBCM reporting are supported on many operation systems (like
Linux, Mac, Windows), but not on Chrome OS. In this change list, a
report scheduler will be triggered to report related information
periodically.

Bug:1010213

Change-Id: I18ecce77852b16e21456d666c5c301c05e5f0d61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862447
Commit-Queue: Anqing Zhao <anqing@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721371}

Disabled these tests due to random failures:
PasswordManagerBrowserTest.HTMLLoginAfterHTTPAuthIsBlacklisted
PasswordManagerBrowserTest.NoPromptForSeperateLoginFormWhenSwitchingFromHttpsToHttp
PasswordManagerBrowserTest.Redirects
PasswordManagerBrowserTest.SameOriginIframeAutoFillTest

TBR=dvadym@chromium.org

No-Try: true
Bug: 1030579
Change-Id: I03ee08ec048ad85af50908d6d929db61b02793fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949830Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721370}

Since the z-order of SurfaceViews is pretty arbitrary, in some android
versions after a screen wakeup, the TWV surface is created in wrong order
and hence gets hidden behind the main compositor surface.
Investigated a few options : setZOrderOnTop, setZorderMediaOverlay.
However the main compositor already uses setZOrderMediaOverlay. So we
are left with we can use setZOrderOnTop to fix this issue.
Added ThinWebViewConstraints class  to enable client specify this use case.
Also added support for opacity in the TWV which would be useful for
some clients.

Bug: 1024622
Change-Id: I613c9a34e5b134a8b6d2f794ca2e488bbfe2f454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939892
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721369}

Also, adds additional PRESUBMIT checks to ensure automation keeps in sync with
ax_enums for MarkerType.

Test: existing browser_tests --gtest_filter=ChromeVoxEditing*.*
Change-Id: I58556cc8317cbca62f00aed8d9f3afbcf7feeee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940868
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721368}

Previously, focus would jump to the first element when
the underlying network list was updated.  This fix
attempts to maintain focus on a particular network if it
is still present, otherwise it tries to stay on the same
index, and finally falls back to the first element.

Fixed: 1005934
Change-Id: I9a7e2307bc604f8ba08b659e22f80ba88ad66156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920188Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721367}

https://chromium.googlesource.com/angle/angle.git/+log/a5045ac36d17..249cb200173f

git log a5045ac36d17..249cb200173f --date=short --first-parent --format='%ad %ae %s'
2019-12-03 syoussefi@chromium.org Translator: Rename TIntermInvariantDeclaration to ..GlobalQualifier..

Created with:
  gclient setdep -r src/third_party/angle@249cb200173f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: Ie7106cfe6a1413beb3fc690f48ded76406ba8d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949770Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721366}

In main thread scrolling, the content of the scrollbar's graphics layer will be
painted into drawing display items directly.

Visual rect is stored in display item list's RTree, and used to extract only the
required ops which will replay into a canvas. There will be no rasterization if
it is empty.

Change-Id: I3c3cfaf3e83289d05b0db97431aae0561fe83fa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942753Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721365}

This is a preliminary change for https://crrev.com/c/1928100.

Do not try to read request's payload body if
 - There is no Content-Length header, and
 - Transfer-Encoding: chunked is not found.

Bug: 1027011
Change-Id: I20de558733ba215419575d8fe87d624cef126f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936438Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721364}

https://dawn.googlesource.com/dawn.git/+log/be5c13567227..53782d60dc73

git log be5c13567227..53782d60dc73 --date=short --first-parent --format='%ad %ae %s'
2019-12-03 enga@chromium.org Use GetBindGroupLayout in TextureViewTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in TextureFormatTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in SamplerTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in RenderBundleTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in ComputeCopyStorageBufferTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in DepthStencilStateTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in IOSurfaceWrappingTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in MultisampledRenderingTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in ComputeStorageBufferBarrierTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in ComputeSharedMemoryTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in ComputeIndirectTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in TextureZeroInitTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in CompressedTextureFormatTests
2019-12-03 enga@chromium.org Use GetBindGroupLayout in ColorStateTests

Created with:
  gclient setdep -r src/third_party/dawn@53782d60dc73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Idc55042e70500c1f3abcdde162890d38615ac61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949768Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721363}

Buffer allocation is time-consuming action. This CL makes
PlatformVideoFramePool not try to allocate new buffers if all the
arguments that affects the physical layout of buffer are not changed.

Bug: 1018817
Bug: 1028406
Test: media_unittests --gtest_filter=PlatformVideoFramePool.*
Test: video_decode_accelerator_tests on Kevin and Eve

Change-Id: I3f1a2b91b0f8c762d7c16f3a873648274176a6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948009Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721362}

When the tree width is small in files-ng, it should be redrawn for the
so-called "clipped" state. Add a "clipped" attribute to the tree, that
enables the CSS animation that redraws the tree in "clipped" style.

The design does not currently specify the "clipped" break point so use
and arbitrary value (135 px) for now.

A test for this requires that we first fix the directory_tree_unittest
because it fails with files-ng enabled: it tests directorytree.js code
does not wrap the code in a <div class='dialog-navigation-list'> [1].

[1] This CL is for Files App, and it has that <div> wrapper around the
directory-tree always. In a future patch we decided that the "wrapper"
can be removed, that we can measure width from .this, and the unittest
would then pass unchanged too :)

Bug: 992819
Change-Id: I81e8d459cafd3fe1fb46dc5c21dad4605d5b2c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947603Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721361}

Updates the test-config for the Preview Tab (aka Ephemeral Tab) to
use the Bottom-Sheet version instead of the Overlay version.

BUG=913075

Change-Id: I92ad27d5deebbd8cceef87901fac6c50198fe756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947952Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721360}

MemberBlinkNames provides names for some common APIs and
internal C++ member variables for each dictionary member.
It also works for [ImplementedAs].

Bug: 839389
Change-Id: I9448312f8056102dd4c108b5a7687281352cd35c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947518Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721359}

libgifcodec was recently added to the DEPS for gclient sync:
https://chromium-review.googlesource.com/c/chromium/src/+/1944286

Synced files should be ignored by git.

Bug: 1014044, 1030577
Change-Id: I1fbd3c73368e0c13eb4b314f5bf0606af3b39992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949810
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721358}

Previously, when using Search + Arrow to navigate through
VPN quick settings, there was no stop on the disconnect
button for a connected VPN.  This change also updates the
a11y labels for both the VPN row and disconnect button
to identify what action is performed.

Bug: 760222
Change-Id: I0bc1ea2930c874255f9dfd9601b2741810fbc4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938041Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721357}

This was added way back in
https://chromiumcodereview.appspot.com/12090014 when we used to
have scroll bubbling and was used to prevent bubbling in certain cases.
We've since switched to a "scroll latching" model for gestures so we no
longer bubble scrolls at all.

Note: This changes the behavior of IsActivelyScrolling slightly in that
it now returns true as soon as we latch, right after the GSB, rather
than before where it returned true only after the first GSU. I don't
think that was an intentional choice and should be safe based on the
checked call sites (a GSB is always followed by a GSU).

Bug: 1016229
Change-Id: I7ac3d8373ce342a3d58876ff8cd91d66fb877643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945352
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721356}

In preparation for launching to stable channel per go/finch101.

Bug: 953970
Change-Id: Ia64d055a4ecbebe738a3507c5622f0d3b1ed8de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949698
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721355}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a4af7676feb0..e58c080d4f02

git log a4af7676feb0..e58c080d4f02 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 johnkslang@users.noreply.github.com Merge pull request #1990 from ianromanick/INTEL_shader_integer_functions2

Created with:
  gclient setdep -r src/third_party/glslang/src@e58c080d4f02

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com
Change-Id: Ia951225d4f8127fe17a3d2dfe682578b3fa248b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949771Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721354}

https://chromium.googlesource.com/external/leveldb.git/+log/2c9c80bd539c..58a89bbcb28d

This CL also adds googletest as a dependency to tests, and fixes a
fuzzer that depended on leveldb implementation details.

$ git log 2c9c80bd5..58a89bbcb --date=short --no-merges --format='%ad %ae %s'
2019-12-02 costan Add WITHOUT ROWID to SQLite benchmark.
2019-12-02 pwnall Fixup for adding the third_party/googletest submodule.
2019-11-25 no-reply Internal change.
2019-11-25 pwnall Fixup for adding the third_party/googletest submodule. (#754)
2019-11-21 costan Switch testing harness to googletest.

Created with:
  roll-dep src/third_party/leveldatabase/src

Change-Id: I3a00eb1eaa97e3c801be9de019ee25ae24fd0876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947963
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721353}

This helps with casually observing BFCache's behaviour.

Change-Id: I36e4573cca27c53d36427bf72fa767154b0ee296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949803Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721352}