- 19 Oct, 2020 3 commits
-
-
Kenichi Ishibashi authored
This CL duplicates AppCacheDiskCache{,Entry} into ServiceWorkerDiskCache{,Entry} to remove the AppCache dependency from service workers. See [1] for the reasoning of this duplication. To avoid risks of behavior changes, this CL only makes minimum tweaks which includes: * Address Tricium warnings (use default member initializers, prefer emplace_back). * Follow the current coding style guide. * Remove `use_simple_cache_` flag. It's always true for service workers. * Add a sequence checker. Follow-up CLs will do some refactoring like addressing crbug.com/586174. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/ Bug: 1117369 Change-Id: Ia62fe55a23c2c84b569516e97e0059994c7755bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452029 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c66973fd885f..2c4e97da9c2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ie94a9fd3104b8dc09d67a81a1de41aad23a1583a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483500Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818325}
-
Peter Kasting authored
This allows converting |targets_| from a member to a parameter that's passed around. I also did some other cleanup while there. Bug: 772945 Change-Id: Iaa7f70594ba109d1598da3566856e90c8b09629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481246 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#818324}
-
- 18 Oct, 2020 37 commits
-
-
Dylan Cutler authored
identifiability study. This API can be used to compute the size of a client's scrollbar, which is information which could be used to build a fingerprint to track users across different origins. This CL refactors the method used for instrumenting HTMLElement.offset[Width|Height] introduced in http://crrev.com/c/2436650 to support both use cases. Bug: 973801 Change-Id: I518841aad9093b8df9368f2e6977ebab20536a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472528Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#818323}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/37d41eea0477..1f7eab68c0ce 2020-10-18 hta@webrtc.org Remove superfluous #includes from peer_connection.cc, and add IWYU 2020-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d65b746..f16d83f8 (818170:818270) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id6c19b7e073175c45f5efc7f99a59d19bf7309ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818322}
-
Alice Boxhall authored
Bug: 1122961 Change-Id: I7e442291cb2b830227ee6f1e0aa1b3896ac8eb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466012Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818321}
-
Christopher Cameron authored
This should release the CMSampleBuffer in the destructor, not the constructor. Bug: 1125879 Change-Id: Idb266a891fdadaf16a0469e821644c2a1b78e63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482245Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#818320}
-
Nicholas Hollingum authored
Previously tasks only indicated true/false fro success/fail. Following crrev.com/c/2467818 which reports errors to users of the context manager, we make a similar modification to tasks s.t. they report failures to the context manager. We similarly extend the unit tests slightly to ensure that errors are passed from tasks to the ResultCallback. Bug: b/162562622 Change-Id: I9ce094c00cad8fc13f72da9109effa6f0f91580b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470276Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#818319}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5b7c5b349326..188d0fe69b67 2020-10-18 jmadill@chromium.org Make Metal shader-gen cross platform. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I2d4cd6e2314bff89a4990ada18f7f43344ec929e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483496Reviewed-by:
-
Liquan (Max) Gu authored
Following up on CL[1], this CL is to save a use of mParams.hasClose() on PaymentUiService#onlySingleAppCanProvideAllRequiredInformation() by passing the paymentOptions from ChromePaymentRequestService. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2422783/4..7/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentUIsManager.java#b1403 Change-Id: I02161365bb4d73a6918341174f848fa64d4f6a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481357 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#818317}
-
Liquan (Max) Gu authored
Context: Having iframe navigating multiple times would make the payment handler WebContents invokes the "didFailLoad" callback. Currently, didFailLoad applies for both the mainframe and subframes. The UI shouldn't close when the load failure happens on subframes. Before: The UI closes when the subframes fail to load. After: The UI doesn't close when the subframes fail to load. Bug: 1137929 Change-Id: Iaba361e895d6bb4e46b0fb969a87958e9daebe57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469536Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4b5d1a4fc3e31cf565d957efae33dd08cc0aef68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483490Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/27f7fe32f49b..a5e8f6b40233 2020-10-18 fmalita@chromium.org [svg] Post-relocation cleanup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I5403e21e687f351f990408c3752183457519e909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483649Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603016324-8e6ea231596d691a8dc59ff220e78ad4dc7ffd0d.profdata to chrome-mac-master-1603040487-b7e085dfa5b01aa0e050891b4bb7d6888509a540.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iddc2e482b1cf3d3ebc0cf6dc6950848e29c4d56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483486 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11974978bd2a..c66973fd885f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4209b826033b4a28df9275ff1f0f1ae380497056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483489Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603016324-5b1f923422a32f307f0353bbcd6f801857438a34.profdata to chrome-win32-master-1603031994-5f3b6fcba7bce636145481c18ca09ca6363425d3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I13769960180521aad1984f19ea1c0f3ad0b36a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483483Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603016324-9f22c835bf8cfc77fd9f0cc007f6f7cbdd364850.profdata to chrome-linux-master-1603040487-eaa3c4357e49dc6962268bee93995df4eace45df.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0058e6e6f391501f8fa71d87e35a252c138ac3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483647Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d58f771c13c..11974978bd2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I5716cf3a5ced813202f28deec658b8b61ec3bcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483484Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4761cf50d032..958dc6267f2d 2020-10-18 petermcneeley@chromium.org Fix goma regex detection and add optional nice launching If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I8e292d72ed465426cba123ae2b67272765018be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483602Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d73338a50dc..89eeef5150cb 2020-10-18 ericlaw@microsoft.com Improve Netlog Import View with Field Trial information If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133396 Tbr: wenbinzhang@google.com Change-Id: Ieb4d341306d1b7910a96e2ce73b2323c805dd87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483582Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603011284-615c03508d0085036a17522d8126ddb6399876a3.profdata to chrome-win32-master-1603016324-5b1f923422a32f307f0353bbcd6f801857438a34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If9d5d112c34d733ff412c03fedf5da92f60c54e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483308Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010180700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/wHmgVwhdw29vHqkyUXbbeSCuBeOGOHCSL0B8dd3273MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ibcd8d341ed256e117184c58b13f2a1a3246b6ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483307Reviewed-by:
-
Koji Ishii authored
* Grouped into single place. * 4 failures were tagged for crbug.com/591099 [meta] LayoutNG. Re-tagged them to correct issues. * Re-tagged crbug.com/958672 because it was resolved as duplicated to crbug.com/639223. * `midword-break-priority.html` is from a different cause. Filed crbug.com/1139693. TBR=ikilpatrick@chromium.org, yosin@chromium.org, tkent@chromium.org Bug: 639223, 958672, 963369, 1139693 Change-Id: I1df465ec2bd821786a94f1021d43688cedec9067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482566 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818304}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9047954c1708..5b7c5b349326 2020-10-18 lehoangq@gmail.com Metal: don't precompile default shaders. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Icd3abc06019c9a3c2cadc928f625ecb3163e2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481638Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d474002ab20d..5d58f771c13c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ie907a852e9546f1598bd29027dfd91e364877d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483306Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d328953a. With Chromium commits locally applied on WPT: 994866f4 "MSE-in-Workers: Cross-thread function and tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ie9737f070f6058078ea69b375118df87f6a54039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483323Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818301}
-
Finnur Thorarinsson authored
This CL also introduces a wrapped tracker object that can proxy calls from C++ over to Java, which allows the test to cover the IPH functionality from end to end (including showing the IPH and making sure the events to suppress it finds its way to the Java test). Bug: 1135551 Change-Id: I9e6a76a5a116aed6a6ca2047f01d7e32ee01f291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468120 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#818300}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603000322-1da9ecd0cc7e49240c8635179c40d870432fcd8e.profdata to chrome-mac-master-1603016324-8e6ea231596d691a8dc59ff220e78ad4dc7ffd0d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icaa0c673bb31a8bf6c3f09cbd096d748b8290569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483305Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603000322-801f3305e6cd0fd292b441f558ed769b5b382498.profdata to chrome-win32-master-1603011284-615c03508d0085036a17522d8126ddb6399876a3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieacb8c25516d5d1c00337c93e2eac661a7311a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483304Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603000322-460e5efe11eca139cb5b3e534b17a57053c1a664.profdata to chrome-linux-master-1603016324-9f22c835bf8cfc77fd9f0cc007f6f7cbdd364850.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id1a397c448bbf70e94c5d60c35faa329fee3b21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481637Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/992b13db..bd239eff Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia3476138d4f741567054060ced1a5524be41c8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483322Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818296}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7a1a3aa74f00..a9da93c46a90 2020-10-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7bca3f2d075fa3746cae5596541c366e2d5c48ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481634Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/873d33e1a626..d474002ab20d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I8d9500c28f023e2dc36bd671d136535d65e66aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483303Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6f92cbf9cb863c90c0e34d11668018d1792060a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481667Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I60f39498f076baa3099a4b23a15b3037cae168cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482699Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818292}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602989941-f472dd2895e3d168cbef56052f08ad7200f1ebf8.profdata to chrome-win32-master-1603000322-801f3305e6cd0fd292b441f558ed769b5b382498.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I873358f3c193acdd04d742316da8e21de1b6957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481690Reviewed-by:
-
Mei Liang authored
This CL introduces a generic LayoutStateObserver for getting notifications from the Layout system about every supported layouts show/hide state changes. This LayoutStateObserver is added to the Layout system via the LayoutStateProvider. Additionally, this CL merges the SceneChangeObserver interface into LayoutStateObserver: * SceneChangeObserver#onTabSelectionHinted -> LayoutStateObserver#onTabSelectionHinted * SceneChangeObserver#onSceneChange -> LayoutStateObserver#onStartedShowing Note: 1. This CL breaks from crrev.com/c/2353875. 2. This new notification system has been integrated to production code with zero callers. Change-Id: I23bd2b5b1b674a6df554a2edd1ffbfb32da5d6b1 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463850 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#818290}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e81b934dc23b..7a1a3aa74f00 2020-10-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I331b5b11e19e2973c2d1a3004be0099c8b6da1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483182 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Anton Bikineev authored
This change was automatically created by applying a custom clang-tidy checker. Change-Id: Ifc90daf2b62f1efd7d2af6a4ebf49538ba5255b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446056 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#818288}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be8004d2fb6c..27f7fe32f49b 2020-10-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ic970f7bc9f9ae4c262c49e115a829ffc0885b9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483029Reviewed-by:
-
