- 22 Aug, 2019 40 commits
-
-
Andy Paicu authored
It's been over a year since modal permission prompts have been enabled by default. The usage is now very low so it's time to removed them. https://uma.googleplex.com/histograms?sid=19aaae5bcd78f725505eebc7e91172ce Usage in stable less than 0.0003% Bug: 935900 Change-Id: Ifecfacec485fc1a18fccbf7d219209d3727946b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757939Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689420}
-
Marc Treib authored
http/tests/devtools/elements/styles-3/styles-computed-trace.js http/tests/devtools/elements/styles-3/styles-add-new-rule-colon.js http/tests/devtools/elements/styles-2/force-pseudo-state.js TBR=luoe@chromium.org Bug: 994008, 994034, 994027 Change-Id: I47a3cb1c8c6d3355d28e54a56b05a2eca6207f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760796Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689419}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ccbb1967..152e05a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65d5f4cd6a8c638f6156ba89068eb0d910549a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765329Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689418}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60d1f774d1f3..d65c05cb1aa9 Created with: gclient setdep -r src-internal@d65c05cb1aa9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9597cb99247abe3362cf18c31285fd663cde351f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764937Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689417}
-
Miyoung Shin authored
This CL converts ServiceWorkerHostAssociatedPtr, ServiceWorkerHostAssociatedPtrInfo, ServiceWorkerPtr and ServiceWorkerRequest in content and blink to new Mojo types, and uses pending_receiver<ServiceWorker> in embedded_worker.mojom and pending_associated_remote<ServiceWorkerHost> in service_worker.mojom. Bug: 955171, 978694 Change-Id: If912d112250d3bb4786f5545d3039179abb26654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757954 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#689416}
-
Marc Treib authored
This reverts commit 2ff72648. Reason for revert: Suspected of making various PrintBrowserTests flaky, see crbug.com/996185 Original change's description: > Remove print document race condition using synchonous message > > JavaScript window.print() requests have been returning back to the > renderer process before the print has actually completed. When the > print preview is disabled it is easier to expose a race condition > between serving the print logic and whatever comes next in the > JavaScript. > > If the script has a popup window to be printed, which has > window.close() immediately after the window.print(), then the document > to be printed has its destruction racing against being printed - and > will typically lose that race, resulting in a lost or empty print job. > > Resolve by ensuring that the renderer process does not proceed past > window.print() until the DidPrintDocument message is sufficiently > completed. Making this message synchonous achieves this effect. > > This means that the renderer process will be blocked for all sites > which it serves for slightly longer than it already does. [1] > > [1] https://www.chromium.org/developers/design-documents/printing > > Bug: 974480 > Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275 > Reviewed-by: Shimi Zhang <ctzsm@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Alan Screen <awscreen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688096} TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,ctzsm@chromium.org,awscreen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974480, 996185 Change-Id: I3ae34235d1bbdb98619a157a451e94e6b0e1cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760795Reviewed-by:
-
Marc Treib authored
This reverts commit e525e385. Reason for revert: DumpAccessibilityTreeTest.AccessibilityArticle/uia fails on Win7, see crbug.com/995723 Original change's description: > Fix <article> ControlType and <figure> LocalizedControlType > > Change ControlType of <article> from "Document" to "Group" per > https://w3c.github.io/html-aam/#el-article > > Change LocalizedControlType of <figure> from "group" to "figure" per > https://thepaciellogroup.github.io/AT-browser-tests/test-files/figure.html > > > Bug: 994380 > Change-Id: I36e59265650b1655b2811ccb3baac8b67e8552a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757145 > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Dan Clark <daniec@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#688255} TBR=aleventhal@chromium.org,kbabbitt@microsoft.com,daniec@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994380, 995723 Change-Id: I72844052b3ecf808fb77e383611168ee926174ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763680Reviewed-by:
-
Michael Lippautz authored
These metrics are either important for day to day operation or ongoing projects. Bump expiration of metrics to M84. Bug: 988635, 988652, 988675, 995507, 995509 Change-Id: Ib4dfd873ee1edd6203392e85ee6b4060250ccfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760961Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#689413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ddd16494fd70..49980fb4f214 git log ddd16494fd70..49980fb4f214 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 kcwu@chromium.org auto-updater: fix exception message Created with: gclient setdep -r src/third_party/chromite@49980fb4f214 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1cc94217c402cd6d6de30c7937d70d401940266d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764658Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689412}
-
Matthias Körber authored
Adds the capability to retrieve all login credentials stored in the database using a specific password. Change-Id: I05cc22bc67213cd5166322341ff458c4a0c93675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757931 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#689411}
-
Marc Treib authored
After https://crrev.com/c/1752826, it has no effect. Bug: 990745 Change-Id: Ibfc35e2e2eed5f10732ec43bf12ac9cbd5343f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762085 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689410}
-
David Jean authored
Removed deps and (un-needed) sources that include part of ui/events/ (ui/events is main includer of ui/latency) Bug: 824384 Change-Id: I55e14b04b88b48bda077688f1f1e69fd7a93a20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760737 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#689409}
-
Canon Mukai authored
RawResource is now cancelled asynchronously, so this logic is no longer needed. Bug: 683000 Change-Id: Ie7f4888727aa10b58b6a0b07c3453fec5e4d6029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763566Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#689408}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 43a861d9. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I5e5233cf20d4fe809fbdd433b91bfe37d4b55481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763884Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689407}
-
Tanisha Mandre authored
A change, cropping the QR Scanner preview layer was uploaded by mistake in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1730906 This CL reverts this change. Bug:996638 Change-Id: I4a9c462aa4fe6de81951dbf3473ac663b2e5cde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758240 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#689406}
-
Marc Treib authored
Bug: 996170 Change-Id: I46b322cc58635a6509a53ad4fb14a58067491e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757933Reviewed-by:
-
Mohamed Amir Yosef authored
The feature has fully launched and has been enabled be default for at least one milestone. Change-Id: I2aa60b4e9ff986b82536b291e15b7b045c430af1 Bug: 801985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763755 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I63e0c5b2c40820836ce9e3e49d49c87e3ec6bb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764860Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/af5edffa..ccbb1967 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If338826520d5680bbe34c2834067ba1f35b3b305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763883Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b689af4c995e..224c69d52748 git log b689af4c995e..224c69d52748 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 nisse@webrtc.org Delete ext_seqnum member from VoiceSenderInfo and VoiceReceiverInfo Created with: gclient setdep -r src/third_party/webrtc@224c69d52748 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iabc852ad0f79f0533eeb56c652f9549fc4719706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764859Reviewed-by:
-
arthursonzogni authored
The TestNavigationURLLoader and the CachedNavigationURLLoader are very similar. The difference: the first one executes the NavigationRequest callback when instructed by the NavigationSimulator, the second one posts to a task queue. Using the CachedNavigationURLLoader caused issues, because the posted task where executed at inappropriate times. This CL makes the TestNavigationURLLoader to be used in tests. Bug: 992846 Change-Id: Idc25df7de55e632169651ba183f744dc721e126d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751733Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689400}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0cbdc7a2c35b..aef8f92b2bb6 git log 0cbdc7a2c35b..aef8f92b2bb6 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 stevenperron@google.com Even more id overflow in sroa (#2806) 2019-08-21 stevenperron@google.com Add name for variables in desc sroa (#2805) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@aef8f92b2bb6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I335090586b53743d57fe047f89384b9b7187fc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764659Reviewed-by:
-
Kuo Jen Wei authored
Extract ResultSaver interface for saving captured photos and video. Bug: 967611 Test: All CCA capture function work as expected. Change-Id: Ifde8ee94d88357f4541e248819e0c3a1a98c0fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757720Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#689398}
-
Xiaocheng Hu authored
Bug: 978682 Change-Id: I03310f9116f66d3ec2248a357c209d704deb85cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764669Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#689397}
-
Yuki Shiino authored
Implements constant values and default values. Bug: 839389 Change-Id: Id8de1de689eebf9b45bc879175e290711855bb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763662Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#689396}
-
Rakina Zata Amni authored
The test is failing in Linux MSAN. Since this is under the display locking flag, will just disable the test for now and investigate the cause (instead of reverting the whole CL that included this test). TBR=treib@chromium.org Bug: 996625 Change-Id: Id41d175a7e1030ae63589d15e4203b1d9a4375fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765089Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Ankit Kumar 🌪️ authored
Refactoring the function and breaking it into smaller chunks. Bug: 981448 Change-Id: I5f8e8eefeb87c61f8ec098840312221788e42082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753795 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689394}
-
Tanisha Mandre authored
- MobileCreditCardScannerClose - Scanner closed using cancel button without scanning a card. - MobileCreditCardScannerError - Scanner closed from alert due to error. - MobileCreditCardScannerScannedCode - Scanner closed after successfully scanning a card. Bug:989432 Change-Id: I6457867e76ddab986fee643812933fed75be9a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763689Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#689393}
-
Matt Falkenhagen authored
Code in //chrome etc will need to use these. Bug: 824858 Change-Id: I17942f3050aab63ef35f567f7cc610c52a02baa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763524Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#689392}
-
Jan Wilken Dörrie authored
This change introduces more metrics for the Leak Detection feature. In particular it adds metrics regarding the handling of server responses. Bug: 986298 Change-Id: Icf2a6dc1bae161ed1b71aeef88d9cee552bd6a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763687 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I2e5045c315c62c2c20764c7f1fe3051701061cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763526 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#689390}
-
Aran Gilman authored
Bug: 994548 Change-Id: I89776a8ff3ebec8adabc3d133dee62e50134ed33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762474 Auto-Submit: Aran Gilman <gilmanmh@google.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
nancy authored
BUG=994434 Change-Id: I7f6c32124512b439f1436aa224595fe41d5ca08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757246 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689388}
-
Marc Treib authored
This reverts commit a09403d6. Reason for revert: PDFiumPageTextTest.GetTextRunInfo fails on MSan, see crbug.com/996629 Original change's description: > Add logic to break PDFiumPage text runs by page objects > > This CL introduces a logic to break the text runs whenever a link is > found while generating the text runs in PDFiumPage::GetTextRunInfo(). > > A new method PDFiumPage::CalculatePageObjectTextRunBreaks() is > introduced which pre-populates a set of text breakpoints according to > the start and end char indices of links in the page. > PDFiumPage::GetTextRunInfo() uses that pre-populated set to determine > the text run boundary. > > This CL includes a unit test to verify the text tuns in a pdf page which > has a link in between a text block. > > Bug: 981448 > Change-Id: I2365dc84fa1e1206a58cd8fa4e918d660ce8bc00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714773 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Pratish Kumar <prkum@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#689356} TBR=thestig@chromium.org,kbabbitt@microsoft.com,manojb@microsoft.com,mohitb@microsoft.com,virens@microsoft.com,ankk@microsoft.com,prkum@microsoft.com Change-Id: I31ac68a47651ea51fa0dc1b4cc94e1aad9ee63c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981448, 996629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763764Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc63d7ac7438..60d1f774d1f3 Created with: gclient setdep -r src-internal@60d1f774d1f3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id2ed5edf76a80d1cdf7ae0a5e6ca6acc8859b7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764656Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31316e16555f..c071fc92cd3d git log 31316e16555f..c071fc92cd3d --date=short --no-merges --format='%ad %ae %s' 2019-08-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6d653c02dd24..91dc5da80684 (8 commits) 2019-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 85a90848..0ef8680c (479 commits) 2019-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 92eb0415d0b1..23742c0958dd (3 commits) Created with: gclient setdep -r src/third_party/skia@c071fc92cd3d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Iddaf9b659e20099eda07ce8884f31a4fd7d6ff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764620Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts WebSocketHandshakeClientPtr to new Mojo types. It updates CreateWebSocket from network_context.mojom and Connect from websocket_connector.mojom and methods and members which implements them. Bug: 955171, 978694 Change-Id: I8b64aa95a38a4a50bcfd71de1a4f0a207db6f4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761885Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#689384}
-
Mohamed Amir Yosef authored
TBR=poromov@chromium.org Change-Id: I8a156833ecc05b3238e837b7b8c58a16f3261d2c Bug: 985287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742234 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Oleg Davydov authored
Checks that installation stages are all reported. This isn't a new test method, but part of PolicyTest.ExtensionInstallForcelist. Bug: 989526 Change-Id: I4fc9e82dd38228bc1396f05ba0c1406167cf297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745994Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#689382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b91d75c9..af5edffa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f392fcd54dc50db89c8fbb72c8fa6d6c9e1eded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763882Reviewed-by:
-
