- 31 Oct, 2020 40 commits
-
-
Chris Thompson authored
Bumps the flag for the Legacy TLS interstitial (on Desktop) to expire in M-92, which is the release after we plan to remove support in May 2021. Change-Id: I7b3e00c1777b2a9c8a50d4f4c223459729b708b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508634 Auto-Submit: Chris Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#822932}
-
Sven Zheng authored
Bug: 1133499 Change-Id: I868514ca0ef55ce2f9b45b7206283ff477877ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510880Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822931}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604080750-57b938941e5d0fc2e4e9a8db795b6e934af11898.profdata to chrome-mac-master-1604102313-62a5870852d3f270530ddcb01f9462f63d32dd85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If7adc5e2f614eafe6e78fcbf1d00e3638f5fa017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822930}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604080750-96a3ce07c396c7c5f9c28dac9995321371c2c9a1.profdata to chrome-linux-master-1604102313-6511a5d636270bec531104682121d6c64f4f3624.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic6a0f18d9faa2dff4adabb4a8879237dba41cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511902Reviewed-by:
-
Hiroki Nakagawa authored
`PrerenderManager::mode_` is always PRERENEDR_MODE_NOSTATE_PREFETCH in production code. We no longer have to keep the other PRERENDER_MODE_SIMPLE_LOAD_EXPERIMENT mode. Bug: 755921 Change-Id: I3607d878e709484ef3366b73377645365935fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486824Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#822928}
-
Yuly Novikov authored
Disabling test failures found in try runs Bug: 1134735, 1144207, 1144247, 1144258, 1144270 No-try: true Change-Id: I48fc3daa05cc7673de4f820d07ca0b84ea285b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506106 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822927}
-
Gavin Williams authored
This change adds a option to the Scan To dropdown that opens the select dialog and lets the user choose the directory to save completed scans. Screenshot: http://screen/dnTcAPoV48BZmDJ Bug: 1059779 Change-Id: Id35ed06fff8fe1f4ca4c3e0c8c6d5ace852ea750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508151 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#822926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/750109bfd19d..df208a341b64 2020-10-30 tdenniston@google.com [svg] Add several skeleton classes for filters 2020-10-30 tdenniston@google.com [svg] Add 'filter' presentation attribute and parsing 2020-10-30 jmbetancourt@google.com add non-looping option to SkottieViews through xml attributes 2020-10-30 csmartdalton@google.com Fix crash in SampleCCPRGeometry 2020-10-30 johnstiles@google.com Fix unknown-identifier issue discovered by fuzzer. 2020-10-30 tdenniston@google.com [svg] Rename gradient units type to object bounding box units 2020-10-30 johnstiles@google.com Add initializer_list support to SkTArray. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I475a379da4f7a5106f8354a6c179034c483b81b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511196Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cabef8da90bf..fa71f05ed064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059013,chromium:1112471 Tbr: Change-Id: I9ff945fd97f6576800a39c25ecb06a9f5c041590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822924}
-
Lukasz Anforowicz authored
After pressing ui::VKEY_BROWSER_BACK, the test needs to wait for the navigation to finish + for the load to finish. Both can be accomplished with the help of content::TestNavigationObserver. Fixed: 846623 Change-Id: I1e7ab80ad4caa37b12c2e99a50eba2393b4bc2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511253 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822923}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5a1d786754ad..0a374dce6653 2020-10-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 17e0deaebaa6 to 5bee67fced90 (1 revision) 2020-10-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5d40a5621b7d to 17e0deaebaa6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I706e53408f86c38afd8d5c3d22ae459c8a415713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511895Reviewed-by:
-
Collin Baker authored
This feature is already enabled on non-ChromeOS desktop platforms. It is also enabled at 50% non-stable and 4% stable for ChromeOS, without issue. Fixed: 1069634 Change-Id: Ia510899463ba7b33c48b72d9d67ea4235fca06cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510713Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822921}
-
Anupam Snigdha authored
This patch contains the geometrychange JS event and overlayscontent implementation of the new VirtualKeyboard APIs on Android. This is a new feature that would let web authors to control whether they want the default occlusion of web content and changing of visual /layout viewport in response to VK visibility or not. The explainer has some examples as to where this would be useful and how it would be used by the web authors. Test page: https://bocupp-microsoft.github.io/VirtualKeyboard/geometrychange.html Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardAPI/explainer.md Design Doc: https://docs.google.com/document/d/1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing Check the Android Design section for more info on the proposed design We also discussed in the TAG review about this event and haven't seen any objections yet. https://github.com/w3ctag/design-reviews/issues/498 Bug: 856269 Change-Id: I42a7fa737dec06be04b8b1a59b3f511d3678c791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463811Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822920}
-
Joon Ahn authored
`browser_tests --gtest_filter=DiagnosticsApp*` to run in a single instance. `browser_tests --run-manual --gtest_filter=DiagnosticsApp.MANUAL_*` to run each test on a new instance. Bug: 1125150 Test: Described above. Change-Id: Iebef0469550523c2ef588e6ff6816ee2cc54683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508792 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
-
Peter Kvitek authored
These ifdefs were there since the test was part of Compositor fixture, which is not the case anymore, hence no need to limit testing on platforms that don't support BeginFrame control. Change-Id: I331e656ea64e7f2941a2eb3b7584b98caf21ceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511855Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822918}
-
Miriam Zimmerman authored
The resizeTo function is deprecated, and it set the height of the overall window -- including window chrome. On mac, there are 20px or so of chrome at the top of the window. This resulted in the window being too short. See https://developer.chrome.com/apps/app_window#type-AppWindow TEST=on my personal mac, edit html of feedback page to contain an extra\ line, then edit feedback JS to match this CL and run \ resizeAppWindow(). Verify window size is correct. Fixed: 2461725 Change-Id: I0d75d9e07d25e2a93a9c3fa17c7dbb98913724dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508974 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#822917}
-
Austin Eng authored
This adds webgl_conformance_tests with --enable-unsafe-js-fast-calls to: Optional Win10 x64 Release (NVIDIA) Win10 FYI x64 Release (NVIDIA GeForce GTX 1660) Win10 FYI x64 Release (NVIDIA) Win10 FYI x86 Release (NVIDIA) Win10 FYI x64 Exp Release (NVIDIA) They run on the trybot win_optional_gpu_tests_rel Bug: 1101475 Change-Id: Ic832e9a67528fad38874eefa70962ec70965a043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506519Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Tom Anderson authored
This is a speculative fix for a crash where seccomp blocks lazy library loading, which may occur on certain versions of the Nvidia driver. R=kbr BUG=1137632 Change-Id: I7716739263ffb3b478003ad9eef4ffaa2b6467f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510360 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Michael Hansen authored
Removes the "Contacts" title and updates strings in the description for each visibility mode to match the latest specs. Screenshots: https://screenshot.googleplex.com/An6Ta8EDzfS3KZU.png https://screenshot.googleplex.com/C5WwqifMeCnLhkH.png https://screenshot.googleplex.com/C48HQVfgouJrhHF.png Strings spec: https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag Bug: b:168841167 Change-Id: I5facb117242e22b838266c2fa5e2629b221e6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511852Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#822914}
-
Charlene Yan authored
The ID 2001 was already in use by the SendTabToSelfMenu. Also delete some unused constexprs. Bug: 1141858 Change-Id: I10f04c0eb01f17d26f4962b37789588adde3e079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495713Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- Remove unused ContiguousContainer methods such as Clear(), Swap(), etc. - Replace RemoveLast() with ReplaceLastByMoving(). This removes the logic to deal with removed items, making ContiguousContainer appending only. - Let ContiguousContainer store Buffer directly in the vector instead of through unique_ptr. - Use 'item' instead of 3 different terms 'item', 'element', 'object' in ContiguousContainer - Remove DisplayItem::IsMovedFromCachedSubsequence() because with the new PaintChunkSubset we can use PaintChunk.is_moved_from_cached_subsequence. - etc. Bug: 917911 Change-Id: I8b3004d001ea12a00fed96fc3e031986db1ee005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501064Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822912}
-
Avi Drissman authored
Bug: 1100642 Change-Id: I1e282150bd7c0774aa00f59012a14d1330d43f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511090 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822911}
-
Gordon Seto authored
Add QR code detection logic and styling to cellular esim setup. Screenshots: https://screenshot.googleplex.com/64NSd3tsBZWT2pJ.png https://screenshot.googleplex.com/7ks7FBaXpYFAt6z.png https://screenshot.googleplex.com/86VbgmA3Y2TDFAG.png Bug: 1093185 Change-Id: I9631aeeee9db8fe67a4b18cf48fd7576556b32cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495873 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#822910}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e9a7015ec876..5cbd052dfba9 2020-10-30 apodtele@gmail.com Add preamble. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4f521ab2294810c0c03ac9d3a4dcc4082d860756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509554Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#822909}
-
Shimi Zhang authored
We reinterpret scroll gestures conditionally for cursor control purpose. This is done by add a new bit |kInternalPanXScrolls| to TouchAction, This bit is suppressed by TouchAction::kPanX, i.e. we only set this bit when TouchAction::kPanLeft or TouchAction::kPanRight is set. By default, if an element has TouchAction::kPanX, it will be set. Therefore, TouchAction::kAuto has this bit as well. When |kInternalPanXScrolls| is set, we don't do cursor control. When an element is flagged as editable, we remove |kInternalPanXScrolls| bit for that element and its descendants. Therefore, if there is an editable element, because it is not equal to TouchAction::kAuto, the browser side will get a signal and set |has_touch_event_handler_| as true in TouchActionFilter. In painting stage, we also calculate horizontal scrollable information for an element, if an element or its ancestor is horizontal scrollable, we put |kInternalPanXScrolls| bit back to the corresponding TouchActionRegion to disable cursor control. When a touch start event happens, it will be dispatched to the renderer since we know there is a touch event handler, the browser will get the compositor touch action from the compositor hit test. The event will be further dispatched to the renderer main thread, we do another hit test, we also need to acquire the horizontal scrollable information for the hit test result element, so we could decide to put |kInternalPanXScrolls| back to the main thread touch action or not. Main thread touch action will also be sent to the browser. When a GestureScrollBegin generates, we use the compositor touch action and the main thread touch action to filter it, because compositor touch action is permissive, if we don't have |kInternalPanXScrolls| bit on the touch action, we delay the event until we get the main thread touch action. If |kInternalPanXScrolls| is not set and |kPanX| is allowed and this is a horizontal scroll, we set the GestureScrollBegin's |cursor_control| flag to true, therefore, the whole scroll gesture sequence will be used as cursor control. In this way, we fulfilled multiple design goals: 1) cursor control can be disabled by not set touch-action: pan-x 2) cursor control can be disabled by register a non-passive event handler of the touchstart event and calling event.preventDefault() inside. 3) cursor control is disabled when the element is horizontally scrollable. 4) cursor control is not interleaved with scroll. Bug: 1126778 Change-Id: I7a1c58f60740ff87dbee460524de66c67878dc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435324 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822908}
-
Jimmy Gong authored
Onboarding UI is now hidden when either the user dismisses the UI or if the user has completed the onboarding flow. Bug: 1106937 Fixed: 1141634 Test: chromeos_components_unittests Change-Id: I0e34bed1977f6b72cf45bab1f2fd289deaa630da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508953 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Tim Song authored
This CL adds the following metrics logging the current screen when a given event occurs: * Ash.PhoneHub.ScreenOnSettingsButtonClicked * Ash.PhoneHub.ScreenOnBubbleOpen * Ash.PhoneHub.ScreenOnBubbleClose To implement these metrics, we also refactor the individual content views to return a Screen enum. BUG=1138137,1106937 Change-Id: I8f78bd270004a34794882252b73d68d0d8f0942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500578Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Dale Curtis authored
The entire output buffer should be used, but apparently it's not always. So to avoid exposing uninitialized memory, zero initialize the AudioBuffers just like we do for VideoFrames given to ffmpeg. R=cassew Fixed: 1144070 Change-Id: Ic08a760cd63ca4fae26932621445991e781a0941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511969 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#822905}
-
Mike Wittman authored
Replace DISALLOW_COPY_AND_ASSIGN, delete destructor, use NoDestructor in place of LazyInstance, and make enums camel case. Change-Id: Icf278d2755acc8e3fd8fb97b071d0c199f4353b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438887 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#822904}
-
Bill Budge authored
- Adds SharedArrayBuffersAllowed method to ExecutionContext, which checks for the feature flag, or cross-origin isolated status. - Checks that SABs are enabled before transferring them. - Disables no COOP+COEP tests on desktop, as SABs are enabled by default, which causes these to fail. - Enables *most* WPT /safe-passing-of-structured-data/shared-array-buffers tests on Android. Several of these test transfer of SABs. Bug: chromium:923807 Change-Id: Ib91233884376a3ea55d9d61f06e498bc53517f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343658 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#822903}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 1142671 Change-Id: Ib1f4ae0de89d1777357b2904ef6ed756fc9b1f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500558 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822902}
-
Sorin Jianu authored
Bug: 1144360 Change-Id: I60389ee39fd525250a768f184132d2f812a34be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511755Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822901}
-
Josiah K authored
AX-Relnotes: Add support for panning the fullscreen magnifier viewport with Ctrl+Alt+Arrow keys Change-Id: I263be6236f7060cd12d2037e82f070a6f0863cf4 Bug: 1140624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510911 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822900}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I225fa0314dc0a0daa377a6e344d2f05811b065ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510666Reviewed-by:
-
Bartek Nowierski authored
The pointer is used for reinterpret_cast in: net/third_party/quiche/src/quic/core/qpack/qpack_receive_stream.cc:29 net/third_party/quiche/src/quic/core/http/quic_spdy_stream.cc:773 net/third_party/quiche/src/quic/core/http/quic_spdy_stream_body_manager.cc:99 Bug: 1069567 Change-Id: If0c54da8255f312f047bc3da6c35c601e8d868d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509891Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Olivier Yiptong authored
Minor refactor that makes the cache initialization have clearer steps. Also paves the way for future cache invalidation functionality. Change-Id: Ie929e32e44ad890cde9313bdeb218cdb2e380086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505560 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822897}
-
Ana Salazar authored
We want to give users a quick shortcut to access recent nearby shared files within Tote. As user receives a file via nearby share, we should be able to add them to the holding space model in a similar way we add downloads as they are completed. Bug: 1130625 Change-Id: Iba7ab69e7f8d9b7c05e740e8e4331b85a890b423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463584Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#822896}
-
Xianzhu Wang authored
We had two places where PaintLayerCompositor::CanBeComposited() was called for the LayoutView in a throttled frame. Now let the callers check throttling status and fallback to use the current compositing status when the frame is throttled. This avoids the need of forced compositing inputs update when a throttled frame is unthrottled. Bug: 1139116 Change-Id: Id8069d5b26707e1ee3422b27742a6de29029a619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505727Reviewed-by:
-
Devlin Cronin authored
The following are still useful. Extend their expiration date to 2021. PageActionController.ExtensionsWithPageActions ExtensionToolbarModel.BrowserActionsCount ExtensionToolbarModel.BrowserActionsVisible Extensions.UninstallDialogAction Extensions.ResetPermissionsIncrease Extensions.ProcessManagerStartupHostsTime2 Extensions.Permissions_WebStoreInstall3 Extensions.Permissions_AutoDisable3 Extensions.Permissions_InstallCancel3 Extensions.Permissions_WebStoreInstallCancel3 Extensions.Permissions_Load3 Extensions.Messaging.MessageSize Extensions.LoadUserScript Extensions.ExtensionServiceInitTime Extensions.EventPageIdleTime Extensions.ExtensionServiceNotifyReadyListenersTime Extensions.DidCreateScriptContext_ContentScript Extensions.DidCreateScriptContext_WebUI Extensions.DidCreateScriptContext_WebPage Extensions.DidInitializeServiceWorkerContextOnWorkerThread Extensions.DidCreateScriptContext_Unspecified Extensions.DidCreateScriptContext_LockScreenExtension Extensions.DidCreateScriptContext_BlessedWebPage Extensions.DidCreateScriptContext_Blessed Extensions.DidCreateScriptContext_Unblessed Extensions.BackgroundPageLoadTime2 Extensions.Bindings.NativeBindingCreationTime ExtensionBlacklist.SilentInstall ExtensionBlacklist.UnblacklistInstalled ExtensionBlacklist.BlockCRX ExtensionBlacklist.BlacklistInstalled Extensions.HasPermissions_WebStoreInstallAbort3 Extensions.HasPermissions_InstallAbort3 Bug: 1140057, 1140044, 1140042, 1140041, 1140040, 1140038, 1140037, 1140036, 1140035, 1140034, 1140033, 1104939, 1088786 Change-Id: If788baa32b7933c50b309be199558d175f45273d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485618Reviewed-by:Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822894}
-
Meilin Wang authored
This CL updates the bubble width to use |kTrayMenuWidth|. This CL also includes minor refactoring such as: - Replaces hard-coded constants with calculation. - Introduces ui_constants.h to store both appearance and URL constants. Screenshot: https://screenshot.googleplex.com/6PBiuFovTjyfjaa.png BUG=1143058,1106937 Change-Id: Icdf17321a9acd9be53b7287023e197e027fcac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510551 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#822893}
-
