- 26 Nov, 2019 40 commits
-
-
Clemens Arbesser authored
Clicking a text link will end the action immediately and send the current state of the form action (including the state of counters and checkboxes) to the backend. This CL also fixes a bug where multi-line radio button descriptions where not correctly vertically centered. Bug: b/144402029 Change-Id: I6e14f01744edf16bd703df9b560a45c9498bd2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929820 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719297}
-
Mounir Lamouri authored
Bug: 1028449 Change-Id: I8e60112a7da55ad07845f4651724504a8906f506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935929Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#719296}
-
chrome://discardsSigurdur Asgeirsson authored
Change-Id: Icda679eabd038ac15ac79e42b064a395bef4f9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933201 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719295}
-
Min Qin authored
properly deleted BUG=1028666 Change-Id: I59b60a897a5f2529d4e61d8632aebe421dbc71b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933738Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719294}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fe2d3ddde90a..5b2740c57090 git log fe2d3ddde90a..5b2740c57090 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 syoussefi@chromium.org Vulkan: Remove unnecessary barrier in image -> buffer copy Created with: gclient setdep -r src/third_party/angle@5b2740c57090 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I27268d0155bb23de102627f06fe3c4e55079b3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719293}
-
Arthur Wang authored
R=aluo@chromium.org, bsheedy@chromium.org, carlosk@chromium.org, harringtond@chromium.org Bug: 1021309 Change-Id: Icda90823cbb4e73f5735008d96f3d51e23c4a9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898438 Commit-Queue: Arthur Wang <wuwang@google.com> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#719292}
-
Toni Barzic authored
BUG=1026964 Change-Id: Idd32c959203b7155e6a8639937e34cb206498bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928618 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719291}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6807a2568cda..f06a1962beff git log 6807a2568cda..f06a1962beff --date=short --first-parent --format='%ad %ae %s' 2019-11-26 9856269+sarahM0@users.noreply.github.com spvc: Fix spvc_spirv_cross_spvc_parser_tests failure by updating known_spvc_filures (#909) Created with: gclient setdep -r src/third_party/shaderc/src@f06a1962beff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I2129b3486511d21ebf65b42c5f53ff39c2acb3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937348Reviewed-by:
-
Mikel Astiz authored
The new enum was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1714585 but the Java enum has remained outdated since. This patch adds the new value also in Java by auto-generating the Java enum via GENERATED_JAVA_ENUM_PACKAGE, which prevents similar future issues. Wherever there is passphrase-type-specific logic, the new TRUSTED_VAULT_PASSPHRASE is treated similarly as the keystore case. Bug: 1019687 Change-Id: Ib7339e8f60a0f7905626d5821fc6673659173b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932904 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719289}
-
Andrew Grieve authored
Enableds the following: * BinderIdentityRestoredDangerously * EmptyIf * EqualsBrokenForNull * InvalidThrows * LongLiteralLowerCaseSuffix * RedundantOverride * RemoveUnusedImports * StaticQualifiedUsingExpression * StringEquality * TimeUnitMismatch * UnnecessaryStaticImport * UseBinds * WildcardImport Bug: 894616 Change-Id: I2eb886044d27b45d751ab54eceb606b176458a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936892Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c959541ab602..6f1240d519b7 Created with: gclient setdep -r src-internal@6f1240d519b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028600,chromium:None Tbr: jbudorick@google.com Change-Id: Id492b5c57f377f843e39196baa468816a2109b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937350Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719287}
-
Caleb Rouleau authored
This change https://chromium-review.googlesource.com/c/chromium/src/+/1908715 accidentally enabled this test on Mac. R=ellyjones@chromium.org Bug: 1023255, 1028240 Change-Id: I13817e90e01b1dc3ae7474ea16b3f29c33832c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937142Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719286}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/20c014cee7c3..74cebd68792d git log 20c014cee7c3..74cebd68792d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 cwallez@chromium.org Allow using swiftshader with the Vulkan backend 2019-11-26 rharrison@chromium.org Remove build rules for spvc support & spirv-cross fuzzers Created with: gclient setdep -r src/third_party/dawn@74cebd68792d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic26cb4bd6bfc6af8b3e516757c954f3614d30d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937145Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1b1f18689958..c92898569764 git log 1b1f18689958..c92898569764 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 hjd@google.com Merge "trace_processor: improve costing algorithm to better account for sort" 2019-11-26 skyostil@google.com Merge "TrackEvent: Add support for debug annotations" Created with: gclient setdep -r src/third_party/perfetto@c92898569764 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic3d02becb77cf1617d3cceacf7b34f3288541cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937143Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/17096c763c24..882115da6b31 git log 17096c763c24..882115da6b31 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 borenet@google.com [infra] Make CheckGeneratedFiles use Clang 2019-11-26 robertphillips@google.com Stop using GrPixelConfig in Metal & Dawn's GrProgramDesc creation 2019-11-26 reed@google.com Revert "Revert "switch to new filltype for SkPath"" Created with: gclient setdep -r src/third_party/skia@882115da6b31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I6a591ff520b33c1c32d0cfac7105a36c9fcd9a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936906Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 224 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-05-24. Change-Id: I8910fb8b2afe1c4c654b8b3c34dd3c28a9fd5a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937207 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#719282}
-
Jacques Newman authored
- Updated the wording on the switch comment - Split 'GetOrCreateWindowRootAccessible' into UIA and MSAA versions. This is only used in test code, so I think it makes sense for the test to decide which version it wants to use. - Added ProviderOptions_HasNativeIAccessible flag to provider options - Removed MSAA Event disablement when the UIA flag is enabled. This means we will be firing events for both UIA and MSAA when the flag is on. - ViewAXPlatformNodeDelegateWin will can no longer return an AXFragmentRoot. This case is handled in AXPlatformNodeWin::Navigate. Note: Windows will "translate" some IA2 events to UIA, and it is not possible to turn this feature off, therefore, we will receive duplicates for Focus and menu events. Bug: 928811 Change-Id: I758b34264ddf9daeaa30674e1e207709e7e252fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906896 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#719281}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mpawlowski@opera.com Bug: 1023677 Change-Id: I76203f21c6974634ca44651e792dd1b732f32fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926792 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#719280}
-
Megan Jablonski authored
When I rebased crrev.com/c/1921655 I accidentally reverted this part of crrev.com/c/1918655. Bug: 976352 Change-Id: I6d74e6d21f0b91fd41a9ba007a88c566c3e7bc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935491Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#719279}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa91fcd5. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5b35f001300a1f6dc834216355d1c48bd7fe087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937227Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719278}
-
Marc Treib authored
This feature was never meant for a full launch, and thus probably shouldn't have been in the fieldtrial testing config in the first place. It certainly makes no sense to enable it in browser tests and developer builds. Bug: 1009999 Change-Id: I3cf0eab118f8fff65cfe0f2ea99222fbe32344a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936311 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Christopher Thompson authored
This adds infobars on Desktop and Android for showing the known monitoring disclosure. The infobar is shown once every 7 days. The last dismissal time is tracked in a pref on Android (to carry over across sessions) and in-memory on Desktop (since sessions are longer -- this means on Desktop we will always show on startup). These currently link to chrome://monitoring (implemented in crrev.com/c/1913715), and are triggered on visiting https://badssl.com/test/monitoring-disclosure/ (to be replaced by checking for the new monitoring CertStatus based on CRLSets). Screenshots - Desktop: https://drive.google.com/file/d/1AF2uCGfYfrQHJbLGjIX132xR0n8GqG5R/view - Android: https://drive.google.com/file/d/1FeDSEQNasHfPdc6bbkprm_wOaMZcCDQl/view Bug: 1014711 Change-Id: I31e9d5be6da7d87dfda2f5c739f1b94df1c8a0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918188Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719276}
-
Ayu Ishii authored
This change adds metrics to measure why the SmsService has been destroyed. Included changes: - SmsService destroyed because of navigation to new page (possibly moving onto the next step w/o using the API) - SmsService destroyed because of navigation to same page (reload by clicking enter on omni box on same page) - SmsService destroyed because of navigation to existing page (includes using back/forth buttons and pulling down for reload) Does not include: - SmsService destroyed on tab close - This change affects multiple files that may cause difficulty to cherry-pick - Renaming timeout response to be "NavigatedAway" - This change also affects multiple files that spreads from files for browser process to renderer process, but will make a separate CL that will not be cherry-picked - This change will not give us more info than we have now. We can change metrics to show NavigateAway instead of Timeout for now w/o cherry-pick risk Change-Id: I5100298ebff91fab0ce7ea57134f0daf2d149a7d Bug: 976332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906325 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#719275}
-
Christopher Grant authored
This is an unchanged reland of 0c8f0867. See the associated bug for reasons why this work is happening. Refactor the version number generator script to be more explicit, and do away with the hack that was in place to support multiple version numbers in 64-bit config. Also, add the new pure 32-bit Mono and Trichrome numbers, as well as an alias 32_64 version number, which is equivalent to the ambiguous "Monochrome" version. TBR=agrieve@chromium.org Bug: 1027573 Change-Id: Ib1d32b02c9db6e57eba49fba602486503071fce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936890Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1020267 Change-Id: Idb1651019f9034f9c1b00dc1ca70411724ca1120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929092 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719273}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/feedback This CL was uploaded by git cl split. R=bsimonnet@chromium.org Bug: 1018667 Change-Id: I7a69248b11bda233894700f6d9a39a167e7322c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917510Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719272}
-
Bo Liu authored
Looking at chrome and android webview, looks like cache dir is used for http cache and code cache. Use these in weblayer as well. Note before these, neither disk cache are enabled, so there is no need to consider any migration issue. Bug: 1027627 Change-Id: Ib6e615e975a9cd8f7e456c6f5af1c0fac4bceea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937087 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719271}
-
Yngve N. Pettersen authored
Some FileUtilTest tests fail if run on a Windows file system that is being compressed. This CL filters the compressed file attribute away before testing the file attributes. Change-Id: I015ebc633920fe35902f2195452a26993c26c293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917216 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
-
Jenny Zhang authored
Bug:1025820 Change-Id: Ib6c9cae33be5befb60e5c91e5bafd3d4b04f1c8a TBR=holte@chromium.org Change-Id: Ib6c9cae33be5befb60e5c91e5bafd3d4b04f1c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935172Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719269}
-
Tomasz Wiszkowski authored
TBR=pkotwicz@chromium.org Bug: 1028636 Change-Id: Ib43142773bc7ae526d8e45149384bee16f1a7663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935370Reviewed-by:
Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719268}
-
Jenny Zhang authored
Bug:1025880 Change-Id: Id8419e7417556c454b916a52fc3187f9cd43236e TBR=holte@chromium.org Change-Id: Id8419e7417556c454b916a52fc3187f9cd43236e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935547Reviewed-by:
-
Ken Buchanan authored
remote_viewport_intersection_ was subsumed by IntersectionObservationState and is no longer referenced. This is just a cleanup. Change-Id: I326b1199172d7dc4d38bb4783d78350aa35ebca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937133 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719266}
-
Michael Crouse authored
This change persists the model and host model features received from a fetch to the remote Optimization Guide Service by places them within the store owned by the PredictionManager. A future change will add browser tests and metrics to confirm expected behavior of prediction manager, fetcher, and models. Bug: 1001194 Change-Id: I705785d32560160b14f69f846f0148d3ef6abc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934827Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#719265}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a069fea..c92a0fa4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I90ccb314d5553d6f971b53aa3ce5baed70e47dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937228Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719264}
-
Alan Screen authored
During print preview user can choose a custom page range for printing. This can easily be less than the entire document. The recent change for concurrent PDF composition [1] erroneously always expected the full document to be collected, which fails with a hung preview if the user selects a custom page range. Correct this by updating the PrintRenderFrameHelper to pass along only the number of pages rendered for the page selection. [1] https://crrev.com/c/1917685 Bug: 1028104 Change-Id: Ic6ecbc09d09a8c7f30bc959b0a3808d66f1274ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935724Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719263}
-
Sidney San Martín authored
Issue: When "Add period with double-space" is turned on in System Preferences, typing two spaces after a word inserted a space, a period, then a second space. The period should replace the first space instead. It turned out that, since a key event is being handled at the time of the replacement, insertText:replacementRange: took a path that didn't consider replacementRange, and the period just got appended before the second space. The fix avoids the key press path when a replacement range is specified. Bug: 752640 Change-Id: Ia051e04f87345cd12bbd3438cf351cdc649149c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933408Reviewed-by:
-
Matt Falkenhagen authored
As part of converting to Once/Repeating variants of base::Callback. This CL also converts away from gmock action templates, which don't support move-only types. Bug: 1007685, 1007763 Change-Id: I5386a16ba2cbb6339aae2e00c2d1f49d7ec9d959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935294 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719261}
-
Demetrios Papadopoulos authored
- Moving no-var and prefer-const to the top-level .eslintrc.js file. - Enable prefer-const in a few folders that were only using no-var previously. - Explicitly turn off no-var and prefer-const on folders that still have plenty of violations, for example chrome/test/data/extensions. Bug: 720034 Change-Id: I927fff375b04cd8f1326082c99ceef6f8e01e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885181Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719260}
-
rbpotter authored
Update template expressions replacement to use the new HTML template start and end markers instead of looking for _template: html` and `,. This allows some simplification of the logic and will enable i18n replacements in JS files using class based Polymer 3 syntax, since the autogeneration code adds these markers to the start and end of HTML templates at build time regardless of syntax. Also modifying some existing tests to use class based syntax, and adding more tests for less common cases and for mixed class/legacy syntax. Bug: 1023841 Change-Id: I764ee18621bc526f259b7b970e6008e0de220711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935609Reviewed-by:
-
Andrew Grieve authored
Two semantic changes here: 1. ChromeTabUtils.java had a milliseconds vs seconds mismatch in a timeout (passing ms to function that took seconds). 2. Disables errorprone in custom_tabs_client_shared_java since it contains an unused import in a sub-repository. Fixes failures for: * BinderIdentityRestoredDangerously * EmptyIf * EqualsBrokenForNull * InvalidThrows * LongLiteralLowerCaseSuffix * RedundantOverride * RemoveUnusedImports * StaticQualifiedUsingExpression * StringEquality * TimeUnitMismatch * UnnecessaryStaticImport * UseBinds * WildcardImport Will enable these checks in a subsequent CL. TBR=agrieve # lint fixes Bug: 894616 Change-Id: Iee4b8bd187d68af93fcff042e58e87bb7faf46db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935889 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
