- 23 Aug, 2019 14 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56db378961af..5ec048801014 git log 56db378961af..5ec048801014 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 dakshidnani@google.com Reland "Make Mac SystemInfo reflect the currently active GPU on dual GPU machines" Created with: gclient setdep -r src/third_party/angle@5ec048801014 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: chromium:985486,chromium:984780 Change-Id: I289b58ba70b8d85b0f3e8d451a092d67dcf9e4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689745}
-
Kyle Milka authored
Bug: 996587 Change-Id: I30894289635cfb232b36394d1a4e861455b86f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764905 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#689744}
-
Ovidio Henriquez authored
This change updates the gattserverdisconnected-event tests in wpt/ to be standalone window tests. This change allows the tests to be formatted with clang-format. Bug: 994756 Change-Id: Id08fd9bdef1fc8b37d8ad192b23e11a77a99f4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761071 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#689743}
-
Sophie Yang authored
Change MenuManager to use the new open and close functions introduced in issue 1760673. This change lays the foundation for submenus to be implemented for the Switch Access menu in a follow-up change. See go/cros-switch-menu-redesign for more information. Test: With emulated Chrome OS on Linux, manually verified that opening the menu, navigating through the menu, selecting actions on the menu, and closing the menu worked as before. Bug: 994256 Change-Id: Iffdfdde22de712aebec117bd37662cff315ddc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761086 Commit-Queue: Sophie Yang <sophyang@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#689742}
-
Wei-Yin Chen (陳威尹) authored
Delay the thumbnail taking a bit more to make it less likely to happen before the thumbnail taking triggered by ThumbnailFetcher. This is likely to happen when "skip-slow-zooming" replaces the shrinking animation with a short fade-in animation. Bug: 996385 Change-Id: I5fd91e1ac43dba520f41d10c34162502376c9824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764661 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689741}
-
Hwanseung Lee authored
Use enum class instead of enum for FocusManager::FocusChangeReason enum class is more type safety. Bug: 940736 Change-Id: Ic635038be25929f3b9a233490617bdb5deb6d141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767281 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689740}
-
Reilly Grant authored
This is a no-op since [Exposed=Window] is the default for interfaces. It updates Blink's WebIDL to match the specification as modified in, https://github.com/w3c/geolocation-api/pull/32 Bug: 931847 Change-Id: I5084d84f9c5558ca64ee7aeaef87e00b791a90ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766005 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Matt Menke authored
HttpServerProperties tracks what servers require HTTP/1.1, so there's no need for this method. The code isn't wrong, but it means we have very little integration test coverage for HttpServerProperties. The down side of this approach is that with SPDY session pooling, we only mark one server as requiring HTTP/1.1, instead of all the pooled sessions, though we could change that. Bug: None Change-Id: I127875bb9efc9cd000717b9fcb3f7ee9642df685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765655 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#689738}
-
Sophie Yang authored
Add new functions for opening and closing menus in MenuManager. Note that these functions are not currently being used anywhere, but will be used in a follow-up change for adding submenu infrastructure to the Switch Access menu. See go/cros-switch-menu-redesign for more information. Bug: 994256 Change-Id: I38250d6eeca61ba3ef430721d462a6489b9e2755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760673Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8b51b25cb2fc368260984201d4fd1d3e943ff7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767065Reviewed-by:
-
K Moon authored
This change splits DocumentLayout::page_rect() into two methods, page_rect() and page_bounds_rect(), to better mirror the corresponding APIs in PDFEngine, GetPageRect() (page rectangle before insets) and GetPageBoundsRect() (page rectangle after insets). The existing page_rect() method is equivalent to PDFEngine's GetPageBoundsRect(), which is confusing, so it has been renamed to page_bounds_rect(). The new page_rect() method is equivalent to PDFEngine's GetPageRect(). (This will be useful in a future change.) DocumentLayout is now responsible for adding insets to the page rectangles returned by draw_utils::GetRectForSingleView(), etc., eliminating the need to pass the insets to these functions. Bug: 885110 Change-Id: I4ef345333abbb5b75892c32ffff8dee24e20ef05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762601Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689735}
-
Victor Costan authored
Change-Id: I5620226e814bc14a342010f876956f7c52e8378f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757733Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689734}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6b81fbf. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib3adecc5cea7fc19bb83ae79ba616f1dbb1cb32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765496Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689733}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/00bc04d26609..30e70ea37d89 git log 00bc04d26609..30e70ea37d89 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 dhanyaganesh@chromium.org Make wizpig experimental 2019-08-22 tcwang@google.com afdo: Implement build API of benchmark-afdo-generate builder. Created with: gclient setdep -r src/third_party/chromite@30e70ea37d89 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ieb89d9ddcd68eee4b70876a32056e2da180f036c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766888Reviewed-by:
-
- 22 Aug, 2019 26 commits
-
-
Ahmed Fakhry authored
This reverts commit 0567f059. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=968047#c135 Original change's description: > Reland "Reland "Reland [base] Require task posters to specify an explicit destination"" > > This is a reland of d7b74986 > > As usual, if this fails **please** paste the build failure, not just > silent revert, logs can be hard to find in retrospect. > > Reason for reland: > - joenotcharles@ fixed the windows build in > https://chromium-review.googlesource.com/c/chromium/src/+/1764471 > - google chromeos build failure fixed in > https://chromium-review.googlesource.com/c/chromium/src/+/1764256 > > Original change's description: > > Reland "Reland [base] Require task posters to specify an explicit destination" > > > > This is a reland of dd34a877 > > > > Rebased on a few more fixes including a local full build of: > > - Windows + is_chrome_branded > > - ChromeOS + is_chrome_branded > > (except for the libassistant portion which is giving weird errors...) > > > > Original change's description: > > > Reland [base] Require task posters to specify an explicit destination > > > > > > This patch makes it a requirement for all task traits to specify their > > > thread affinity. Previously task traits that did not name a specific > > > thread would implicitly run on the thread pool, which could be > > > surprising. To make this more obvious, thread pool tasks must now use > > > the base::ThreadPool() trait. > > > > > > This is the final reland of > > > https://chromium-review.googlesource.com/c/chromium/src/+/1635827 > > > (will attempt to fix errors that caused original revert before > > > relanding). > > > > > > Bug: 968047 > > > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056 > > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > > Reviewed-by: François Doray <fdoray@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#688782} > > > > Bug: 968047 > > Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689097} > > Bug: 968047 > Change-Id: Ie338781aba9b5f5990ffe74e02bb85f08fe683d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764398 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689665} TBR=gab@chromium.org,fdoray@chromium.org Change-Id: I7fdf51bd629a68d3fb46ed39331ec67aca68b41a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767097Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#689731}
-
Mandy Chen authored
Outdated local branch and the use of --bypass-hooks can result in localizability errors in master. Run the localization checks on commit so CQ runs can report errors. Screenshot: https://imgur.com/8kaBsKO Bug: 941561 Change-Id: I51ca39f76356df48f16a76a2cb46002ff0f2f107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764274Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689730}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9d9d76c590e9..3f21e11e240a git log 9d9d76c590e9..3f21e11e240a --date=short --no-merges --format='%ad %ae %s' 2019-08-22 enga@chromium.org Fix RenderBundleValidationTests Created with: gclient setdep -r src/third_party/dawn@3f21e11e240a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I379e18a11be6068c4109dd4f692ebc070de23d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766887Reviewed-by:
-
Nigel Tao authored
The AppService (and specifically app_service/arc_apps.cc) currently uses the ARC_GET_INSTANCE_FOR_METHOD macro directly, which is really a private implementation detail of the ArcAppListPrefs class and its friends, such as ArcAppIcon and ArcAppIconLoader. A follow-up CL, adding ArcAppIcon support for providing compressed icons, will let us delete the ARC_GET_INSTANCE_FOR_METHOD macros in app_service/arc_apps.cc. BUG=826982 Change-Id: Ifc5a88deea2693c2fe4c6c1ae3fe0b33661dbee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758024Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689728}
-
Derek Schuff authored
This reverts commit 382570ad. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=996603#c1 Original change's description: > Add DCHECKs for correct thread usage of KeyedService code > > Bug: 701326 > Change-Id: If652eb76fabc09cabdd61865cdb409f72c140392 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748083 > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Reviewed-by: Cait Phillips <caitkp@chromium.org> > Commit-Queue: Derek Schuff <dschuff@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686622} TBR=dschuff@chromium.org,caitkp@chromium.org,blundell@chromium.org,ljusten@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 701326 Change-Id: Ibc4ea2793a1cc0cf97b268fb6bf902791023c365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765499Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#689727}
-
Mandy Chen authored
In rare cases, strings in .grdp files can change without any .js change. Update the presubmit localizability check to run when .grdp files change. Bug: 941561 Change-Id: Ia5e2d084b7c4939b045f6a9ef40e299abec89d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727399 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
pliard authored
There is a recent regression where USB serial devices (SuziQ) quickly disappear from Crostini after being attached. It's unclear yet whether the auto-attach to ARCVM, which is mostly a no-op when ARCVM is not running modulo the extra device open prior to that, is causing it. Nonetheless this ARCVM-specific functionality should be put behind the ARCVM feature flag to avoid side effects when ARCVM is not enabled. Bug: 996113 Test: CrosUsbDetectorTest.DevicesDontGetAutoAttachedToArcVmWhenDisabled Change-Id: Ib5f251402a27da95a28fb70a6b695741342ebc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763558Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Philippe Liard <pliard@google.com> Auto-Submit: Philippe Liard <pliard@google.com> Cr-Commit-Position: refs/heads/master@{#689725}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread. This CL makes the check for extensions work when the feature is enabled. Bug: 824858 Change-Id: I6f9054bc3d77b8261b7e832e97f6cc71e2b3013d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763651Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#689724}
-
Clark DuVall authored
When multiple network contexts are created for a profile (e.g. from storage partitions for extensions), DRP stopped syncing the config to the first network context. This probably didn't show up before http://crrev.com/c/1746682 because of timing issues with the thread hops. Also cleans up the mojo types to use the new versions. Bug: 996334 Change-Id: I1c92e7da6fd9a1df7f46cfc5f8e435fb1fc11d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764897Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689723}
-
Mandy Chen authored
This CL fixes the localizable strings in grdp files that got checked in without descriptions and/or placeholder examples. A follow-up CL will make sure these violations get caught in CQ. Bug: 941561 Change-Id: Icc1279b6209073b263b5df629e400f5f074c9759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764265 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
David Bertoni authored
Bug: 448165 Change-Id: Ic28626c018c09cfab985087aae41e3dc99b896cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764833Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689721}
-
Erik Chen authored
Previously, a WebViewImpl was being passed as a WebWidget to RenderWidget, even though WebViewImpl shouldn't even be a WebWidget. This CL passes a WebViewFrameWidget to RenderWidget. This CL begins, but does not finish fixing RenderWidget usage of WebWidget. The implementation of RenderWidget still fetches the WebView's MainFrameWidget, which is still a reference to a WebView. Change-Id: I62a44f50eba231e0096ebb5e5e353d3fbc7fb85d Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764611 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689720}
-
Marijn Kruisselbrink authored
User activation will have likely expired by this time, but we should still show a picker again if the user opted for selecting a different file/folder after selecting a restricted one initially. Bug: 996224 Change-Id: I12fcccaab5a5447b1da266537e0afc373a47dbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764887 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689719}
-
Kevin Marshall authored
Popup metadata is now attached directly to WebContents instances and is no longer stored as FrameImpl fields. Bug: 888131 Testing: all existing browser tests pass Change-Id: Id8d2e3d94a350302689dc3c61b987192b5115db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766352 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689718}
-
Mike Wasserman authored
Add strings for the dialog to use when the user is selecting files. (selection of files within sensitive directories is restricted) Plumb a flag for whether the user is selecting a directory or file(s). Upload screenshots and add sha1 files to the repo. TBR=nasko@chromium.org Bug: 992627 Change-Id: Ifd5f0a1c048fe2a7a50d3cd8eb5db0e01e0a8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766435Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#689717}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a5954140b49..146307000f01 git log 2a5954140b49..146307000f01 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-22 herb@google.com Revert "Don't send strike with no pending glyphs" 2019-08-22 egdaniel@google.com Reland "Merge GrOpList and GrRTOpList and rename to GrOpsTask." 2019-08-22 egdaniel@google.com Revert "Merge GrOpList and GrRTOpList and rename to GrOpsTask." 2019-08-22 fmalita@chromium.org Revert "[canvaskit] Optimize CK builds for size" Created with: gclient setdep -r src/third_party/skia@146307000f01 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:996636 Change-Id: I8ec59e967a194bd642d8a3a7306d058af5900978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766561Reviewed-by:
-
Steven Bennetts authored
This CL: * Uses mojo properties in the internet detail dialog page * Includes some cleanup in internet_detail_page.js to share code and remove OncMojo.oncPropertiesToNetworkState. Bug: 853953 Change-Id: I4cf1e3f4cfae63f73233cb0000a4624f549d879b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757110 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#689715}
-
Peter Boström authored
With this change we can instantiate one renderer for all footers instead of instantiating a new one per browser window. Bug: chromium:993502 Change-Id: Id85fbff777d0d405c9278fb0f920559722047082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766097Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#689714}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/152e05a4..7e55ad9b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaf70b1ab61a417d69e9703a7321fe049e561ba55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765498Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689713}
-
Morten Stenshorne authored
If there's no content inside a multicol container, there should be no columns. Change-Id: Idf4feb5b782a79e6c9b79f96baafa3ed34257cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766070Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#689712}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ec4ea59c6d52..659a8ea9f3a9 git log ec4ea59c6d52..659a8ea9f3a9 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 9856269+sarahM0@users.noreply.github.com spvc: Add option to inject code to enforce robust-buffer-access Created with: gclient setdep -r src/third_party/shaderc/src@659a8ea9f3a9 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Iedf19f674638896474120e69a05740d2512fe67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766450Reviewed-by:
-
David Benjamin authored
This provides some bounds checks and avoids a potential mishap if OnPaint were ever called twice in a row somehow. Also spans are fun. Bug: none Change-Id: Ibc6043099c99e41f67f3f3a2132b01766b8353dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766252 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#689710}
-
Matt Reynolds authored
In NintendoDataFetcher::GetGamepadData we call GetPadState to get a pointer to an unused PadState slot. This pointer may be null if there are no more unused slots (Chrome supports at most four connected gamepads). This CL adds a null check so we don't try to dereference the null PadState and crash. BUG=996052 Change-Id: I48cb1611b1c557e5eaa1a5791bf68d5acf8841ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762603 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#689709}
-
oysteine authored
This reverts commit d246e65b. Reason for revert: Speculatively revert to see if this helps https://crbug.com/996866 Original change's description: > perfetto: Add some CHECKs to help debug crbug.com/983307 > > Bug: 983307 > Change-Id: I7976df41d85268287757afd86af6f9bc4c52e814 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758065 > Commit-Queue: oysteine <oysteine@chromium.org> > Auto-Submit: Eric Seckler <eseckler@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687703} TBR=oysteine@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983307 Change-Id: I6981dd299a33612c7bd37c3ff74afad60268a169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764276Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#689708}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/243997ac5d09..e7151f77dda5 git log 243997ac5d09..e7151f77dda5 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 capn@google.com Fix mapping NaN inputs for E5B9G9R9 to 0 Created with: gclient setdep -r src/third_party/swiftshader@e7151f77dda5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138944025 Change-Id: I2033eb6dea496e520b6d9b5912f5d7e6ae5f5f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766290 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for MenuItemView::MenuPosition enum class is more type safety. Bug: 940736 Change-Id: Ia49dbb2a7b3134b2394251546cc365dfc58c0e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765053 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
