GitLab

TBR=mcgrathr@chromium.org
BUG=106197
TEST=tsan bots go greener

Review URL: http://codereview.chromium.org/8776056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Run with no dump.json around.

Review URL: http://codereview.chromium.org/8770056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:104530
TEST=PyAuto tests

Review URL: http://codereview.chromium.org/8587004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112751 0039d316-1c4b-4281-b951-d872f2087c98

Remove code. We can add this back when we actually need it.

Review URL: http://codereview.chromium.org/8775038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106016
TEST=manual


Review URL: http://codereview.chromium.org/8772006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112749 0039d316-1c4b-4281-b951-d872f2087c98

This adds WEBKIT_GLUE_EXPORT, WEBKIT_PLUGINS_EXPORT, and WEBKIT_EXTENSIONS_EXPORT macros that are used by the files in
webkit/{glue,plugins,extensions} to show what needs to be exported from a DLL.

R=darin@chromium.org
BUG=98755
TEST=waterfall stays green.

Review URL: http://codereview.chromium.org/8741006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112748 0039d316-1c4b-4281-b951-d872f2087c98

ActiveLoader encapsulates an active WebURLLoader and takes care of maintaining deferred status, references to parent object, and automatic cancelation during teardown.

As a result of fixing the imbalanced reference counts to BufferedResourceLoader there were a few use-after-free bugs due to doing work after executing callbacks. The ordering has been updated to ensure that no more work is done after executing callbacks.

BUG=100914

Review URL: http://codereview.chromium.org/8667002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112747 0039d316-1c4b-4281-b951-d872f2087c98

Fast close to titlebar only -> pause on titlebar-only -> slow minimize.

Also, moved close button 1 px lower so it doesn't show up when panel is minimized.

BUG=104645

Review URL: http://codereview.chromium.org/8773030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105130
TEST=Open Task Manager. Enable Instant. Type a query into the omnibox. Observe that the Instant preview is listed as "Instant: ..." instead of "Tab: ...".


Review URL: http://codereview.chromium.org/8759009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112745 0039d316-1c4b-4281-b951-d872f2087c98

The pyauto-based perf tests output perf results in a special format, which
are extracted from stdout and stored for graphing purposes.  I encountered
a case where one of these specially-formatted perf output lines was broken
up by other, interleaved output, causing the perf value to be missed when
the output was parsed to search for perf values.  I believe that flushing
stdout immediately after printing each perf output line should fix this
problem.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8772022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112744 0039d316-1c4b-4281-b951-d872f2087c98

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Review URL: http://codereview.chromium.org/8637006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112743 0039d316-1c4b-4281-b951-d872f2087c98

Was causing confusion with code within the file calling the helper functions directly.

Also put back accidentally deleted line and re-enabled NoOverlapping test.

BUG=None
TEST=Panel*Test.*

Review URL: http://codereview.chromium.org/8772029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112742 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rtenneti@chromium.org
BUG=106196
TEST=greener tsan bots

Review URL: http://codereview.chromium.org/8769047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112741 0039d316-1c4b-4281-b951-d872f2087c98

This removes some manual registration code. It should also make FileRef private
work in process, it didn't look like it was being registered for in-process use
before.

Review URL: http://codereview.chromium.org/8772027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112740 0039d316-1c4b-4281-b951-d872f2087c98

- This CL makes media_unittests linked.
- The audio_track_output_stub_android.cc is in place of
  audio_track_output_android.cc because the Java environment is not
  avaliable yet.
- Also changed to dependence on '../third_party/ffmpeg/ffmpeg.gyp'
  only if os is not Android in media.gyp.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8718014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112739 0039d316-1c4b-4281-b951-d872f2087c98

Small changes to WGC3DInProcessImpl to pass the extension up to WebKit.

BUG=none
TEST=with https://bugs.webkit.org/show_bug.cgi?id=67341 and --use-gl=osmesa


Review URL: http://codereview.chromium.org/8772021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112738 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112735 0039d316-1c4b-4281-b951-d872f2087c98

Reason: performance regression on Linux LowMem PageCycler Intl1.
Original CL: http://codereview.chromium.org/8772038/


BUG=
TEST=


Review URL: http://codereview.chromium.org/8770049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112734 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure the user gets what the admin configured instead of the Welcome
pages, on first login.

BUG=chromium-os:23463
TEST=First login on an enterprise ChromeOS device (with a managed user of the same domain) won't show the Welcome pages when the admin has specified Startup URLs for the user.


Review URL: http://codereview.chromium.org/8713017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112733 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8776040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112732 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpolukhin@chromium.org
BUG=104535
TEST=mac vg bots go green

Review URL: http://codereview.chromium.org/8770052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8770050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112730 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vsevik@chromium.org
BUG=106183
TEST=WebKit layout valgrind bots greener

Review URL: http://codereview.chromium.org/8776052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21709
TEST=none


Review URL: http://codereview.chromium.org/8770045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112728 0039d316-1c4b-4281-b951-d872f2087c98

TBR=avi

Review URL: http://codereview.chromium.org/8772049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http:b/5609053
TEST=See unit tests for valid and invalid URLs.

Review URL: http://codereview.chromium.org/8728004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112726 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bashi@chromium.org
BUG=96568
TEST=greener vg bots

Review URL: http://codereview.chromium.org/8775056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112725 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=noelallen@google.com

TBR
Review URL: http://codereview.chromium.org/8772048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112724 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8682027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100131

Review URL: http://codereview.chromium.org/8590015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=aura_shell_unittests compiles with component=shared_library

Review URL: http://codereview.chromium.org/8776037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=43460
R=mirandac@chromium.org

Review URL: http://codereview.chromium.org/8775053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112720 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8704005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112719 0039d316-1c4b-4281-b951-d872f2087c98

I removed the return in a previous cleanup which allowed us to get data
on the fact that this is indeed reached in the wild.

R=mattm
BUG=105767
TEST=none

Review URL: http://codereview.chromium.org/8741019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112718 0039d316-1c4b-4281-b951-d872f2087c98

Identical to this CL http://codereview.chromium.org/8479042/
Fix base URL problem. All comments about the changes are in the above URL.

This CL makes certificate viewer for chromeos looks like the screen shot posted
in issue 102511. It hacks bubble_frame_view.cc to get rid of the body padding
and add a x button in the title area.

It should not affect the appearance of any other html dialogs.

BUG=102511
TEST=Go to https://www.google.com; Click the locker icon on the left side of URL in the omnibox and click "certificate information". For screenshots, see http://code.google.com/p/chromium/issues/detail?id=102511


Review URL: http://codereview.chromium.org/8461015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112717 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sadrul@chromium.org
BUG=106109
TEST=Linux vg bots go green

Review URL: http://codereview.chromium.org/8776050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112716 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib

Review URL: http://codereview.chromium.org/8773044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112715 0039d316-1c4b-4281-b951-d872f2087c98

for new users only when the oauth login token is successfully generated.
Make sure for existing logged in users, it continues to setup sync
properly on startup.
Review URL: http://codereview.chromium.org/8760019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112714 0039d316-1c4b-4281-b951-d872f2087c98

Read from the bottom to the top:
* Add new unit tests to cover what was removed before.
* Rename SignedSettingsTempStorage to SignedSettingsCache.
* Revitalize existing tests for SignedSettings[Helper].
* Add the needed infrastucture to support enrollment as well.
* Remove the second cache in OwnershipService it is obsolete.
* Remove the prop ops completely.
* Remove direct prop op from the proxy stuff.
* Serialize policy changes correctly and map side effects of policies.
    Mainly make sure we never serialize dirty policy.
    Don't reload if policy is serialized fine.
    Clear local state registration.
* Clean up redundand SS ops and make proper callbacks for the helper
    Move the temp storage finalization to where it belongs.
* Make the temp storage be the cache and use policy ops.
* Make DeviceSettingsProvider work with the protobuf blob directly.
* Merged DeviceSettingsProvider and UserCrosSettingsTrust.
* Rename UserCrosSettingsProvider to DeviceSettingsProvider.
* Extract the SignedSettingsMigrationHelper in its own file.

BUG=chromium-os:14054
TEST=unit_tests:SignedSettings*,*CrosSettings*,suite_Smoke:login_OwnershipApi

Review URL: http://codereview.chromium.org/8727037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112713 0039d316-1c4b-4281-b951-d872f2087c98

This broke because an incompatible change was made to Process, and because there was no test that would catch it. I've fixed the underlying problem for both Linux and ChromeOS and made it testable.

BUG=102726
TEST=Added new RenderProcessHostTest.Backgrounding

Review URL: http://codereview.chromium.org/8506036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112712 0039d316-1c4b-4281-b951-d872f2087c98