GitLab

Change-Id: Icc7d5bac5d15f3132f4ff257fefabf72cda4f677
Reviewed-on: https://chromium-review.googlesource.com/940139
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548022}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I57846f1fa7a86e58ed810363c63a723441b46cd0
Reviewed-on: https://chromium-review.googlesource.com/994932Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548021}

It's timing out in the wpt-importer runs and resulting in "Duplicate
or ambiguous entry lines":
https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15345

Also update the bug numbers.

No-Try: true
TBR: raphael.kubo.da.costa@intel.com
Bug: 828746
Change-Id: Iec0188a4e5ae45a65c7df7fe1de6be627ddd4684
Reviewed-on: https://chromium-review.googlesource.com/995432Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548020}

- Replacing NDEBUG => DCHECK_IS_ON
- Validating match before adding it as a shortcut.

Change-Id: Iaa29faa7cc37c8cf75d833ce8c166c2122d6da55
Reviewed-on: https://chromium-review.googlesource.com/986054
Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548019}

This is a mere cleanup.

Bug: 721400
Change-Id: I85c5cced89001c5e03020089fc1babb397e19682
Reviewed-on: https://chromium-review.googlesource.com/994914Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548018}

This patch supports all the animation/transition properties except
animation-name and transition-property (need spec feedback first).
We also fix the <time> tests so that computed time values use canonical
units as spec'd in [1].

[1] https://github.com/w3c/css-houdini-drafts/issues/725

Bug: 820299
Change-Id: I7c038ce419f8bdb1c789493554776c5e7f9810c7
Reviewed-on: https://chromium-review.googlesource.com/983094
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548017}

Correct V4L2VEA to execute flush callback by GPU main child thread.

BUG=b:71882314
TEST=video_encode_accelerator_unittest

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If6eb0c8f87dcd59a0006c811514f230e8a023f0e
Reviewed-on: https://chromium-review.googlesource.com/989873Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548016}

https://pdfium.googlesource.com/pdfium.git/+log/4c22dd5690cd..28bb2f2ffe75

$ git log 4c22dd569..28bb2f2ff --date=short --no-merges --format='%ad %ae %s'
2018-04-03 dsinclair Remove DefaultAppearance HasColor and return an optional instead

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I946971c1ecf91bddd9b48aac68daf4262f423bfb
Reviewed-on: https://chromium-review.googlesource.com/994239Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548015}

The default audio controls for <audio> tag gets bigger recently.
To fit the control, the region for audio control in quick view needs to be
bigger.
This is a quick fix to fix the regression.
The quick view should handle any size of audio control. It should be fixed by a
separated CL.

Bug: 826860
Test: Manually tested by mp3 files with and without cover arts.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib6cae6bc514d05090b65e076fcc276c8a3aabbca
Reviewed-on: https://chromium-review.googlesource.com/984914Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548014}

Instead of using the default zoom level, we can set fit-to-zoom mode by default
to resize the preview automatically when Files app window is resized.

Bug: 809314
Test: Manually tested
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6e8d2113c9bbbd65071de2191f4be37b62ef6fd0
Reviewed-on: https://chromium-review.googlesource.com/984912Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548013}

In certain (extreme) jumbo build configurations, SendReport in
chrome/browser/net/chrome_report_sender.h and
chrome/browser/net/trial_comparison_cert_verifier.cc ended up as
symbols in the same translation unit and then the address
operator didn't know which function to refer to in a Bind(...) call.

This renames the local SendReport in
net/trial_comparison_cert_verifier.cc to SendCertVerifyReport.

Change-Id: I9cc17beb509452f66f5620cf7ea4ca4f1f04ed33
Reviewed-on: https://chromium-review.googlesource.com/992495
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548012}

This patch changes "4580583-{1,2}.html" to utilize |selection_test()| and
integrate into "4580583-1.html", since both tests use similar test input, for
ease of maintenance.

Following patch will rename "4580583-1.html" to
"insert_newline_in_quoted_content.html".

Note: "4580583-{1,2}.html" is failed on layout_ng bot due by pixel test.

Bug: 679977, 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie2eff78bee11cbc09f2bbdfa1f915b6cf662fe55
Reviewed-on: https://chromium-review.googlesource.com/991695
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548011}

Some public headers, like umbrella headers for frameworks, are generated
and so we need a direct dependency path between the copy public headers
target and the target that generates the header.

Change-Id: I14b73804498065c8049a4cea24453b89b759d94c
Reviewed-on: https://chromium-review.googlesource.com/992868
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548010}

This reverts commit a5442982.

Reason for revert: 
Causes browser_tests failing on chromium.chromiumos/linux-chromeos-dbg

failures:
CrSettingsAndroidAppsPageTest.All
CrSettingsFingerprintListTest.All

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-dbg%2F5028%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrSettingsAndroidAppsPageTest.All%2F0
AssertionError: expected undefined to be false
    at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31)
    at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:862:17)
    at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/android_apps_page_test.js:125:7)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[1113:1113:0403/172824.531829:ERROR:web_ui_test_handler.cc(82)] Test Errors: 1/9 tests had failed assertions.
[1113:1113:0403/172824.531924:ERROR:web_ui_browser_test.cc(475)] CONDITION FAILURE: encountered javascript console error(s):
[1113:1113:0403/172824.531950:ERROR:web_ui_browser_test.cc(477)] JS ERROR: '[1113:1113:0403/172824.017897:ERROR:CONSOLE(48)] "Mocha test failed: AndroidAppsPageTests SubPage Disable
AssertionError: expected undefined to be false
    at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31)
    at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:862:17)
    at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/android_apps_page_test.js:125:7)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
'
[1113:1113:0403/172824.531980:ERROR:web_ui_browser_test.cc(479)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc:2866: Failure
Value of: RunJavascriptTestF( true, "CrSettingsAndroidAppsPageTest", "All")
  Actual: false
Expected: true


Original change's description:
> WebUI Polymer 2 migration: Convert <dialog is=cr-dialog> to a <dialog> wrapper.
> 
> Polymer2 does not support HTML element extensions, so all such elements need to
> be converted to wrappers.
> 
>  - Introduced a new --cr-dialog-native CSS mixin, such that users of <cr-dialog>
>    can still style the inner native <dialog>. Before, this was not necessary,
>    since <cr-dialog> itself was a <dialog>, and not a wrapper. Update all such
>    cases to use the mixin.
>  - Introduced a public getNative() method to expose the internal <dialog>, which
>    is necessary in a few cases (both tests and prod).
>  - Mirrored <dialog>'s |open| attribute such  that it updates synchronously as soon
>    a dialog is opened or closed. This matches the internal <dialog>'s behavior.
>  - Updated tests as necessary (and did a significant amount of manual sanity
>    checking).
> 
> Bug: 818279
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I4fb35237d3ea3fa3dbb8ef4602036a4783f1e896
> Reviewed-on: https://chromium-review.googlesource.com/976394
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547860}

TBR=stevenjb@chromium.org,dpapad@chromium.org,rbpotter@chromium.org,scottchen@chromium.org

Change-Id: If9454d64d28b600267dc8fa4a18151dce71fe722
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 818279
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/994439Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#548009}

This aligns behavior more closely FireFox, though less closely
with Edge and Safari.  See RFC at https://mimesniff.spec.whatwg.org/
(This behavior is also more consistent with
https://tools.ietf.org/html/rfc7231#section-3.1.1.1)

In particular, no longer split the string around semi-colons first,
but instead parse character-by-character (Which only really affects
weird things like charset=";"), and use backslash as an escape
character in quoted string values.  This affects both charset and
boundary parameters, so we should keep an eye out for bug reports
about either of those breaking in corner cases.

This also applies the quoted string parsing logic to Content-Type
boundary parameters (It was just used for charsets before) - this is
unlikely to break anything, since the one consumer of that field
arbitrarily removes all leading/trailing spaces and quotes from
boundary strings.

Bug: 774429
Change-Id: I28c9c035e1c1c28e181bd0e8005266cfd63af7e9
Reviewed-on: https://chromium-review.googlesource.com/990995
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548008}

Updating quic_flags_list.h.

https://chromium-review.googlesource.com/c/994475/


Remove the references to 'wangyix' in TODO comments.

Merge internal change: 191313627

https://chromium-review.googlesource.com/c/994474/


In QUIC, add fast path to QuicStreamSequencerBuffer::OnStreamData.
Protected by FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data.

Merge internal change: 191296630

https://chromium-review.googlesource.com/c/994095/


In QUIC, rewrite OnAckRange to avoid costly operation of IntervalSet.
Protected by
FLAGS_quic_reloadable_flag_quic_use_incremental_ack_processing3 which
replaces gfe2_reloadable_flag_quic_use_incremental_ack_processing2.

Merge internal change: 191294985

https://chromium-review.googlesource.com/c/994473/


Change a DLOG(INFO) to a DVLOG(1) in SimpleSessionNotifier because it's
very verbose in BBR tests.

n/a (DLOG change)

Merge internal change: 191293210

https://chromium-review.googlesource.com/c/994395/


Remove the reference to 'jri' in a TODO comment.
Merge internal change: 191292402

https://chromium-review.googlesource.com/c/994094/


Change QuicFramer::ProcessIetfStreamFrame to use the ReadVarIntStreamId
convenience method and remove unused Append methods.

n/a (Unreachable code from the GFE)

Merge internal change: 191289478

https://chromium-review.googlesource.com/c/994472/


Move a test function, WaitForDelayedAcks, from quic/core/end_to_end_test
to quic/test_tools/quic_test_client.

n/a (test only change)

Merge internal change: 191117918

https://chromium-review.googlesource.com/c/994093/



[quartc-tracegraf] Support tracegraf logging in //gfe/quic/quartc.

The QuartcSession now allows setting a QuartcSessionVisitor, which is an
interface for injecting a QuicConnectionDebugVisitor into QuartcSession.  This
interface is necessary because QuartcSessionInterface does not expose the
underlying QuicConnection and some debug visitors cannot be constructed without
a pointer to the QuicConnection.  This is the case with the base class for the
tracegraf visitor.

There's one implementation of the QuartcSessionVisitor for now:  a visitor for
tracegraf logging.  It's built on gfe's QuicTracegrafVisitor.

This visitor is not portable, so it must be kept in a separate target from
//gfe/quic/quartc:quartc and cannot be compiled into Quartc production code.

QuartcConnection provides a method for setting a session visitor at runtime.
Quartc tests (which are mostly non-portable anyway) can build the tracegraf
visitor and set it on their connections.

The AudioQualityTest now has a flag to enable tracegraf logging.  When set, the
AudioQualityTest will create tracegraf visitors for each end of the connection.

n/a (Quartc changes only)

Merge internal change: 191106735

https://chromium-review.googlesource.com/c/993425/


Add last_packet_is_ietf_quic_ to QuicFramer. Pluming boolean indicating whether it is IETF QUIC to places which ends up sending version negotiation and public reset.

n/a (Add unused variable)

Merge internal change: 191102650

https://chromium-review.googlesource.com/c/993497/


Change 2 instances of implicit_cast to static_cast in net/tools/quic/quic_spdy_client_session_test.cc

Merge internal change: 191095094

https://chromium-review.googlesource.com/c/993424/


Deprecate FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2.

Merge internal change: 190985264

https://chromium-review.googlesource.com/c/993421/


In QUIC, when stream data gets acked, compare acked offset with the largest acked byte to determine whether it is disjoint before calling IntervalSet::IsDisjoint. Protected by FLAGS_quic_reloadable_flag_quic_fast_is_disjoint.

Merge internal change: 190934114

https://chromium-review.googlesource.com/c/993419/


Change QuicConnection::OnConnectionMigration to virtual.
Change QuicConnection::StartEffectivePeerMigration to non-virtual.

Merge internal change: 190804126

https://chromium-review.googlesource.com/c/993655/


For QUIC server proxy support, split QuicConnection.peer_address_ into QuicConnection.direct_peer_address_ and  QuicConnection.effective_peer_address_. Protected by FLAGS_quic_reloadable_flag_quic_enable_server_proxy.

QuicConnection.direct_peer_address_ stores the address of a connection's direct peer. It is only used as the destination address when sending packet. Not used for connection migration.

QuicConnection.effective_peer_address_ stores the address of a connection's "effective peer", for non-proxied connections, it is the same as the direct peer; for proxied connections they can be different(this is a flag protected new behavior). Both types of connections use this address for connection migration.

Once the CL is rolled out and flag deprecated, we can consider rename direct_peer_address_ back to peer_address_.

Merge internal change: 190683072

https://chromium-review.googlesource.com/c/993495/


Move flag count for FLAGS_quic_reloadable_flag_quic_free_mem_slice_out_of_order and gfe2_reloadable_flag_quic_fast_path_on_stream_data_acked to better positions.

n/a (flag verification)

Merge internal change: 190646949

https://chromium-review.googlesource.com/c/993416/


Add comment for QuicSmallMap about pointer stability.

Merge internal change: 190640241

https://chromium-review.googlesource.com/c/993652/


Remove dead code in
net/quic/test_tools/simple_session_notifier(.h|.cc|_test.cc)

Merge internal change: 190540542

https://chromium-review.googlesource.com/c/993415/


Deflake simulator competition test.

Merge internal change: 190508569

https://chromium-review.googlesource.com/c/993413/


Remove dead function 'GenerateQuicHttpHeaderName' from
net/quic/http/tools/quic_http_random_util.(h|cc).

Merge internal change: 190489246

https://chromium-review.googlesource.com/c/993492/

R=rch@chromium.org

Change-Id: I80f893d85572415c2244a5c320bbca2613afa4b8
Reviewed-on: https://chromium-review.googlesource.com/994513
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548007}

These are hitting a NOTREACHED() and blocking WPT imports after
https://github.com/w3c/web-platform-tests/pull/9373 landed upstream.

TBR=foolip

Bug: 828748
Change-Id: I72ec5dbe80bd9f5e893a56380acd99aa62a91da0
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/995094Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#548006}

tools/cygprofile (and its dependencies, among them //base) are built
without instrumentation, as the previous version of it was calling
//base functions, and to avoid infinite recursion. This is no longer
necessary.
Removing this has two benefits:
- More code is instrumented (as some parts of //base were off-limits)
- Simpler build files.

Also:
- Explain why //tools/cygprofile is a dependency of
  //tools/android/md5sum
- Instrument libwebp, and remove the opt-out of instrumentation

TBR=digit

Bug: 758566
Change-Id: I62cad01d216adbab759c62c42d2baa08f7a8a0b1
Reviewed-on: https://chromium-review.googlesource.com/985973
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#548005}

Following CL:993112, these 4 tests are also affected by the
line-height quirks bug.
  fast/block/float/float-in-float-hit-testing.html
  fast/block/float/float-in-float-painting.html
  fast/css/color-correction-on-backgrounds.html
  http/tests/local/file-url-sent-as-referer.html

2 of them require rebaseline, because of the layout change in
other parts.

Bug: 828457
Change-Id: Ifab5b4d096277fc48c04bdff21318fd86405cec8
Reviewed-on: https://chromium-review.googlesource.com/992972Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548004}

This reverts commit de013df9.

Reason for revert: 
Suspect causing the following failure on Linux ChromiumOS MSan Tests:
CrashRestoreComplexTest.RestoreSessionForThreeUsers:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6545%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrashRestoreComplexTest.RestoreSessionForThreeUsers%2F0

  Uninitialized value was created by a heap allocation
    #0 0xa37813 in __interceptor_posix_memalign /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:165:3
    #1 0x1276df0f in base::AlignedAlloc(unsigned long, unsigned long) ./../../base/memory/aligned_memory.cc:31:7
    #2 0xaab5970 in Message ./../../mojo/edk/system/channel.cc:120:7
    #3 0xaab5970 in mojo::edk::Channel::Message::Message(unsigned long, unsigned long, unsigned long) ./../../mojo/edk/system/channel.cc:74:0
    #4 0xaaf24f0 in make_unique<mojo::edk::Channel::Message, unsigned long &, const unsigned long &, unsigned long &> ./../../buildtools/third_party/libc++/trunk/include/memory:3079:32
    #5 0xaaf24f0 in CreateMessage<void> ./../../mojo/edk/system/node_channel.cc:140:0
    #6 0xaaf24f0 in mojo::edk::NodeChannel::CreateEventMessage(unsigned long, unsigned long, void**, unsigned long) ./../../mojo/edk/system/node_channel.cc:182:0
    #7 0xab389d6 in mojo::edk::(anonymous namespace)::CreateOrExtendSerializedEventMessage(mojo::edk::ports::UserMessageEvent*, unsigned long, unsigned long, mojo::edk::Dispatcher::DispatcherInTransit const*, unsigned long, std::__1::unique_ptr<mojo::edk::Channel::Message, std::__1::default_delete<mojo::edk::Channel::Message> >*, void**, unsigned long*, void**) ./../../mojo/edk/system/user_message_impl.cc:144:33
    #8 0xab3bafd in mojo::edk::UserMessageImpl::AppendData(unsigned int, unsigned int const*, unsigned int) ./../../mojo/edk/system/user_message_impl.cc:465:21
    #9 0xaac2f8c in mojo::edk::Core::AppendMessageData(unsigned long, unsigned int, unsigned int const*, unsigned int, MojoAppendMessageDataOptions const*, void**, unsigned int*) ./../../mojo/edk/system/core.cc:545:16
    #10 0xaaaceb6 in MojoAppendMessageDataImpl ./../../mojo/edk/embedder/entrypoints.cc:96:18
    #11 0x176afb6a in CreateSerializedMessageObject ./../../mojo/public/cpp/bindings/lib/message.cc:93:8
    #12 0x176afb6a in mojo::Message::Message(unsigned int, unsigned int, unsigned long, unsigned long, std::__1::vector<mojo::ScopedHandleBase<mojo::Handle>, std::__1::allocator<mojo::ScopedHandleBase<mojo::Handle> > >*) ./../../mojo/public/cpp/bindings/lib/message.cc:198:0
    #13 0xe293231 in ash::mojom::AppListControllerProxy::ResolveOemFolderPosition(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, syncer::Ordinal<syncer::StringOrdinalTraits> const&, base::OnceCallback<void (mojo::StructPtr<ash::mojom::AppListItemMetadata>)>) ./gen/ash/public/interfaces/app_list.mojom.cc:1004:17
    #14 0x21340e32 in ChromeAppListModelUpdater::ResolveOemFolderPosition(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, syncer::Ordinal<syncer::StringOrdinalTraits> const&, base::OnceCallback<void (ChromeAppListItem*)>) ./../../chrome/browser/ui/app_list/chrome_app_list_model_updater.cc:372:25
    #15 0x21318489 in app_list::AppListSyncableService::ResolveFolderPositions() ./../../chrome/browser/ui/app_list/app_list_syncable_service.cc:701:21
    #16 0x21315b92 in app_list::AppListSyncableService::HandleUpdateFinished() ./../../chrome/browser/ui/app_list/app_list_syncable_service.cc:459:3
    #17 0x21311a0d in app_list::AppListSyncableService::BuildModel() ./../../chrome/browser/ui/app_list/app_list_syncable_service.cc:412:3
    #18 0x126f6624 in Run ./../../base/callback.h:95:12

Original change's description:
> Reland "app_list: merge AppListViewDelegate into AppListClientImpl in Chrome."
> 
> This is a reland of db8976b8
> 
> Original change's description:
> > app_list: merge AppListViewDelegate into AppListClientImpl in Chrome.
> >
> > This commit does a few things:
> >
> > - merges the Chrome AppListViewDelegate into AppListClientImpl;
> > - cleans up unused references;
> > - updates methods to proper accesses.
> >
> > Ownership of major classes:
> >
> > - Each user has its own AppListSyncableService, and it holds its own
> >   AppListModelUpdater, ModelBuilders, etc.
> > - There's only one AppListClientImpl in ChromeBrowserMainExtraPartsAsh
> >   shared by all users, and it holds Search classes, a mojo pointer to
> >   the AppListControllerImpl in Ash, etc.
> > - There's only one singleton AppListServiceImpl shared by all users,
> and
> >   it holds AppListControllerDelegateImpl.
> >
> > Their lifecycles:
> >
> > - Among these classes, AppListClientImpl is the first to be initiated,
> in
> >   PreProfileInit. It binds to AppListController in Ash, and then tells
> >   AppListServiceImpl two pointers (AppListController*,
> AppListClientImpl*).
> > - When AppListServiceImpl receives the two pointers, it should have
> been
> >   initiated as a singleton.
> > - The AppListClientImpl is associated with the current active user
> profile
> >   when it's accessed from AppListServiceImpl.
> >
> > Bug: 733662
> > Change-Id: Iac6de011185bf88c4b3c575871b69bd7a67c340b
> > Reviewed-on: https://chromium-review.googlesource.com/974660
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Commit-Queue: Jiaquan He <hejq@google.com>
> > Cr-Commit-Position: refs/heads/master@{#546247}
> 
> Bug: 733662
> Change-Id: Ia779e0ec795a9457dc7214f38b528c2dab688b90
> Reviewed-on: https://chromium-review.googlesource.com/991232
> Commit-Queue: Jiaquan He <hejq@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547956}

TBR=xiyuan@chromium.org,hejq@google.com

Change-Id: Iccc96b53a54fbc46ca02af619c9746079d1ba7f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 733662
Reviewed-on: https://chromium-review.googlesource.com/994438Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#548003}

Virtual keyboard's extension may call this function when controller has
been destroyed(when system switch from virtual keyboard to physical
keyboard) or in full width mode, no need to throw exception in these
cases.

Bug: 825709
Change-Id: I8e565f7b090f619d08814af55450ad0f437486cd
Reviewed-on: https://chromium-review.googlesource.com/994497Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Li Zhao <iloahz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548002}

When I set up the bot I imagined it was a "buildbot" bot, but AFAIK
it will work fine in LUCI as well. Or actually, I have no idea, but
it appears the chromium.linux buildbot waterfall has gone away.

If there's no change needed on the recipe side, this should be
enough to fix it.

Bug: chromium:776284
Change-Id: I3cff6f866a241db1f4a60446480f6f7c40e95ef7
Reviewed-on: https://chromium-review.googlesource.com/991853Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548001}

NavigationPreload is enabled by default[1] and the function is no longer used.

[1] https://www.chromestatus.com/feature/5734842339688448

Bug: 661071
Change-Id: I36955d9458743dc38fda0c31f6900c728b772f94
Reviewed-on: https://chromium-review.googlesource.com/989522Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548000}

Moving the floating keyboard on a secondary monitor did not work well.
The keyboard movement would be bounded to certain nonsensical ranges
that would correspond to the primary display.

Bug: 828701
Change-Id: Ic910ee48d4cfa17b37334b7d9c719090da502414
Reviewed-on: https://chromium-review.googlesource.com/994632
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547999}

Enables heap verification when running in the incremental marking configuration.

No-try: true
Bug: chromium:757440
Change-Id: I4bc75ac0779021e34d0e637192157695567e825c
Reviewed-on: https://chromium-review.googlesource.com/993056
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547998}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I2ab4e22c26cf710fbc22adeb951c1eb12440f354
Reviewed-on: https://chromium-review.googlesource.com/975281Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547997}

The code guide doesn't allow "using namespace", and they have
a tendency to cause problems with jumbo builds so this is just
a cleanup to avoid possible future problems.

Change-Id: I058ed20ba072036b1995cf039ddb3c2ffc884483
Reviewed-on: https://chromium-review.googlesource.com/992952Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#547996}

This is based on:
https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/66463
https://webrtc.googlesource.com/src/+/1d7392a45c95794b385f6a7c3a9dfa5428c4bbed

Bug: webrtc:7602

Change-Id: Id7f0cdb64cc98cc7c561e6cc99ddbb33db58ab92
Reviewed-on: https://chromium-review.googlesource.com/992320Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547995}

This creates problems when running on a case sensitive file system.

When the path of a checkout contains uppercase characters, the
following command fails:

$ gn gen out/win64 --args='target_os="win" target_cpu="x64"'
ERROR at //build/config/win/BUILD.gn:338:27: Script returned non-zero exit code.
vcvars_toolchain_data = exec_script("../../toolchain/win/setup_toolchain.py",
.... src/build/toolchain/win/setup_toolchain.py", line 240, in main
  assert vc_bin_dir
AssertionError

Bug: None
Change-Id: If4c792e9d04d56987a87a55e824d764a1c4e62ed
Reviewed-on: https://chromium-review.googlesource.com/985835Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547994}

The original cl was here:
https://chromium-review.googlesource.com/c/chromium/src/+/990092
This CL fixes the following problems with the original CL:
1. The apk_merger script fails because the unwind tables were only added
   in 32-bit apk. The merger script expects all the files to be same and
   the ones different should be checked.
 1a. The resources.arsc is non-hermetic and ordering is affected by
     adding file to only one apk. As a workaround for crbug/828528,
     add an empty (valid) unwind table file to the 64 bit monochrome
     apk to make the resource.arsc consistent.
 1b. The merger script simply adds all the files in apk which are not
     same. To keep the script simple and functional, the unwind resource
     is renamed to unwind_cfi_32 and unwind_cfi_empty in respective
     builds and the app_merger is updated to specify this file is
     expected to be different and included. This causes an extra file
     (4 byte) in the merged apk.

2. The unwind tables were always generated for "libchrome.so" for all
   chrome apks. The different chrome_apk(s) have different shared
   libraries like libchromefortest, etc.. So, update the unwind asset to
   get unwind table for the right library for each apk. Only adds assets
   to *_public_apk(s).

3. The monochrome_apk_checker was failing because the unwind file
   included was different in chrome_apk and monochrome_apk. This CL adds
   the asset to all apk at the same time and adds exception for this
   file.

BUG=819888
TBR=dpranke@chromium.org

Change-Id: Ibceeeacc19fa424d519891b8c17e349ee6c2dfd6
Reviewed-on: https://chromium-review.googlesource.com/991236
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547993}

This patch removes flag-specific expectation files that are
the same as the on in parent chains (platform/linux, platform/win,
or generic.)

This can happen when once rebaselined, but the actual images get
back to the original and rebaseline again, or rebaseline occurred
in parent after flag-specific rebaselines.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I30b71082585604a68ca082b56a3a2c66ac50ffe6
Reviewed-on: https://chromium-review.googlesource.com/994436
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547992}

According to the spec [1], shorthands with pending-substitution values
should be serialized as empty strings. Only shorthands which were
specified with explicit var() references should be serialized to the
original value. Update our implementation to match this.

[1]: https://drafts.csswg.org/css-variables/#variables-in-shorthands

Bug: 687653
Change-Id: Icb3acdcc88452a32077fe7f67ecc6c3614b4d91c
Reviewed-on: https://chromium-review.googlesource.com/994734Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547991}

This patch adds an interface for updating the Crostini App Registry
over D-Bus at org.chromium.VmApplicationsService:UpdateApplicationList.

The proto is being added in:
https://chromium-review.googlesource.com/q/I05b05f03

Bug: 821662
Change-Id: I7effada1c0de237ef3ec49da84d5c1f76415781e
Reviewed-on: https://chromium-review.googlesource.com/965803
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547990}

This patch changes "remove-list-from-range-selection.html" to utilize
|selection_test()| for ease of maintenance.

Note: "remove-list-from-range-selection.html" is failed on layout_ng bot
du by pixel test.

Bug: 679977, 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1c3257701ae53ceacbb651ca544925d982a30e5d
Reviewed-on: https://chromium-review.googlesource.com/991625
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547989}

This reverts commit 605ee933.

Reason for revert: The overall approach is hacky and has introduced too many regressions.

Original change's description:
> Change TranslateHelper to use a textContent-like text dump
> 
> Currently, TranslateHelper caputres page innerText to decide the
> page language. The text capturing is done in
> RenderFrame::DidMeaningfulLayout(), in which we normally have the
> clean layout, which is necessary for computing innerText.
> 
> However, due to some layout bug [1], we don't always have clean
> layout at the call site. As fixing the layout bug is hard, this
> patch changes the text capture algorithm to return a string similar
> to textContent [2] instead, which doesn't require clean layout.
> 
> The difference between the new and old text capture is subtle:
> 
> - textContent may include invisible text nodes, while innerText never
>   does that. However, this patch uses a slightly modified textContent
>   that doesn't include text nodes in STYLE or SCRIPT elements.
>   Other invisible text may still be included.
> 
> - textContent is a simple concatenation of all text nodes. innerText
>   does some "formatting" by inserting/deleting some whitespace
>   characters, including:
>   - Insertion of '\n' between blocks of text (e.g., between <div>)
>   - Insertion of '\t' between table cells
>   - This patch uses a custom dump algorithm that still collapses
>     consecutive whitespaces; however, the collapsing happens regardless
>     of style
> 
> [1] crbug.com/803403 and crbug.com/585164. The crash happens in the
>     wild, but we haven't even found a stable repro case yet.
> 
> Bug: 803403
> Change-Id: I7e108d368cbcaccbbb60582323a9e9e041d95269
> Reviewed-on: https://chromium-review.googlesource.com/891582
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Rachel Blum <groby@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536969}

TBR=toyoshim@chromium.org,groby@chromium.org,tkent@chromium.org,xiaochengh@chromium.org,napper@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 803403
Change-Id: I15189591a99f40ad105f32ccc75de8bd008aa998
Reviewed-on: https://chromium-review.googlesource.com/994712Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547988}

Existing code performs bidi adjustment for 'unicode-bidi: plaintext' only
for the right edge of InlineBoxes. This patch makes it handle both edges
to allow caret to appear at the left edge.

This patch also makes the bidi adjustment code symmetric for left and
right edge handling, so that we can de-duplicate in future refactoring.

Bug: 828657, 771398
Change-Id: I3fd22280327c7186fcfddfb0ba1bb13c4a5dfeff
Reviewed-on: https://chromium-review.googlesource.com/994389Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547987}

This value is logged when the user quits the app during in-progress
downloads.

Bug: 981327
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If19c9e16045ab0af2af1a77a941df843cc6fdeb8
Reviewed-on: https://chromium-review.googlesource.com/987200
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547986}

A new method is added to the Aura shell interface. When client call this
method, the startup ID is set as a property on the Aura window.
This is going to be used to identify a specific virtual machine
applications that a window is for.

TEST: still compile.
Bug: 828147
Change-Id: If86547f4a58ca7793887acfdbb7f6eb0036bf761
Reviewed-on: https://chromium-review.googlesource.com/990791Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547985}

Change ChromeDriver build bot setting for Windows, to generate
full symbols.

Change-Id: I31ea9abd5ff619f12f15da8ef46ad01590f162a3
Reviewed-on: https://chromium-review.googlesource.com/994735Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547984}

This CL imposes a limit on the maximum number of page patterns an extension can
whitelist using the chrome.declarativeNetRequest.addWhitelistedPages API. This
limit is currently set to 100. A new property MAX_NUMBER_OF_WHITELISTED_PAGES is
introduced in the declarativeNetRequest API for the same.

It is important to limit this since the whitelisted patterns are stored in the
browser memory (and also persisted across sessions using Extension preferences).

BUG=811460, 696822
Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing

Change-Id: I674da154107ac06269827272576f1af911f13338
Reviewed-on: https://chromium-review.googlesource.com/987392
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547983}