GitLab

Bug: 888668
Change-Id: I2ca249628b9395480f5dfcaaf2b300046dba9b2c
Reviewed-on: https://chromium-review.googlesource.com/c/1243503Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596315}

Bug: 888668
Change-Id: Iddc72d0638ddebbab044f070237d6bd885c557aa
Reviewed-on: https://chromium-review.googlesource.com/c/1243523Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596314}

This CL converts AudioFocusManager to use mojo MediaSessions and
converts the required methods. We also add a mojo
MediaSessionObserver to keep track of MediaSession state.

This changes the AudioFocusManager logic slightly so we recieve
a request ID when we get focus. This is used to identify the
MediaSession in the future when we want to abandon or request
a different audio focus type.

Adds GetMediaSessionInfo which gets session state in a struct
to avoid needing multiple calls over Mojo. Makes GetDebugInfo
public which is needed by Mojo media session implementations.

The next step will be to move AudioFocusManager to the media
session service.

BUG=875004

Change-Id: Ideb7c761c647bb057ab988f0af9bf867688df3fe
Reviewed-on: https://chromium-review.googlesource.com/c/1187707Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596313}

      establish for the test app.

Bug: 889151
Test: Deployed to guado device and verified that a connection can be
Change-Id: I2704c373b30efb49b2932f30f24939c7f9dbb7b2
Reviewed-on: https://chromium-review.googlesource.com/c/1220728
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596312}

The cronet_package target packages cronet library, headers and license into $root_out_dir/cronet.
Disable histogram manager on Mac and Win platforms to reduce binary size.

Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I3f5ac065e405734260926ea774b9fa08efa4d060
Reviewed-on: https://chromium-review.googlesource.com/c/1255802
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596311}

Specifics:
        +6,604 bytes normalized apk size
            +1 zip entries file count
        +5,308 bytes main dex size
InstallSize:
        +1,296 bytes APK size
    +22,740.32 bytes Estimated installed size
InstallBreakdown (+24,585.32 bytes):
          +268 bytes Non-compiled Android resources size
          +173 bytes Package metadata size
    +23,436.32 bytes Java code size
          +708 bytes Compiled Android resources size
Dex:
           +23 entries fields
           +33 entries methods
            +3 entries types
            +9 entries strings

Change-Id: I9dcf0da1a60a2d50925a68bc0b5345245b64059d
Reviewed-on: https://chromium-review.googlesource.com/c/1257654
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596310}

This is a preventative fix for the case where the pacing bucket has
a zero rate.  We may want to continue investigating why the bucket
has a zero rate though (that can be a follow-up CL though).

This was a tricky one to track down as the crashes from the last 2
releases had optimized stacks which obfuscated the exact LOC which
was causing the divide by zero.  I looked back to our earlier
releases and found that this crash was occuring back then (lower
hit rate due to fewer connections using WebRTC back then) with the
same base stack but pointing to the LOC I am addressing in this CL.

Bug: 891725
Change-Id: Ic42e910614d35c683959b8c6e4417b0197a63818
Reviewed-on: https://chromium-review.googlesource.com/c/1258823Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596309}

This change adds a fudge factor of ~1px to the logic which determines
whether to reshow the disconnect window after it has been hidden.
I suspect the reports of the window being reshown are due to small
accumulations for the cursor position or potentially just raw input
events where the cursor does not change.  We want to avoid reshowing
the dialog in cases such as this because it is quite annoying for the
remote user.

Bug: 891584

Ignore mouse messages if the position or button states don't change

We've received reports that the disconnect window is appearing at
odd times after the auto-hide timeout has taken effect.  I suspect
there could be hardware which is emitting spurious HID events which
is triggering the reshow logic.  My assumption is that this behavior
is't egregious, otherwise the user would notice the mouse cursor
moving or errant keypresses.  Thus I want to prevent triggering the
reshow logic if we receive a RAWINPUT event where the cursor has not
moved and no button states have changed.

Change-Id: I310f2cb4a5f30b0b7e14bf7221d250030492add8
Reviewed-on: https://chromium-review.googlesource.com/c/1258979
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596308}

For Hangout sinks in the AVAILABLE state, show its domain as the status
text in the sink list.
Screenshot:
https://drive.google.com/open?id=1pOk8gsxW5MH8sUFJeg1WMLFanMtclPKv

Bug: 891087
Change-Id: I7faf94e4d89a03da8487264aae2aa73e95debb7c
Reviewed-on: https://chromium-review.googlesource.com/1258245
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596307}

The sampler used to always record the very first allocation on each thread
because the accumulator is initialized with zero. The patch makes such
allocations be treates as all the others.

BUG=803276

Change-Id: I3eeec1e069ecc640e6c9756f707dfc336d16e159
Reviewed-on: https://chromium-review.googlesource.com/1257597
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596306}

This CL fixes the color of the Download icon in the three-dots menu. The
appearance of this icon was broken by https://crrev.com/c/1245786.
Apparently, a color filter set on drawable by AppMenuPropertiesDelegate
overrides ImageView.setImageTintList used by ImageViewCompat on API 21+.
Fortunately, there's no need to manually tint the drawable, because
AppCompatImageButton for the Download icon is always tinted. This CL
removes the manual tinting of the drawable.

Bug: 891645
Change-Id: I9eb9f326445e044a77fa8802b6816e5bc16e0993
Reviewed-on: https://chromium-review.googlesource.com/1258987Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596305}

Cc requires that a rectangular clip is 2d-axis-aligned with the render
surface to correctly apply the clip. When we find that a rectangular
clip is not 2d-axis-aligned with the render surface, we should create
an effect node and let it create a render surface.

Bug: 890919
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6f7b462d5506949d1571c60231e066d27b9a238d
Reviewed-on: https://chromium-review.googlesource.com/1244104Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596304}

This patch adds a check for tablet in the logic that decides whether
a light or dark title is used.

Bug: 891666
Change-Id: I6f05aa06ef01cd67a1f58a12e6f7436debe74e6b
Reviewed-on: https://chromium-review.googlesource.com/1259285Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596303}

Adding/modifying tests to cover some newly tweaked behaviors and a
recent regression:
(1) Destinations dialog correctly does not close if escape is pressed
while in the search box if there is any text, but does close if there
is no text.
(2) Copies setting correctly stays valid for an empty input, and the
input is reset to the default value if blurred. However, if an invalid
value is explictly entered, the setting does not stay valid or reset
to the default value when cleared.
(3) Number settings sections correctly block 'E' and '+' key events.

(2) is broken into 2 separate tests. The new interactive test for
number-settings-section validates the reset/no reset on blur behavior.
The additions to the SetCopies test verify that the setting value is
correctly set/not set for the various cases.

Bug: None
Change-Id: If7e3461c525c9cf057ac9404d5bf5da5da03e9f2
Reviewed-on: https://chromium-review.googlesource.com/1252339
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596302}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/457799c2a3af..5cc52fbcc765


Created with:
  gclient setdep -r src-internal@5cc52fbcc765

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:891734
TBR=mmoss@chromium.org

Change-Id: I2531849fbfae321612a79fb6828ea363a93ed5ae
Reviewed-on: https://chromium-review.googlesource.com/1259262Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596301}

This CL enables throttling of child synchronization events. In a child-
initiated synchronization, the child's frame will likely activate
before the dependent parent's CompositorFrame arrives. Upon activation,
the child will see that the new surface does not cause any damage to the
display (because it's not embedded by any parent yet) and calls the
draw callback immediately, thereby sending back a DidReceiveCompositorFrameAck
to the client immediately.

This, in turn, results in the client sending another CompositorFrame to Viz,
and another and so on, letting the child get further and further ahead of the
parent. This results in a lot of wasted work because the child's surface will
not be shown on screen until the parent embeds it and so multiple child
initiated synchronization events are pointless.

This CL throttles DidReceiveCompositorFrameAck of the child on child-initiated
synchronization events until the parent references the child.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I62416d87f8d871b32f4caad565cff515a9c55445
Bug: 672962, 879207
Reviewed-on: https://chromium-review.googlesource.com/1236931
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596300}

The shift modifier is *almost* always incorrect to use for menu items -- it is
instead appropriate to apply the shift modifier directly to the keyEquivalent.

Bug: 882166
Change-Id: I6507a2a8981241cb1b80a8737213c5ac45fdab2e
Reviewed-on: https://chromium-review.googlesource.com/1259362Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596299}

In vietnamese layout, cmd + [vkeycode=18] does not print any characters. This
should still be correctly interpretted as a hotkey for cmd + '1'.

Previously, the logic for cr_firesForKeyEvent would early exit when
charactersIgnoringModifiers had 0 length. Subsequent logic would use characters
in place of charactersIgnoringModifiers. This CL moves the latter logic before
the former logic so that if charactersIgnoringModifiers has 0 length, we'll
instead check characters.

Change-Id: I3fcc45579c7697ca843ef3472fa294fa2da02262
Bug: 889424
Reviewed-on: https://chromium-review.googlesource.com/1259342
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596298}

`SlowPathAlloc` has 3 tactics for getting new memory. Of these, only the 1st
(calling `PartitionDirectMap`) seems to most obviously get a fresh, zeroed page
from the OS. I think it is safe to optimize in that branch. It might be safe on
some platforms to optimize in the other 2 branches, but it's less obviously
safe, and we've had trouble on at least macOS. This CL enables the 1st branch
but turns off the optimization in the 2nd 2 branches.

Bug: 890752
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel
Change-Id: Ibd9ff599ba78aeab47c2369c472af71a4f71d600
Reviewed-on: https://chromium-review.googlesource.com/1256211Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596297}

We've seen an increase in Memory.Browser.PrivateMemoryFootprint that is
suspected to be caused by leveldb use for sync purposes, which is more
common the more datatypes are migrated to USS.

In order to tune leveldb's memory usage and confirm that recent
regressions are caused by sync, various feature toggles are introduced.
By default, there is no behavioral differences.

Bug: 887068
Change-Id: Idada6be78a39db7ef04ee582ca01b8ed0c427838
Reviewed-on: https://chromium-review.googlesource.com/1257912Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596296}

Bug: 850250
Change-Id: I1a7af66367665bcb1577b5c6efc3f2e5d2748113
Reviewed-on: https://chromium-review.googlesource.com/1171801Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596295}

https://skia.googlesource.com/skia.git/+log/49fdd7ad1875..f1709049243e


git log 49fdd7ad1875..f1709049243e --date=short --no-merges --format='%ad %ae %s'
2018-10-03 bsalomon@google.com Move integer rect checks from GrRenderTarget::drawTexture to GrTextureOp
2018-10-03 mtklein@google.com Revert "Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN.""


Created with:
  gclient setdep -r src/third_party/skia@f1709049243e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:862144
TBR=mtklein@chromium.org

Change-Id: I072cdf9b67cfb8174017bb2c145d4c0d2ec94976
Reviewed-on: https://chromium-review.googlesource.com/1259263Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596294}

Android O's WebView zygote code doesn't handle split APKs correctly when
preloading the code for the current WebView implementation, creating an
incorrect entry in the Java classloader cache. This causes a crash when
the renderer process initializes, since it tries to load the native
library into two different classloaders as a result, which is not
permitted.

We're hoping to work around this using reflection to correct the cache
entry during the zygote preloading phase, so that when the renderer
starts up, it correctly reuses the preloaded classloader instead of
creating a new one. However, we're not sure if this reflection will work
on all devices due to vendor changes.

To validate that the reflection works, this CL will attempt the
reflection but not actually change anything - if the reflection fails
due to a framework change, it will catch the exception instead of
crashing, and simply record that in a static variable which can later be
logged with UMA.

Bug: 891452
Change-Id: I41dabb9c4cb4151676229a07abd37c803dbc3967
Reviewed-on: https://chromium-review.googlesource.com/1255388
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596293}

This is a follow-up to r556547 and updates the unit tests for
SiteDataCountingHelper to use the network::mojom::CookieManager
interface.

Bug: 823297
Change-Id: I41914390a0efc33e5ee9a2fdeca628ff1a1c5f84
Reviewed-on: https://chromium-review.googlesource.com/1258246Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596292}

This migrates WaitForNetworkCallbackHelper from NetworkChangeNotifier
to NetworkConnectionTracker, which works with the network service
enabled.

Bug: 887056
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I70cc4863630ffbbd808ed91f5b4cee7dcc003296
Reviewed-on: https://chromium-review.googlesource.com/1239261Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596291}

Builders don't (and shouldn't) have global git user name/email
configured, and the recipe only configures git user in the Chromium
checkout (the recipe doesn't know about the tmp WPT checkout). When git
user cannot be found (neither in the repo or globally), `git commit`
will fail. (Previously, we didn't notice the issue on BuildBot because
the bot had some leftover global configurations from an earlier version
of the recipe.)

To make sure we always have a git user configured, this change
explicitly sets git user name & email in the tmp WPT checkout to the bot
account. It is still safe to run the script manually because GitHub
allows committers to be different from the uploader.

Besides, remove an unnecessary pair of quotes in a format string for
`git show`; we don't use shell to start subprocesses so spaces don't
need to be quoted.

Bug: 803111
Change-Id: Ife020c8a18120ff607b8802c32cf9539bf6a36c9
Reviewed-on: https://chromium-review.googlesource.com/1258977
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596290}

https://webrtc.googlesource.com/src.git/+log/f9d38f2e4e5d..7988589e4858


git log f9d38f2e4e5d..7988589e4858 --date=short --no-merges --format='%ad %ae %s'
2018-10-03 benwright@webrtc.org Add missing headers to new objective-c API.
2018-10-03 steveanton@webrtc.org Add jeroendb@ and shampson@ as media/sctp/ OWNERS
2018-10-03 peah@webrtc.org Hooked up the control of the adaptive AGC2 mode in audioproc_f
2018-10-03 danilchap@webrtc.org Set public visibility for rtp_rtcp and video_coding targets


Created with:
  gclient setdep -r src/third_party/webrtc@7988589e4858

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8527696381db4210640cea3564b271995dadb30a
Reviewed-on: https://chromium-review.googlesource.com/1257721Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596289}

This results in more intuitive behavior of Chrome with respect to tab switching
shortcuts.

Bug: 889424
Change-Id: I1ccba5141a3ddbfd2391d2d40e0d5884b50a382f
Reviewed-on: https://chromium-review.googlesource.com/1259244Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596288}

Original CL:

- https://codereview.chromium.org/1410353005

  Add generic.total_physical_bytes property to MallocExtension

  The actual physical memory usage of tcmalloc cannot be obtained by
  GetNumericProperty. This accounts for the current_allocated_bytes,
  fragmentation and malloc metadata, and excludes the unmapped memory
  regions. This helps the user to understand how much memory is actually
  being used for the allocations that were made.

  This change is done only in chromium tree since the
  metadata_unmapped_bytes is added only in the chromium's tcmalloc in
  CL: www.crrev.com/10499004.

  This is to be used by malloc dump provider for tracing.

  BUG=546491
  Committed: https://crrev.com/0752ec9c6adf641985db1a3a224bf9b8e32e4ac8
  Cr-Commit-Position: refs/heads/master@{#357155}

BUG=724399,b:70905156

Change-Id: I68ae586aacf2f2c1ab09721716b9093d402d649c
Reviewed-on: https://chromium-review.googlesource.com/1130803Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596287}

Bug: chromedriver:1408
Change-Id: Ia317f5e00e2b55092c2423f836eb5d04debfedb2
Reviewed-on: https://chromium-review.googlesource.com/1258086Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596286}

Some override functions in LayoutNGMixin are not to be
overridden further. This patch marks them as 'final' so that
calling them from inside of LayoutNGMixin or its subclasses
can make non-virtual calls.

No behavior changes.

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I97e65d70cbe34b6757ab129c62e37bdaddcda72e
Reviewed-on: https://chromium-review.googlesource.com/1258664Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596285}

The timer was added for the fear that the wallpaper animation
completion is never received. In fact, it's guaranteed to be received.

In case there's a decoder issue (more info in the bug) that wallpaper
decoding takes more than 5 sec:

1) If keeping the timer, the user pods will be shown on top of the
   white boot splash screen, which looks buggy.
2) If removing the timer, the user pods will show together with the
   wallpaper. The boot experience feels slow but still smooth.

So IMO the best solution is to remove the timer as well as trying to
fix the decoder issue.

Bug: 890935
Change-Id: I685a0065acae99ebccd2734dcebd9dce2f563dbb
Reviewed-on: https://chromium-review.googlesource.com/1255903Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596284}

Added in https://crrev.com/c/1259122 and https://crrev.com/c/1259125

Change-Id: I7122d66620dd04ba3f14036177a180bd4a26315d
Reviewed-on: https://chromium-review.googlesource.com/1259162Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596283}

We were relying on brittle transitive #include.

Bug: webrtc:8311
Change-Id: Ib67aef5ebead73cc7b9783c1bbc48fb53c332f3e
Reviewed-on: https://chromium-review.googlesource.com/1258912
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596282}

https://chromium.googlesource.com/angle/angle.git/+log/c3bef3e7b028..c2116cd3af9f


git log c3bef3e7b028..c2116cd3af9f --date=short --no-merges --format='%ad %ae %s'
2018-10-03 jmadill@chromium.org Vulkan: Update pipeline barrier interface.


Created with:
  gclient setdep -r src/third_party/angle@c2116cd3af9f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Idcd29fe0d40b4bcdde37947b2b0d10523a79dd31
Reviewed-on: https://chromium-review.googlesource.com/1259104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596281}

NSViews in Views need to implement pasteAndMatchStyle:.

The IDS_PASTE_MATCH_STYLE_MAC main menu item had the wrong key equivalent.

Bug: 882166
Change-Id: I0ba029afddaab8e155d5cfadaccadf2c231a3e79
Reviewed-on: https://chromium-review.googlesource.com/1255864
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596280}

R=eae@chromium.org, kojii@chromium.org

Change-Id: I78bda450dd122b256495b33489dc8bfb7b39fb15
Reviewed-on: https://chromium-review.googlesource.com/1259125Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596279}

Bug: none
Change-Id: I1968359861e40606e6c7336ad7a80371224da76e
Reviewed-on: https://chromium-review.googlesource.com/1255632
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596278}

https://helpx.adobe.com/security/products/flash-player/apsb18-31.html

BUG=412078
TBR=jschuh@chromium.org

Change-Id: If664b6a520360177c8cdfd25dd0025eaf8664ec3
Reviewed-on: https://chromium-review.googlesource.com/1259204Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596277}

This will allow us to pass more AccessibilityNodeInfoDatas even
if they belong to different windows, which is part of the upgrade
path planned for mapping ARC++ windows to Chrome OS.
See go/a11y-arc++-window-mapping > Upgrade path for more.

Bug: 891483
Change-Id: Ic7a1654691cec6d4229898d7d7aaeb3947953234
Reviewed-on: https://chromium-review.googlesource.com/1258207
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596276}