- 06 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7285b9ab36f4..8b1435392e02 Created with: gclient setdep -r src-internal@8b1435392e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib9ea28c552b9ead5575703e2b04be29edf9f1730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694285}
-
Robert Liao authored
This change attempts to be a behavior preserving change at the views layer while allowing the Chrome Typography provider to specify colors for menu item text. The mapping of Native Color IDs to styles are as follows: kColorId_EnabledMenuItemForegroundColor = CONTEXT_MENU + STYLE_PRIMARY kColorId_SelectedMenuItemForegroundColor = CONTEXT_MENU + STYLE_SELECTED kColorId_DisabledMenuItemForegroundColor = CONTEXT_MENU + STYLE_DISABLED kColorId_TouchableMenuItemLabelColor = CONTEXT_TOUCH_MENU + STYLE_PRIMARY kColorId_MenuItemMinorTextColor = CONTEXT_MENU + STYLE_SECONDARY kColorId_HighlightedMenuItemForegroundColor = CONTEXT_MENU + STYLE_HIGHLIGHTED The resultant colors are as follows, with views representing the old colors. Light Mode Light Mode Default (Views) Chrome kColorId_EnabledMenuItemForegroundColor Black GG900 kColorId_SelectedMenuItemForegroundColor Black GG900 kColorId_DisabledMenuItemForegroundColor GG600 [1] 9e9e9e kColorId_TouchableMenuItemLabelColor GG900 GG900 kColorId_MenuItemMinorTextColor Black A:0x89 GG700 kColorId_HighlightedMenuItemForegroundColor GG900 GG900 * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255. [1] kDisabledTextColor Dark Mode Dark Mode Default (Views) Chrome kColorId_EnabledMenuItemForegroundColor GG200 White A:0xDD kColorId_SelectedMenuItemForegroundColor GG200 White A:0xDD kColorId_DisabledMenuItemForegroundColor GG600 GG600 [2] kColorId_TouchableMenuItemLabelColor GG900 White A:0xDD kColorId_MenuItemMinorTextColor Black A:0x89 GG500 kColorId_HighlightedMenuItemForegroundColor GG200 White A:0xDD * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255. [2] Was GG800 by default, but changed to GG600 to maintain previous contrast. We can consider merging the colors after this change. BUG=865318 Change-Id: Ie0c0b566637e752e9947c702e7fb8160d51a3558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767083 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694284}
-
Andrew Luo authored
Bug: 997309 Change-Id: I6f29983c9d5c18c6837a791c1a4abcf0d15ddfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779854 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694283}
-
Andrey Kosyakov authored
This is a reland of 67d9a27b Fixed win Headless.beginFrame tests that were the reason of revert by deferring call to issueExternalBeginFrame in HostContextFactoryPrivate till compositor is configured. TBR=ccameron@chromium.org,sky@chromium.org,dcheng@chromium.org,spang@chromium.org,johannes@chromium.org,sunnyps@chromium.org > Remove ExternalBeginFrameControllerClient interface > > > ... and replace it with a callback to IssueExternalBeginFrame. > > Also, deprecate Headless.needsBeginFrameChanged in the protocol -- > the client is supposed to always attempt to drive frames. > > Bug: 997946 > Change-Id: Idd0f773b80e027241960451b638427366b4b07c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768880 > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692688} Bug: 997946 Change-Id: I4d128e496ecb4b97715565dac1de5d6ec31a4542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788234Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#694282}
-
Aran Gilman authored
Bug: 982354 Change-Id: I3a1ec863edb7f25ac968edae021b5549a2a768de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775159Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#694281}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d915f1866fa0..e2cd0bf51938 git log d915f1866fa0..e2cd0bf51938 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 jclinton@chromium.org Mark gale experimental due to http://b/140523449 Created with: gclient setdep -r src/third_party/chromite@e2cd0bf51938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I22f2fb54870e8de8de0eaabdbd253d3aafaccc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694280}
-
Peter K. Lee authored
- Picked up current Safari/ and AppleWebKit/ version numbers from Safari User Agent. - Deleted version_map[] entries for iOS versions that Chrome no longer supports. This was last updated for iOS 12 in https://chromium-review.googlesource.com/c/chromium/src/+/1102485 Bug: 1001261 Change-Id: I337b736d279c86727302e7a5828602bd8bfae787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788504Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#694279}
-
chrome://flags/deprecatedchrome://flagsYann Dago authored
Flags Deprecated visual: http://screen/acUoJdkq6p6 Flags Visual: http://screen/95M6sZUb2n1 Bug: 982371 Change-Id: I48efdec4dc217ad11b27b0f20db9512894b51558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785518Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#694278}
-
Ian Clelland authored
Bug: 856601 Change-Id: Iebfdce6071ece01fb82d480139b2c92837467628 TBR: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789962Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#694277}
-
Jeremy Roman authored
Use [RaisesException] for immediate promise rejections in /third_party/blink/renderer/modules/serial. The bindings layer implicitly converts thrown exceptions in promise-returning functions to promise rejections, and using ExceptionState makes this more similar to ordinarily throwing exceptions, notably by including the auto- generated exception context that makes it easier to see what IDL operation caused an exception to be thrown. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1001114 Change-Id: I705359178d1e7c429d48f24f37ca11c28f750d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786934Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694276}
-
Marc Treib authored
It wasn't used outside of tests. Bug: none Change-Id: Iefed7a4ee90ff0252210de425d102c47ed751c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789387 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#694275}
-
Denis Kuznetsov authored
Bug: 999477 Change-Id: Ifd9586437b8116beb9e61d893f936d8043ce254a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778544 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#694274}
-
Antonio Gomes authored
... from Blink. It is sitting unused in the tree. In fact, the whole third_party/blink/public/platform/modules/media_capabilities directory can later be moved down to renderer/platform. BUG=919392 R=haraken@chromium.org Change-Id: I41e4c9bf7e7f78153e404175e21b01a629f7b9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786097 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#694273}
-
Tommy Steimel authored
This CL adds the Global Media Controls IPH triggering logic and connects it with the frontend IPH bubble. Bug: 991585 Change-Id: I3c7b1e824ede5b620a87fa92306f6c9bdac1e348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783667Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694272}
-
Dominik Röttsches authored
This reverts commit 2636d855. Reactivate FontSrcLocalMatching by default on Windows after bot testing stability has been restored. Bug: 999787 Change-Id: If897a8b8193d4ad398d15db421bebc3bb58043b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787287 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694271}
-
Tatiana Buldina authored
This particular test expects ChromeDriver to wait for an extension iframe to load. ChromeDriver has already been modified by r670576 to not automatically wait for iframe load, so this test is no longer valid. Bug: chromedriver:2965 Change-Id: I4f1227c0b2ad27c63f6e8b1614914be24a63528b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787167Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#694270}
-
Jeremy Roman authored
The bindings now provide an ExceptionState and automatically turn the result into a promise rejection (if an exception is thrown), so we don't need to duplicate this in the implementation of HTMLPortalElement::activate. Bug: 1001114 Change-Id: I69f9ffa0301f9d03bd221be5a81fee549f65b73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789822Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694269}
-
Ian Clelland authored
Bug: 998399 Change-Id: Ifccc12c536540c3f7cfe257a6f778034a5b07053 TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789686Reviewed-by:
-
Sam Maier authored
Change-Id: I231e5e1550655976bd81fc72d26aa07fa921a80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789743 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694267}
-
Jun Mukai authored
PaginationModel::SelectPage does not stop the ongoing animation when invoked during a transition animation, which means ContentsView::TransitionStarted() is not invoked at all. This has not been addressed in the current animation scheme since ContentsView schedules the animation on TransitionStarted(). This is a quick fix to finish the existing animation before invoking SelectPage in that case. Bug: 1000920 Test: manually Change-Id: I2b69a485e04cf3965a423d6b6cbda73f1d358643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787448Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694266}
-
Aga Wronska authored
The key event was ignored by the dialog that supports only selected events. Bug: 999385 Test: ParentAccessWidgetTest Change-Id: I76d20dcae6a5b880ecfcdd64fec61909614c3c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783861 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#694265}
-
Ian Clelland authored
This makes it easier to depend on just FeaturePolicyFeature or PolicyValue in other areas of code, without running into a possible circular import situation. Change-Id: Ic7ff6b31320f3c7d13f67153932016f966f63eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784104 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694264}
-
Tao Bai authored
This reverts commit 1a297a80. Reason for revert: The culprit https://chromium-review.googlesource.com/c/chromium/src/+/1778362 was reverted. Original change's description: > Disable flaky test AwContentCaptureTest#test* > > Tbr: michaelbai@chromium.org > Bug: 1001400 > Change-Id: I8a6e2467f020372d7b0de031b84c07948834cfdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789283 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694204} TBR=michaelbai@chromium.org,arthursonzogni@chromium.org Change-Id: Ib92233902f4e760d638d5b53e2d87ba9e19bdaf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789667Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694263}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a3baf2a3b165..30323e2fb25a git log a3baf2a3b165..30323e2fb25a --date=short --no-merges --format='%ad %ae %s' 2019-09-06 ilnik@webrtc.org VP9 screenshare: fix incorrect assumptions on buffer contents 2019-09-06 srte@webrtc.org Fix for rare read of uninitialized value in remote estimate test. 2019-09-06 sprang@webrtc.org Implement stable rate support in SimulcastRateAllocator 2019-09-06 srte@webrtc.org Fix for deadlock in AudioUsesAbsSendTimeExtension test. Created with: gclient setdep -r src/third_party/webrtc@30323e2fb25a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iae4067c4107fb84862187ad1459a13679681a954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789762Reviewed-by:
-
Gabriel Charette authored
Backport some tests in /net/base/network_change_notifier_fuchsia_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /net/base/network_change_notifier_fuchsia_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=wez@chromium.org Bug: 891670 Change-Id: Idbfa9ea4a8945cbbb3e713e6d269e5427eafe4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786817 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#694261}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dff4674a483a..7285b9ab36f4 Created with: gclient setdep -r src-internal@7285b9ab36f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9d72d6b87d8c6dac678e761d4d7311089ac8b86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789554Reviewed-by:
-
Zakhar Voit authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/0418b5904157..db31812cb239 $ git log 0418b5904..db31812cb --date=short --no-merges --format='%ad %ae %s' 2019-08-12 voit login: Add LoginScreeenStorage ListKeys() and Delete() methods. 2019-08-14 kimjae dlcservice: Error and Status propagation 2019-06-12 smbarber system_api: add ConnectChunnel method to vm_cicerone 2019-06-12 smbarber system_api: add chunneld D-Bus interface 2019-08-19 akhouderchah system_api: shill: Remove unused kTypeWimax constant Created with: roll-dep src/third_party/cros_system_api Bug: 980171 Change-Id: If66124da790bfa081429c50ef58eaec994426147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789235 Commit-Queue: Zakhar Voit <voit@google.com> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Zakhar Voit <voit@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694259}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b2b16fad. With Chromium commits locally applied on WPT: 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." c1907c87 "[WPT/common/security-features] Rename common.js to common.sub.js" 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 17df479e "Revert "Temporarily send `Sec-Fetch-*` headers via non-secure transport."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1b041847b0e24b3dc5f1fdc2713e4cbbd5a09af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789443Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694258}
-
Tao Bai authored
This reverts commit 4a10b100. Reason for revert: <INSERT REASONING HERE> Original change's description: > Plumb proper OOPIF compositor viewport rect. > > This CL converts OOPIFs from using a compositor viewport that is the > entire size of the content layer, to a much smaller one based on the > visible intersection of the OOPIF's content with its parent's viewport. > > This should decrease compositor resources used by the OOPIF, and > prevent excessively large tiles being produced. > > Bug: 852348 > Change-Id: I27977e2513d727bc6ba1a414504157cef3436a03 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778362 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694066} TBR=pdr@chromium.org,alexmos@chromium.org,mkwst@chromium.org,wjmaclean@chromium.org Change-Id: Id0cdb4c77487861f8da76dd9de44768097bf480a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789687Reviewed-by:
-
Olga Sharonova authored
TBR=haraken@chromium.org,teib@chromium.org Bug: 1001437,997634 Change-Id: Ia8a7f795d6978a970ddf57ae42137fcb471ea1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789532Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#694256}
-
Armando Miraglia authored
The vulnerability indicated in crbug.com/995964 suggests that the core issue relates to the assumption that device_start_request_queue_ can only contain one occurrence of a controller while this might not be the case. This change makes sure that all occurrence of a controller are removed from the list, instead of removing only the first found. BUG=995964 Change-Id: Ice2a1da37d13339128d3d52d25daa252c5d61155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784726Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#694255}
-
Robbie Gibson authored
The issue with using UIView.appearance.tintColor is that becomes the new default, breaking tintColor's inheritance mechanism. In general, if tintColor is unset, UIKit walks up the view hierarchy until it finds the nearest set tintColor, and uses that. Now, because tintColor is set everywhere through UIAppearance, that never happens. In the linked bug, the close button had a tint set on the UIButton, but not the contained UIImageView. This new method sets the tintColor on the root window, so inheritance still works. If a superview has a provided tintColor, it will apply to any subviews. For a given view, if it and no ancestors have a tintColor, the root window will be the closest ancestor and thus the default. Bug: 1001501 Change-Id: I06b354e56fd43ec8e171be5b4af4b2e3c7c8bbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789384Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694254}
-
Eric Stevenson authored
This reverts commit 91053066. Reason for revert: Failures fixed by a0040e3d. Original change's description: > Revert JNI refactor for AwContentsClientBridge.java > > Reverting whole CL has merge conflicts, so quickly reverting this one > more known bad file. > > NOTRY=true > NOPRESUBMIT=true > TBR=estevenson > > Bug: 1000471 > Change-Id: Ica8158d081cb4e7c833787e8196e2cbf792093bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786671 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693733} TBR=agrieve@chromium.org Bug: 1000471, 1000820 Change-Id: I3a79f8af5236eb411458f85923297a8f5720bcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789684 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694253}
-
Theresa Wellington authored
BUG=985622 Change-Id: Id37b9cb7cf04282eb734fc717f2891b34e8ae279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775349 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#694252}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df0ce01870fa..e64cea302acd git log df0ce01870fa..e64cea302acd --date=short --no-merges --format='%ad %ae %s' 2019-09-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 19b256616d96..b218ad19949f (2 commits) Created with: gclient setdep -r src/third_party/angle@e64cea302acd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I7c4c491d76656f2f820b7454c54808305f202ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789547Reviewed-by:
-
Javier Ernesto Flores Robles authored
Integration test for other password in Manual Fallback. Should fail before the fix (crrev.com/c/1784614) is merged. Bug: 997632 Change-Id: I1c9ea719c85e8ba56fe3a6ca50a1d600e8ad2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783446Reviewed-by:
-
Dominik Röttsches authored
This reverts commit dcf25ed5. Re-enable field trial config on Windows for FontSrcLocalMatching after bot testing has stabilzied, see issue 996167. Note to sheriffs: Should you see crashes or issues with DWriteFontLookupTableBuilder or testing issues relating to matching @font-face: { src: local() } fonts on Windows, in particular Windows 7, please only revert this CL, preferably not the related one: https://chromium-review.googlesource.com/c/chromium/src/+/1777862 - if you can't reach drott@, try getting in touch with etienneb@ please before reverting. Thanks. Bug: 999787 Change-Id: I47a18fc1c31d0879700378a8924aff23de64997a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787614 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694249}
-
Andrew Grieve authored
Guessing they used to be required for ProGuard. Change-Id: I52d708459530daddbab9a20c82dd743ee3193cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786873 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694248}
-
Olga Sharonova authored
This reverts commit 74ae0216. Reason for revert: Looks like not a root cause Original change's description: > Revert "Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded" > > This reverts commit 0b7170d7. > > Reason for revert: Speculative: suspected of causing failures of > InfoCollection_basic > InfoCollection_direct_composition > https://ci.chromium.org/p/chromium/builders/ci/Win10%20x64%20Debug%20%28NVIDIA%29/829?blamelist=1#blamelist-tab > > Original change's description: > > Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded > > > > - Add a JNI method to callback when both DeviceInfoTracker and > > LocalDeviceInfoProvider are ready > > - Also removed redundant setVibration in SharingNotificationUtil > > > > Bug: 996318 > > Change-Id: Id4df6b407ac2fb1c1622071ffb7ee8bb3a747b41 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787379 > > Commit-Queue: Alex Chau <alexchau@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Richard Knoll <knollr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#694208} > > TBR=treib@chromium.org,alexchau@chromium.org,knollr@chromium.org > > Change-Id: I3837352ddf7345751b679f4065b0c00de28d5d43 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 996318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789234 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694223} TBR=treib@chromium.org,olka@chromium.org,alexchau@chromium.org,knollr@chromium.org Change-Id: I377486659e744c6d9f69659e845d6b5d88253fd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789533Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 988278, 860467 Change-Id: Ie77f86b054818f87d9d75531c5d8f160ba8e2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778499 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#694246}
-
