- 27 May, 2014 40 commits
-
-
chrome://networkstevenjb@chromium.org authored
This CL does the following: * Moves chrome://network resources into their own directory * Separates 'requestNetworkInfo' into two separate methods: ** NetworkUI.getNetworkLog ** networkConfig.getNetworks * Moves networkConfig methods into their own module ** networkConfig emulates a subset of the chrome.networkingPrivate extension API ** This module will later also be used by the internet options JS code BUG=366365 For c/b/browser_resources.grd: R=armansito@chromium.org, pneubeck@chromium.org, xiyuan@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/260083007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273007 0039d316-1c4b-4281-b951-d872f2087c98
-
mohammed@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/292203010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273005 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
R=binji@chromium.org, binji BUG=377084 Review URL: https://codereview.chromium.org/296413008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273004 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Revert of Refactor and move ash independent nested accelerator code to ui/wm/core (https://codereview.chromium.org/298703007/) Reason for revert: caused test failures: http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19236 NestedAcceleratorTest.AcceleratorsHandled (run #1): [ RUN ] NestedAcceleratorTest.AcceleratorsHandled Backtrace: ui::PlatformEventSource::OverrideDispatcher [0x0028B66D+253] wm::test::NestedAcceleratorTest_AcceleratorsHandled_Test::TestBody [0x00455D37+215] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x004D5829+329] testing::Test::Run [0x004EFF9E+174] testing::TestInfo::Run [0x004F023D+221] testing::TestCase::Run [0x004F00DF+239] testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x004D5D21+337] testing::UnitTest::Run [0x004F0393+211] RUN_ALL_TESTS [0x004A0EDF+15] base::TestSuite::Run [0x004A1129+233] base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>::Run [0x004150EB+27] base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo [0x00414FFA+26] base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int __cdecl(base::TestSuite *)>::Ru [0x0041506A+74] base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47] base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921] base::LaunchUnitTests [0x00498D15+37] main [0x0041681C+140] __tmainCRTStartup [0x00647D39+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626) mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466) BaseThreadInitThunk [0x76568624+14] RtlInitializeExceptionChain [0x773CAC69+133] RtlInitializeExceptionChain [0x773CAC3C+88] NestedAcceleratorTest.AssociatedWindowAboveLockScreen (run #1): [ RUN ] NestedAcceleratorTest.AssociatedWindowAboveLockScreen Backtrace: ui::PlatformEventSource::OverrideDispatcher [0x0286B66D+253] wm::test::NestedAcceleratorTest_AssociatedWindowAboveLockScreen_Test::TestBody [0x004563B5+517] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x004D5829+329] testing::Test::Run [0x004EFF9E+174] testing::TestInfo::Run [0x004F023D+221] testing::TestCase::Run [0x004F00DF+239] testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x004D5D21+337] testing::UnitTest::Run [0x004F0393+211] RUN_ALL_TESTS [0x004A0EDF+15] base::TestSuite::Run [0x004A1129+233] base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>::Run [0x004150EB+27] base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo [0x00414FFA+26] base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int __cdecl(base::TestSuite *)>::Ru [0x0041506A+74] base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47] base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921] base::LaunchUnitTests [0x00498D15+37] main [0x0041681C+140] __tmainCRTStartup [0x00647D39+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626) mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466) BaseThreadInitThunk [0x76568624+14] RtlInitializeExceptionChain [0x773CAC69+133] RtlInitializeExceptionChain [0x773CAC3C+88] Original issue's description: > Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core > > I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them. > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272740 > > R=ben@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272995 TBR=ben@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/301743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273003 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
BUG=377917 TBR=cpu Review URL: https://codereview.chromium.org/306543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273001 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
> Revert 241291 "Fix a long standing leak on cancellation of rende..." > > This caused crashes elsewhere in the loading code. > > BUG=27911 > > > Fix a long standing leak on cancellation of renderer- > > initiated URLRequests. ResourceDispatcher was not calling > > peer->OnCompletedRequest on cancellation of async requests, > > despite it being expected by WebURLLoaderImpl::Context > > (The only ResourceLoaderBridge::Peer). > > > > This shouldn't impact externally visible behavior at all, > > other than fixing the leak, because once > > WebURLLoaderImpl::Context::Cancel() is called, it will never > > call back into WebURLLoaderImpl. > > > > BUG=328092 > > > > Review URL: https://codereview.chromium.org/113893007 > > TBR=mmenke@chromium.org > > Review URL: https://codereview.chromium.org/306483009 TBR=mmenke@chromium.org Review URL: https://codereview.chromium.org/299393010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273000 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
UMA Metrics for the new avatar menu, including vasquette-detection and Add Account, remove Account, profile switch and locking. For Googlers, a design doc: https://docs.google.com/a/google.com/document/d/1ybiN1r2xAlMj0PBABH63PJIyVWhsM409xPpZI4zlmck/edit BUG=357693 TEST=Turn on new-profile-management and optionally fast-user-switcher. Perform the actions listed above and verify results in chrome://histograms Review URL: https://codereview.chromium.org/288493008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272999 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
This caused crashes elsewhere in the loading code. BUG=27911 > Fix a long standing leak on cancellation of renderer- > initiated URLRequests. ResourceDispatcher was not calling > peer->OnCompletedRequest on cancellation of async requests, > despite it being expected by WebURLLoaderImpl::Context > (The only ResourceLoaderBridge::Peer). > > This shouldn't impact externally visible behavior at all, > other than fixing the leak, because once > WebURLLoaderImpl::Context::Cancel() is called, it will never > call back into WebURLLoaderImpl. > > BUG=328092 > > Review URL: https://codereview.chromium.org/113893007 TBR=mmenke@chromium.org Review URL: https://codereview.chromium.org/306483009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272998 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
This change adds GinJavaBridgeObject and GinJavaBridgeDispatcher classes. GinJavaBridgeDispatcher is a per-RenderFrame manager of injected objects. It interacts with the browser side. GinJavaBridgeObject is a Gin-based wrapper injected into page's context that exposes methods of the corresponding Java object and receives method invocation requests from JavaScript. BUG=355644 R=jochen@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/259033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272997 0039d316-1c4b-4281-b951-d872f2087c98
-
pedrosimonetti@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/295283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272996 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272740 R=ben@chromium.org Review URL: https://codereview.chromium.org/298703007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272995 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
This patch merges message_handling.js and jsep01_call.js. The distinction isn't useful anymore since we used to support multiple signaling bases like ROAP, we don't anymore. Besides, message_handling had evolved to practically be the public interface to the test C++, so this patch makes this role more explicit. Also the code used to be very flexible to support all kinds of permutations that we need to do in the manual test page, but since that code has moved off on its own we can eliminate the flexibility and thereby greatly simplify the code. Also improves the error reporting by including the js stack trace when there's a test failure. BUG=375240 Review URL: https://codereview.chromium.org/293123009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272994 0039d316-1c4b-4281-b951-d872f2087c98
-
kkinnunen@nvidia.com authored
The actual code uses only immediate commands. The shm versions are either unused or used only by the unit tests. Make the unit tests use the immediate commands. Solves the problem of not having to implement one useless function for the a new command when using immediate commands. BUG=373763 Review URL: https://codereview.chromium.org/289993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272991 0039d316-1c4b-4281-b951-d872f2087c98
-
miletus@chromium.org authored
This CL uses LatencyInfo to track the plugin input event latency. 1.Each plugin input event has an associated LatencyInfo which includes some important components from its according ui::Event/WebInputEvent's LatencyInfo. To do that, during the scope of RenderWidget::OnHandleInputEvent(WebInputEvent, latency_info) we first cache the WebInputEvent's latency_info, then if the input event needs to be routed to plugin, we copy the important components from the cached latency_info into the plugin input event's LatencyInfo. 2.A private API InputEventPrivate::TraceInputLatency(bool has_damage) is exposed. 3.If the event is believed to cause rendering damage, private_event.TraceInputLatency(true) can be called, and the input event's LatencyInfo will be sent to renderer with next plugin frame and be tracked until it reaches screen. If the event is believed to not cause any rendering damage, private_event.TraceInputLatency(false) can be called, and the LatencyInfo tracking ends right at the call. BUG=355719 TEST=with custom test touch drawing plugin, input-to-swapbuffer latency is shown correctly in trace viewer. Review URL: https://codereview.chromium.org/252663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272990 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
Try #2 of https://codereview.chromium.org/298653010/ Fixed newly introduced GN dependency. TBR=darin@chromium.org BUG= Review URL: https://codereview.chromium.org/298003008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272989 0039d316-1c4b-4281-b951-d872f2087c98
-
mef@chromium.org authored
BUG=354143 Review URL: https://codereview.chromium.org/293003010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272988 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=311235 R=oshima@chromium.org Review URL: https://codereview.chromium.org/302663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272987 0039d316-1c4b-4281-b951-d872f2087c98
-
wangxianzhu@chromium.org authored
Initialize failure causes immediate renderer crash. The logs about the failures are useful for debugging the reason in the environemnt that can reproduce the failure. BUG=374362,376072 R=jshin@chromium.org Review URL: https://codereview.chromium.org/296293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272986 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
> Change Shell / ShellClient to ServiceProvider > > BUG= > R=darin@chromium.org > > Review URL: https://codereview.chromium.org/298653010 TBR=davemoore@chromium.org Review URL: https://codereview.chromium.org/304593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272984 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG= R=darin@chromium.org Review URL: https://codereview.chromium.org/298653010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272983 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
TBR=binji Review URL: https://codereview.chromium.org/293353005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272982 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272981 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This pulls in the following Native Client changes: r13227: (dyen) Standardized method to define extra substitution paths in toolchain_main. r13228: (dschuff) Do not build PNaCl host toolchain with build.sh r13229: (sbc) Add downloaded gn binaries to .gitignore r13230: (dschuff) Remove cloud-bucket flag from PNaCl package_version update script r13231: (bradnelson) Download spec2k to out instead of assuming it will be installed on the bots. r13232: (dschuff) Make build.sh use the repository directories from toolchain/build r13233: (jvoung) Download the spec harness on the rest of the spec bots. r13234: (sehr) Disable conflicting sysroot= in chromium arm build r13235: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13236: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13237: (dschuff) Update revision for PNaCl r13222->r13228 r13238: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13239: (mcgrathr) toolchain_build: Update gcc revision (4.8.3 release) r13240: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13241: (noelallen) Add OWNERS per-file *.gn for noeallen and bradnelson r13242: (noelallen) Untar raw toolchain and build cooked toolchain. r13243: (mcgrathr) Update nacl_arm_newlib toolchain r13244: (dyen) Toolchain build now displays solutions when an invalid repo is found. r13245: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS BUG=none TEST=browser_tests and nacl_integration Review URL: https://codereview.chromium.org/300033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272980 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272974 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272587 Review URL: https://codereview.chromium.org/296453015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272972 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
This feature can be enabled with "enable-embedded-singin" command-line switch. BUG=308312 TEST=manually NOTRY=true Review URL: https://codereview.chromium.org/296173008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272971 0039d316-1c4b-4281-b951-d872f2087c98
-
nhiroki@chromium.org authored
BUG=371675 TEST=n/a NOTRY=true Review URL: https://codereview.chromium.org/307503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272970 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
We are not interested in computing an order file for the crazy linker. This CL ensures that we never try to instrument it. R=mariakhomenko@chromium.org, pliard@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/292123008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272967 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/300463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272966 0039d316-1c4b-4281-b951-d872f2087c98
-
torne@chromium.org authored
Android WebView builds use a hermetic host toolchain, so detecting the host gcc version with compiler_version doesn't work. Hardcode the current versions used instead. BUG=377684 Review URL: https://codereview.chromium.org/302633006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272965 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
Added automatic mode to FakeInputAudioStream to generate automatic beeps. This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio", which I hope it will make things less confusing. NOTRY=true TBR=grunell@chromium.org BUG=358541 TEST=bots existing webrtc tests. Review URL: https://codereview.chromium.org/301633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272964 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This CL generalizes the UserContext::password_ field into a Key class which can hold a plain text password, a key derived from a password by hashing or, in the future, other key types. BUG=367847 TEST=Updated tests; added new unit test R=antrim@chromium.org TBR=pamg (c/b/managed_mode/chromeos/manager_password_service.[h|cc]) Review URL: https://codereview.chromium.org/296773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272963 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
BUG=377728 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/305573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272962 0039d316-1c4b-4281-b951-d872f2087c98
-
henrika@chromium.org authored
BUG= R=xians@chromium.org Review URL: https://codereview.chromium.org/287873004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272961 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
BUG=374105 TBR=shannonwoods@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/301623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272959 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
Most of our other existing scopers have this method. It allows the scoper to "give up" its ownership claim. R=thakis@chromium.org, thakis Review URL: https://codereview.chromium.org/295933017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272956 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272955 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/294273002/reed@google.com authored
NOTRY=True Review URL: https://codereview.chromium.org/307513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272954 0039d316-1c4b-4281-b951-d872f2087c98
-
rdsmith@chromium.org authored
BUG=None R=willchan@chromium.org Review URL: https://codereview.chromium.org/292063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272953 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
Setting no-try since this test doesn't run on trybots anyway. BUG=373252,377383 NOTRY=True Review URL: https://codereview.chromium.org/301653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272952 0039d316-1c4b-4281-b951-d872f2087c98
-