GitLab

Several notifications layout tests misues assert_object_equals, passing
in non-object values, and assuming it will behave like assert_equals.

Spoiler - it doesn't: assert_object_equals(true, false) passes!

BUG=none

Review URL: https://codereview.chromium.org/1321643002

git-svn-id: svn://svn.chromium.org/blink/trunk@201317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently CacheQueryOptions(ignoreSearch, ignoreMethod, ignoreVary) are not
supported on Cache.match/matchAll/delete/keys and CacheStorage.match, but
these APIs can accept the options and just drop them internally.

This CL makes these APIs show a warning message when unsupported options
are specified.

BUG=426309, 499216, 482256, 520784

Review URL: https://codereview.chromium.org/1320823003

git-svn-id: svn://svn.chromium.org/blink/trunk@201316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When applying any other property than "all", we already perform this whitelist
check, but applying "all" is a separate code path, and the checks were missing
there.

BUG=524682
R=rune@opera.com

Review URL: https://codereview.chromium.org/1304123006

git-svn-id: svn://svn.chromium.org/blink/trunk@201315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=497522

Review URL: https://codereview.chromium.org/1299323005

git-svn-id: svn://svn.chromium.org/blink/trunk@201314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove a raw pointer to a PlatformEventController instance in PlatformEventDispatcher on Oilpan build

BUG=509911

Review URL: https://codereview.chromium.org/1301543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This series of CLs fixes WebCallback parameter types used in BackgroundSync.

 - WebSyncRegistration* (ownership transferred)
  => PassOwnPtr<WebServiceWorkerResponse>
 - bool* (ownership transferred)
  => bool
 - WebVector<WebSyncRegstration*>* (ownership transferred)
  => const WebVector<WebSyncRegistration*>&
 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebSyncError* (ownership transferred)
  => const WebSyncError&

1/4: https://codereview.chromium.org/1309143002/
2/4: https://codereview.chromium.org/1311053002/
3/4: https://codereview.chromium.org/1308273002/
4/4: https://codereview.chromium.org/1308283002/

BUG=493531

Review URL: https://codereview.chromium.org/1311053002

git-svn-id: svn://svn.chromium.org/blink/trunk@201312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a regression from r201058. We incorrectly marked the shadow root
node for style recalc instead of the host. Marking the host is necessary
to apply new :host rules.

R=esprehn@chromium.org
BUG=525280

Review URL: https://codereview.chromium.org/1311463004

git-svn-id: svn://svn.chromium.org/blink/trunk@201311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@70d47dff45667002f8acdbd137f8cf2b04109365
imported web-platform-tests@1831450b96c77f1b8fa631f6987e3bc1e4eacf8e

* css-color-4 was added and skipped.

* 1 file to skip was renamed.

* 6 tests no longer fail and removed from TestExpectations
  - 1 in html/semantics/embedded-content
  - 4 in shadow-dom
  - 1 in css-writing-modes-3

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org
BUG=490511, 492664, 505364

Review URL: https://codereview.chromium.org/1313623003

git-svn-id: svn://svn.chromium.org/blink/trunk@201310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Depends on https://codereview.chromium.org/1316093003

BUG=none

Review URL: https://codereview.chromium.org/1309273006

git-svn-id: svn://svn.chromium.org/blink/trunk@201309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes a race that would occur if the blink scheduler wanted to
prioritize loading tasks.

BUG=510398

Review URL: https://codereview.chromium.org/1318463004

git-svn-id: svn://svn.chromium.org/blink/trunk@201308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes reference type style to follow other files in Blink, e.g.
move |&| just after type name without a space for improving code health.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1310493003

git-svn-id: svn://svn.chromium.org/blink/trunk@201307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=524261

Review URL: https://codereview.chromium.org/1309673004

git-svn-id: svn://svn.chromium.org/blink/trunk@201306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

GlobalFetch::ScopedFetcher instances are heap objects, so avoid using
WeakPtr<>s over those.

Also switch over to using WeakPtr* transition types where possible.

R=haraken
BUG=509911

Review URL: https://codereview.chromium.org/1320563003

git-svn-id: svn://svn.chromium.org/blink/trunk@201305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves a member function |intersectsNode()| out from
|VisibleSelection| class as a preparation of templatizing |VisibleSelection|
for introducing composed tree version of |VisibleSelection|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1316303002

git-svn-id: svn://svn.chromium.org/blink/trunk@201304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |PositionInComposedTree| version of |enclosingBlock()|
by introducing template function |enclosingBlockAlgorithm()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_filter=EditingUtilitiesTest.enclosingBlock

Review URL: https://codereview.chromium.org/1310073006

git-svn-id: svn://svn.chromium.org/blink/trunk@201303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves global function |lowestEditableAncestor()| in
"EditingUtilities.{cpp,h}" to local function in "VisibleSelection.cpp" to
narrow visibility for improving code health and ease of implement composed tree
version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1318943002

git-svn-id: svn://svn.chromium.org/blink/trunk@201302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523952

Review URL: https://codereview.chromium.org/1312733003

git-svn-id: svn://svn.chromium.org/blink/trunk@201301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes |RenderedPosition| constructor with |VisiblePosition|
parameter simpler by using delegating constructor for improving code helath.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320543003

git-svn-id: svn://svn.chromium.org/blink/trunk@201300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes memory leaks caused by not calling disposePerContextData on
ScriptState.

BUG=524875

Review URL: https://codereview.chromium.org/1314333002

git-svn-id: svn://svn.chromium.org/blink/trunk@201299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1318713003

git-svn-id: svn://svn.chromium.org/blink/trunk@201298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace null with isNull in comment because 'null' means nullptr typically.
We prefer not to use double negation so reverse impl in isNull and isNotNull.
It gets straightforward.

BUG=

Review URL: https://codereview.chromium.org/1318913004

git-svn-id: svn://svn.chromium.org/blink/trunk@201297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=n/a
R=tyoshino@chromium.org

Review URL: https://codereview.chromium.org/1316523003

git-svn-id: svn://svn.chromium.org/blink/trunk@201296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In a couple of places, we now have a larger cull rect bound for drawing recorders
because of using enclosingIntRect. This is always safe to do.

BUG=524259

Review URL: https://codereview.chromium.org/1316163002

git-svn-id: svn://svn.chromium.org/blink/trunk@201295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SegmentedString::push() had an exotic behavior, where
two consecutive push would swap its order.

This CL changes the push() implementation so that it would always push
the new char in front of the SegmentedString.
This CL also updates the HTMLEntityParser code which relied on the behavior.

BUG=None
TEST={SegmentedStringTest,HTMLEntityParserTest}.*

Review URL: https://codereview.chromium.org/1308573006

git-svn-id: svn://svn.chromium.org/blink/trunk@201294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change Rect and Quad to be CSSQuadValue, and remove rects and quads from
CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1304993002

git-svn-id: svn://svn.chromium.org/blink/trunk@201293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords (patchset #5 id:80001 of https://codereview.chromium.org/1314923005/ )

Reason for revert:
Broke WebKit Linux Leak

See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/13676

Original issue's description:
> Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords
> 
> Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion
> 
> I plan to merge this to the M46 branch ASAP.
> 
> R=esprehn@chromium.org,yoav@yoav.ws
> BUG=475104
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201259

TBR=esprehn@chromium.org,yoav@yoav.ws,cbiesinger@google.com,cbiesinger@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475104

Review URL: https://codereview.chromium.org/1318933002

git-svn-id: svn://svn.chromium.org/blink/trunk@201292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This case contains SVG zoom/scroll animation including 20 frames zoom in, 
20 frames scroll and 20 frames zoom out. Final result is total time used to 
animate these 60 frames.

Review URL: https://codereview.chromium.org/1267093002

git-svn-id: svn://svn.chromium.org/blink/trunk@201291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated all const methods on CSSPrimitiveValue to actually use the
const keyword. This is needed for later work that calls methods on const
references of CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1314783002

git-svn-id: svn://svn.chromium.org/blink/trunk@201290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |Position| version of |enclosingBlock()| as a preparation
of templatzing it.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed a bug in CSSCursorImageValue::equals() which was causing any
cursor images with the same hotspot to be treated as equal. Also added a
test.

BUG=510188

Review URL: https://codereview.chromium.org/1311783009

git-svn-id: svn://svn.chromium.org/blink/trunk@201288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rects incorrectly included composited scroll offset. They should not, and
instead follow the example set by https://codereview.chromium.org/1287413002.

BUG=524547

Review URL: https://codereview.chromium.org/1315203002

git-svn-id: svn://svn.chromium.org/blink/trunk@201287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes duplicated decrementAndCheckLength() logic in SegmentedString.

BUG=None
TESTS=Refactoring only. No change in behaviour

Review URL: https://codereview.chromium.org/1320813002

git-svn-id: svn://svn.chromium.org/blink/trunk@201286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes the visual-viewport-managed scrollbars exclusive to
Android and improves normal scrollbars to be usable during pinch as follows:

1. Attach the scrollbar layers to the visual viewport, so they're always
   onscreen as you zoom in (as already shipped on Mac).
2. Set the container layer to the inner clip layer, so that the size and
   position of the thumb reflects the sum of the two viewports,
   instead of just the layout viewport.

Note that result of these changes is visually indistiguishable at
minimum page scale.  It only improves the behavior when zoomed in.

BUG=523056

Review URL: https://codereview.chromium.org/1308053003

git-svn-id: svn://svn.chromium.org/blink/trunk@201285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a trivial patch, split off from https://codereview.chromium.org/1315993004.
This patch removes an incorrect "paintOffset" name and fixes the recorder
type in BlockFlowPainter.

Review URL: https://codereview.chromium.org/1316883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes a few small clean-ups to getValueName:
- Type argument as CSSValueID instead of unsigned short
- Disallow trying to serialize invalid CSSValueIDs
- Don't add values for CSSValueInvalid in the offset tables

Review URL: https://codereview.chromium.org/1302273005

git-svn-id: svn://svn.chromium.org/blink/trunk@201283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer need paint-phase-based subtree display items because we'll
use paint layers as units of subtrees. This greatly simplifies subtree
caching.

Renamed subtree to subsequence.

BUG=410087

Review URL: https://codereview.chromium.org/1313223002

git-svn-id: svn://svn.chromium.org/blink/trunk@201282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method should be allowed to execute JS since it needs it to collect call stack.

BUG=525305

Review URL: https://codereview.chromium.org/1313693007

git-svn-id: svn://svn.chromium.org/blink/trunk@201280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525109

Review URL: https://codereview.chromium.org/1311363007

git-svn-id: svn://svn.chromium.org/blink/trunk@201279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specification at https://heycam.github.io/webidl/#idl-constants mentions the constants
should be defined as:

  const type identifier = value;

whereas the |type| is mentioned as:

  The type of a constant (matching ConstType) must not be any type other than a primitive
  type or a nullable primitive type

And string literals are not treated as primitive types. Hence we should remove the support
for having a constant like:

  const DOMString hello = "world";

BUG=469961

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1315663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When user use styles formatting option with borders it can be important to not produce additional string tokens.

BUG=520724
R=lushnikov@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1310303004

git-svn-id: svn://svn.chromium.org/blink/trunk@201277 bbb929c8-8fbe-4397-9dbb-9b2b20218538