- 06 Aug, 2019 40 commits
-
-
Varun Khaneja authored
R=drubery TBR=holte (since http://cl/261944627) Bug: 965587 Change-Id: Ic8a8c8a05be012bae3bf375d511399eba47c1ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739588 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#684414}
-
Gayane Petrosyan authored
Set picker value to the exact value that user selected instead of the darkest of the calculated colors. These 2 colors are similar but not always the same. Therefor picker value to the exact value so that selected color doesn't jump after OnThemeUpdate. Bug: 990379 Change-Id: Iac9ddae122be5daf01ec95bca571ec832aa5a981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737330 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#684413}
-
Ella Ge authored
With flag kConsolidatedMovementXY enabled, we compare the incoming event's coordinates with the |synthetic_move_position_| to tell if the event is a synthetized move that comes from |MoveCursorTo| call. The check didn't consider the error introduced by converting from pixel to dip, which causes a failure when there is a fractional device_scale_factor. This CL makes the check use the same logic as w/o kConsolidatedMovementXY. This also removes |synthetic_move_sent_| boolean and use |synthetic_move_position_| for both the flag enabled/disabled. Bug: 802067 Change-Id: I4847397e317d29b62328d02910b7cb3e8de13759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704743Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#684412}
-
Sadrul Habib Chowdhury authored
BUG=984159 Change-Id: I18d9882adc86ad163a7ef161bd8f48ee2484f80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739113 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#684411}
-
Ben Kelly authored
This is a reland of 053b22e8 The CacheStorageManagerTest.TestErrorInitializingCache test has been modified to reduce flakiness. Original change's description: > CacheStorage: Write index after simple disk_cache. > > When we load the cache_storage index we try to determine if its fresh > or stale by comparing its timestamp against the timestamp of the > various simple disk_cache directories. Both cache_storage and simple > disk_cache write their index files out using a delay. The > cache_storage delay is 5 seconds and the simple disk_cache delay is 20 > seconds. This means that the simple disk_cache index is always written > last and as a result the cache_storage index is almost always > considered stale. > > This CL fix this by extending the cache_storage delay to match the > simple disk_cache delay. It also implements a shorter delay on android > when in the background like simple disk_cache uses to avoid losing > data when the app is killed by the operating system. Finally, the CL > also now properly flushes the index to disk if there is a pending write > when the cache_storage subsystem is torn down. > > Over time this should cause ServiceWorkerCache.UsedIndexFileSize to > show more cases where the index file is used to provide the size. > > Bug: 988001 > Change-Id: Idaa09b956edcfa9e70ac1fdb9b43adcd73ec0508 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721389 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682409} Bug: 988001 Change-Id: I12aa006bf1d18be5ae121c0330d97e51a97ff906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739408Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#684410}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/060fcf777159..3aec8a3be749 git log 060fcf777159..3aec8a3be749 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 chrisforbes@google.com Tidy around sampler handling Created with: gclient setdep -r src/third_party/swiftshader@3aec8a3be749 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/134584057 Change-Id: I3b892e49f28ce5261a3ad54b056c681e8e1012bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684409}
-
Rayan Kanso authored
UKM collection review doc (Google-only): https://docs.google.com/document/d/17roFDpjKXeglB9_dzfX7uGykoWeRCVTa_4SDDJyv04Y/ Bug: 973844 Change-Id: I2a8d36286ff7b0472c64313b222f7404f88e241e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724077Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684408}
-
Kristi Park authored
- Move order of menu header items (e.g. back button and daily toggle) so that they follow the submenu nav buttons using keyboard navigation. - Support selection on SPACE for color/background tiles. - Like backgrounds/colors, use arrowkeys instead of TAB to navigate the shortcut options (i.e. TAB to focus the shortcuts menu, then use arrowkeys to move between the shortcut options). - Add role=button to upload & default background tiles for screenreader support. Bug: 953822 Change-Id: Iae8c1b8390d917f1513e234b46f0b75cc9bae3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737743 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#684407}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 968047 Change-Id: I32f6d432ffa2550f58d433775e0adef216cf9ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738593 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Elad Alon <eladalon@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#684406}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36756e459041..c5f95c03ada3 git log 36756e459041..c5f95c03ada3 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c5f95c03ada3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Id342cf080995fdd38d5ece41d466daca5b6ea30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738995Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=alph@chromium.org Bug: 968047 Change-Id: Ib6128dd00c45055be4f045a73665fa61cc6a0a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728588 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#684404}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/61b15905b014..7cbee84610a8 git log 61b15905b014..7cbee84610a8 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 srte@webrtc.org Reland "Adds PeerConnection scenario test framework." 2019-08-06 sprang@webrtc.org DegradedCall: fake network using TaskQueue instead of ProcessThread 2019-08-06 mbonadei@webrtc.org Disable RunPythonTests on rtc_tools. Created with: gclient setdep -r src/third_party/webrtc@7cbee84610a8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I696d68c872e0622c9fc9cb635c5ac7d929b84639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738994Reviewed-by:
-
Sammie Quon authored
The app list view already skips events during overview, but this is not enough because the app list window still consumes the tap event, and then gets activating, exiting overview. Its ok now as we'd want to exit overview anyways, but we're introducing side scrolling soon, so we need the tap down event to not exit overview. SearchBox view now does not need to check if we are in overview anymore, since searchbox widget is a child of AppList window. Test: manual Bug: 991040 Change-Id: Ice13a42eff72a5897fb4ba44cb56152aee57e479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737823Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#684402}
-
Peter Boström authored
Replaces the png graphics that blends into the default-color highlight effect. Bug: chromium:978388 Change-Id: I33e63b1e15c225761f6f089aac5e853463169b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736440Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#684401}
-
Yue Zhang authored
This CL adds the MVC components for TabGridIph component. Right now there are no consumers for this part of logic. Bug: 987043 Change-Id: I877d5909a164fad79d1f7206652e98eab8c54efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731178 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#684400}
-
Lan Wei authored
Instead of adding a variable to check if the test should be finished, we can create a promise object and end the test at its last callback. Bug: 606367 Change-Id: I6be3a61db1f54fa88b56e919b8be6dfa318b21c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704865Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#684399}
-
Sorin Jianu authored
https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/3668 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8905912644874073840/+/steps/compile/0/stdout [7588/69449] CXX obj/chrome/updater/win/installer/lib/installer.obj FAILED: obj/chrome/updater/win/installer/lib/installer.obj ... In file included from ../../chrome/updater/win/installer/installer.cc:31: In file included from ../..\base/files/file_path.h:114: In file included from ../..\base/stl_util.h:26: ../..\base/logging.h(23,10): fatal error: 'base/logging_buildflags.h' file not found #include "base/logging_buildflags.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. TBR=waffles CC=jdonnelly Bug: 989772 Change-Id: I4f660a6a5fc420c691a8c8c4018c90e32e76f2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739319Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684398}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites with tools/git/mffr.py. This CL was uploaded by git cl split. R=oshima@chromium.org Bug: 968047 Change-Id: I9ee81e17587644f1651afd664168c0f864df93ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728877 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684397}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77c12644ba94..fc9e4928e7c0 Created with: gclient setdep -r src-internal@fc9e4928e7c0 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0e2a5b91336ea8422d82b52f621b45a4f25b9d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738993Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684396}
-
James Cook authored
The link icon is presentational, so take it out of the tab order. Add an aria-label to the clear button. This is needed to get a11y browser tests to pass when we flip the SplitSettings flag. Bug: 950007 Test: enable Chromevox, tab through settings Change-Id: Id5be0809de94f4107231f5a7f4d932e5cb143479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739392 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#684395}
-
Brian Sheedy authored
Adds the Intel UHD 630 to the list of approved Intel GPUs on Windows in the GPU integration tests. Without this, one of the info_collection_tests fails on the new Optiplex 7060 that is being qualified. Bug: 986939 Change-Id: I2d71c2a8499367e8c6de131e8f41279e0f4b3b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737810 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684394}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3a543aafd4e6..bdb0919dcc6a git log 3a543aafd4e6..bdb0919dcc6a --date=short --no-merges --format='%ad %ae %s' 2019-08-06 robertphillips@google.com Use GrComputeTightCombinedBufferSize in GrMtlGpu::uploadToTexture Created with: gclient setdep -r src/third_party/skia@bdb0919dcc6a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I6b3ea554bb09d275d7108afe9a05c18d47d1d633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738329Reviewed-by:
-
Bing Xue authored
In ObjectManager, when ConnectToNameOwnerChangedSignal is called the first time, we could have already missed the NameOwnerChanged signal if we get a value from UpdateNameOwnerAndBlock. This means NameOwnerChanged callbacks will never be called until that service restarts. In ObjectManager we run into this problem: 1. ObjectManager::SetupMatchRuleAndFilter is called, calling bus_->GetServiceOwnerAndBlock shows empty service name owner. 2. ObjectManager::OnSetupManagerRuleAndFilterComplete callback will call object_proxy_->ConnectToSignal, which in turn calls ConnectToNameOwnerChangedSignal the first time. At this point, UpdateNameOwnerAndBlock calling bus_->GetServiceOwnerAndBlock returns the current name owner of the service, this means the NameOwnerChanged signal is already sent on system bus. 3. As a result, ObjectManager::NameOwnerChanged is never called while the service is already online. This in turn causes GetManagedObject to never be called, and the object manager interface never added. See detailed sample logs in b/138416411. This CL adds the following: 1. Make SetNameOwnerChangedCallback run ConnectToNameOwnerChangedSignal when called. Since ObjectManager calls SetNameOwnerChangedCallback before posting SetupMatchRuleAndFilter (in which ObjectManager attempts to get the service name owner through a blocking call), this removes the time gap described above that causes lost signal. 2. Make dbus thread the only writer to |service_name_owner_|, given that connecting to the NameOwnerChanged signal right away in ObjectManager ctor causes potential data race in writing to |service_name_owner_| in both NameOwnerChanged (on origin thread) and SetupMatchRuleAndFilter (on dbus thread). BUG=b:138416411 TEST=Manually on device. Change-Id: Ie95a5b7b303637acadebda151cc478e52b6a1af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733111 Commit-Queue: Bing Xue <bingxue@google.com> Auto-Submit: Bing Xue <bingxue@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684392}
-
Adam Ettenberger authored
This change separates updating AXNodeData in AXTree::UpdateNode from notifying that the node data will change, and node data has changed. --- Problem : AXTree notifies AXTreeObservers of node and subtree changes in the middle of a tree update, which means observers may be seeing a tree state that's incomplete. This can lead to subtle bugs when observers access nodes in the AXTree other than the node being updated. e.g. |GetUnignoredParent| may be invalid during a notification, but correct afterwards. Proposed solution : Separate notifications from updates in AXTree::Unserialize. This requires the following steps : 1. Record all operations that would be performed on the tree. 2. Fire all on destroy and OnNodeDataWillChange callbacks. 3. Apply all update operations. 4. Fire all created and node data changed callbacks. For additional context, see these comments by Nektarios and Dominic : https://chromium-review.googlesource.com/c/chromium/src/+/1650222/20#message-ffe9bf96b616a915bebf2e69d7803bcae6a18b24 https://chromium-review.googlesource.com/c/chromium/src/+/1535171/69#message-7b62970b193439a1878d7339cdc94d2556d0a416 I plan to submit approximately 3 CLs to resolve this : 1. Handle Pre/Post Tree changes (create node / destroy subtree) 2. Handle Pre/Post Node data changes (attributes will / have changes) 3. Add DCHECKs to AXNode::*Unignored* accessors, along with any remaining work required to do so, to help harden these paths. Bug: 974444 Change-Id: Iade343a572003e31d79039b08cced689fb6e9cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710128 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#684391}
-
Rune Lillesveen authored
If we need to recalculate style for a pseudo element, we forced it through the StyleRecalcChange passed in, even if the only reason was that the pseudo element itself was style dirty. The problem with that is that it would look like an ancestor change made the recalc necessary. If an ancestor change made it necessary we could not use the optimized base computed style path for style recalc. Make sure we only translate kUpdatePseudoElements into kRecalcChildren and still benefit from base computed style if the incoming StyleRecalcChange propagation is kNo. Bug: 988834 Change-Id: Ib2efcd6a932623bfec6226512eb3692418c84928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738559Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#684390}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/7be3caccf..a0c8f5aa0 $ git log 7be3caccf..a0c8f5aa0 --date=short --no-merges --format='%ad %ae %s' 2019-08-04 bnc Add QpackEncoder::SetMaximumDynamicTableCapacity() and SetMaximumBlockedStreams() and call them when corresponding settings are received. 2019-08-02 dschinazi Fix coalesced packet processing 2019-08-02 renjietang Remove incorrect uses of GetHeadersStreamId(). Change-Id: I8d44ef3d884f4321050d795d376a3ed06be74d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739290 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#684389}
-
Shimi Zhang authored
- Add test for fragment navigation - Add test for setWebMessageListener() with different WebMessageListener Bug: 918065 Change-Id: Ia655a8b9988d043387a51370bc2cc0ecf4508a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734744Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#684388}
-
Tommy Li authored
For view-source URLs, applying steady state elisions is confusing, as the user lacks the normal lock icon needed to surmise that the scheme is HTTPS. Moreover, view-source users are likely developers or Defenders of the Web that want to see the full URL. This CL simply turns off elisions for the inner-url portion of view-source scheme URLs. Bug: 981490 Change-Id: I64d7e130cf9096f86a3af1215ef30c0abfd96c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737366Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#684387}
-
Toni Barzic authored
Moves key handling for the case SearchBoxSelection feature is disabled to a separate method. This makes it easier to follow feature specific parts of the logic (and make subsequent changes to the key handler easier). BUG=939106 Change-Id: I52ed5f2a1458d281f89249eff656f4404b0fb8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737807Reviewed-by:
-
Tom Sepez authored
Bug: 968591 Change-Id: I3aa9dacc4612c16a549ff2f07842c1e439987517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736138Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#684385}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/c691071e933e..7be3caccf89c $ git log c691071e9..7be3caccf --date=short --no-merges --format='%ad %ae %s' 2019-08-02 renjietang Remove completed TODO's. 2019-08-02 renjietang Simply QuicSpdySession::HasActiveRequest(). 2019-08-02 dschinazi Enable more TLS stateless reset tests 2019-08-02 ianswett Move local_delayed_ack_time from QuicSentPacketManager to QuicReceivedPacketManager, set the delayed ack time to 1ms for Initial and Handshake packet number spaces when using v99, and use peer_delayed_ack_time instead of local_delayed_ack_time when with the MAD1 connection option. 2019-08-02 dschinazi Send correct stateless reset token when using TLS 2019-08-02 ianswett Use peer_max_ack_delay_ not local_max_ack_delay_ when using the MAD1 QUIC connection option. Both fields are set to identical values, so this is a no-op. Created with: roll-dep src/net/third_party/quiche/src Change-Id: I85ede16ccff071c9cdf38fa8c51e50a95c786b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739406 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
David Benjamin authored
Bug: 646113 Change-Id: I4a6d0990d365e9b9279d5348154abb44e1f23a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737438Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#684383}
-
Geoff Lang authored
The finch release process says that the feature should be enabled in Chrome ToT at the same time as it is launched so that a max_version can be set. BUG=882580 Change-Id: I4b3e3eb70236dab1f4269ef9f38073c89a93d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736798Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
This change separates updating tree structure in AXTree::Unserialize and AXTree::UpdateNode from notifying that the tree structure will change or has changed. --- Problem : AXTree notifies AXTreeObservers of node and subtree changes in the middle of a tree update, which means observers may be seeing a tree state that's incomplete. This can lead to subtle bugs when observers access nodes in the AXTree other than the node being updated. e.g. |GetUnignoredParent| may be invalid during a notification, but correct afterwards. Proposed solution : Separate notifications from updates in AXTree::Unserialize. This requires the following steps : 1. Record all operations that would be performed on the tree. 2. Fire all on destroy and OnNodeDataWillChange callbacks. 3. Apply all update operations. 4. Fire all created and node data changed callbacks. For additional context, see these comments by Nektarios and Dominic : https://chromium-review.googlesource.com/c/chromium/src/+/1650222/20#message-ffe9bf96b616a915bebf2e69d7803bcae6a18b24 https://chromium-review.googlesource.com/c/chromium/src/+/1535171/69#message-7b62970b193439a1878d7339cdc94d2556d0a416 I plan to submit approximately 3 CLs to resolve this : 1. Handle Pre/Post Tree changes (create node / destroy subtree) 2. Handle Pre/Post Node data changes (attributes will / have changes) 3. Add DCHECKs to AXNode::*Unignored* accessors, along with any remaining work required to do so, to help harden these paths. Bug: 974444 Change-Id: I6f9c20389da444d81a33b5c27774faf81a2f066c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703466 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=rayankans@chromium.org Bug: 968047 Change-Id: Iac4a5f35210b2baf7280bc0d9be89b68183c2ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729257 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684380}
-
arthursonzogni authored
Adding: - NavigationControllerBrowserTest.HistoryBackTwiceFromRendererWithUserGesture - NavigationControllerBrowserTest.UtilizationOfSpareRenderProcessHost - WebContentsImplBrowserTest.SetPageFrozen Bug: 990354, 991194 Change-Id: Ia3814961b4a33d871556a49da2b7b7caac38aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738452 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#684379}
-
Ben Kelly authored
This feature was enabled by default in crrev.com/c/1736868. Bug: 954442 Change-Id: I60b3c34aa1427a4e91230074d326d3ba5fa08d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739528 Commit-Queue: Ben Kelly <wanderview@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684378}
-
Gayane Petrosyan authored
https://screenshot.googleplex.com/R2K3Ps4khBi.png Bug: 990952 Change-Id: I1a5277a73a5a4e7c710529f66f1260dc900fae61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737162 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
David Benjamin authored
Bug: 646113 Change-Id: I3c6c52586080a053e390ca27b08d53fb777cd69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737428 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... and remove it out of the Blink exposed API. This change is a follow up of [1], where AecDumpAgentImpl::Delegate was factored out into AecDumpAgentImplDelegate, and made temporarily public. [1] https://crrev.com/c/1710237 BUG=704136,919392 R=guidou@chromium.org Change-Id: I130a45549b5866fd9235099ef4e1a4963f9eedf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739289 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#684375}
-
