- 08 Sep, 2020 37 commits
-
-
Darren Shen authored
Add a new file containing protobufs to communicate between Chrome and the new native input engine. Add an OnFocus proto message. Send the OnFocus proto when focusing on an input field. Bug: 1019541 Change-Id: Ia890efb881f92bfb5fe161208c83c9ed3a6368f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370885Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#804838}
-
Mitch McDermott authored
Previously, files of equal timestamps were being sorted in their loaded order. To further align with the Files app, this CL instead sorts equal timestamped files lexicogrpahically by their names. Bug: b/159959835 Change-Id: Idbcd9e540f3ac9afeb4bea6056a8110e248b10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397118 Commit-Queue: Mitchell McDermott <mcdermottm@google.com> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#804837}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599492790-48f26b1814d8ee70ca5f6f24d850f389c1625719.profdata to chrome-win32-master-1599525924-8e0161c47f5f22554f3324d544d18a882035921a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I644d7751653741b7f55458845d3c89225e9ef8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804836}
-
Nicholas Hollingum authored
In crrev.com/c/2277694, mouse movement events on CrOS will have ordinal motion. We add a flag that will be used to control whether Exo reads those, or just continues to use accelerated motion. We want a flag in the short term because the hardware units we get on CrOS are too small, and we require some investigation in how to scale them appropriately. Bug: b/161755250 Change-Id: I3ac45b020d033a8fe180789bd979e7a50a68e0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370683 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#804835}
-
Siye Liu authored
We introduced interim composition character highlight for Windows in crrev.com/780377. However, we need to revert to previous UI (solid underline) due to strong user request. Bug: 1124602 Change-Id: Ia4ac41f9719fabb4fcdf6171f94d242472009689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394195Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804834}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3b36eb57c37..6f29c57c715c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia5e3befc77d0b0dd1c8326a3d276c09853b31a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397277Reviewed-by:
-
Peng Huang authored
This CL implements render pass overlay on macOS. With this implementation, SkiaRenderer draws render passes with filters with a DDL recorder canvas, and then stores DDL and related information in the CALayerOverlay. The SkiaOutputSurfaceImplOnGpu will create overlay shared images backing base on the DDL, and then replays DDL against the backing, and then the backings will be presented as overlays. However this CL doesn't recycle overlay shared images. It always creates new shared images for each render pass overlay. Shared image backing recycling will be implemented in follow-up CLs. Since recycling is not implemented, so the the render pass overlay is not enabled in this CL. Bug: 1100728 Change-Id: I8389393a790b9e0fdc0dda69c60afd2566a68dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388885 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#804832}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I9b5e9e86da91c2b9cc908b27b38bad7841b26da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397316Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804831}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3b36eb57c37..6f29c57c715c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If20d7bf46ccb3a3f9296637252514278b5c0216a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396918Reviewed-by:
-
Minggang Wang authored
Currently, content::IsOriginSecure() util is used by ResourceDispatcher, which will be removed along with OnionSoup. This patch moves content::IsOriginSecure() into Blink, so that we could onion-soupify the ResourceDispatcher. Change-Id: I7b9975ccc50bb28e13c37107588c9e071450f39f Bug: 1110032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392044 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#804829}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/132445728c15..d3b36eb57c37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7c2c854106e07d495dd9e102070e46bdbc418218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396936Reviewed-by:
-
HyunJi Kim authored
CSS property listed in css_properties.json5 should be listed in kPropertyLookupTable with the same name Bug: 1122869, 1124823 Change-Id: I7fae9ec52d7bebdba7b960dd305fffba96b5e4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390594 Commit-Queue: HyunJi Kim <hjkim3323@gmail.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804827}
-
Fredrik Söderqvist authored
Mechanical change (with luckily no repercussions). Bug: 1017723 Change-Id: Iaae9529d3a4fb84f2dd4478875afdfc1ad211bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395620 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#804826}
-
Austin Tankiang authored
Bug: 1115025 Change-Id: If5d1c23f2a267b6e6b674e2f2d0105e0d2e3164f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360057Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#804825}
-
Ye Kuang authored
Bug: 894045 Change-Id: Ib106460ead97d78630d082386b1ac71037b609bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397055Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#804824}
-
Dominic Farolino authored
R=hajimehoshi@chromium.org, haraken@chromium.org Bug: 870606 Change-Id: I99c11a168b13e8492ef05de7bca69843d9bec4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396600Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#804823}
-
minch authored
Changes: 1. Make AshColorProvider::Get*LayerColors without |given_color_mode|, get color info from IsDarkModeEnabled() instead. 2. Remove AshColorProvider::Get*LayerColorImpl, move all the logic into corresponding Get*LayerColors function. 3. Return the color of each type based on IsDarkModeEnabled() now, no need to get both light and dark colors and then return on |color_mode_|. 4. Oobe and notification don't support dark mode currently. Set the colors of them as constant for now. Will switch to AshColorProvider later if needed. Follow up cls: Remove all the DeprecatedGet*LayerColor and AshColorMode. Bug: 1107056 Change-Id: Idd3d4ea055ef66cd68c7c1fff356cc313442500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376992 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#804822}
-
Eric Willigers authored
Bug: 1035527 Change-Id: I01684142f18665a83bd5b0e1f74de97cf64c90bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392029 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804821}
-
Dongjun Kim authored
These C++ objects are destroyed in PaymentRequestImpl.closeUIAndDestroyNativeObjects(). However, if an object is garbage-collected for any reason without PaymentRequestImpl.closeUIAndDestroyNativeObjects() being called, then it will cause a memory leak. A finalize method should be added to these objects to ensure destruction of the owned C++ objects. Bug: 1090918 Change-Id: I12df86f9705d81d630b63223d15354d2b022e888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392290 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804820}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a56a85e63bec..e46a2aea1478 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I8624c97ea4d6c0cf255d24c52a3104ef00ece6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396717Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804819}
-
Kenichi Ishibashi authored
|deleted_version_id| and |newly_purgeable_resources| aren't used anymore as of crrev.com/c/2348734. Bug: 1055677 Change-Id: I66d5e144a4631894b919171565a51dd03303c645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395320Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
Reduces the estimated pre-processed size by ~2.1M. Bug: 242216 Change-Id: I68ea30c3c7437dffc5667d26d8972276c7d79792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396302 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Ian Struiksma authored
Bug: 1121441 Change-Id: Icce79358d5ff3cca2c013310015e076ceb7267c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373132Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#804816}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3b36eb57c37..6f29c57c715c 2020-09-07 treehugger-gerrit@google.com Merge "tracing: Add a way to query service state" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5c586aaf93fb5bc82cdfc30c7a506be7555929f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396407Reviewed-by:
-
Victor Costan authored
The distinction between kShared and kExplicit is large enough that there are significant readability advantages to having the default be explicit in the code. Bug: 1125315 Change-Id: Ifeeedc4f51e44e5348177c67d48361da1ac79cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394720 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Evan Stade authored
Since the dialog code always calls ContactsPicker.onDialogDismssed, but the test did not launch the dialog through ContactsPicker, the null assert was hit. Change the test to launch the dialog by way of ContactsPicker. Bug: 1125409 Change-Id: I2212aca6e13b960dfe09ae145f9f75e70830e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394647 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#804813}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7026a1db5b74..132445728c15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia606af26d6442b24cf2708fbdeddeaf76d0f80bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396596Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/132445728c15..d3b36eb57c37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib56668784a4f5dca6d65c4abd29468504254e97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396598Reviewed-by:
-
Kent Tamura authored
- Add missing dependencies - Allow circular includes with renderer/platform:platform - Expose renderer/platform/heap:heap to scheduler Bug: 800764 Change-Id: I49a1182125023c65876294e0f4e848f41908b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394901 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
wutao authored
Changes: 1. When updating fails, we will use backoff policy until max retries. 2. However, we will update immediately if the update is called from Settings UI. 3. Caching the incoming updates when there is a ongoing updating and will update the cache when the ongoing update finishes. Bug: b/152921891 Test: manual Change-Id: I48f6c13f724696b75ee58ed1f7fc24cad7107a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378894Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#804809}
-
Frédéric Wang authored
Bug: 6606 Change-Id: I754d2241915c85b5c1eb75a7056d5f4c428d1d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396241 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804808}
-
Sangwoo Ko authored
As per https://html.spec.whatwg.org/multipage/rendering.html#tables-2 , text-indent for table should be initial. Bug: 999088 Change-Id: I59833ff9684f04916f112c585be0ceafbfe6d7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395900Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#804807}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599450822-c8039978cfc4f91681250dd400e03a84f6c9a29d.profdata to chrome-win32-master-1599492790-48f26b1814d8ee70ca5f6f24d850f389c1625719.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I248fba9375f37e3793eea364893f4937e5ee259c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396402Reviewed-by:
-
Nathaniel Mitchell authored
Adds a network traffic annotation for Contextual Search Followed documentation standards set by: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/network_traffic_annotations.md Followed the protocols at: https://source.chromium.org/chromium/chromium/src/+/master:tools/traffic_annotation/traffic_annotation.proto?q=traffic_annotation.proto Bug: 870398, 1121633, 1121634 Change-Id: Ic5bc596dd729518c108a1bb2ba792011a2c4c2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355097Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#804805}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599480000-359ed9b37932456efdafd52df427d9044e87d251.profdata to chrome-win64-master-1599501535-4517b466b7e93a6fa96665d6e0ac00556c34e7cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ibc2207476f94504e73deaa472180d77d1c807832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396412Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 723e2961. Reason for revert: no obvious changes for the metris. Tiling invalidation on change of raster translation seems not a reason of the regressions. Original change's description: > Temporarily disable tiling invalidation on change of raster translation > > This is to investigate performance regression shown on UMA. > > The disabled logic was introduced in crrev.com/798268 to achieve sharp > text in composited layers with fractional transform. It is expected to > cause performance regressions for JavaScript animations without > will-change:transform. > > This CL won't cause loss of all crrev.com/798268. A composited layer > will be still initially drawn with perfect raster translation if > eligible. Only skip update of raster translation on subsequent > fractional transform changes. > > Bug: 1123555 > Change-Id: Id220df3f05c9757ea571ea948a529b2e247d7483 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386657 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803576} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123555 Change-Id: I16a8d1bbc362d1eafe39b56814d82b29f2eedafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396577Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e00cd77675baecbf0c7cabfa030b546e4f483bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396716Reviewed-by:
-
- 07 Sep, 2020 3 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599458176-11e2917dc2d8682a1e6ca50080f9502cff8643cc.profdata to chrome-win64-master-1599480000-359ed9b37932456efdafd52df427d9044e87d251.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4e6fd62c0663487051b1e6171a5be53a80c8dc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396282Reviewed-by:
-
Nela Kaczmarek authored
This change records GetChangePasswordURLMetric in AffiliationService and FetchTimeMetric in AffiliationFetcher. Bug: 1108279 Change-Id: Ibbeb4fc29e30c8b28dd98e8312608f64ed9173d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385360 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#804800}
-
Nick Diego Yamane authored
Detaching a tab by dragging it upwards was not supported until crrev.com/c/2362987, which modified wl_data_device::leave event handling so that it dispatches fake motion events with [-1,-1] location, so giving higher level GUI components (e.g Chrome's TabDragController) a chance to detect when the pointer leaves that window. Such approach works, but it turns out to cause an issue in the drag offset calculation as can be seen in screen cast [1]. This issue can be avoided by keeping the 'x' coordinate value and using -1 only for 'y'. NOTE: This is a workaround targeted specifically to Chrome's tab drag and should ideally be reworked in the future, with a broader change, in higher level layers, such that they handle platforms that do not support global screen coordinates appropriately. Further context: The aforementioned problem happens because //chrome code assumes global screen coordinates are available in platform located events, in this specific case, TabDragController uses a vertical "magnetism" constant to determine when to detach the dragged tab selection [2]. Such constant may result in coordinates outside the browser window boundaries, mainly when dragging upwards, which is ok in a platform where screen positions are available. That's not the case for Wayland, where DND is used for tab dragging, where neither implicit grab is supported. [1] https://youtu.be/NKv4h4Ut-gw [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_drag_controller.cc;l=1105-1107;drc=6e8b402a6231405b753919029c9027404325ea00 R=msisov@igalia.com Test: Covered by ozone_unittests Bug: 896640 Change-Id: I4909acaa7e8a9fbb17968a4ec38632ac61915a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388762Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804799}
-
