- 12 Nov, 2019 40 commits
-
-
Andreas Haas authored
Crashes caused by the OOM_CRASH macro are currently not classified as OOM crashes by Chrome Crash at the moment. The reason is that Chrome Crash analyzes the stack trace to do the classification, and OOM_CRASH does not show up in the stack trace at the moment. This CL changes OOM_CRASH to call the NOINLINE function OnNoMemory, which then causes the crash. Thereby the OOM crash is visible on the stack trace and can thus be classified correctly by Chrome Crash. R=rmargold@chromium.org, yuzus@chromium.org Bug: chromium:1019661 Change-Id: Id1a755076db4464b5de9a36aaf4ddeaa9a7dbc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906148 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714448}
-
Stephen Nusko authored
This reverts commit f8dd1ecf. Reason for revert: Seems to be causing the mac-builder-perf to fail (see linked bug). Original change's description: > Capture test_api.js javascript dependencies in 2 places (rather than ~13). > > test_api.js depends on a bunch of JS libraries that appear in many lists. > > This CL consolidates those dependencies to two places: > - js2gtest.gni, and > - A JsTestApiConfig class declared in chrome/test/base/js_test_api.h > > Note not all lists captured the axs_testing.js dependency, but this change > uses the same dependency list in all locations for consistency. > > TBR=aboxhall@chromium.org (mechanical change) > > Bug: 1000989 > Change-Id: If6e0716c03e42783a2d3529baa70475a9d305045 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900512 > Commit-Queue: Trent Apted <tapted@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714421} TBR=tapted@chromium.org,dbeam@chromium.org,aboxhall@chromium.org,blundell@chromium.org Change-Id: I3d93382a9833f85aabe2eb0e0469c16e451c65ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000989,1023795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911748Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714447}
-
Bo Liu authored
See documentation on Reference.reachabilityFence for why this is needed. Change-Id: I38e51364a5bf6542be65904ea30b0c65fd8dbe2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887151 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714446}
-
Anqing Zhao authored
To support uploading usage data for Chrome OS. We need support ChromeOsUserReport in CloudPolicyClient similar to ChromeDesktopReport. Bug: 1010213 Change-Id: I7c6467fcbd8b1f5f6d6bb68fae3bc1af52601eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893195 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#714445}
-
Jinsong Fan authored
For the writing-mode: vertical-*, the bounds of the selection are horizontal, so the variable names of |top| and |bottom| are confused. The |start| and |end| are more better, the CL adjusts the variable names through the entire call chain for consistency. Bug: 1015274 Change-Id: I724c9720c998586d00c98c090dd1ea7da55e645d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897555Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#714444}
-
Giovanni Ortuño Urquidi authored
Remove createRequest() and createProxy(). Bug: 968369 Change-Id: Iecccafcbe8189e70e6426a5b947b9e6e0e5b134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906849Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714443}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e4abc9ac382..12e54dae167c git log 3e4abc9ac382..12e54dae167c --date=short --no-merges --format='%ad %ae %s' 2019-11-12 ehsannas@gmail.com Update Offset to ConstOffset bitmask if operand is constant. (#3024) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@12e54dae167c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I2323c371aadb7bcedc8cf0d889320626154036a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714442}
-
Gabriel Charette authored
Details @ https://docs.google.com/document/d/13PIBPuSPJbrgHAgyRbY22EWAfH2narnxpa_CgBmZbSY/edit R=fdoray@chromium.org Bug: 1022972 Change-Id: I89b0404b28c92fc144b40352eed95a847f1a19ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906637 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#714441}
-
Mitsuru Oshima authored
* frame mode is either normal, immersive (auto hide) or none if the window is frameless. * frame is visible if the frame is fully visible (normal, maximized), or revelaed state in immersive. Bug: 1021604 Test: covered by unittests Change-Id: I62f2e176af3d690fb4a8c7da557c0ba522d7eea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906951Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714440}
-
Stephen Nusko authored
It was already disabled for nexus5 and nexus5x but its failing now on, pixel2 and nexus6x. It only seems to run and pass on linux-perf. NOTRY=true TBR=crouleau@chromium.org Bug: 1023792,894147 Change-Id: Ie183a3715d0b32e7ab378ea21187bea598555cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911744Reviewed-by:
-
Marc Treib authored
The entry point to this removal was IsDeleteJournalEnabled: It was true only for BOOKMARKS, but bookmarks have been migrated to USS (and the old implementation removed), so this wasn't relevant anymore. Bug: 854684 Change-Id: I038cc01a3d8eb1c66e4961f9851cf1f89479d100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910226 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#714438}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f4cf10c66fbf..c9d5be6b0170 git log f4cf10c66fbf..c9d5be6b0170 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 rharrison@google.com Remove deprecated items from result/message refactoring (#878) 2019-11-11 9856269+sarahM0@users.noreply.github.com Add spvc parser support and unit tests for OpVariable, OpDecorate, OpExtInstImport, … … (#873) Created with: gclient setdep -r src/third_party/shaderc/src@c9d5be6b0170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ib0fd2d8c1cfbf9200196f47e98fafba26752f625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911139Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc903818f301..92ac890fc48d git log fc903818f301..92ac890fc48d --date=short --no-merges --format='%ad %ae %s' 2019-11-12 andrewlamb@chromium.org Use 0o777 instead of 777 in replication_lib_unittest. 2019-11-12 vapier@chromium.org locking: fix under Python 3 2019-11-12 engeg@google.com chromite: update protos and generate for build api 2019-11-12 dburger@chromium.org Fix broken binhost_test.py. 2019-11-11 dburger@chromium.org Remove chrome-pfq and chromium-pfq configs. 2019-11-11 sanikak@chromium.org auto_updater: Restructuring Transfer Abstract Base Class 2019-11-11 andrewlamb@chromium.org replication_lib: Use copy2 instead of copyfile to preserve file metadata. 2019-11-11 andrewlamb@chromium.org Add replication_util, a CLI for replication_lib. Created with: gclient setdep -r src/third_party/chromite@92ac890fc48d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I639c3d994fb8596135503a8027b1d7f1f7d7b94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911489Reviewed-by:
-
Kuo Jen Wei authored
In former behavior, the CCA will only announce camera active after click on switch camera facing button. This CL integrate the announce logic into camera reconfiguration cycle and announce once the change of active camera used in preview. Bug: 1020239 Test: Navigate and toggle buttons related to stream reconfiguration by chromevox manually, see if the CCA announce as expected. Change-Id: I95656861f0d34c4bb3cc03e9f9df42952a5e1c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909677 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714435}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e33c1582b4bc..867f8c92ed1a git log e33c1582b4bc..867f8c92ed1a --date=short --no-merges --format='%ad %ae %s' 2019-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 31edef751a8d..9da287fd0264 (6 commits) Created with: gclient setdep -r src/third_party/angle@867f8c92ed1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: Id07e5645eef487937e2f006249a2fe6203ff7936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911686Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea1884b651e6..79d4f9950680 git log ea1884b651e6..79d4f9950680 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 ehmaldonado@chromium.org Reland "git-cl: Fix some python3 compatibility errors." 2019-11-11 ehmaldonado@chromium.org depot_tools: Add ehmaldonado to WATCHLISTS. 2019-11-11 ehmaldonado@chromium.org fetch: Fix GCLIENT_PY3 on Windows 2019-11-11 ehmaldonado@chromium.org git-cl: Fix error message when -B is not specified. Created with: gclient setdep -r src/third_party/depot_tools@79d4f9950680 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002209,chromium:939847,chromium:1018293 Change-Id: I44213620eebb7f63de388bb5faaf15d0d41ff4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911286Reviewed-by:
-
Colin Blundell authored
//components/resources is a group target that both generates the headers via grit and also generates the pakfile. The only reason that this direct dependency would be needed from the weblayer_lib target was if the files in weblayer_lib were including the grit-generated headers from //components/resources (making sure that the necessary resources are packaged in a given app is not the responsibility of weblayer_lib). However, they're not. Note however that //weblayer:weblayer_lib already has indirect dependencies on //components/resources (e.g., via //components/security_interstitials/content:security_interstitials_page), so this change impacts only logical clarity. Change-Id: I3898aa6d7bcc772af39983b8c1e9c164cbade752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906211Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#714432}
-
Noel Gordon authored
- renamed the input files to match the names of the existing volume PNG image icon files used in Files app - tested that these icon could be used as CSS -webkit-mask, or else filled with a CSS specified (fill/background) color - use <svg width="20" height="20" ... > everywhere - viewBox is 0 0 20 20 as a rule: however, two icons have 0 0 24 24 viewBox to be updated later by UX (computer.svg, shared.svg) - optimized using the SVGO in chrome/src with --precision 4 Bug: 992819, 1002393 Change-Id: Ibeb42bbcb490c4263d8944f1b0339b5cbeb986c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911346Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714431}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eab1e281fa5e..ad21d47cfa8d git log eab1e281fa5e..ad21d47cfa8d --date=short --no-merges --format='%ad %ae %s' 2019-11-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-11 bsalomon@google.com Clamp RGB outputs of GrYUVtoRGBEffect. 2019-11-11 herb@google.com Remove belongsToCache from SkStrike 2019-11-11 jlavrova@google.com Correct cluster index 2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e51ca8b81987..0e5f77218153 (1 commits) 2019-11-11 sgilhuly@chromium.org Roll Dawn, fix build issues in Skia Dawn 2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b118cb0ef477..e51ca8b81987 (1 commits) 2019-11-11 robertphillips@google.com Remove GrProgramDesc's need for the GrGpu 2019-11-11 mtklein@google.com add int3, vptest, jc Created with: gclient setdep -r src/third_party/skia@ad21d47cfa8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None,chromium:None Change-Id: Iea9987c350bb73f118760aca23b84b8130af8fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909815Reviewed-by:
-
Shik Chen authored
Bug: b:144320997 Test: Open CCA in video mode and check control.captureIntent is VIDEO_RECORD with metadata inspector. Change-Id: I7b7027aaf0f6f8d5cae71fa9301edb5eabd36c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911800 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#714429}
-
Anastasiia Nikolaienko authored
OnDialogClosed is also called during shutdown. Opening Settings at this point leads to a crash. Check that Chrome is not attempting shutdown before opening the window. Bug: 1018658 Change-Id: I99997e8d6cc7e83d3f8f1ad3be3b6c72b3c3c8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903365Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#714428}
-
Sara Kato authored
crrev/c/1159176/ removed usage of this function, but did not remove it. This CL performs clean up to remove this unused function. Test: none (clean-up) Bug: none (clean-up) Change-Id: I27294b205347df3f632c2842b87486ec132f4afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904553Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#714427}
-
Arnaud Mandy authored
Consolidating constant value of kMeanGravity by declaring it in src/base, instead of having it in many places in the code. Bug: 1020501 Change-Id: Ie52e05834530280528a8f126f4099deac5afeb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899373Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#714426}
-
Miyoung Shin authored
This change converts BeforeUnloadControl mojom interface client in components to use BrowserInterfaceBroker. Since MimeHandlerViewGuest is a WebContentsObserver, a static helper function is used to register its binder. Bug: 936482 Change-Id: If7d60be6d20307a11028ef5b682fa373cc8033b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895099 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714425}
-
Peng Huang authored
This CL adds VulkanInfo in GPUInfo, and then send it to browser process with GPUInfo. And it will be serialized to binary data and pass to about:gpu page for displaying. This CL adds a vulkan_types.mojom generated from vulkan header file. The structs in that files have many fields. It increases binary size. The increasing is expected. Bug: 887018 Change-Id: I2725326091ef47c3034939b3970d0e5bbaf6dc3f Binary-Size: Size increase is unavoidable (see above) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868832Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714424}
-
Jiajun Ou authored
The primary use case is to allow opening CWVWebView from WKWebView on window.open(). Background: https://docs.google.com/document/d/1IjJho7tGNp8azsA075VWBowrsi0m4lHAQarCvfF286I/edit#heading=h.bj843njsw7va Design doc: https://docs.google.com/document/d/1cVySp7_L-kRqP2Q_R3YrS8d7XsbVqTjUbb7UhIMni0k/ Change-Id: I95753c511affaa91f355cf9e75d336933850d854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864750Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Jiajun Ou <garzonou@google.com> Auto-Submit: Jiajun Ou <garzonou@google.com> Cr-Commit-Position: refs/heads/master@{#714423}
-
Oleh Lamzin authored
Use correct shill::kErrorResultNotSupported instead of NetworkDeviceHandler::kErrorNotSupported to handle failure to change USB Ethernet MAC address source. BUG=b:143695438 TEST=unittests TEST=manual verify on device that we handling correct error Change-Id: Ida9103e28857c795c33c7311509bce95fd2f5f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908540Reviewed-by:
-
Trent Apted authored
test_api.js depends on a bunch of JS libraries that appear in many lists. This CL consolidates those dependencies to two places: - js2gtest.gni, and - A JsTestApiConfig class declared in chrome/test/base/js_test_api.h Note not all lists captured the axs_testing.js dependency, but this change uses the same dependency list in all locations for consistency. TBR=aboxhall@chromium.org (mechanical change) Bug: 1000989 Change-Id: If6e0716c03e42783a2d3529baa70475a9d305045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900512 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#714421}
-
Kuo Jen Wei authored
Focus to play video/confirm button when entering video/photo review result page. Restore to camera view default focus when leave review page. Bug: 1020239 Test: Navigate entering/leaving review result page by chromevox and verify all related function works correctly. Change-Id: I784b08667bdfbaceb4e6c1956051801311a23199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906451 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3943.1-1572873357-benchmark-80.0.3961.0-r1 to 80-3904.92-1573478033-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I488e9588bfde8da09f0d6902c9440e50b983b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911152Reviewed-by:
-
Morten Stenshorne authored
When entering a child that establishes a new formatting context, we passed the wrong fragmentainer block-offset. We passed an initial estimate, even excluding margins. Positioning new formatting context children is complicated, and, in addition to the margin, there are things like floats and clearance to consider. Pass the block-offset of the layout opportunity when creating a constraint space for such a child. This means that we'll now (as a side-effect) force the BFC block-offset for all new formatting context children, but this seems harmless, and it does seem better than adding yet another parameter to CreateConstraintSpaceForChild(). Change-Id: I49256d7bd87f55088b72d27475d0d42e8d43c3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901070Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#714418}
-
Hirokazu Honda authored
Chromium should query a driver its supported H264 profiles. Thanks to this CL, Chromium can know the truly supported profiles in advance. Bug: 970152 Test: Check h264 profiles queried with driver patches Change-Id: Ib387fdd9d5e606fa58d3a0f67734b6e42aac12a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903240Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714417}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5eb17d38f7f7..c85c137c5de6 git log 5eb17d38f7f7..c85c137c5de6 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 thestig@chromium.org Roll third_party/icu/ 2ecd66c69..88ea42af7 (8 commits) 2019-11-12 thestig@chromium.org Roll third_party/zlib/ ddebad26c..f4f46747b (4 commits) 2019-11-12 thestig@chromium.org Roll third_party/libjpeg_turbo/ 38c693569..bc1357852 (2 commits) 2019-11-12 thestig@chromium.org Roll third_party/depot_tools/ e90e5fe20..79d4f9950 (165 commits; 37 trivial rolls) 2019-11-12 thestig@chromium.org Roll third_party/catapult/ 830565958..3992f6564 (132 commits) 2019-11-12 tsepez@chromium.org Add embedder tests using page rendering flags. 2019-11-12 tsepez@chromium.org Add command line flags to pdfium_test for rendering flags. 2019-11-11 thestig@chromium.org Roll third_party/freetype/src/ 5a1a79c0e..3aaae716b (7 commits) 2019-11-11 awscreen@chromium.org [FXCRT] Fix overflow for CFX_FloatRect::GetOuterRect() 2019-11-11 tsepez@chromium.org Remove unused private RENDER_* definitions. 2019-11-11 tsepez@chromium.org Remove unused CBC_ReedSolomonGF256Poly::Multiply() (scalar form) Created with: gclient setdep -r src/third_party/pdfium@c85c137c5de6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1019026 Change-Id: Ic79a822205650bc42b3aa7a9b872200a64fa2537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910785Reviewed-by:
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetWebRtcWorkerThread directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. [1] https://crrev.com/c/1805159 Note that to match the actual return type (base::SingleThreadTaskRunner) the PCDF method is renamed to GetWebRtcWorkerTaskRunner(). BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I56d4dd2720150cd86a85d98c8cfae1dfd9c711ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806846 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3943.1-1572866479-benchmark-80.0.3961.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I35fdb8f7241fc0e4c8e6670866bdf6f7bc6ac0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911151Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/64e07f445a10..8cbb33c0d04b git log 64e07f445a10..8cbb33c0d04b --date=short --no-merges --format='%ad %ae %s' 2019-11-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e2cf3bc0..38612283 (714186:714324) 2019-11-11 terelius@webrtc.org Simplified throughput estimator 2019-11-11 mbonadei@webrtc.org RTC_EXPORT RTCStatsMember::StaticType and VideoFrame::Builder. 2019-11-11 yvesg@webrtc.org Expose NetEqDecodingTest for re-use in chromium tests. Created with: gclient setdep -r src/third_party/webrtc@8cbb33c0d04b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1002973 Change-Id: I62353011af23116b741dd7871bc69a845eed478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910747Reviewed-by:
-
Ben Joyce authored
This is necessary for androidx.browser. Androidx.browser provides the Android APIs that allow us to support Custom Tabs and Trusted Web Activities - it's basically the new version of custom_tabs_client. Since androidx.browser is an Android API, it must adhere to their API guidelines, which involves using ListenableFuture instead of accepting Callbacks(see b/138381050) Bug: 1016484 Change-Id: I1f0dde3533b6b03c5976ea85397d25e509600917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872642Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Kazuki Takise authored
We want to control the visibility of a window in overview mode from the Android side. The actual scenario we have so far is: We want to hide the Netflix home (non-video) window if the video is in PIP mode because selecting the Netflix home window in the alt-tab cycler kills PIP, which is a bit confusing and may not be the user's intention. See b/129367828 for more details. BUG=b:143789289 TEST=PIP'd Netflix and confirmed the netflix home window is not listed in the alt-tab cycler. Change-Id: Iee4aac66c54646972a030cf3a00a138cf5762896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905302 Auto-Submit: Kazuki Takise <takise@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
-
Olivier Robin authored
These files include test code that triggers presubmit warning. As these files will never be compiled in the prod application, exclude them from these tests. Change-Id: I00f58dd9a3510617485ba655009307a8d6c95dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906209Reviewed-by:
-
Kuo Jen Wei authored
ResolutionEventBroker was designed for aggregating a set of resolution related callbacks passing to all deep nested resolution related components. After several refactor works, all resolution related function will be moved into ConstraintsPreferrer and this broker is no longer needed. Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I92f0b22b4d645155862f506347752d48e8b63714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883470 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
