- 30 Jan, 2015 40 commits
-
-
scottmg authored
Adds functionality to create_installer_archive.py to generate a .d file that includes all of the files that it packages into chrome[.packed].7z. This is done by tracking the source of all the files that are copied into the staging dir that is given to 7za to package the .7z file. The depfile is then used in a gyp 'depfile' to correctly specify the implicit dependencies for the mini_installer target. Previously it used a fake output of 'xxx2.out' to cause it to rebuild every time (which is what we're trying to avoid in this change). Additionally, switch from a rule to an action in gyp -- gyp currently only supports 'depfile' on actions, and as there's only one file being built here, they're equivalent. BUG=342974,451499 Review URL: https://codereview.chromium.org/887673003 Cr-Commit-Position: refs/heads/master@{#314015}
-
bnc authored
This CL changes the argument of GetCanonicalSuffix() from HostPortPair to std::string (both const&) to better document the fact that GetCanonicalSuffix only operates on that field. BUG=392575 Review URL: https://codereview.chromium.org/868753007 Cr-Commit-Position: refs/heads/master@{#314014}
-
kkimlabs authored
- Top level folders are now all the sub folders of Bookmark Bar, Mobile, and Others nodes. - We no longer use Uncategorized. BUG=453024 Review URL: https://codereview.chromium.org/869193008 Cr-Commit-Position: refs/heads/master@{#314013}
-
ariblue authored
BUG=452266 Review URL: https://codereview.chromium.org/887763003 Cr-Commit-Position: refs/heads/master@{#314012}
-
xunjieli authored
This CL implements the following four methods: - getHeaderFields() - getHeaderField(String key) - getHeaderField(int pos) - getHeaderFieldKey(int pos) BUG=398997 Review URL: https://codereview.chromium.org/784853004 Cr-Commit-Position: refs/heads/master@{#314011}
-
morrita authored
Without this, ChannelMojo doesn't work. R=inferno@chromium.org, tsepez@chromium.org TBR=jamesr@chromium.org BUG=453571 Review URL: https://codereview.chromium.org/867903006 Cr-Commit-Position: refs/heads/master@{#314010}
-
jbauman authored
If the bitmap wasn't allocated, return false instead. BUG=411505 Review URL: https://codereview.chromium.org/879143002 Cr-Commit-Position: refs/heads/master@{#314009}
-
scottmg authored
Avoids ninja expecting an import .lib to be generated so that it doesn't continually rebuild because the import lib is "missing". To be landed after gyp roll at https://codereview.chromium.org/890043003/ lands. R=robertshield@chromium.org BUG=342974,451499 Review URL: https://codereview.chromium.org/886123002 Cr-Commit-Position: refs/heads/master@{#314008}
-
felt authored
This updates the permission prompt (infobar and permission bubble) icons with the new icons provided by sgabriel@: https://drive.google.com/a/google.com/folderview?id=0B-Vmdj5n- YddWktRd1BMeHZYWWs&usp=sharing BUG=451490 Review URL: https://codereview.chromium.org/893603003 Cr-Commit-Position: refs/heads/master@{#314007}
-
sdefresne authored
ScheduleAndForget is a thin wrapper around ScheduleTask that hides a base::Bind() call and passing the HistoryBackend pointer as the first parameter. As they are templated function, they prevent splitting HistoryService into a pure virtual interface and a implementation interface that would improve the componentization velocity. BUG=370850 R=droger@chromium.org Review URL: https://codereview.chromium.org/865443005 Cr-Commit-Position: refs/heads/master@{#314006}
-
fsamuel authored
For GuestView types in the browser, such as <webview> in WebUI and <extensionoptions> in WebUI, we would live status messages to appear in the browser. This CL plumbs that information out to the embedder. ContentsMouseEvent, LoadingStateChanged, and UpdateTargetURL are calls out to the content embedder that are used by Browser to update status indicators such as the spinner, and status text. This CL plumbs those calls out from the guest to the embedder. This is a bit racy because guest status and embedder status can interleave but that's OK because these status texts are transient and eventually they'll settle and disappear so there's no long lasting raciness of consequence. BUG=453216 TBR=lazyboy@chromium.org Review URL: https://codereview.chromium.org/880983006 Cr-Commit-Position: refs/heads/master@{#314005}
-
mathp authored
No longer rely on DidFailProvisionalLoad, solving other issues. Includes a rename of URLRequestMockHTTPJob::AddUrlHandler BUG=373455 TEST=NewTabPageInterceptorTest Review URL: https://codereview.chromium.org/845973005 Cr-Commit-Position: refs/heads/master@{#314004}
-
meacer authored
This CL adds Wi-Fi SSID to the captive portal interstitial on Mac and Linux, if the connection is Wi-Fi. WiFiService isn't available on other platforms, so we will be using other mechanisms such as NetworkChangeNotifier on those. BUG=451272 Review URL: https://codereview.chromium.org/887573002 Cr-Commit-Position: refs/heads/master@{#314003}
-
alexclarke authored
This is needed to make the webkit_unit_tests pass when the HTML parseing tasks are posted on the loading task queue. Required for patch https://codereview.chromium.org/876623002 BUG=391005 Review URL: https://codereview.chromium.org/878413002 Cr-Commit-Position: refs/heads/master@{#314002}
-
pmeenan authored
This is in preparation for adding preconnect support which goes through the same underlying plumbing. dns_prefetch was too restrictive of a component name and was only exposing the single method. There are no functionality changes in this CL, just the rename (the namespace was also renamed) BUG=450682 Review URL: https://codereview.chromium.org/848303005 Cr-Commit-Position: refs/heads/master@{#314001}
-
scottmg authored
r2030: win: Add NoImportLibrary flag for ninja generator TBR=grt@chromium.org BUG=451499 Review URL: https://codereview.chromium.org/890043003 Cr-Commit-Position: refs/heads/master@{#314000}
-
scheib authored
BluetoothDispatcherHost is extended to supply all the attributes of the BluetoothDevice web API. Also, add device::BluetoothDevice::VENDOR_ID_MAX_VALUE for use in the IPC message. Depends on https://codereview.chromium.org/882223002/ to define new attributes on WebBluetoothDevice, and will not be visible to script until https://codereview.chromium.org/876623003/ BUG=438305 Review URL: https://codereview.chromium.org/885723002 Cr-Commit-Position: refs/heads/master@{#313999}
-
jsbell authored
The IDB implementation uses journals to track blob files which are to-be-written or to-be-deleted so that the files can be cleaned up following a crash or abort. The journal records are updated as part of a two-phase commit, and during database deletion. The journal updates and cleanups incorrectly assumed that only one transaction could commit at a time per backing store, so the first phase of a second transaction could inadvertently "clean up" the in progress work by a previous transaction, resulting in missing files. Untangle this and ensure that (1) transaction commits only append/remove journal entries, not the entire journal, and (2) changes outside transactions are deferred if transactions are running. R=cmumford@chromium.org BUG=447836 Review URL: https://codereview.chromium.org/865013002 Cr-Commit-Position: refs/heads/master@{#313998}
-
mef authored
BUG=441466 Review URL: https://codereview.chromium.org/890893006 Cr-Commit-Position: refs/heads/master@{#313997}
-
xunjieli authored
UploadTestServer was originally intended for testing uploads. This CL renames it to NativeTestServer, since it has been used as a general test server. BUG=452643 Review URL: https://codereview.chromium.org/873593006 Cr-Commit-Position: refs/heads/master@{#313996}
-
meacer authored
The SSID is going to be displayed in the captive portal interstitial as such: "The network you are using (Google Guest)..." BUG=451272 Review URL: https://codereview.chromium.org/880143003 Cr-Commit-Position: refs/heads/master@{#313995}
-
mstrum authored
Manual verification of the mapping was done using: http://www.html5rocks.com/en/tutorials/doodles/gamepad/gamepad-tester/tester.html This also adds tests to check for mapping regressions for all gamepads. BUG=453178,373942 TEST=GamepadMappingsTest Review URL: https://codereview.chromium.org/875813003 Cr-Commit-Position: refs/heads/master@{#313994}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/f76ca40..ae50934 TBR=junov@chromium.org,vsevik@chromium.org Review URL: https://codereview.chromium.org/889573004 Cr-Commit-Position: refs/heads/master@{#313993}
-
davidben authored
Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/a87de9b..be629e0 BUG=none Review URL: https://codereview.chromium.org/890893005 Cr-Commit-Position: refs/heads/master@{#313992}
-
mad authored
BUG=None Review URL: https://codereview.chromium.org/890793004 Cr-Commit-Position: refs/heads/master@{#313991}
-
jmadill authored
BUG=450673 R=kbr@chromium.org Review URL: https://codereview.chromium.org/881873003 Cr-Commit-Position: refs/heads/master@{#313990}
-
mkearney authored
This test should pass, allowing extensions/index to redirect to extensions. Review URL: https://codereview.chromium.org/886903002 Cr-Commit-Position: refs/heads/master@{#313989}
-
rch authored
Review URL: https://codereview.chromium.org/890883004 Cr-Commit-Position: refs/heads/master@{#313988}
-
dfalcantara authored
* Makes it so that infobars hide when scrolling the page and return at the top of the page. * SwipableOverlayView is now the base class of InfoBarContainer and now extends from ScrollLayout. * Adds way to disable the SwipableOverlayView from being swiped away. * AppBannerView (which is going away soon) is adjusted to account for the new ScrollLayout requirement of having only one child. BUG=453170 Review URL: https://codereview.chromium.org/893483002 Cr-Commit-Position: refs/heads/master@{#313987}
-
felt authored
The permission request text fragments (shown in permission bubbles) should have consistent capitalization and punctuation, in the format: * Foo * Foo and bar * Foo bar Also renames "Desktop notifications" to "Notifications." BUG=451490,453902 Review URL: https://codereview.chromium.org/891643002 Cr-Commit-Position: refs/heads/master@{#313986}
-
mef authored
Review URL: https://codereview.chromium.org/890043002 Cr-Commit-Position: refs/heads/master@{#313985}
-
rockot authored
BUG=451321 Review URL: https://codereview.chromium.org/880613005 Cr-Commit-Position: refs/heads/master@{#313984}
-
dnicoara authored
SetDisplayPower() is called by powerd to turn the panel on. After that powerd will set the backlight level. Since DisplayConfigurator may be executing the SetDisplayPower() operation asynchronously, the panel may still be off when powerd tries to set the backlight level. So powerd's operation would be ignored by the driver. BUG=chrome-os-partner:35662 Review URL: https://codereview.chromium.org/886103002 Cr-Commit-Position: refs/heads/master@{#313983}
-
mlamouri authored
This is also adding some logic about empty and invalid ServiceWorkerClientInfo. BUG=450634 Review URL: https://codereview.chromium.org/871013003 Cr-Commit-Position: refs/heads/master@{#313982}
-
spang authored
This creates a new thread for polling evdev on, and moves the InputDeviceFactoryEvdev object onto that thread. We'll use this new thread to avoid UI-thread jank affecting the cursor. BUG=449710 TEST=boot link_freon & move cursor with simulated UI jank. cursor moves while UI thread is stalled. Review URL: https://codereview.chromium.org/873833002 Cr-Commit-Position: refs/heads/master@{#313981}
-
jeremyim authored
This instance will be created by the DataReductionProxySettings class, and take ownership of the DataReductionProxyParams (currently owned by DataReductionProxySettings). BUG=452773 Review URL: https://codereview.chromium.org/880963006 Cr-Commit-Position: refs/heads/master@{#313980}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#313979}
-
sergiyb authored
BUG=426897 R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/800013002 Cr-Commit-Position: refs/heads/master@{#313978}
-
stanisc authored
This change prepares the client to deal with implicit permanent folders in Sync server updates. That includes the following: - Expect type root folders to not come from the server on the initial sync. The client auto-creates type root folders for all types except Bookmarks and Nigori when progress marker changes from empty to non-empty. These folders are created as local nodes (with client IDs) that aren't expected to sync back to the server. - Expect empty parent IDs in updates for both new and existing items. - Because the client code updates first, the client must expect server to override locally created type root folders. To enable that the directory update code that matches update entities to local entities was updated to look at server unique tags in addition to client unique tags. Later when the server stops generating folders we should be able to remove that code. - Added some extra special cases in Directory::CheckTreeInvariants to deal with client side created type root folders. - Added / modified a few tests to cover cases with implicit parent IDs in updates. BUG=438313 Review URL: https://codereview.chromium.org/867793003 Cr-Commit-Position: refs/heads/master@{#313977}
-
thakis authored
Apparently nobody has tried to run them locally in months. BUG=452130 TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/876633004 Cr-Commit-Position: refs/heads/master@{#313976}
-