- 21 Sep, 2020 40 commits
-
-
Anastasiia N authored
Update ProfileOAuth2TokenServiceDelegateChromeOS to return nullptr and use AccountManager's URLLoaderFactory in CreateAccessTokenFetcher() instead of using the one which is provided in parameters. Bug: 1119401 Change-Id: I1a02c1167f808144d83327762b8f3ba7fb5d19ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369092 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#808817}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e627a7fbb803..101b41c4cb7e 2020-09-21 wolfi@chromium.org Turn link icon into mask If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1072335,chromium:1122511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I257fdff0822fe802c67a0aa906baa1a72ba96c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808816}
-
Rahul Goyal authored
This CL adds a new onboarding informational text for two new intents. Bug: b/168690281 Change-Id: I518273c372a8ac36e6a76dd08f324b7f086368e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419012Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#808815}
-
Mahmoud Gawad authored
Add UMA stats for the success / failure of: GenerateECKey, GenerateRSAKey, SignECKey, SignRSAKey. These operations belong to PlatformKeysService. Bug: 1128332 Change-Id: Ic7418d9578ac22d5537555cad21f0d56cd1418d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416454 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808814}
-
Kushagra Sinha authored
Set per-file ownership of: - chrome/browser/ui/webui/signin/inline_login_handler_impl.{h,cc} - chrome/browser/ui/webui/signin/inline_login_dialog_chromeos.{h,cc} to the OWNERs of Chrome OS Account Manager. Fixed: 1129352 Change-Id: Iff179cef7daa8a405ba5c0c81940559aa10c4da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416448Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#808813}
-
Matthias Körber authored
This CL adds the structured address representation into the AutofillProfile and implements functions to test the mergeability, invoke the merging and return the structured address tree. Bug: 1128367 Change-Id: I0c8704c49b59170261359478b03208f072ee83ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418409Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#808812}
-
Irina Fedorova authored
This CL adds GetWeakCredentials, OnWeakCredentialsChanged, addWeakCredentialsListener and removeWeakCredentialsListener functions to provide the ability to use weak credentials in the UI. This CL updates the StartPasswordCheck in password_check_delegate to also check credentials for weakness. Bug: 1119752 Change-Id: I4bfee58ddebda551e41e3833792051527a41beb9 Tbr: rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414271 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#808811}
-
Tim Song authored
Given the PhoneHub notification data, this CL fills in the created CrOS corresponding notification's details: * timestamp * icons and images * priority * inline reply button Screenshot: https://screenshot.googleplex.com/8bhJVzvqFmPcufT.png BUG=1128091,1106937 Change-Id: I82d64c1bb01235bb1dc64fab0b29cd00b3bef1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418557 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808810}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/50ae4c5f4427..60ce96e2ff10 2020-09-18 afdx@google.com spirv-fuzz: Add pass recommendations (#3757) 2020-09-18 stefanomil@google.com spirv-fuzz: Consider all ids from dead blocks irrelevant (#3795) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC syoussefi@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: syoussefi@google.com,radial-bots+chrome-roll@google.com Change-Id: Ia0b9d05a357f7032fc2f115c0cfd730f2f7779d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421170Reviewed-by:
-
Boris Sazonov authored
Modifies logic for the signed out state: X-Chrome-Connected with eligible_for_consistency is now sent to Gaia URLs only. This only affects Android and iOS with MobileIdentityConsistency flag enabled. Bug: 1129777 Change-Id: Ib702f0efabeb926f45b553841a6690c384f1187e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418576 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#808808}
-
Christian Dullweber authored
There are lots of setting specific methods in WebsitePreferenceBridge that have no special logic. Merge them into one method. Change-Id: I402b529b2ac702922e52e9910e4d6f454406627d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410409 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#808807}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c1248064f2d..431ce7786b0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC elklm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: elklm@google.com Change-Id: I5d7d507bc6bb74d3193d77a8289152dcf6cd685b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421174Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808806}
-
sandromaggi authored
The condition has shown to be stable enough that the bailout can be removed. Bug: b/159309621 Change-Id: I4d66174ac0fd2c117d31aa81303b2d2ee1e7cf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414179Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#808805}
-
Jan Wilken Dörrie authored
This change modifies the WellKnownChangePasswordNavigationThrottle to only be instantiated for navigations that were triggered from Google UI. This includes native UI on Android that starts Chrome in a CCT via an API call, or links clicked on passwords.google.com or chrome://settings. Bug: 1129323 Change-Id: I0addfba9d187d35297d9843fae1e79ac6ed8e788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416275 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifb89fd343d5ac8189bb3171f533c0d1b77ba0892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419721Reviewed-by:
-
Palak Agarwal authored
Bug: 1128167 Change-Id: Ic79945517ee854a18788f08efe1686707086354b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418399 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#808802}
-
Tanmoy Mollik authored
Update sync error summary for sync_setup_incomplete error. Also update the strings for the error card that is shown for this error. Update the summary message on the sync row in main settings page when sync is requested off. Screenshot: https://crbug.com/1129813#c1 Bug: 1129813 Change-Id: I42082ab8f7976104e68c43b26529b0c99adebf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418444Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808801}
-
Omar Morsi authored
Bug: 1056550 Change-Id: Idafa91e74cd7707632dbeaaaa0a27b448ae92719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416372Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808800}
-
Victor-Gabriel Savu authored
Bug: chromium:1125660 Change-Id: I74db1c53cc125489babbaf254841e21cee2fe014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416589Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#808799}
-
Martynas Sinkievic authored
Accidentally added this bug in CL#2377727, probably failed at fixing a merge conflict. Bug: 1129697 Change-Id: I69438cebe7051bbdf1f9cec26b103a3530133c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418575Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#808798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/244d77022cb2..e0244d9798ab 2020-09-21 tandrii@google.com Roll lucicfg tool to @ 8803da5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1119883 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia126f39b62beb02f7d22ecec331920a1ba3a2e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421095Reviewed-by:
-
Henrik Boström authored
When we are encoding the same MediaStreamTrack multiple times there is a race that causes VideoStreamEncoder to crash. To aid debugging, this CL adds WPT test coverage for it. Bug: webrtc:11485 Change-Id: I0cb2b1b1528521755c18d5c6117b60fc053480dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418376 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#808796}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600624217-98a19371068d023c49f8bc861690590aa8a6e095.profdata to chrome-mac-master-1600667868-753d2e8ebb132428b671d1eab55299188459911c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I14c4a2760e8d706e64b39cb1884a3cb4c06d7f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421092Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I8fc2730ee8324d24eea96033d2a15fc38064d05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421208Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808794}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600638747-b39109ce7bdab703631e0bd6b8da0918c8493b27.profdata to chrome-linux-master-1600667868-1426c4c889ab6f1601c0d673866dfd0987cca740.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I7098143a15ad0ab0b8840194691563f4b15579c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421168Reviewed-by:
-
Joel Riley authored
Select-to-speak will re-order SVG children nodes by reading order based on position, instead of DOM order. SVGs have no concept of reflow, but are instead absolutely positioned, so DOM order can easily be out of sync with visual order. Re-order logic will keep original groupings intact (nodes within SVG <g> element), as these groupings can be semantic in nature, for instance, columns of text. Note: This is LTR only for now. AX-Relnotes: Select-to-speak will read SVG content in LTR reading order on ChromeOS. Example SVG content is Google Slides. Bug: 892822 Change-Id: Ia9092557442451b52c8ac4d10643cf720dc8d3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391266 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808792}
-
Joel Hockey authored
crostini.BackupRestore tast test is failing due to failing to share the backup file, so adding more context to log message to help debug. Bug: 1130412 Change-Id: I6e1e2e33044532d7acd2b8695f9411b5d8f8265c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418529 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#808791}
-
Andrei-Laurențiu Olteanu authored
Rename GetAvailableRoutines test to comply with other diagnostics tests. Bug: b:168793232 Change-Id: I9e18b091859c1b711ab0f528c901a964c3771888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416493 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#808790}
-
Rainhard Findling authored
* This is a follow-up to crrev.com/c/2328669 with further fine tuning from findings in https://crbug.com/1103844#c22. * The current translation screenshot presubmit check flags modified messages: 1) if the message does not yet have a screenshot, or 2) if the message content itself changed. * This CL changes the behavior to for modified messages check in this order: 1) if the message content itself changed -> flag the message. 2) if the message meaning changed and there is neither an existing screenshot nor is a new one added with the CL -> flag the message. * Important cases to consider: messages that don't yet have a screenshot and for which only the message meaning attribute changed will require a screenshot, but messages for which only the message meaning changed and which already have a screenshot do not require a new screenshot. And messages of which only the description attribute changed simply never require new screenshots at all. Bug: 1103844 Change-Id: I0318e685b2182a455dccfb0630ce768f5c990a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412727Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#808789}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e660dd467bc..d970d657aa56 2020-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8d4331eeb5ea to 48588bd1810d (27 revisions) 2020-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 33c87dad to 688a0b34 (560 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:895969 Tbr: csmartdalton@google.com Test: Test: Test: CQTest: Test: DrawCallPerfBenchmark.Run/vulkan_attrib_changeTest: Test: DrawCallPerfBenchmark.Run/vulkan_null_attrib_changeTest: Test: angle_unittests with --bot-mode, sharding, and filter Change-Id: Id9e40cdb633f3d805719aac64e4eb06661bbc813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421002Reviewed-by:
-
Thomas Lukaszewicz authored
This CL adds a missing data source needed by Tab Search WebUI to use favicon2 resources. This fixes loading issues for all profiles non off the record profiles. Bug: 1099917 Change-Id: I20b8f709580fcab544726e546c06a7cdc020f638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419390 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808787}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600638747-34240090420db5fc9f2f60b0a6a352b993266e44.profdata to chrome-win64-master-1600656338-a4c2e29456479f7c103840465e0fb2a2783db828.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd89e174e217f47fb88247ebe3692065d37bcd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420991Reviewed-by:
-
Changhao Han authored
Currently we're enabling CSS Grid experiment by default, which creates small differences in layout test expectations. Since Grid feature is still experimental, we will postpone updaing the expectations and instead skip Grid-related logic in these two tests for now. This change will unblock the frontend change: https://crrev.com/c/2416525 Bug: chromium:1047356 Change-Id: Ic0a26b17b09d13889ad0bcfafa6879b21089c2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418315 Commit-Queue: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808785}
-
Maggie Cai authored
Currently I spotted couple of cases where there is preferred app stored in the PreferredApps file but has empty app id. I cannot consistently reproduce this but both cases happened to an Android app. In addition to this, the GetAppIdByPackageName is the only place in the code that is possible to introduce an empty app id as far as I can found. Add a skip and ERROR log to avoid the scenario and hopefully help to debug this issue and fix it properly. BUG=853604 Change-Id: I6ae0d338fff8141f2c3748ee810f62d05f7e6d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418512 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#808784}
-
chrome://media-appTrent Apted authored
Current sort order is by modification time, which means mixed photos and videos from the camera app always "get older" when pressing right. However, feedback suggests this is confusing when opening the gallery from the files app. Sorting by name instead is more likely to match the sorting field in the files app, and consistent with what the old gallery app did. The order defaults to reverse-lexicographic so that pressing "right" still goes to older files from the camera app. Bug: b/169012791 Change-Id: I2240ca022519a52f04cd5c1ca1f42f29d014a6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419099 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#808783}
-
Lei Zhang authored
Change-Id: I2b3896dd2cec65ef9623a2f97766b5d296637068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419535Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808782}
-
Zufeng Wang authored
If you go to a app that uses message pipe (e.g. the inner frame of media_app) and run: window.parent.postMessage('something', '*') You get an error: "Uncaught TypeError: Cannot read property 'substr' of undefined" This happens because message pipe intercepts all postMessages and tries to handle them. This CL makes message pipe ignore messages where event.data.type isn't a string. This change is to help with migrating help app to use message pipe -- to prevent the existing postMessages from causing errors. http://crrev.com/c/2405044 Bug: b/166043485 Change-Id: Ia66259bd4de542d628228282503c1d00a51d3e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413650 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#808781}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/822d3abc1392..8e660dd467bc 2020-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d6498a41ab4e to dcd37fa4f476 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I6fd3abc58b62c76930bb1f57ecc4b833a4eb187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420993Reviewed-by:
-
Andreas Haas authored
V8 uses a signal handler to implement memory bounds checks for WebAssembly. Therefore signal handler have to be allowed in all V8 fuzzers. R=ochang@chromium.org Bug: chromium:1127927 Change-Id: Ieb43e384879cd8fdfbbcaf59b16f4f66d626bfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410485Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#808779}
-
Yunke Zhou authored
Bug: 1122954 Change-Id: I94856a1379c6b04d28cd464bf6c7b326ab019934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396215 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808778}
-
