- 28 Oct, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
Bug: 1001038 Change-Id: I08747c6a733ac42bd564f985e3f9ad52478ce210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879207Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709870}
-
Kazuhiro Inaba authored
RestartArcSession() can reuse the upgrade_params_ data that was previousely set. Moving the content is not appropriate. BUG=b:143439620 BUG=b:142144019 BUG=b:143092860 TEST=ArcSessionRunnerTest.Restart TEST=`adb reboot` successfully restarts the ARC container. Change-Id: Ie7a9254e03de29efde94a4a8918e80a1b871471c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883427Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#709869}
-
Yuki Shiino authored
It turned out that some of SymbolDefinitionNodes need to be followed by UnlikelyExitNode just like the following example, so this patch makes SymbolDefinitionNode inherits from SymbolScopeNode so that a definition can consist from multiple CodeNodes. Example: const auto& return_value = F(exception_state); if (exception_state.HadException()) { return; } A symbol definition of |return_value| needs to be followed by UnlikelyExitNode to return early if an exception is thrown. Note that SymbolNode is just moved and should have no code change. SymbolDefinitionNode is updated accordingly. Bug: 839389 Change-Id: I65e2f730084ad5018c2521ea0826c058910d153b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882253 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#709868}
-
Mark Cogan authored
This is the third CL of several breaking crrev.com/c/1860025 into smaller chunks. This just plumbs a Browser into the signin promo classes. Change-Id: Ie059a52ea81e801a1d5d1cfe59940b3faffed6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863026Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#709867}
-
Arthur Hemery authored
We are now always using the NavigationClient to commit a successful navigation or an error page. We update all the "commit calling" stack to reflect that. One important exception to note is committed interstitials, that commit without a NavigationRequest. This prevent us from fully removing the old FrameNavigationControl::CommitNavigation path. Bug: 784904 Change-Id: Ife819ed0d2274630939323ad21863c354229a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819242Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#709866}
-
Olya Kalitova authored
Propagates CrostiniAnsiblePlaybook policy value to CrostiniManager so playbook applied to the default Crostini container during its startup is the one specified by policy. Test: unit_tests --gtest_filter="Crostini*" Bug: 973793 Change-Id: I680faa6e3d570eab502d797633a39a12b8a3d6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879298 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709865}
-
Yves Gerey authored
* single_user_demo_mono_16kHz.pcm was never used, apparently. * speechmusic_mono_16kHz.pcm was only referenced by one test, which was removed here: https://codereview.chromium.org/194813002 TEST=content_unittests Bug: chromium:331030 Change-Id: I4b77c264729db411d38f5d0568496cb76a2ce4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882308Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#709864}
-
Yuki Shiino authored
It turned out that duplicated SymbolDefinitionNodes emit unnecessary newlines and it makes the code ugly. This patch removes duplicates. Bug: 839389 Change-Id: I1a319f18457eb77a847f0131ae65d2e187205687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882248Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/076f869ce5ac..225301d6dc53 git log 076f869ce5ac..225301d6dc53 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f44f7c066a67..1737a30e3e34 (1 commits) Created with: gclient setdep -r src/third_party/angle@225301d6dc53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I4c7ce95eea1c980a56a4744a922a2bf0fc711e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709862}
-
Adam Rice authored
Previously the Transform() and Flush() methods of TransformStreamTransformer returned void. This meant that there was no way for them to wait for asynchronous work to finish. Change the function signatures to return ScriptPromise. Transform() or Flush() won't be called again until the returned promise is settled. Returning v8::Local<v8::Promise> would have been slightly more efficient, but ScriptPromise was used for consistency with UnderlyingSinkBase and UnderlyingSourceBase. Add tests that Transform() and Flush() promises are actually waited for. BUG=962837 Change-Id: I2e79c6a79a457fd021eee17eca4f1502c3aa521f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865735Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709861}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLSpanElement> and DynamicTo<HTMLSpanElement> as new downcast helper 2. Use IsA<HTMLSpanElement>(element) in place of IsHTMLSelectElement(element) Bug: 891908 Change-Id: If2150ecebb45b7dd6dd78682ffac47eb60372c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878269Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#709860}
-
Tim van der Lippe authored
Change-Id: I567141992ec4a9269068c03a1798f2561dba24f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879946 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709859}
-
Yuki Shiino authored
Renames CodeGenerationContext.property to |property_| in order to avoid conflict with the built-in property function. Also adds more utility properties. Bug: 839389 Change-Id: I166374af1d3dc451b1e783d873f61f5b6aa48c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882188Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1f6fbe1. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iabab2e29d81fac05ed33609c1de3208a5213c501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882935Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709857}
-
Marina Sakai authored
Function inlining of the GetSymbol function using SymbolKey instance as a key is not negligible because that might bloat out code size especially with the Android compiler. This CL prevents function inlining of the GetSymbol function by defining it in v8_private_property.cc. Bug: 715418 Change-Id: I73aa068ee71802ed4b0ebf001d846520ae13be08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880900Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The tests are flaky across multiple buiders. While the underlying issues are investigated, let's disable them all. TBR=mmoskvitin@chromium.org Bug: 1012222,1012223,1009372 Change-Id: I0375dc684547d3fd927521f25898bd26514f4723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883647 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709855}
-
Sergio Villar Senin authored
In order to remove the WebContextMenuData dependency from chrome/browser we need to extract all the data types used in c/b from web_context_menu_data.h and move them to different files under third_party/blink/public/common. This is the first step of those migrations. We took the chance to convert the WebContextMenuData::MediaType into a strongly typed enum class. In order to keep the amount of changes under control we are adding an alias (using MediaType = ContextMenuDataMediaType) to the new structure so that no additional changes are required. A follow up patch will remove that alias and perform the renames. Bug: 1014517 Change-Id: I33a351a81eec1e0a7c09d783859f8078a5355778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866520Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#709854}
-
Pavel Shmakov authored
Change-Id: I8cb125cf9ee2d2f72ba22f498248dd5fa6fd5c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865334 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709853}
-
Oleg Davydov authored
ExceptionCacheFake class don't have dependencies in chrome/ and can be useful in tests in extensions/. Bug: 1015817 Change-Id: I91613840fa5c6f5cc2543157be3ef11997aadaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879262Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#709852}
-
Mathias Carlen authored
Before this patch, all potential direct actions were reported unconditionally. The fetch_website_actions direct action is only required to bring up the AA stack and fetch/check for scripts once. This patch ties this filtering to the controller being up and ready and the first round of scripts has been checked for matching preconditions. This will give external callers a better signal as to when AA is up to date and when it needs to be setup first before being able to execute actions. Bug: b/138833619 Change-Id: I8acb0c7ea7937a0cbafe1462e92251c29153b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879911 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709851}
-
Greg Thompson authored
Tests using BackgroundFetchDataManagerTest::MatchCache inadvetantly held files in the profile dir open beyond the lifetime of the test function, inhibiting ScopedTempDir's ability to clean them up during TestBrowserContext destruction. This change causes MatchCache to wait until the main RunLoop goes idle, thereby allowing for residual tasks to be posted and run upon destruction of the response given to DidMatchCache. BUG=546640,1016662 Change-Id: I4e2a989ec2b744b61b75e3ba2d09270c0eab3c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882310Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709850}
-
Olya Kalitova authored
Adds CrostiniAnsiblePlaybook cloud user external policy that allows to specify Ansible playbook file that should be uploaded to default Crostini container during container startup. Based on: https://crrev.com/c/1800310 Bug: 973793 Change-Id: I756e1e6ff12a14830c19170c723587b95ce30a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872061 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#709849}
-
arthursonzogni authored
This reenable: - SignedExchangeRequestHandlerBrowserTest.Simple - SignedExchangeRequestHandlerBrowserTest.VariantMatch Histograms in this file are recorded when the RenderFrameHost is deleted. This is triggered by a navigation. The problem is that the deletion is never synchronous and the test wasn't waiting for this. To fix this, wait for any RenderFrameHost to be deleted before checking the histograms. Along the way, flush the BackForwardCache to release the remaining RenderFrameHost Bug: 1016865, 965925 Change-Id: Icc0c26baf9b0e0d7f539eec1ed1e53f1e0d49ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878770Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709848}
-
Yngve N. Pettersen authored
root output directory is actually located. The existing fixed paths assumed the out dir is located in the chromium src directory. Downstream projects may have their out directory located elsewhere, for example in the chromium src dir's parent dir. This CL calculates the relative path between the out directory and the tool base directory, and uses that to generate the paths in the dependency notes. Change-Id: Ie584c3133baeaba1f2b18225a9a7e6501fce6dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879457 Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Reviewed-by:
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/c20eb36aa7..77f2a9d8d6 TBR=aerotwist@chromium.org Change-Id: Idb841a0cbca580699afc971ef0ebcb84661c4226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882315Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709846}
-
Matt Falkenhagen authored
There is no longer content/browser/loader/upload_data_stream_builder.cc since r682406. Change-Id: I85825d2d040a3d6d9a452847069fa25253054d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880501Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be638514..e4fd34ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ef4046eb0d6388078ea76a32291556f0dca29f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882936Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709844}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactory from //androdi_webview, // chromecast, //components, //google_apis, //ios, and // storage to new Mojo types using PendingRemote and Remote. With this CL, URLLoaderFactory is fully converted to new Mojo types. Bug: 955171 Change-Id: Id1d7d75cfc8ecc99fde7ee8449d1d25993702ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872050 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#709843}
-
Alex Ilin authored
The network annotation contained a special description for ChromeOS that is no longer accurate since Unity launch in M78. Bug: 951781 Change-Id: I56dffbd46cc0bdf8084e6e48e202c82faace726c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816541Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709842}
-
Tobias Sargeant authored
This also adds the definition of the os-specific path beneath which crash dumps should be stored. Change-Id: I500d9e0fef2844550c62dfe6a7e71bddf786f2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879261 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#709841}
-
Mark Cogan authored
This is the second CL of several breaking crrev.com/c/1860025 into smaller chunks. Change the various classes and tests in ui/first_run/ to accept a Browser where before they accepted a BrowserState. Spurious use of, and dependency on, TabModel is also removed. Change-Id: I961a684231d78036881084be0222d56787a55e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863017 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#709840}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a8c4e3a48ffd..c5f1be68e3ff git log a8c4e3a48ffd..c5f1be68e3ff --date=short --no-merges --format='%ad %ae %s' 2019-10-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c5f1be68e3ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iae99589d8abefd835ece32e87a07ca93063f9e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883065Reviewed-by:
-
A Olsen authored
During SAML flow, we might get extra information about when the password expires from the SAML IdP, which we store so we can then warn the user when their password expires. However, this information is no longer relevant - and will never be updated by the SAML IdP - if the user no longer uses SAML to log in. In that, case, we should simply delete it. We should also delete it if the feature that uses it is turned off - if an admin decides this feature is not useful to them and turns it off, then we should clear the data. Later if they decide to try and out the feature again, they shouldn't need to worry about data reappearing that has been stored since last time they had the feature enabled - that data could be very stale since it will not have been kept up to date. Stale data can lead to spurious password-expiry notifications. Bug: 930109 Change-Id: Ia2f6abba306adea8b64a5f756579826ded8ffc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866750Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709838}
-
Peter E Conn authored
The factory doesn't do anything at the moment, but I'm going to move downstream over to use this method before further changes. Bug: 1018672 Change-Id: I35092af3d0659733eca3587d33ef064c49ca4f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881166Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#709837}
-
Alice Wang authored
This CL fixes the disabled BookmarkPersonalizedSigninPromoTest related to launching SigninActivity in different scenarios. A SigninActivityLauncher is created to setup the intent and launch the SigninActivity with different account settings. Bug: 789531 Change-Id: I09ff0419fb268b2482984c3d0bd3c5cb3227860a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868878Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#709836}
-
Mohamed Amir Yosef authored
The name PasswordGenerationState is kinda misleading. The class does more than keeping the state of the generation. It also modifies the underlying password store. Change-Id: If21a78b11268fe7a4a2d2c8adea9c769bb4351f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882311Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#709835}
-
Mihai Sardarescu authored
This CL restricts the concatenation of the Gaia email and the local profile name to Chrome instances with kProfileMenuRevamp enabled. This should simplify the finch configuration for rolling out the profile menu revamp and at the same time reduce the risk as users using the old profile menu will not be affected by the profile name being the concatenation of the Gaia email and the local profile name. Bug: 1018202 Change-Id: I4c28dba17e2c3d8e13b2efeeedcd788909f550e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879291Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#709834}
-
Yuki Shiino authored
Introduces ease-to-use APIs to ExtendedAttributes. Bug: 839389 Change-Id: I8f23ec9f9d6b7dddb9b17720ed2963e16fbd8cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882252Reviewed-by:
-
Mathias Carlen authored
Before this patch the direct action list_assistant_action was used to start autofill assistant and to return available actions. That is misleading and this patch disconnects that by renaming list_assistant_action to fetch_website_actions and return a success bool instead of a list of actions. Out of scope for this patch: the next step will be to tie the availability of the fetch_website_actions action to controller state and to remove perform_assistant_action entirely. Bug: b/138833619 Change-Id: I279e5bc2e6d13a48151d5c161483a2b9662dd940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873752 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e38e11986f00..c189ace20a43 git log e38e11986f00..c189ace20a43 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 04c3c4c8..d68d92fb (709704:709806) Created with: gclient setdep -r src/third_party/webrtc@c189ace20a43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id48fa26113d190e49da2854a64b222949d604b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883060Reviewed-by:
-
