GitLab

This CL stubs in an AssistantBubble/AssistantContainerView as part of a
series of CLs to move the AssistantBubbleView out of the app_list.

With this CL:
- Bubble will be shown on interaction start.
- Bubble will be auto-dismissed after interaction finish (w/ delay).

See bug for demo.

Bug: b:77637813
Change-Id: I69c146f386405e33d3a0a503f9bf87072d704abe
Reviewed-on: https://chromium-review.googlesource.com/1024804
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553702}

Bug: 733662
Change-Id: I3db2d80a9a8edab1609b12deac96f320a9630273
Reviewed-on: https://chromium-review.googlesource.com/1026848Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#553701}

Bug: 835867, 575305
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I03bd2083fc5df341ce0d4717d0c5af3abe822763
Tbr: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1028224Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553700}

Replacing it with modern RunLoop+QuitClosure usage.

R=caseq@chromium.org

Bug: 825327
Change-Id: I43e021d3a3c5e76923e77c8d28560931dc3ee866
Reviewed-on: https://chromium-review.googlesource.com/1024445Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553699}

mDelayedInitialTabBehaviorDuringUiInit is a private runnable that is
never set. It looks like it is added here
(https://codereview.chromium.org/2912473003).

Change-Id: Ic612e95340616ab905d594a25471daea62e6fac1
Reviewed-on: https://chromium-review.googlesource.com/1026422Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553698}

This brings things back in sync after a failed branching.

TBR=govind@google.com
NOTRY=true

Bug: 825063
Change-Id: Id141a41135fab3b5b4736746d5b790659a254bf5
Reviewed-on: https://chromium-review.googlesource.com/1028665
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553697}

This reverts commit f09f52a1.

Reason for revert: yet another friendly lesson on the dangers of notry.

Original change's description:
> Add mac_window_server_killers to browser_tests data on Mac.
> 
> TBR=ellyjones@chromium.org,liaoyuke@chromium.org
> 
> Bug: 828031
> Change-Id: Ie98ee83cee2d4c98c29a2ac1290728da5b87c4a7
> No-Try: True
> Reviewed-on: https://chromium-review.googlesource.com/1028482
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553626}

TBR=ellyjones@chromium.org,liaoyuke@chromium.org,jbudorick@chromium.org

Change-Id: Ida00d9ae602b301008a0bdaab46255c2361c6107
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828031
Reviewed-on: https://chromium-review.googlesource.com/1028491Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553696}

This adds Network.takeResponseBodyForInterceptionAsStream, which returns
a stream handle that can be used with IO.read/IO.close.
Note this is only supported with the Network Service currently, the
legacy URLRequestJob based interception support will be added later.

Bug: 831887
Change-Id: Ibc5a43e86824f0c86397f200b5a6852171705f0e
Reviewed-on: https://chromium-review.googlesource.com/1026692Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553695}

Bug: 836187
Change-Id: Id072e00ca0d6e4f278a43f34deea6880d2aa0536
Reviewed-on: https://chromium-review.googlesource.com/1026039Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553694}

This class can be useful for any classes to implement/support multiple
versins of library CDM interface. Hence, move it out of clear_key_cdm
folder. In a later CL, I'll use them for a mock library CDM
implementation.

Bug: 836046
Test: No functionality change.
Change-Id: I7567e405de0251ddce3718eb76d102f07ff8f33e
Reviewed-on: https://chromium-review.googlesource.com/1026970Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553693}

https://pdfium.googlesource.com/pdfium.git/+log/ac19439e28b6..d9da586dd3db

$ git log ac19439e2..d9da586dd --date=short --no-merges --format='%ad %ae %s'
2018-04-25 npm Roll third_party/freetype/src/ 26ad1acbc..2157d8fa6 (21 commits)

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I22f771416c8dde47fd823191cb2b196499d9dfdd
Reviewed-on: https://chromium-review.googlesource.com/1028475
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553692}

R=cmasso@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icd4046545efb94a6a54de3a5452ac085fee311fa
Reviewed-on: https://chromium-review.googlesource.com/1028657Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553691}

Bug: 773295
Change-Id: I791e51cafbfc1a03f64f1edc58699e65307ce3b5
Reviewed-on: https://chromium-review.googlesource.com/1025068Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553690}

 - Move some styles from shared_style_css.html to paper_button_style_css.html.
 - Update paper-button styles per latest spec.
 - Collapse previously different types of buttons "primary" and "action" into a
   single button type.

Note this change is intentionally changing the shared styling for buttons. If a
certain WebUI page needs a different pre-MD refresh style, should be updated
individually to override (hopefully there are no such cases though).

Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If083bf3ad1d60623300bb9e584ae9179e815ef7d
Reviewed-on: https://chromium-review.googlesource.com/1028478Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553689}

BUG=832313,820250

Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
Reviewed-on: https://chromium-review.googlesource.com/1011350
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553688}

This change removes the Physical Web privacy preference.

BUG=826540

Change-Id: I5bd06d3df7cb6e03051921a3c6d8d02b2c82b329
Reviewed-on: https://chromium-review.googlesource.com/1024756Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553687}

Change-Id: I41aa3d4be8cbd16c9ed78cd888b0341dedc8727a
Reviewed-on: https://chromium-review.googlesource.com/1028353Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553686}

When openWindow() is not triggered by user activation, currently throws
InvalidAccessError. But it's already deprecated in spec level. Instead
we should throw NotAllowedError.

Related spec change:
  https://github.com/w3c/payment-handler/pull/291

Bug: 833532
Change-Id: Icc21301abcafa0ecd00d6232d73a273ca6e4dd9b
Reviewed-on: https://chromium-review.googlesource.com/1013659
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553685}

This will help us understand how many articles show
up with a thumbnail in downloads home.

Bug: 794828
Change-Id: I4576620f877147e0d897e29af11186150ddcf816
Reviewed-on: https://chromium-review.googlesource.com/1024639Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553684}

This reverts commit 8839d302.

Reason for revert: causing WebUI renderer kills

Original change's description:
> Enforce user gesture requirement on browser side for WebUI.
> 
> WebContentsImpl now tracks the last time it received an input event that
> could be considered user interaction. When the browser process receives
> a WebUI message that requires a user gesture, it checks the WebContents
> hosting the WebUI to make sure that the user recently interacted with
> it.
> 
> This also cleans up a few incidental bits of code:
> - RenderWidgetHost no longer prefilters events before notifying the
>   delegate. This exposed some broken event filtering, tracked at
>   https://crbug.com/827659.
> - Since the delegate method no longer prefilters input events,
>   RenderWidgetHostDelegate::OnUserInteraction() is now named
>   RenderWidgetHostDelegate::DidReceiveInputEvent().
> - The IPC message used to pass WebUI messages from the renderer to the
>   browser sends the source URL. However, this requires trusting the
>   untrustworthy renderer to not lie about the URL. Instead, just use
>   GetLastCommittedURL().
> 
> Bug: 823864
> Change-Id: I687776c8c7f7f93f78c968dd432b1674d65629c0
> Reviewed-on: https://chromium-review.googlesource.com/1023174
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553001}

TBR=dcheng@chromium.org,thestig@chromium.org,isherman@chromium.org,alexmos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 823864
Change-Id: I7e6266f5e0d87197a76f2f201faef13bce129734
Reviewed-on: https://chromium-review.googlesource.com/1028335
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553683}

If we recieve a request for an extension that doesn't have a 'cast_url'
key present defer to the normal extension request processor to load
the files from disk

This is also required to load background pages (as it is from disk)

Bug: b/73768170
Test: Load extension that loads from disk, verify fallback occurs
Change-Id: I7bf477f92dbebfd37077ed417e12d17a03d35308
Reviewed-on: https://chromium-review.googlesource.com/934924Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553682}

When kVTVideoEncoderSpecification_RequireHardwareAcceleratedVideoEncoder is set,
VideoToolbox doesn't create encoder sessions below 640x384 resolution. From the
spec, this indicates that it is falling to SW implementation. Since we want to
actually test HW backed cases, we should input a higher resolution video for
Mac.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Change-Id: Ie10cd533473ffca501f80772fffe27644004e123
Reviewed-on: https://chromium-review.googlesource.com/1019733
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553681}

This is an opportunistic fix for a crash that we were not able to
reproduce locally.

Bug: 833360
Change-Id: If376405dd75591bcbbb47273e2330027de8ebd0d
Reviewed-on: https://chromium-review.googlesource.com/1028359Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553680}

Test: ash_unittests SplitViewControllerTest.ShadowDisappearsWhenSnapped
Bug: 818295
Change-Id: Icb1ed1d1c03e00cd74cf9d60986d6853b3160ea5
Reviewed-on: https://chromium-review.googlesource.com/988935
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553679}

When a layout object is the effective root scroller, the
OverflowClipRect uses the ViewRect rather than computing the padding box
as usual. This is because the padding box won't expand when the URL bar
is hidden.

Unfortunately in the root scroller case we forget to set the passed in
location. This patch adds that so the rect is in the correct coordinate
space. Additionally, this all works only if the box set as the effective
root scroller has no border since the OverflowClipRect uses the padding
box. I've updated the root scroller to ensure the padding box matches
the viewport rect.

Ideally we'd just return View()->OverflowClipRect - which does remember
to set the location - in LayoutBox but this could lead to an infinite
recursion as that calls LayoutBox::OverflowClipRect if the ViewRect is
empty. Thus, we call ViewRect directly.

Bug: 816161
Change-Id: I2f622ff0c25e58373955e1d0e22d54e254e134ff
Reviewed-on: https://chromium-review.googlesource.com/1026517Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553678}

Bug: b/74612005
Test: On device unittests
Change-Id: I628a3ad8563fb1fb35ea783f73f24a62e497091a
Reviewed-on: https://chromium-review.googlesource.com/1028560Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553677}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9990de59..96706998

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If2540c38879b3438082a7569b931945f7d00bb75
Reviewed-on: https://chromium-review.googlesource.com/1027803Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553676}

The internal class owns AdapterRefs which have to be destructed on the
main thread. As such, the last reference to the internal class had to
be freed on the main thread. In flaky cases, when tasks were posted to
the signaling thread, an operation performed and a task posted back to
the main thread - the main thread would finish before the signaling
thread task and the last reference to the internal class would be
released on the signaling thread, causing DCHECK crashes at
~AdapterRef for being on the wrong thread.

With destructor traits, if we are not already on the main thread we
post to the main thread and delete RTCRtpReceiverInternal there.

The TearDown of RTCRtpReceiverTest is updated to ensure that any pending
tasks get a chance to execute, in case the signaling thread was not
finished yet or else the destructor posted to the main thread does not
get a chance to execute and the test would flakily leak.

Before this CL: Flake's symptoms could be reproduced by adding a thread
sleep at RTCRtpReceiverInternal::GetStatsOnSignalingThread. After this CL:
Unable to repro flake.

Bug: 827450
Change-Id: Icdfdd3e22c3e86308ee7911e67eff43590fde581
Reviewed-on: https://chromium-review.googlesource.com/1013492
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553675}

The FunctorTraits blacklist entry blacklisted thousands of call sites
unrelated to the specific failing test cases. By limiting the scope of
the blacklist entry it exposes that the majority of the previously
blacklisted call sites were actually not checked anyway due to them being
pointer-to-member calls.

Change-Id: I98491b2cb704b607efa2b7cbf11b942fef218d9c
Reviewed-on: https://chromium-review.googlesource.com/1028378Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553674}

This brings things back in sync after a failed branching.

TBR=govind@google.com
NOTRY=true

Bug: 825063
Change-Id: Ia1b98d068b6c38cc1bb0337abe9492e723c8e70d
Reviewed-on: https://chromium-review.googlesource.com/1028611Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553673}

Marks common callbacks that do not produce JS-observable side-effects
on: Document, DOMTokenList, Element, Node, Window, HTMLElement.

Note that several Window properties are lazy and need extra V8 support
to be whitelisted.

Bug: 829571
Change-Id: I9ad50c1ca9b8c260ec898bc94423286c142d6bec
Reviewed-on: https://chromium-review.googlesource.com/1024863Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553672}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=dnicoara@chromium.org

Bug: 825327
Change-Id: I2d0a66205586d87c27d7ba8b87a7d4f4416f1728
Reviewed-on: https://chromium-review.googlesource.com/1024446Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553671}

We already look at workarounds. If tests fail without virtualized
contexts we should get the workarounds properly populated.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I22a8c47260c84bff4b8c8eb2ec457b704eed9e36
Reviewed-on: https://chromium-review.googlesource.com/1028213Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553670}

We only need to lock those while iterating persistents and while processing
weak persistents.

Bug: chromium:836306
Change-Id: I788d349672c9d9550e3889c13ec4b79b5e5c6ee9
Reviewed-on: https://chromium-review.googlesource.com/1026675
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553669}

MacViews does not yet implement maximized windows and a trivial
implementation doesn't seem to work.

BUG=834754,836327

Change-Id: I4fd6fbd4295134053cc58d028d0c2397088150a8
Reviewed-on: https://chromium-review.googlesource.com/1026350Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553668}

BUG=818732

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie1639a9112b16aeade373449e75934c8e63fedb7
Reviewed-on: https://chromium-review.googlesource.com/1027900
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553667}

This CL changes the webtiming-resolution to test that resolution is
larger than 10 microseconds, instead of testing for a specific value.
This allows the test to no longer be flaky and to be moved to wpt.

The webtiming-ssl test is moved to WPT, using an https connection to
ensure that secureConnectionStart is correctly defined.

Bug: chromium:801341
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4d31faa08d00251098f3dc648c794d80bbcc2f22
Reviewed-on: https://chromium-review.googlesource.com/867310
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553666}

On Android, the facing mode of capture devices is currently reported only in
form of a string appended to the device name. This was probably a legacy
solution before facing mode has become an official field that can be queried.

This CL fills the facing mode field so that it gets reported correctly.
It then sorts device infos reported during device enumeration such that
user-facing devices get listed first. This has the effect of making them
preferred over back-facing cameras in case no facing-related constraints are
given.

Bug: 814298
Change-Id: I366475903693401c64ed7ff3f65d39536d6c13ba
Reviewed-on: https://chromium-review.googlesource.com/1025213Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553665}

This furthers previous lifecycle framework cleanup, and fixes an
outstanding technical-debt bug in the process.

BUG=768079
R=ymalik

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I6743ed68e16f437d68ccc27849f3694af347617a
Reviewed-on: https://chromium-review.googlesource.com/1015645
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553664}

CupsPrinters is becoming a BCKS. This change modifies services using it
to create and store handles to it correctly.

BUG=chromium:829492
TEST=manually ensured behavior unchanged

Change-Id: Ibca680fd3b29314b38a72288ed28f6b0f2dca42e
Reviewed-on: https://chromium-review.googlesource.com/998612Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553663}