GitLab

Revert of Enable extended debugging symbols to including  better tracking. (patchset #3 id:40001 of https://codereview.chromium.org/362183003/)

Reason for revert:
Breaks with

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/libwebp/enc/libwebp_enc.config.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=216630 -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../../third_party/libwebp -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_Builder__dbg_/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-format -Wno-unused-result -m64 -march=x86-64 -O0 -g -gdwarf-4 -fvar-tracking-assignments -fvar-tracking -funwind-tables -gsplit-dwarf -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare   -c ../../third_party/libwebp/enc/config.c -o obj/third_party/libwebp/enc/libwebp_enc.config.o
clang: error: unknown argument: '-fvar-tracking-assignments'
clang: error: unknown argument: '-fvar-tracking'

See http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/79150/steps/compile/logs/stdio for more info.

Original issue's description:
> Enable extended debugging symbols to including better tracking.
>
> Adding -fvar-tracking-assignments and -fvar-tracking to improve
> tracking of variables and assignments. While mostly useful when
> compiling with optimisations on (-O flags), it does help with clang
> (and later gccs) which are doing many optimisations all the time.
> (It does sometimes default to on when compiling with -O flags.)
>
> From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
> > -fvar-tracking
> >  Run variable tracking pass. It computes where variables are stored
> >  at each position in code. Better debugging information is then
> >  generated (if the debugging information format supports this
> >  information).
> >
> >  It is enabled by default when compiling with optimization (-Os, -O,
> >  -O2, ...), debugging information (-g) and the debug info format
> >  supports it.
> >
> > -fvar-tracking-assignments
> >  Annotate assignments to user variables early in the compilation and
> >  attempt to carry the annotations over throughout the compilation
> >  all the way to the end, in an attempt to improve debug information
> >  while optimizing. Use of -gdwarf-4 is recommended along with it.
> >
> >  It can be enabled even if var-tracking is disabled, in which case
> >  annotations are created and maintained, but discarded at the end.
>
> Committed: https://crrev.com/9f7cb7480b85d868fb3420b960018d9137c9954a
> Cr-Commit-Position: refs/heads/master@{#296662}

TBR=thestig@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/602023002

Cr-Commit-Position: refs/heads/master@{#296664}

BUG=406236

Review URL: https://codereview.chromium.org/494413002

Cr-Commit-Position: refs/heads/master@{#296663}

Adding -fvar-tracking-assignments and -fvar-tracking to improve
tracking of variables and assignments. While mostly useful when
compiling with optimisations on (-O flags), it does help with clang
(and later gccs) which are doing many optimisations all the time.
(It does sometimes default to on when compiling with -O flags.)

From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
> -fvar-tracking
>  Run variable tracking pass. It computes where variables are stored
>  at each position in code. Better debugging information is then
>  generated (if the debugging information format supports this
>  information).
>
>  It is enabled by default when compiling with optimization (-Os, -O,
>  -O2, ...), debugging information (-g) and the debug info format
>  supports it.
>
> -fvar-tracking-assignments
>  Annotate assignments to user variables early in the compilation and
>  attempt to carry the annotations over throughout the compilation
>  all the way to the end, in an attempt to improve debug information
>  while optimizing. Use of -gdwarf-4 is recommended along with it.
>
>  It can be enabled even if var-tracking is disabled, in which case
>  annotations are created and maintained, but discarded at the end.

Review URL: https://codereview.chromium.org/362183003

Cr-Commit-Position: refs/heads/master@{#296662}

Adds a function to the hotword private API to allow the Hotword Audio
Verification app to set the always-on-hotword setting.

Gives control over the always-on-hotword pref to the app from the settings page.

This cl is dependent on https://codereview.chromium.org/528113003/

BUG=390086

Review URL: https://codereview.chromium.org/559303002

Cr-Commit-Position: refs/heads/master@{#296661}

BUG=402536

Review URL: https://codereview.chromium.org/580403003

Cr-Commit-Position: refs/heads/master@{#296660}

BUG=348066
TEST=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/586273002

Cr-Commit-Position: refs/heads/master@{#296659}

To support persistent serial connections on mojo, serial.Connection and
its dependencies must be serializable to mojo structs so it can be
stashed. This adds serialization support to the two serial.Connection
dependencies: DataSender and DataReceiver.

BUG=389016

Review URL: https://codereview.chromium.org/571333002

Cr-Commit-Position: refs/heads/master@{#296658}

Ah, the dangers of dynamic typing and implicit type conversion.
Typo in https://codereview.chromium.org/577893003

BUG=336556, 336558
TEST=None.
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/605633002

Cr-Commit-Position: refs/heads/master@{#296657}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/598483002

Cr-Commit-Position: refs/heads/master@{#296656}

Removal the corresponding changes in blink are applied in the following patch
https://codereview.chromium.org/599863002/

BUG=402536

Review URL: https://codereview.chromium.org/598923002

Cr-Commit-Position: refs/heads/master@{#296655}

This pulls in the following Native Client changes:

r13760: (mseaborn) untrusted.gypi: Factor out duplicated "--gomadir" option
r13761: (mseaborn) Fix mmap() with length > 0xffff0000 to behave consistently on 32/64-bit
r13762: (teravest) Support file path metadata for the main nexe.
r13763: (teravest) Add CreateNaClDescWithFilePathMetadata fn.
r13764: (dschuff) Switch PNaCl lib, include, and translator directories for new layout
r13765: (dschuff) Pass naclsdk_validate=0 to scons runs run by main waterfall bots
r13768: (dbrazdil) Allowed decrementing program break with sbrk() in MinSFI
r13769: (dyen) Added tests for rename functions in irt_ext.
r13770: (dyen) Added tests for unlink functions irt_ext.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg
TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/604483002

Cr-Commit-Position: refs/heads/master@{#296654}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/81f4797..6811fe1

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/604653002

Cr-Commit-Position: refs/heads/master@{#296653}

The fling curve for touchpad and touchscreen used to be configurable for
experimenting with, but these parameters have been stable for a long time now.
So make the values default, and remove all the code and preferences that were
necessary for the configurability.

BUG=none
R=avi@chromium.org, kenrb@chromium.org, sky@chromium.org, wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/586933003

Cr-Commit-Position: refs/heads/master@{#296652}

BUG=402485
TBR=thakis@chrmoium.org for chrome_nibs.gyp

Review URL: https://codereview.chromium.org/595283002

Cr-Commit-Position: refs/heads/master@{#296651}

R=estade@chromium.org
BUG=407539

Review URL: https://codereview.chromium.org/594403004

Cr-Commit-Position: refs/heads/master@{#296650}

Because base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/600163003

Cr-Commit-Position: refs/heads/master@{#296649}

The test framework returns an empty string as the localized strings are
not supported. This caused the assert to fail on android debug builds,
because of which https://codereview.chromium.org/541693003/ had to be
reverted. This is the chromium side changes needed for the patch to be
restored.

BUG=401506

Review URL: https://codereview.chromium.org/593113003

Cr-Commit-Position: refs/heads/master@{#296648}

Using  base::StringPairs in base folder
Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/605613003

Cr-Commit-Position: refs/heads/master@{#296647}

BUG=417582
NOTRY=true
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/599093007

Cr-Commit-Position: refs/heads/master@{#296646}

BUG=100022,100983,101359,102327,102621,102920,104756,104786,105022,105323,105339,105341,105342,105523,105524,105526,105527,105580,105938,107179,107541,109994,112078,112086,117310,127499,131361,141293,171722,173779,177540,231969,244420,244437,246567,247506,257276,257501,264886,280583,292913,310761,320918,340718,340909,340957,369597,375391
NOTRY=true
TBR=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/599183004

Cr-Commit-Position: refs/heads/master@{#296645}

Previous DCHECK uses IsUnderDriveMountPoint method which takes paths for
external file system. But the paths used in FakeFileSystem are drive paths that
are extracted from external file system paths. So it goes into infinity loop
during traversing parent directory when a path pointing the out of my drive
directory is given.

The CL removes the check, and add util::GetDriveMyDriveRootPath().IsParent(file_path) to
prevent the infinity loop.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/583583003

Cr-Commit-Position: refs/heads/master@{#296644}

Currenty active_version() is used to check whether the page is under the control of the ServiceWorker.
But this is not correct.
We have to use controlling_version().

BUG=417351
TEST=http/tests/serviceworker/uncontrolled-page.html in https://codereview.chromium.org/600843003

Review URL: https://codereview.chromium.org/600303002

Cr-Commit-Position: refs/heads/master@{#296643}

The CL rename following symbols.

* kDriveScheme -> kExternalFileScheme
* drive::DriveProtocolHandler -> chromeos::ExternalFileProtocolHandler
* drive::DriveURLRequestJob -> chromeos::ExternalFileURLRequestJob
* Utility functions in drive/file_system_util.{h,cc} -> fileapi/external_file_url_util.{h,cc}
* Related tests

BUG=367027
TEST=Open HTML, MHTML, PDF, GDOC files on the drive volume.

Review URL: https://codereview.chromium.org/580023003

Cr-Commit-Position: refs/heads/master@{#296642}

Adds a function to hotwordPrivate API for the Hotword Audio Verification app with. This function allows the app to check which mode it should launch in.

BUG=390086

Review URL: https://codereview.chromium.org/528113003

Cr-Commit-Position: refs/heads/master@{#296641}

BUG=314505

Review URL: https://codereview.chromium.org/597853003

Cr-Commit-Position: refs/heads/master@{#296640}

BUG=112278
NOTRY=true
TBR=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/606523002

Cr-Commit-Position: refs/heads/master@{#296639}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1ff6c52..81f4797

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/606503003

Cr-Commit-Position: refs/heads/master@{#296638}

There is no reason for the following files to live in content/ layer
and they should all be moved to ui/ layer.

BUG=302114

Review URL: https://codereview.chromium.org/574673003

Cr-Commit-Position: refs/heads/master@{#296637}

BUG=417570
NOTREECHECKS=true
NOTRY=true
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/600333002

Cr-Commit-Position: refs/heads/master@{#296636}

Revert of Installs test CA to android devices as part of browser startup so that apps can be tested with prox… (patchset #8 id:140001 of https://codereview.chromium.org/572123002/)

Reason for revert:
Making the Android nexus perf bot all red.

Original issue's description:
> Installs test CA to android devices as part of browser startup so that apps can be tested with proxy HTTPS server without code changes.
>
> BUG=412826
>
> Committed: https://crrev.com/f28d9cace2df4a9dcaa992c4df5b85e3b2674dbb
> Cr-Commit-Position: refs/heads/master@{#296619}

TBR=tonyg@chromium.org,slamm@google.com,slamm@chromium.org,wuhu@google.com
NOTREECHECKS=true
NOTRY=true
BUG=412826

Review URL: https://codereview.chromium.org/606533002

Cr-Commit-Position: refs/heads/master@{#296635}

Required exposing new Mac versions to Telemetry's test expectations.
Added unit test.

BUG=417415

Review URL: https://codereview.chromium.org/597383002

Cr-Commit-Position: refs/heads/master@{#296634}

BUG=

Review URL: https://codereview.chromium.org/588603002

Cr-Commit-Position: refs/heads/master@{#296633}

Revert of Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://codereview.chromium.org/601983002/)

Reason for revert:
Broke Android bots:
http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/2225
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/66337

Original issue's description:
> Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://chromiumcodereview.appspot.com/579543003/)
>
> Reason for revert:
> All the bots have been switched to Java 7 according to https://code.google.com/p/chromium/issues/detail?id=411503#c19
>
> Original issue's description:
> > Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/)
> >
> > Reason for revert:
> > Not all bots have Java 7 yet :(
> >
> > Original issue's description:
> > > Set the javac target and source to 1.7
> > >
> > > BUG=336589
> > > TBR=yfriedman@chromium.org
> > >
> > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b
> > > Cr-Commit-Position: refs/heads/master@{#295162}
> >
> > TBR=cjhopman@chromium.org,yfriedman@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=336589
> >
> > Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99
> > Cr-Commit-Position: refs/heads/master@{#295165}
>
> TBR=cjhopman@chromium.org,yfriedman@chromium.org
> BUG=336589
>
> Committed: https://crrev.com/119c6fa8247481d2e36910d30175d0214fd2ece5
> Cr-Commit-Position: refs/heads/master@{#296630}

TBR=cjhopman@chromium.org,yfriedman@chromium.org,aurimas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336589

Review URL: https://codereview.chromium.org/603833002

Cr-Commit-Position: refs/heads/master@{#296632}

Previously, menus were dismissed by adding a click handler to the <body>,
but that doesn't intercept clicks on the plugin element and complicates
the logic somewhat because a second click on the button while the menu is
visible then triggers both the show and hide handlers by default. This CL
adds an explicit <div> covering the entire window, but behind the menu in
the z-order. This <div> doesn't prevent window dragging, despite being on
top of the title-bar, so I've also made that conditional on there being
no menu visible.

BUG=416307

Review URL: https://codereview.chromium.org/592793003

Cr-Commit-Position: refs/heads/master@{#296631}

Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://chromiumcodereview.appspot.com/579543003/)

Reason for revert:
All the bots have been switched to Java 7 according to https://code.google.com/p/chromium/issues/detail?id=411503#c19

Original issue's description:
> Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/)
>
> Reason for revert:
> Not all bots have Java 7 yet :(
>
> Original issue's description:
> > Set the javac target and source to 1.7
> >
> > BUG=336589
> > TBR=yfriedman@chromium.org
> >
> > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b
> > Cr-Commit-Position: refs/heads/master@{#295162}
>
> TBR=cjhopman@chromium.org,yfriedman@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=336589
>
> Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99
> Cr-Commit-Position: refs/heads/master@{#295165}

TBR=cjhopman@chromium.org,yfriedman@chromium.org
BUG=336589

Review URL: https://codereview.chromium.org/601983002

Cr-Commit-Position: refs/heads/master@{#296630}

BUG=416225

Review URL: https://codereview.chromium.org/601003002

Cr-Commit-Position: refs/heads/master@{#296629}

Introduced c/b/ui/views/athena/athena_util so that
arbitrary code under chrome/browser doesn't have to depend on athena/

BUG=414340,410499

Review URL: https://codereview.chromium.org/603033002

Cr-Commit-Position: refs/heads/master@{#296628}

Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/)

Reason for revert:
flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850

failures:
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0
LoggedInSpokenFeedbackTest.AddBookmark

Original issue's description:
> Add test for ChromeVox keyboard commands.
>
> This is just a couple of quick sanity checks to prevent future regressions
> like the one in the linked bug. It tests both a Search+Shift shortcut and
> the corresponding Prefix Key shortcut.
>
> Adds support for sending the meta modifier key in
> aura/x11 tests.
>
> BUG=404470
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0
>
> Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362
> Cr-Commit-Position: refs/heads/master@{#293687}
>
> Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a
> Cr-Commit-Position: refs/heads/master@{#296074}

TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404470

Review URL: https://codereview.chromium.org/603823002

Cr-Commit-Position: refs/heads/master@{#296627}

The OSX 10.10 dictionary changed its suggested corrections to "bouy", which
used to include "buoy". I updated the test to check that "bouy" has the
suggested correction "bout", which is present in the dictionary for both OSX
10.9 and OSX 10.10.

BUG=390276

Review URL: https://codereview.chromium.org/591313002

Cr-Commit-Position: refs/heads/master@{#296626}

Only chrome is interested in implementing these methods.
Move the code to ChromeAppDelegate.

BUG=411352

Review URL: https://codereview.chromium.org/557833007

Cr-Commit-Position: refs/heads/master@{#296625}