- 25 Sep, 2017 40 commits
-
-
Stephen Lanham authored
This is a new feature that is enabled by the network service (http://crbug.com/689549). A recent change landed on master, causing a DCHECK at runtime, and blocking the roll: http://crrev.com/c/581488. Disable this feature by default while we work with clamy@ to add support. BUG=768526 Bug: b/66275254 (Chromium merge for Cast) Test: Run cast_shell on desktop, Cast YT. Change-Id: I35323e01215b2923d0f24130dbb423c0cd55018d Reviewed-on: https://chromium-review.googlesource.com/682955Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504188}
-
Michael Thiessen authored
Bug: Change-Id: Idf976d5de2b507c38bd2666f4e16d08e9fd5a25a Reviewed-on: https://chromium-review.googlesource.com/683000Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#504187}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/94fddf83816a..f40ae1a4b536 $ git log 94fddf838..f40ae1a4b --date=short --no-merges --format='%ad %ae %s' 2017-09-25 reed Revert "migrate to sk_sp for SkFontMgr API" 2017-09-25 benjaminwagner Specify CPU for CT Swarming tasks. 2017-09-25 reed migrate to sk_sp for SkFontMgr API 2017-09-25 mtklein Simplify / fix SkBitmap::ReadRawPixels() 2017-09-22 enne Make SkPath::readFromMemory failure silent Created with: roll-dep src/third_party/skia BUG=765858 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Id721b8de8164bd59065b7a4a5203a5689e1022a3 Reviewed-on: https://chromium-review.googlesource.com/682954Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504186}
-
Khushal authored
Currently blink caches SkImage uniqueIDs created by BitmapImage to ensure reuse of cached decoded data for the frames of this image. The 2 systems that can cache the decode are cc and skia. 1) cc: The image decode cache in cc uses PaintImage::FrameKey to cache the decodes and does not rely on SkImage uniqueIDs anymore. 2) skia: Skia's decode caching is tied to the lifetime of the SkImage, which invalidates skia's cache in its dtor. This means that reusing the same uniqueID will still result in purging of the decode from skia's cache. Also note that the only case where the reuse of uniqueID is important is for each frame of a multiframe image. For static images, BitmapImage already ensures caching of the decode by storing the PaintImage which internally keeps a reference to the SkImage, and is cleared in DestroyDecodedData. All cases which require animation of images go through cc and use cc's image decode cache. The few cases, for instance Canvas2D, which decode on the main thread and use skia's cache only use the first frame of an animated image. R=chrishtr@chromium.org, fmalita@chromium.org Bug: 753639 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I78dcf84a8dad25c7742526af31c05ee381da7cf4 Reviewed-on: https://chromium-review.googlesource.com/677916Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#504185}
-
Mark Pearson authored
Both the local suggestion providers and the server can provide better suggestions with this context. Remove a now redundant / unnecessary function here. Bug: 738559 Change-Id: I4780c99a1347b2aa80bc52cb57a1f772709b3ad8 Reviewed-on: https://chromium-review.googlesource.com/665514 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#504184}
-
chrome://policy-toolAnton Urusov authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic15b36b92460885e00718e52bc882a111ff14227 Reviewed-on: https://chromium-review.googlesource.com/675666 Commit-Queue: Anton Urusov <urusant@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#504183}
-
Becky Zhou authored
The changes make CompositorViewHolder not focusable and OverviewListLayout not important when there is some view obscuring tabs. Bug: 739382 Change-Id: I7739e25c31a659aae435c4e16313378caf7c4529 Reviewed-on: https://chromium-review.googlesource.com/679620Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504182}
-
Brett Wilson authored
Remove armansito who isn't actively working on ChromeOS any more. Change-Id: I8d65bc75c8ba67018038a4f7e6d166dc1c13ab43 Reviewed-on: https://chromium-review.googlesource.com/683005Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504181}
-
Florin Malita authored
The flag is no longer used in Skia. Change-Id: Ibe8dd12b274bc59d48c656665add5bcdd277ebdd Reviewed-on: https://chromium-review.googlesource.com/682714Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#504180}
-
Sammie Quon authored
The wireless network icon on the system tray has some information about the signal strength which ChromeVox users miss out on. Add a accessibility string in addition to convey the signal strength to ChromeVox. The strings are weak, medium, strong and should match the icon as well as possible. Test: manual Bug: 747468 Change-Id: Ib86ae9301a74342743fcf7e02aee874b18be4f15 Reviewed-on: https://chromium-review.googlesource.com/678917Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#504179}
-
Yuwei Huang authored
This migrates the Chromium version of the CRD app icons to AppIconset. Bug: 768180 Change-Id: I2f369a93c617877be5d1f970cdbcd26f88ca5cfc Reviewed-on: https://chromium-review.googlesource.com/680275 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#504178}
-
James Robinson authored
Change-Id: I8ded09baf6ff050b088dd5c93b3a206a0bd6b695 Reviewed-on: https://chromium-review.googlesource.com/682475Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504177}
-
Toni Barzic authored
UX with lock screen app windows being shown behind (as a background) lock screen UI has been abandoned (in favour of simply closing the app window). This means that TrayActionState::kBackground is now unreachable, and can be removed. This CL removed background state handling from LockActionHandlerLayoutManager, which used to restack app window over/bellow lock window depending on the current note action state (now app windows should never be stacked bellow the lock window). BUG=765039 Change-Id: I7cb95e2aa906fb7e8141f5ad7061df8973e10197 Reviewed-on: https://chromium-review.googlesource.com/669953Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#504176}
-
Christopher Cameron authored
Previous behavior was: * If the destination transfer function is sRGB, use the sRGB transfer function * Otherwise use the transfer function from the bt709 spec This new behavior will more closely match other platforms and user studies. Bug: 763260 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaf49c0c8a5a20e53248854b6a7ecad72d685436d Reviewed-on: https://chromium-review.googlesource.com/673165 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#504175}
-
Eric Roman authored
This matches the name in the generator script. Bug: 649000 Change-Id: Id9470ea73c270c4251c476ae2af787aea2b425c3 Reviewed-on: https://chromium-review.googlesource.com/679863 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504174}
-
Brett Wilson authored
This class is inserted into vectors and has slow-to-copy-but-fast-to-move members so would benefit from being moveable. It was also assignable which was generating large implicit inline operator= implementations. This makes operator= explicit and out-of-line. Uses C++11 syntax for member initialization. Change-Id: Ie4c591b716f85197f30603ebaeec27ddfc7cb2d6 Reviewed-on: https://chromium-review.googlesource.com/677058Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504173}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a46655f. With Chromium commits locally applied on WPT: 4d3c601c "Refactor wpt/2dcontext/drawing-images-to-the-canvas/ layout tests:" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2429 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: If65a183be27535b82a2087ded50289bae39a9f9c Reviewed-on: https://chromium-review.googlesource.com/682185 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504172}
-
Biao She authored
This CL did the following: 1. remove dead code in vr_input_manager 2. rename vr_input_manager to web_contents_event_forwarder 3. move web_contents_event_forwarder to chrome/browser/vr folder Bug: None Change-Id: I8eb93eb036de8dc51a15cd6ce32ed077ac35a6d8 Reviewed-on: https://chromium-review.googlesource.com/677282 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#504171}
-
Simon authored
TBR=rnephew@chromium.org Bug: 768472 Change-Id: I3cba6604827932c9651b801f39da4833e525c6da Reviewed-on: https://chromium-review.googlesource.com/682640 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#504170}
-
Alex Newcomer authored
This change ensures the launcher cant be dragged below the shelf when the drag originates on the AppListView. Bug: 765522 Change-Id: I8101f8f5568ff72cf91013199fe7c44438a2c679 Reviewed-on: https://chromium-review.googlesource.com/679855Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#504169}
-
Kent Tamura authored
Bug: 578345 Change-Id: Iff108780265ef892cce89b0e0b11f59728431a0e Reviewed-on: https://chromium-review.googlesource.com/680770Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#504168}
-
Derek Cheng authored
- Update various tests that uses https://google.com/cast... to Cast URLs Should be landed only after the extension-side patch lands + sticks. Bug: 757358 Change-Id: I58a7635872cb4880fed9a3ba2539c01271d3ba01 Reviewed-on: https://chromium-review.googlesource.com/623040 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504167}
-
Evan Stade authored
Test: - log into two users, - maximize windows on both desktops, - switch between users Expected: - icons fade to and from black Actual (before patch): - no fading, just a white flash Regressed in 5fa8d94b Bug: none Change-Id: Ia43c309a1cafa4f868221605f0ceaec6400d7dad Reviewed-on: https://chromium-review.googlesource.com/682879Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#504166}
-
Eugene But authored
The test were probably failing because the page did not finish layout after the load. Grabbing an HTML element forces layout and makes page prepared for the testing. This is a speculative fix, because I could not reproduce the failure locally. Bug: 767339 Change-Id: Id261b4d531b728a52ac7cb9276553bdb6978961e Reviewed-on: https://chromium-review.googlesource.com/682396Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#504165}
-
Sigurdur Asgeirsson authored
This is necessary to make these DLOG statments non-fatal in Albatross builds. Bug: 596231 Change-Id: I7634aad4eb74f2a0736f9e5775c6198368151c55 Reviewed-on: https://chromium-review.googlesource.com/679254 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#504164}
-
Avi Drissman authored
This reverts commit 06b45622. There already was a function to do this. BUG=none Change-Id: I66da553ce7eaecae8945cc1290d8045ff454209b Reviewed-on: https://chromium-review.googlesource.com/681847Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504163}
-
Hongchan Choi authored
This is a speculative fix for the associated issue. It is to prevent OfflineAudioContext from going away while there is an ongoing rendering task. - |run-webkit-tests| with "--enable-leak-detection" shows no leak. Bug: 763798 Change-Id: Id41e6966bed7d5af946ae29fdeea5a2a43af8220 Reviewed-on: https://chromium-review.googlesource.com/679287 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#504162}
-
Francois Doray authored
WorkerPool is being deprecated in favor of TaskScheduler. Bug: 659191 Change-Id: I6b0455425ef6e2f7ea899ca0b2634aa7768d63b7 Reviewed-on: https://chromium-review.googlesource.com/637024 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#504161}
-
Lei Zhang authored
Change-Id: Ib48380ccab99ea7fc75ce62be8bf014017ee9404 Reviewed-on: https://chromium-review.googlesource.com/673375Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504160}
-
Weidong Guo authored
Changes: 1. Override OnKeyEvent in AppListView and SearchBoxView to redirect key event to SearchBoxTextfield through Textfield::InsertChar() and Textfield::OnKeyEvent(). 2. Make SearchBoxTextfield focused when query changes in SearchBoxView::ContentsChanged or key event is handled by Textfield::OnKeyEvent(). 3. Add a SetFirstResultSelected() in SearchResultContainerView to set a fake focus (highlight background) on first search result whenever query is updated. Hitting enter when SearchBoxTextfield is focued opens the first search result. 4. Add test coverage: a. Type query when focus is on close button, suggestion app, expand arrow. b. First result is selected when query updated. c. Hitting Enter when search box is focused opens the first result. Design doc: go/applist-focus BUG=767996 TEST=AppListViewFocusTest Change-Id: I5e523c4d2d392b888d8029043dab843010031080 Reviewed-on: https://chromium-review.googlesource.com/679157Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504159}
-
Kevin Cernekee authored
shill now handles connections from Android VPN apps. BUG=696865 TEST=none Change-Id: I5e2fab8ccb9e212098caba87cbe27ae96df4469d Reviewed-on: https://chromium-review.googlesource.com/679866 Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504158}
-
Carlos Knippschild authored
Moves schema creation and migration code out of PrefetchStore and into the newly created PrefetchStoreSchema. This is a step towards having a generic storage architecture for all of Offline Pages features. This also introduces the first migration code that will upgrade the schema from version 1 to version 2. This will ensure that all users have the latest version of the items table, for which the default |file_size| column value is -1. PrefetchStoreSchemaTest has unit tests for the schema management class itself and for SQLite preconditions that ensure its logic works. Bug: 701939 Change-Id: Ica8c2905bbb4f9bf76721c83e69d2b61044fa95d Reviewed-on: https://chromium-review.googlesource.com/656402 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504157}
-
Ken Rockot authored
Adds a utility class to the public C++ API for feeding arbitrary string data into a data pipe producer handle. This takes care of chunking the string data as necessary to account for limited data pipe capacity. BUG=721414 R=jcivelli@chromium.org Change-Id: I45c9d8355ccf57cd7d1b22bf44caae1b50534248 Reviewed-on: https://chromium-review.googlesource.com/682634Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#504156}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/29bf84f08a37..94fddf83816a $ git log 29bf84f08..94fddf838 --date=short --no-merges --format='%ad %ae %s' 2017-09-25 liyuqian Add measurement command line args to SampleApp 2017-09-25 wangxianzhu Reland "Fix SkImageSource::filterBounds()" again 2017-09-25 nagarajan.n Merge fCurrIncrementalCodec and fCurrScanlineCodec usage into single variable 2017-09-25 liyuqian Reland blitFatAntiRect with guard to avoid overhead in MaskAdditiveBlitter Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ifd2c6ce7915561b952ef8e92c9070f8b741f4ce6 Reviewed-on: https://chromium-review.googlesource.com/682646Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504155}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c42c017f..89e89852 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I340b06cb9ffa6458201426dd9402e4e7290d0c53 Reviewed-on: https://chromium-review.googlesource.com/682183Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#504154}
-
Lori Oliver authored
Move logic of generate_system_health_csv to generate_system_health_csv.py in order to allow for imports. Move into tools/perf/core Bug: chromium:723636 Change-Id: Ied8df78b51200110f8baa61b0e7cba8a617e2b72 Reviewed-on: https://chromium-review.googlesource.com/675667 Commit-Queue: Lori Oliver <loloangela@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504153}
-
Xida Chen authored
This is the follow-up CL after this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/677648 This CL also moved some tests from fast/canvas to fast/canvas-api/ Bug: 725651 Change-Id: I73f5324973c963a69933ac96a2a9aaec7eafd71c Reviewed-on: https://chromium-review.googlesource.com/678334Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504152}
-
kylechar authored
This CL replaces instances of make_scoped_refptr() with MakeRefCounted() for constructing scoped_refptr<>s where possible. MakeRefCounted() only works if the class has a public constructor, so not all instances are replaced. Bug: 765333 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic53d512940f7cc53a959e967a63da0ca94a95eae Reviewed-on: https://chromium-review.googlesource.com/676646 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#504151}
-
Alexander Alekseev authored
Bug: 760490 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e0046a02ad521fdf060e2677ae7d657a602a3d0 Reviewed-on: https://chromium-review.googlesource.com/682154Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#504150}
-
Zhiling Huang authored
Previously, for tags that are unknown, we will include the logcat only when its priority level is e(error). This condition makes us lose a lot of usefull logcat, because the condition basically means we do not include logcat by default. It was a whitelist only. In this cl, I am removing this condition. Thus for all tags that are unknown, we will include the logcat no matter what its priority level is. This way we will make sure that no important logcats are lost, and will include logcat by default. In the future, if we find that we have included too many logcats and want to blacklist a tag, we can simply add <tag>:S into the LOGCAT_FILTERS to blacklist the logcat with that tag. Bug: 766743 Change-Id: I970a646a65b06fb66009a90c9a49df122c74d31d Reviewed-on: https://chromium-review.googlesource.com/680894Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#504149}
-