- 26 Jul, 2019 40 commits
-
-
Patrick Monette authored
Ready for round 2. We're now aware of the side-effect of turning this process mitigation for TSF IMEs (sets immersive mode) and we're ok with it. Bug: 557798 Change-Id: I2f2dbb3e6182f4d9cf05e1f97424a3959fde920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721458Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#681460}
-
Ahmed Fakhry authored
Windows placed in inactive virtual desks will be considered hidden by the occlusion tracker. This currently end up in a call to RenderWidgetHostViewAura::Hide() which unnecessarily hides the aura::Window. This causes issues when reflecting that window in the desks mini_views. This CL keeps the aura::Window visible, while updating only the occlusion state. BUG=866622 TEST=Added a new test. Change-Id: I7f71cfa072240264fea2e4934f2c7350f66a74c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711113Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#681459}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e5bc2758b312..e2a6c7b2edba git log e5bc2758b312..e2a6c7b2edba --date=short --no-merges --format='%ad %ae %s' 2019-07-26 tsepez@chromium.org Weakly cache CPDF_IccProfile in CPDF_DocPageData 2019-07-26 tsepez@chromium.org Remove UnownedPtr<>s to CPDF_Object subclasses. Created with: gclient setdep -r src/third_party/pdfium@e2a6c7b2edba The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ide77e1f79754b5220768aa3dabe2bfcc1311c3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721182Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681458}
-
Matthew Cary authored
Change-Id: I31efe81b4623e4a4e8c15b7594137aad03a237e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697622Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681457}
-
Abhishek Bhardwaj authored
This change ensures that the attempt to unmount crostini's sshfs completes before the device is allowed to suspend. Previously, the device may suspend while the unmount attempt is ongoing. BUG=968060 TEST=Manually test that sshfs is unmounted and device is allowed to \ suspend. Change-Id: Ifd480c2bf6ad90cb1962786e34b2cc359f1e10f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719777 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Auto-Submit: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#681456}
-
Tibor Goldschwendt authored
Move the resources for the internal bluetooth about pages out of the browser_resources.grd and into a newly created GRD file. Add grit target for the new GRD file. This CL prepares moving the resulting PAK file into the dev UI DFM on Android. Bug: 955494 Change-Id: I3a12c92d977c39ca65b61b6c6022c5f229cc9434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709999 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#681455}
-
Sofiya Semenova authored
Bug: 972128 Change-Id: I517faf278f4f92e55daa973966bac9ca0ff920f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688355 Commit-Queue: Sofiya Semenova <sofiyase@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681454}
-
Steven Bennetts authored
Bug: 987923 Change-Id: Iff95482d23ae0f9851b55a69d15679da17387297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721018 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#681453}
-
Daniel Clark authored
An <input type='search'> should have LocalizedControlType of "search box" per https://w3c.github.io/html-aam/#el-input-search and https://www.w3.org/TR/core-aam-1.1/#role-map-searchbox Currently its LocalizedControlType is "edit". This change updates it to "search box" by changing AXNodeObject::NativeRoleIgnoringAria() to check for input type='search' and use ax::mojom::Role::kSearchBox for it (instead of ax::mojom::Role::kTextField as was used before). The UIA_LocalizedControlTypePropertyId case of AXPlatformNodeWin::GetPropertyValue is changed to check for the kSearchBox role and return the correct string rather than falling back to the value provided by Windows' UIA implementation. Additionally, AXPlatformNodeWin::UIAAriaRole() is updated such that <input type='search'/> has the AriaRole of searchbox rather than textbox. Bug: 986554 Change-Id: I268c6c0d1bc3d136e3d533a90d5f2a0436945789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713867 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681452}
-
Ken Rockot authored
ServiceFactory is relatively simple helper API for Mojo consumers to handle service interface requests, typically in a sandboxed service process. This is used here to reduce error-prone and inconvenient boilerplate around out-of-process service launching in Content and its embedders. Bug: 977637 Change-Id: Iae3dcd1335280fc2ec96014d7009ce5183060638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717474 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681451}
-
Sophie Chang authored
This initially introduces a subset of PreviewsHints logic into this new service to incorporate the component hints and puts it into the store without any mechanisms for retrieving it out of the store (that will follow in subsequent CLs). Following this new path is subject to the new "OptimizationGuideKeyedService" Feature being enabled. Once this new path for loading and managing hints is fully landed, the logic will be removed from PreviewsHints and PreviewsOptimizationGuide. Bug: 969558 Change-Id: Ieebaf137e1b93dadc55dc381d3edad0606fe7b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709652 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#681450}
-
Natalie Chouinard authored
Now that the preferences Support Library migration is complete, and duplicates have been removed (crrev.com/c/1709880), we can remove the Compat suffix from all methods and classes. Bug: 967022 Change-Id: I91a82a965a2469fbbd3013fe8277fe8f00813da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710054 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#681449}
-
Eugene But authored
This directory contains callbacks to present UI and inspect UI-related properties. TBR=mahmadi@chromium.org Bug: 942244 Change-Id: Iad2b186a949681961769b1daba1242668d08237b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717882 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#681448}
-
Robert Kaplow authored
Bug: 969926 Change-Id: I6dfab44d9edf50c29c32e2b32da8d3ed6c597a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709784Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#681447}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/094fa97a20d7..bff98571c079 git log 094fa97a20d7..bff98571c079 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 hjd@google.com Merge "Fix presubmits" Created with: gclient setdep -r src/third_party/perfetto@bff98571c079 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I699c4e7bbde6715b29d0d9a70071dde89b5c581a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721016Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681446}
-
Robert Kaplow authored
Bug: 975043 Change-Id: If80af23260743ff4ba098e95f8599771a1d2ee8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710193Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#681445}
-
Dominic Battre authored
These tests have been labeled as slow on Linux and Windows but they are also timing out on MacOS 10.13. TBR=serb@chromium.org Bug: 983642 Change-Id: I70b43867cf47b8056d441a4a3e3399ddb8e3c2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720877Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#681444}
-
Mohsen Izadi authored
The actual content rect of magnified container might be larger than its bounds. To avoid this extra content becoming visible in the docked magnifier, clip magnifier layer to its bounds. BUG=947565 Change-Id: I185df56c12a2d45118b5cf35ce6240ac2b5a5fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717540Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681443}
-
Dominic Battre authored
To simplify debugging of client problems, we now log version info, including variations in our internals pages. Bug: 928595 Change-Id: I25d1e59ed373c5c320372af73f32756013374c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710656 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#681442}
-
Mustafa Emre Acer authored
Change-Id: I9319577e1ddaeff2a1fa084b2855d45e3a6e643b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716954Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681441}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0716ce0a2c0c..6e9098629bca git log 0716ce0a2c0c..6e9098629bca --date=short --no-merges --format='%ad %ae %s' 2019-07-26 jonahr@google.com Update dEQP charts. 2019-07-26 dongja@google.com Vulkan: invalidate translation buffers for SSBOs 2019-07-26 lujc@google.com Fix param name of glDrawArrays capture 2019-07-26 clemendeng@google.com Get rendering to texture working Created with: gclient setdep -r src/third_party/angle@6e9098629bca The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I8ec6e614d78ea6a122371b8fcfdb1479f15e6c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681440}
-
kylechar authored
The tests pass so they can be enabled and the TODO removed. Bug: 622107, 916318 Change-Id: Iad24954f9d4648e42d870ab20a6df83eb31697f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721456 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#681439}
-
Dave Tapuska authored
Extensions are allowed to talk to other extensions in other frames so they should have the same agent. BUG=970360 Change-Id: Ic16f5e4179ef1af67a9fbefa0679f56293200d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709095Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681438}
-
Jordy Greenblatt authored
3 of the pageVisibility paths (search, androidApps, system) that are read by the settings-basic-page [1] are never defined and are not part of the PathVisibility typedef [2]. I think the dom-if they control were simply never removed when the paths ceased to be used. This CL cleans up settings-basic-page by removing the references to non-existent paths. [1] https://screenshot.googleplex.com/CPO8xHQ9WSx [2] https://screenshot.googleplex.com/nxGJbNy8vbx Change-Id: I25a99720a6f4df25a6e5b1ac64acd419bba15eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716338Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#681437}
-
Xiyuan Xia authored
This reverts commit 2c8bdfae. Reason for revert: https://crrev.com/c/1719447 makes the CL unnecessary. Original change's description: > cros: Fix ml::UserActivityManager shutdown crash > > SessionManager is released in PostMainMessageLoopRun that > happens before PostDestroyThreads. ml::UserActivityManager > is released with DbusServices PostDestroyThreads. Hence it > crashes on shutdown when trying to un-observe SessionManager. > > This CL adds a OnSessionManagerDestroyed to SessionManagerObserver > interface so that ml::UserActivityManager could clean up in time. > > Bug: 987010 > Change-Id: I05043a3e0b946bfb9e733ad476dacc35e9a9a3b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715401 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680197} TBR=xiyuan@chromium.org,jiameng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 987010 Change-Id: I7fbd5cc8d3e693c7d6b1ceb169d10914040afa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720999Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681436}
-
Jordy Greenblatt authored
Bug: 987786 Change-Id: I6d2fd6049c2fd24d8de3a80311875ce533085b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719450Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#681435}
-
Nico Weber authored
Bug: 747727 Change-Id: I33f44e3f4011873e193088796483ecdc48f7f05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720610Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681434}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/378cae2543f5..170480122614 git log 378cae2543f5..170480122614 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 yvesg@webrtc.org Prevent concurrent access to AudioSendStream's configuration. Created with: gclient setdep -r src/third_party/webrtc@170480122614 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2cdac076edbf17fe7c1ace32e83c52ac9b4f0e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681433}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/506ce9bba43b..e69627f35ec5 git log 506ce9bba43b..e69627f35ec5 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 natlee@microsoft.com Backdoor to get the number of texture lazy clears for testing Created with: gclient setdep -r src/third_party/dawn@e69627f35ec5 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5d0d55ee216f47d8885fe8886cbea75c4a036efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681432}
-
Matthew Cary authored
Add an UnsafeSharedMemoryRegion constructor for BitstreamBuffer. While BitstreamBuffer continues to represent its shared memory internally by base::subtle::PlatformSharedMemoryRegion due to being used sometimes read-only and sometimes writable, this constructor makes the bitstream buffer easier to use in the common case of client/tests which create a buffer backed by unsafe (writable) shared memory. Bug: 849207 Change-Id: I271bcd389e936ab2e7207bb2684fc6bcd8c2d529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695264 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#681431}
-
Malay Keshav authored
chrome_extensions.js: 313586d3a33182f2493f4440aae39847b689225e -> 66f8cf1fdb5799a63f72e6e054c12aae99152d64 Important changes: - clipboardData property of an Event class is different from the clipboardData property of the ClipboardEvent. The former is of type ClipboardData while the latter is of type DataTransfer. The API being used throughout file_transfer_controller.js for clipboardData is that of DataTransfer, but it was being marked of type ClipboardData, thus resulting in compiler errors. Specific examples: - clipboardData.items.add() - setDragImage() - Using HTMLElement instead of Element since DataTransfer API to set drag image requires an HTMLElement. - Changing calls to web_animations API so that the format being used is a supported one. This will need to be updated when the web_animations API is updated upstream in closure and the support for all formats as described in w3c standard are added. - As of now KeyframeEffectOptions is not in the closure extern. Until it is added KeyframeAnimationOptions needs to be used which is its base class. - KeyframeEffectReadOnly, KeyframeEffect and Animation are now a part of the closure compiler upstream and do not require externs on the chromium checkout. Bug: 987835 Change-Id: I869ee497ffd4017abca889f5767df1981781b80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715123Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#681430}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3614ad6f574..c10743f873f3 git log e3614ad6f574..c10743f873f3 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c10743f873f3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I70be8575c0a62b14525b16106f9516cab3692afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681429}
-
Will Harris authored
BUG=750886,988021 Change-Id: I01e07a3e36815d9f9f8081a9890976f9cefb9764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721509Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681428}
-
Natalie Chouinard authored
This reverts commit a076c4e2. Reason for revert: Compile failure List of errors: ../../chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java:147: error: cannot find symbol Original change's description: > [StartSurface] Implement explore surface with feeds > > Screenshots: > https://drive.google.com/file/d/14ssIg6-tvLU_yAa8RTZEPHNsvbfGYgTa/view?usp=sharing > > This CL split the original FeedNewTabPage, FeedNewTabPageMediator and StreamLifecycleManager > into multiple classes, but we do not expect visible changes on FeedNewTabPage. > > This CL also fixed the dummy FeedNewTabPage which was broken by > https://chromium-review.googlesource.com/c/chromium/src/+/1709731 > > Bug: 982018 > Change-Id: I933cb01789d5eda8a196de00e4bf279bb7d6d785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715410 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: David Trainor <dtrainor@chromium.org> > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Auto-Submit: Ganggui Tang <gogerald@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681412} TBR=dtrainor@chromium.org,yusufo@chromium.org,gogerald@chromium.org,skym@chromium.org Change-Id: I6af1d483fc1b912d1b60d2ba9b7280125c65b410 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 982018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721000Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#681427}
-
Kristyn Hamasaki authored
Change from text() to GetText() and read_only() to ReadOnly() in order to convert to properties. Bug: 979037 Change-Id: I07939e24857d4ebce541c54394fb41d0f77d29df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679533 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#681426}
-
Yuwei Huang authored
This CL removes unused scopes from Android client and test binaries. Bug: 983282 Change-Id: I2e8b7ff344e0dcfafafca28d3025ec8b49c3fed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719228 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#681425}
-
Hesen Zhang authored
- Added sanity check for icons field in NotificationData. Bug: 987823 Change-Id: I01e839a3c77783931a3ca8da58b99e6f6e941c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719671 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681424}
-
Owen Min authored
Turn off pretty print. Use default value of no convert value, no device data, convert type and includes user policies. Bug: 983174 Change-Id: I54ac204c18d55463431beade7e54d619b4b81051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721450Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681423}
-
K Moon authored
Refactors layout-specific state (document size, rotation) from PDFiumEngine into a separate DocumentLayout class. This will allow new layouts to be computed without disturbing the current layout. As a side benefit, this should be another step towards simplifying PDFiumEngine to be less of a grab bag of concerns. Bug: 885110 Change-Id: Ieabde78d8acdcb2f83aac980d03f6fd8f28295a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716158 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#681422}
-
Xiyuan Xia authored
Release MachineLearningDecisionServiceProvider before tearing down ash to fix the crash. Bug: 987687 Change-Id: Ice42d1c50b0534d5f8386038087b74a84bd6969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719447Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681421}
-