- 02 Dec, 2019 40 commits
-
-
Steven Bennetts authored
This provides support for type="chrome_messages_json_gzip" in grit/build.py, which compresses the output files (which should have .gz appended to the name, e.g. messages.json.gz). This makes it fairly simple to convert an extension (e.g. chromevox) to use compressed l10n files. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1913610 For changes reviewed in the original CL: TBR=agrieve@chromium.org Bug: 1023568 Change-Id: Ibf8dfa374f5e759b3b459d007fde2423f83873a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931097 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720686}
-
Ian Barkley-Yeung authored
enums.xml changes for https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1940859 Also adds the enums.xml change forgotten from https://chromium.googlesource.com/chromiumos/platform2/+/0fa84e461270d78304f704117b997fd222b499b2 BUG=chromium:1021374 TEST=See other change Change-Id: I87d4427f91e58397a0c2c92468c819e2caeee87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941049 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#720685}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3945.24-1574681176-benchmark-80.0.3964.0-r2 to 80-3945.42-1575283012-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7918481b83d6107e0b28482531e59ec3a5e7400d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720684}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3945.24-1574678177-benchmark-80.0.3964.0-r2 to 80-3945.42-1575284288-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id60e38a7e93b5a2ecf16ed344fa0a06d83739c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946537Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ae4817ada0b..02b5af35755b git log 5ae4817ada0b..02b5af35755b --date=short --first-parent --format='%ad %ae %s' 2019-12-02 apolito@google.com fix hashtags: double colons are not hashtags 2019-12-02 bsheedy@chromium.org Switch yapfignore to fnmatch Created with: gclient setdep -r src/third_party/depot_tools@02b5af35755b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027953,chromium:896110 Tbr: agable@chromium.org Change-Id: I3483e11ad192e72a9609c237b268748683cfc9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946866Reviewed-by:
-
chrome://media-appTrent Apted authored
Adds a consumer for window.launchQueue in chrome://media-app that opens the file and sends it to the existing loadBlob(), which sends the blob to the unprivileged guest app to load. Adds an integration test that ensures launch params passed via the AppService OpenApplication() will correctly open an image in the media app. SystemWebAppManagerBrowserTest is refactored away from extensions slightly. Rather than use extensions::browsertest_util::LaunchAppBrowser(), it uses LaunchService::OpenApplication(AppLaunchParams) directly. Mostly this just avoids having to fetch the Extension* only to use extension->id() to get the app_id back again. Bug: 996088, 1023742 Change-Id: I85624e93618d82ccce1c80d04d21d81303579a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913282Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#720681}
-
rbpotter authored
Bug: 1022212 Change-Id: I72a0ed7cf5d998199d720b5af1659e05082c0b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938831 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#720680}
-
Karan Bhatia authored
RulesetMatcherInterface is no longer an interface. Rename and move the files to reflect the same. BUG=974391 Change-Id: I6c9f8a7aaba9637f942e59083c2728c9678d5968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937577 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720679}
-
Bill Budge authored
- Adds cache type parameter to disk_cache::PreferredSize. - Changes implementation to make default cap size 50% larger in if cache type is net::GENERATED_NATIVE_CODE_CACHE. Bug: chromium:917510, chromium:1019999 Change-Id: Ieb5dd21aa76e387774659131a3d3aa3e6eed2889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937852 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#720678}
-
Adrienne Walker authored
This stores a shared remote of the blob remote when generating the IndexedDBBlobInfo and converts the IndexedDB "get" codepaths to use this remote instead of BlobDataHandle. I considered making IndexedDBBlobInfo to be move only and storing the Remote (or a PendingRemote) directly, but there were too many uses in idb cursor-related code that wanted to store info for this to be an easy task. Therefore, the info just stores a shared remote, which can be copied. This is a half-way patch that converts IndexedDBBlobInfo to use blob remotes, but doesn't remote the use of BlobDataHandle. It cleans up a bunch of code though and enables some other cleanup of IndexedDBDispatcherHost: https://chromium-review.googlesource.com/c/chromium/src/+/1910810 The next step after this patch is to remote BlobDataHandle entirely from IndexedDBBlobInfo and convert the writing of blobs using IndexedDB to use blob remotes instead of those handles. Bug: 102214 Change-Id: If13e07797ffe341e9552cb45b56bf8b6071e2068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937374 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#720677}
-
Sorin Jianu authored
The Improved Recovery Component is not using registering prefs. Bug: 1027159 Change-Id: I737b602d01d8c22af61f027641b9229c228c27ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931539 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#720676}
-
Sahel Sharify authored
This cl renames isChanging() to isWaitingForPaymentDetailsUpdate(). This function returns true after changePaymentMethod(), changeShippingAddress(), and changeShippingOption() calls an before updateWith() or NoUpdatedPaymentDetails() are called, showing that change events are fired and we are waiting for merchants response. This cl also renames noUpdatedPaymentDetials() method to onPaymentDetailsNotUpdated() since the latter is more appropriate for showing that the merchant has not updated any payment details in response to change payment method, shipping address, or shipping option events. TBR=kenrb@chromium.org Bug: 984694 Change-Id: I9b9b5080c31b58432a42f611b880afa21fa79ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946597 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720675}
-
Matt Falkenhagen authored
Bug: 1007763 Change-Id: I5d7de99da99b88f59cd56832b0f87c32e8d0be27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942901Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720674}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib05218c52372c4f4fc503f5131f79532a84b4594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946894Reviewed-by:
-
Jasper Chapman-Black authored
Sparse .sizediffs may have zero symbols, and so zero components. Change-Id: I8d24f5715c6b82ea38b544ffa4a8aaad5b988b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945275Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720672}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Icc3ff91a184e5f103ff5ef7faadfe96921503ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946930Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#720671}
-
Tim Song authored
BUG=1021133 Change-Id: I7785f3184be08c33e333b6c918ba97762c25d986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940611Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720670}
-
Fredrik Söderquist authored
For interval updates performed "outside" of the regular flow in SMILTimeContainer, we would use the "previous" presentation - i.e the time just before the time we latest updated timing to. This could cause elements to resolve intervals in the past - for example when the latest update time was at the end of an interval it could discard the current interval and resolve an interval in the past, which could then be propagated to its dependents. When these elements were later updated by the main update loop they would again discard the current (in the past) interval and resolve a new one, notifying its dependents. Repeat. Instead always use the "latest update time" (the same is used by SMILTimeContainer::UpdateIntervals) as the argument to Updateinterval(), and only use the "previous" presentation time when checking if the active state may have changed in a relevant way and for rescheduling. Bug: 1021630, 1028839, 1029327 Change-Id: Ibe691ae336df51a36626fdd800e5ddc2303aee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939788Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#720669}
-
Yuly Novikov authored
In order to limit access to GPU resources by resource type. Moves Mac GPU trybots into a separate file. Bug: 1020753 Change-Id: Ic215312d129540f2674083b67f1261ab14af2d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918372Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#720668}
-
Ahmed Mehfooz authored
Bug: 1026073 Change-Id: I187064836c15c4014eae8f925a6e262df556670b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938257Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19f9f4148196..ca1b0fb895ca git log 19f9f4148196..ca1b0fb895ca --date=short --first-parent --format='%ad %ae %s' 2019-12-02 timvp@google.com VULKAN: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d Created with: gclient setdep -r src/third_party/angle@ca1b0fb895ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: If8ac23b98f79c86781840eac7712ec273a770d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946891Reviewed-by:
-
Elly Fong-Jones authored
This is a reland of 1e92aab4 Original change's description: > cbui: disable PageInfoBubbleView focus tests on Mac > > These tests don't work on Mac - it's possible that they never did, or > they may have broken recently. Unfortunately the entire suite is > disabled (see issue 899286). This change marks these two tests > explicitly disabled pending a real fix. > > Bug: 1029882, 1028239 > Change-Id: I3a11ae61470850fd55ad95353c7eacd4ac516169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946394 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720629} Bug: 1029882, 1028239 Change-Id: I6077af8cd9431e069c766c71717a92de670ed210 Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945895 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720665}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=mbarbella@chromium.org Bug: 891670 Change-Id: I2ef63eb8930f041ef6fb1c304e81d8ed938c9aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944849 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#720664}
-
Martin Kreichgauer authored
Refactor the settings-security-keys-pin-field JS interface to expose a single trySubmit() method that can be used to trigger PIN validation and submission. It previously had separate methods for validation and submission which caused unnecessary duplication in the credential management and fingerprint enrollment dialogs. With the new interface it is simpler to keep the two consistent. This also fixes a bug where it was possible to trigger multiple concurrent PIN submissions in the credential management dialog. The confirm button was disabled during PIN submission, but then re-enabled immediately once the PIN was accepted and credential enumeration was kicked off. If credential enumeration was sufficiently slow, a second PIN submission could be triggered, leading to a crash in the message handler code. No other functional changes. Fixed: 1027039 Change-Id: Ief6967bee17cc382912f158b7e7ec42b86014c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931378 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Ilia Samsonov authored
https://codereview.chromium.org/2857643002 forced all sanitizers builds to print address offsets only. This output is meant to run through tools/valgrind/asan/asan_symbolize.py yet test_env has different configuration to run through the asan_symbolize.py. The asan and tsan builds for this cl give meaningful output. Before, Stack trace: #0 0x55d1d54e8bc3 (/b/s/w/ir/out/Release/content_browsertests+0x1cf42bc2) #1 0x55d1ccb003ab (/b/s/w/ir/out/Release/content_browsertests+0x1455a3aa) #2 0x55d1ccb2b740 (/b/s/w/ir/out/Release/content_browsertests+0x1458573f) #3 0x55d1ccb29747 (/b/s/w/ir/out/Release/content_browsertests+0x14583746) #4 0x55d1c82f2530 (/b/s/w/ir/out/Release/content_browsertests+0xfd4c52f) #5 0x55d1d40a8d42 (/b/s/w/ir/out/Release/content_browsertests+0x1bb02d41) #6 0x55d1d4333e88 (/b/s/w/ir/out/Release/content_browsertests+0x1bd8de87) #7 0x55d1d16f3fc2 (/b/s/w/ir/out/Release/content_browsertests+0x1914dfc1) #8 0x55d1d2e62e79 (/b/s/w/ir/out/Release/content_browsertests+0x1a8bce78) #9 0x55d1d16f0f65 (/b/s/w/ir/out/Release/content_browsertests+0x1914af64) #10 0x55d1d16fb299 (/b/s/w/ir/out/Release/content_browsertests+0x19155298) #11 0x55d1d16eb211 (/b/s/w/ir/out/Release/content_browsertests+0x19145210) #12 0x55d1d1085a78 (/b/s/w/ir/out/Release/content_browsertests+0x18adfa77) #13 0x55d1d1084d99 (/b/s/w/ir/out/Release/content_browsertests+0x18aded98) #14 0x55d1dba2402c (/b/s/w/ir/out/Release/content_browsertests+0x2347e02b) After, Stack trace: #0 0x562f0d54eee3 in StackTrace ./../../base/debug/stack_trace.cc:206:12 #1 0x562f0d54eee3 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #2 0x562f051de24b in StackTraceGetter::CurrentStackTrace(int, int) ./../../third_party/googletest/custom/gtest/internal/custom/stack_trace_getter.cc:22:27 #3 0x562f051fdb40 in testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) ./../../third_party/googletest/src/googletest/src/gtest.cc:820:35 #4 0x562f051fc527 in testing::internal::AssertHelper::operator=(testing::Message const&) const ./../../third_party/googletest/src/googletest/src/gtest.cc:401:25 #5 0x562f0127b36b in content::PointerLockBrowserTest_PointerLockWheelEventRouting_Test::RunTestOnMainThread() ./../../content/browser/pointer_lock_browsertest.cc:518:5 #6 0x562f0c30fba6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:656:5 #7 0x562f0c54407b in Run ./../../base/callback.h:132:12 #8 0x562f0c54407b in content::ShellBrowserMainParts::PreMainMessageLoopRun() ./../../content/shell/browser/shell_browser_main_parts.cc:168:26 #9 0x562f09b284d2 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1031:13 #10 0x562f0b1a6839 in Run ./../../base/callback.h:98:12 #11 0x562f0b1a6839 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #12 0x562f09b25475 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:940:25 #13 0x562f09b2f519 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:128:15 #14 0x562f09b1f61f in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #15 0x562f0959b1e8 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:527:10 #16 0x562f0959b1e8 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:960:10 #17 0x562f0959a50d in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12 #18 0x562f1327ce25 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:423:29 Bug: 877205 Change-Id: Ib83c3e72919f0d1664cd2e2d338cbd21982d1c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894762Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#720662}
-
Joe DeBlasio authored
This CL removes the dump without crashing that was triggered when download initiators were unknown. A subsequent CL will record a histogram here instead, but we've learned what we can from the traces. Bug: 1029003,1028179 Change-Id: I6117add43d77577555707e98eb7ed806ba5fe4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946927 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720661}
-
Arthur Wang authored
R=anushruth@chromium.org, bpastene@chromium.org, gbeaty@chromium.org Bug: 1015440 Change-Id: Ic5f7739fc9ee6efbc4f710f7301c82b3746ca945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910679 Commit-Queue: Arthur Wang <wuwang@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#720660}
-
Andrew Grieve authored
When enumerating classes, filter out those that do not have "Test" suffix. Spot checked 2 random shards of android-kitkat-arm-rel with and without this change. Both before shards took 41 seconds to list tests. Both after shards took 23 seconds. Change-Id: I35b5521095a9ccea857b8fed6d9d009a7d9c7c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946432 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720659}
-
Juan Antonio Navarro Perez authored
Make it easier add new files to update/verify by just havint to create a new "updater" function. Avoids all the code duplication in previous "verify"-ing functions. Bug: 1029042 Change-Id: Ia85209a38b588f7687aabdd04e2b68fb8e820037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944679 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720658}
-
shrekshao authored
Bug: 681341 Change-Id: I09ae60107987e2032a042a7074e39ad0fb5ae454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938249Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#720657}
-
Jasper Chapman-Black authored
The WebAssembly web worker parses .size and .sizediff files, the JS web worker parses .ndjson files. Previously, the web worker would be set on pageload according to the load_url parameter, so if you loaded a .size file and then uploaded a .ndjson to view, the viewer would crash. This CL refreshes the web worker on each file upload. Change-Id: I182ac524bfd7049ed178bd2c6784bb0282f0ee8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946858Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=dalecurtis@chromium.org Bug: 891670 Change-Id: I49b6558414f9fe68fa26c966df03172a2069493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944150 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#720655}
-
Joe DeBlasio authored
This CL allows autofill on pages with valid TLS, but using legacy TLS certs or other non-fatal certificate errors. Bug: 1029906 Change-Id: I3676919fe7aa13c1aad82920f4cb74cb137af21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946984Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#720654}
-
Daniel Murphy authored
This reverts commit 1823d527. Reason for revert: Seems to have caused determinism failures Bug: 1029863 Original change's description: > Update V8 to version 8.0.419. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/adfb6ba3..684d2057 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ia2bb5ff51bfe4d6b2ebc77c171097d374c34df39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944383 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#720481} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I094b8bbd5aa4db4563299c90847a317ef63a106a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel, luci.chromium.try:linux_optional_gpu_tests_rel, luci.chromium.try:mac_optional_gpu_tests_rel, luci.chromium.try:win_optional_gpu_tests_rel, luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946452Reviewed-by:
-
Daniel Murphy authored
TBR=dominickn@chromium.org Bug: 1030009 Change-Id: I93453317cf22604a947e22ecca42e15099eab78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946449Reviewed-by:
-
Etienne Pierre-Doray authored
This reverts commit e48149cf. Reason for revert: Step "compile" failing on 7 builder(s) Original change's description: > Roll src-internal 33ae3e65534f..a9771748c0c2 (2 commits) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae3e65534f..a9771748c0c2 > > > Created with: > gclient setdep -r src-internal@a9771748c0c2 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC jbudorick@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1017165 > Tbr: jbudorick@google.com > Change-Id: I43ccf9ae85647651302c034510f25fbb6bbd1565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946887 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#720642} TBR=jbudorick@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I3a4dbdf003fd3c39c57ca867f6281adcf16b79b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1017165, 1030005 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947096Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#720651}
-
Findit authored
This reverts commit 15204aaf. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 720636 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE1MjA0YWFmMDdlYWZmNTkzZDdhM2Q2ZDdlYjdhNjljOGI5MGE1NWEM Sample Failed Build: https://ci.chromium.org/b/8895149418482727520 Sample Failed Step: compile Original change's description: > refactor android locales in locales.gni > > This CL refactors build/config/locales.gni but makes no actual > changes to what locales are used. > > The primary change is to remove android_chrome_omitted_locales > and replace it with android_non_bundle_locales. > This list should be used directly instead of subtracting omitted > locales from locales. > > Additionally the list all_chrome_locales was added as the superset > of all supported locales. Platform specific lists are made by > subtracting from this list. > > No changes were made to the iOS and Mac locale lists names. > > Bug: 812837 > Change-Id: I26e9c1b2d40397a6ed02777db55c44be93060050 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939962 > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720636} Change-Id: I91d7824e9e0b292c3376556947cbe4aced6bd0be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947226 Cr-Commit-Position: refs/heads/master@{#720650}
-
Daniel Murphy authored
TBR=apotapchuk@chromium.org,xiyuan@chromium.org Bug: 1029965 Change-Id: Ib04027e8d35b6eb54ed95274e866139a7503630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946874Reviewed-by:
-
Findit authored
This reverts commit 1e92aab4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 720629 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFlOTJhYWI0YzVmZjI1YTZlOWM5MzExNzBlNDU2ODY3ZWQ1ZjI2MzcM Sample Failed Build: https://ci.chromium.org/b/8895150372258392000 Sample Failed Step: compile Original change's description: > cbui: disable PageInfoBubbleView focus tests on Mac > > These tests don't work on Mac - it's possible that they never did, or > they may have broken recently. Unfortunately the entire suite is > disabled (see issue 899286). This change marks these two tests > explicitly disabled pending a real fix. > > Bug: 1029882, 1028239 > Change-Id: I3a11ae61470850fd55ad95353c7eacd4ac516169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946394 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720629} Change-Id: I3bb692bd8fc7fbfea575f0ff1119bbcb7f17d019 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029882, 1028239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946868 Cr-Commit-Position: refs/heads/master@{#720648}
-
Findit authored
This reverts commit ca140dc0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 720640 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NhMTQwZGMwOTRmMTZiZGU3NGFkM2RlODUwNzY4YWRkYzgxYzE2ZGYM Sample Failed Build: https://ci.chromium.org/b/8895151056470093664 Sample Failed Step: compile Original change's description: > Replace uses of LogSymbolizedUnsymbolizedMinidumps > > Replaces all uses of LogSymbolizedUnsymbolizedMinidumps with > CollectDebugData, which is functionally identical but the name is more > descriptive of what it actually does. > > TBR=crouleau@chromium.org > > Bug: 1025034 > Change-Id: I1cbb2702efec1e608622ca0878399f5406a2775d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937854 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720640} Change-Id: I79cbb55d5d3d10828d66251e57b388f9377eaa1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946023 Cr-Commit-Position: refs/heads/master@{#720647}
-
