- 21 Sep, 2020 40 commits
-
-
Robert Ma authored
While working on https://crrev.com/c/2419575, I found that errors in PRESUBMIT_test.py were not informative. This CL would produce more error details when e.g. `wpt lint` fails to run. Change-Id: I87cd4a98bdf3eb7ca49313d30e799bd440d4ee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418990Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#808882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22d5e3c0712d..f343742a8c9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC etiennep@google.com,elklm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: etiennep@google.com,elklm@google.com Change-Id: I39eeb72e54303a71d4b9b1710567d2826631d23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421541Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808881}
-
Tanmoy Mollik authored
Scale ic_person_add_24dp to 40dp as discussed on this cl: https://crrev.com/c/2390906 Bug: 1107423 Change-Id: Iac64338e50c072380d53f1aab1ca07f492c1ca30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410387 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808880}
-
Pavol Marko authored
Historically, multi sign-in was disallowed when either the primary Profile or the Profile being added used / had used policy-pushed CA certificates. The reason for limiting this was that the certificate verifier used at that time (NSS) had process-wide caches, so certificate verification results could leak across Profiles. Now that we use the built-in certificate verifier, this risk does not exist, so allow multi sign-in regardless of the policy-pushed certificate state of the primary / secondary Profiles. Also move clearing of the local_state pref that tracks policy-pushed certificate usage for a Profile into UserSessionManagerImpl because MultiProfileUserController does not have a dependency on the policy-pushed certs infrastructure anymore. In a follow-up the pref can likely be migrated to be a user Profile pref now instead of a local_state pref. Bug: 718002 Test: unit tests, browser tests Change-Id: I1006e0cb1cb4c9fdd68f5373e18acb27f5c3eaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297566 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#808879}
-
Tim Volodine authored
This test is failing on L bots and android-bfcache-rel. BUG=1130564 TBR=tedchoc@chromium.org,wenyufu@chromium.org Change-Id: Ib35afbc97a288a79efa686c0011a403267ae00ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421514Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808878}
-
Sylvain Defresne authored
Test TranslateInfobarModalOverlayMediatorTest.UpdateLanguageInfo fails if system locale is not "en-US". This prevents running the test on a developer device if they want to use the device in their language. Bug: 1102968 Change-Id: Icdc61da3c1015388c89a8ecc90aeb45e5e93a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421457 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808877}
-
Swapnil authored
We have many extensions stuck in CREATED stage which is reported in ExtensionManagement::UpdateForcedExtensions when extension list is fetched from kInstallForceList pref. Some of the intermediate stages were added to investigate CREATED stage. This CL moves these intermediate stages to a new enum and introduces a few new stages for investigation. Following histograms are added: Extensions.ForceInstalledCreationStage Extensions.ForceInstalledStage2 Following histogram is deprecated: Extensions.ForceInstalledStage Bug: 989526 Change-Id: I17a1bd7d49c31b6363a0512a424017775098042f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390222Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#808876}
-
Andrew Grieve authored
Use autoninja from PATH so that it matches the version used when building explicitly (allows for devs that are using a custom-built version of ninja). Allow omitting -C when script is run from within the output directory. This matches ninja's behavior. Bug: None Change-Id: I55763f178e2cf85892efbb4397a7ec81ed054aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419608 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#808875}
-
Raphael Kubo da Costa authored
testdriver.js' documentation says "presently, testdriver.js only works in the top-level test browsing context (and not therefore in any frame or window opened from it". If we do not restrict the set_permission() call here, the call to initialize_generic_sensor_tests() in generic-sensor/resources/iframe_sensor_handler.html will time out waiting for it to complete when running the iframe tests outside the Chromium CI (i.e. in wpt.fyi or with "wpt run"). Change-Id: I522a5ebacb7da9e35bbe2ea3564d3288a34c653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421671 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#808874}
-
Norge Vizcay authored
[Autofill assistant] Extend AutofillAssistantPasswordManagerIntegrationTest.java to cover saving password The test was extended to cover presaving and saving password steps. It checks if the new generated password has been saved properly in the password store. Bug: 1130453 Change-Id: I6c05fbc9d3db13acc4724c9437e6e2d29cdd41bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421808Reviewed-by:
Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/master@{#808873}
-
Viktor Semeniuk authored
Change-Id: I89c6a46f6c10c322096ecbdb41870bd87fa80995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421889Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#808872}
-
Alice Wang authored
This CL uses monogram for account avatar when user is signed in and no profile photo is uploaded. Prior to this CL, the placeholder image was used in this case. Bug: 1127886 Change-Id: I7790911e338d8b3f7d4ab4ec9fe3e25e9dcce4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416373 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808871}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I37569794b4526ab0c90e82b0a133ca1d85bb14b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420917Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808870}
-
Rohit Rao authored
Disables the feature by default. BUG=1102794 Change-Id: Ia8132e8d959cc5017f18b5fd31618ae996de8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417654Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#808869}
-
Etienne Pierre-doray authored
org.chromium.chrome.browser.NavigateTest#testRendererInitiatedIntentNavigate TBR=qinmin@chromium.org Bug: 1130419 Change-Id: I72a257cce875efb96124f3167d48a41489898f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421629Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#808868}
-
Sylvain Defresne authored
This reverts commit c793bf0d. Reason for revert: suspected of causing consistent failures of MobileSessionShutdownMetricsProviderTest.ProvideHasPossibleExplanationMetric on iphone-device bot. Original change's description: > [ios] Add previous session info to synthetic crash report > > The data is retrieved from PreviousSessionInfo singleton and > includes the following fields: > - free_disk_in_kb > - memory_warning_in_progress > > Bug: 1103752 > Change-Id: I10e6fe758bfde8ad753cbbd363ab34afc1a52e44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414784 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808397} TBR=eugenebut@chromium.org,olivierrobin@chromium.org Bug: 1103752, 1130551 Change-Id: I372e3efa5e68d3375c9af044ac8bbe2f78125acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421594Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Rename Google services entry from "Other google services" to "Google services". Bug: 1130017 Change-Id: I3d979502eb78bc9b50667b65a8124c8274c0c5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420612Reviewed-by:
-
Amr Aboelkher authored
Extend the expiry date by half a year for the following accessibility shortcuts: - CrosHighContrast - CrosScreenMagnifier - CrosSpokenFeedback BUG=chromium:1081294 Change-Id: If04d8b6de386dcec14c8581d7f52450c9e74cbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418953Reviewed-by:
-
Gyuyoung Kim authored
To reduce including a heavy web_preferences.h only when we need to use AutoplayPolicy enum, this CL moves AutoplayPolicy enum to autoplay_policy.h file. Bug: 919392 Change-Id: I0775d15052d679a06fd49c3586c9c789fa4e7894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418757Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#808864}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5721bfd7a5e6..f2db91bc8aed 2020-09-21 treehugger-gerrit@google.com Merge "Background mode for busy_threads" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If408a96d3ee60f800d68196e556f0d54e5917200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808863}
-
Mike Dougherty authored
The page has multiple results for headers with the text "Bookmarks". Replace the matcher with a new NavigationBarTitle helper. Bug: 1129588 Change-Id: I6c829ccc467e1df48bacd5af6e53c7bf92879206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419239Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808862}
-
Yuki Shiino authored
On Android, malloc, free, etc. are intercepted by using the linker option -Wl,-wrap,FUNC , which means we're intercepting only the symbols undefined at link time. Non-undefined symbols like a call to malloc inside libc are not intercepted. strdup and strndup are such functions that internally call to malloc. However, the return values of strdup/strndup are deallocated with free (= our own free), so we should intercept strdup/strndup to have them use our own malloc. This patch implements wrapper functions for strdup/strndup just like one for malloc. Bug: 1111332 Change-Id: I5747a2c32f19bb63c0380f10f589b9a8f6dd3b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418513Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808861}
-
Amr Aboelkher authored
Update the expire date with another hallf a year. BUG=chromium:1125828 Change-Id: Id9ff8ea0c365a1aec5edff0552a74af7e4474f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418318Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#808860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b774d38d3143..4c87d83d0323 2020-09-21 ilnik@webrtc.org Extend I420 frame buffer pool to also create NV12 buffers 2020-09-21 asapersson@webrtc.org Add support so requested resolution alignment also apply to scaled layers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic7c55e60be09650d82fa34fb26051a81ff1c6cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421538Reviewed-by:
-
Jan Wilken Dörrie authored
This CL is a part of moving PasswordForm class to components/password_manager/core/browser. PasswordForm is used for Profile Import MOJO messages. Instead of removed MOJO definition the IPC definition of PasswordForm is introduced. It contains only needed fields (which is much smaller subset fields). Bug: 1067347 Change-Id: Ief5f302b7cd9500b401cf9ce9d4b022261e560b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190490 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#808858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/feeee8f4b576..fcd0fd47bdba 2020-09-21 sigurds@chromium.org Update protocol 2020-09-21 tvanderlippe@chromium.org Reland "Reland "Remove support for remote modules"" 2020-09-21 tvanderlippe@chromium.org Typecheck network/BinaryResourceView.js with TypeScript 2020-09-21 tvanderlippe@chromium.org Fix issues for TypeScript 4.1 upgrade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec2b4aa18c7f6899e8a3cb6cf624f8e0236caa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421537Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48588bd1810d..078776328d3b 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 50ae4c5f4427 to 60ce96e2ff10 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I3ee1778f2df6bd1288f1a747f99231a5786e1b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421534Reviewed-by:
-
Anastasiia N authored
account_reconcilor_delegate_unittest was removed from BUILD.gn by mistake in https://crrev.com/c/1758072. Change-Id: I659ce3583018bd957781d86178f18c620bc100d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421114Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#808855}
-
Saurabh Nijhara authored
This CL is pre-work for extracting ForceInstalledTracker related unit tests from force_installed_metrics_unittest.cc. This CL extracts the common elements in a test base class which could be used for unit tests of both ForceInstalledMetrics and ForceInstalledTracker. Bug: 1086430 Change-Id: I60a190012b640d87f1dc5f8d3e4e19fcc683dd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416588Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80dc1e80..62f651b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a6dcd9be7ef53bc00eff9349fa27f63a605ba5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421868Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808853}
-
Changhao Han authored
In rare cases, DevTools frontend will call getComputedStyleForNode on a node that no longer has an owner document. This CL fixes this case, other it will result in a DCHECK failure in document.cc. Change-Id: I33b023e9ee600294cb8a3e9ea833b48e60bc0827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421668Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808852}
-
Tim Volodine authored
The test is flaky on multiple bots, see crbug.com/1130550. BUG=1130550 NOTRY=true TBR=xingliu@chromium.org,qinmin@chromium.org Change-Id: If25b96affb01dd87458126cb01a848e9c2ff455c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421370Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600624217-41c1d66e89e64ad55188045c0ed19fbb5037e5e8.profdata to chrome-win32-master-1600678560-73f022cb15ffdf2af0536df3a108de473267405b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8be9928324d47074ff33f14d9666b60a03542198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421529Reviewed-by:
-
Nektarios Paisios authored
This patch was reverted because it was believed that it had caused a failure on the Linux Ozone bots. However, after running this patch through all the Ozone bots, no failures were detected. Original description: For every editing operation in Blink, this patch exposes to the browser and to automation clients the "type" property of its input event from Blink. The enumeration listing event intents was too long, and it included intents such as paste, type and replace. To make using intents simpler, the list of commands is now trimmed down to a few generic ones, such as insert, delete, format and SetSelection. For intents attached to text changed and text attributes changed events, more information is now provided in the intent's input_type member. Values are provided by a new enumeration that uses the same members as the W3C Input Events Specification. This makes the information more detailed, accurate, as well as standard's based. The TextBoundary and MoveDirection enums were also modified to add the "kNone" member so that event intents such as "kClearSelection" that have no boundary information and no directionality need not use them. Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org, rsesek@chromium.org Bug: 989156 Change-Id: I7bc25347e51fc18b730aab84ca01a9eddad8d54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416459Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#808849}
-
Anastasiia N authored
Reland of https://crrev.com/c/2121264, since getAccounts is already implemented. Bug: 1064677, b/123630392 Change-Id: Ic132d1fdfb5ef12a3ef70a6e064319ce904a6965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410858Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#808848}
-
Frédéric Wang authored
math-style was originally implemented in [1] but it was decided with the CSSWG to perform the following changes [2]: - 'display' is renamed 'normal' - 'inline' is renamed 'compact' - the default value becomes 'normal' (instead of 'inline') [1] https://chromium-review.googlesource.com/c/chromium/src/+/2100787 [2] https://github.com/w3c/csswg-drafts/issues/5387 Bug: 6606 Change-Id: I5eb4aa423f434c068ccb02517b086830291fcf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421110 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#808847}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600667868-1426c4c889ab6f1601c0d673866dfd0987cca740.profdata to chrome-linux-master-1600689096-42a268e21a38ce243e34c88881f4529ac993701d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I250391c24c5cccca1c6019c927816e5008fd7db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421539Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/015182971a39..22d5e3c0712d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC elklm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: elklm@google.com Change-Id: I7edaab20bdce8783c845fdcd1421c13905a939e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421535Reviewed-by:
-
Illia Klimov authored
TBR=timvolodine@chromium.org Bug: 1130533 Change-Id: I353b191f652c1ea39a53300226c6b39526f58686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421731Reviewed-by:
Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@chromium.org> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#808844}
-
Henrik Boström authored
This feature has now rolled out to stable, so we change the default of the feature to enabled, allowing us to remove the .gcl file when M87 is promoted to Stable. Because serious/critical thermal signals are so rare (<1% of macOS population) and the impact of this resource is little-to-none, an alternative would be to simply delete the ThermalResource. However, by keeping the code, if the macOS signal is improved in a future release or if the thermal resource becomes available on more platforms (there are WIP CLs on Android and ChromeOS) then having the ThermalResource will automatically make use of these signals. And by having the base::Feature still in here, if changes to OS signals were to cause any regressions, we can use it as a kill-switch. // TBR in place of Evan's +1 (he's not a committer yet). TBR=guidou@chromium.org Bug: chromium:1100336 Change-Id: I03a2a765bd4b8cbbca5a9b618c71d7214b830ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418335Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#808843}
-
