Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Mar, 2018 24 commits
  3. 12 Mar, 2018 16 commits
    • Weidong Guo's avatar
      Close folder when click outside launcher · fca69883
      Weidong Guo authored 
      Before the change, when the launcher receives located events outside its
bounds, the launcher will be closed. This change makes the launcher go
back instead of being closed in that case. Going back means that the
launcher will close the folder or search results page if they exist, and
will close itself otherwise.

BUG=814806

Change-Id: I977011bca34e17cb041dd5a598a4b88ec093a930
Reviewed-on: https://chromium-review.googlesource.com/953585Reviewed-by: default avatarYury Khmel <khmel@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542658}
      fca69883
    • Allen Vicencio's avatar
      Implement NetworkScanner and add tests · d784a163
      Allen Vicencio authored 
      This CL implements NetworkScanner and adds tests. This allows the use of
multiple HostLocators by registering it with NetworkScanner.

Bug: chromium:757625
Change-Id: I5c607450196f3f1751cab44ff42b94057d142442
Reviewed-on: https://chromium-review.googlesource.com/952369Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542657}
      d784a163
    • Pavel Feldman's avatar
      DevTools: bake the screencast module into the remote debugging configurations of the inspector app. · 9018df6a
      Pavel Feldman authored 
      Bug: 819449
Change-Id: I492b98d296a2646a79c34c21d6c2a265dff7cc13
Reviewed-on: https://chromium-review.googlesource.com/953144Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542656}
      9018df6a
    • Jialiu Lin's avatar
      Update Safe Browsing Related Policy · 94d037e8
      Jialiu Lin authored 
      1. Move all safe browsing realted policy to M67
2. Add password form guideline to PasswordProtectionLoginURLs and
PasswordProtectionChangePasswordURL settings
3. Fix type "SAML"

Bug: 804490
Change-Id: Ib35bf249eed1e9bd1f1aa03835f5c6ec627af8aa
Reviewed-on: https://chromium-review.googlesource.com/959042Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: default avatarNathan Parker <nparker@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542655}
      94d037e8
    • Achuith Bhandarkar's avatar
      Roll src/third_party/chromite/ 7ed5549cf..3b75c9d82 (51 commits) · 48497d5c
      Achuith Bhandarkar authored 
      https://chromium.googlesource.com/chromiumos/chromite.git/+log/7ed5549cfa7b..3b75c9d82ebf

$ git log 7ed5549cf..3b75c9d82 --date=short --no-merges --format='%ad %ae %s'
2018-03-10 phobbs metrics: Fix DistributionMetric
2018-03-06 dgarrett cbuildbot_run: Adjust GetVersion to use CIDB Id.
2018-03-08 achuith cbuildbot: Generate and upload uploaded.json.
2018-03-08 yunlian cros_setup_toolchain: add elfutils to sdk.
2018-03-06 cmtice chrome_sdk: Disable CFI on SimpleChrome
2018-03-08 ahassani paygen: calculate metadata size after signing
2018-03-08 xiaohuic Add libassistant.so to chrome paths
2018-03-06 cmtice Enable cfi on caroline and terra release builds.
2018-03-05 phobbs metrics: Add Distribution wrapper function
2018-03-09 pprabhu Revert "cros tryjob: Add --json option."
2018-03-09 chrome-bot Update config settings by config-updater.
2018-03-08 dgarrett cros tryjob: Set email_notify property.
2018-03-08 dgarrett cros tryjob: Cleanup tag/properties.
2018-03-07 dgarrett cros tryjob: Add --json option.
2018-03-07 ahassani auto_updater: cros flash starts update_engine
2018-03-07 achuith [chrome_chromeos_lkgm_unittest]: Remove cruft.
2018-03-08 davidriley remote_access: Log reboot checks as DEBUG.
2018-03-08 davidriley auto_updater: Do not warn if quick-provision.log cannot be copied.
2018-03-07 dgarrett cros buildresult: Improve help messages.
2018-03-07 pprabhu chromeos_config: Mark more flaky paladins experimental.
2018-03-07 linben android_stage: Stop using different URL template for master-arc.
2018-03-07 achuith cros_build_lib_unittest: Fix failure in tearDown.
2018-03-06 manojgupta cros_setup_toolchains: Build compiler-rt in armv7m-cros-eabi.
2018-03-07 pprabhu doc: Add more troubleshooting help for moblabvm.
2018-03-07 pprabhu docs: Add instructions for using existing moblabvm workspace.
2018-03-05 pwang commands: Strip arcnext label from board
2018-03-05 xueweiz vm_test_stages: Increase timeout for GCETest.
2018-03-06 pprabhu cbuildbot: Mark whirlwind-paladin experimental.
2018-02-02 ahassani paygen: Run inside chroot
2018-02-02 ahassani paygen: Add InitSDK stage
2018-03-05 pwang betty-vmtest-informational: Fallback to run CtsDeqp
2018-03-01 laszio DebugInfoTest: perform tests based on debug info
2018-03-02 linben Add support for more master-arc-dev builds
2018-03-05 chrome-bot Update config settings by config-updater.
2018-03-03 chrome-bot Update config settings by config-updater.
2018-03-03 chrome-bot Update config settings by config-updater.
2018-03-02 davidriley merge_logs: Additional trimming support.
2018-03-02 shapiroc Revert "Add support for yaml in cbuildbot"
2018-02-27 achuith [chrome_chromeos_lkgm]: Use CQ to land changes.
2018-03-01 yunlian add terra-chrome-pfq builder to experimental.
2018-02-21 bhthompson Remove Sandybridge boards which are deprecated
2017-11-03 dgarrett cbuildbot: Update CIDB selection logic.
2018-02-28 dgarrett cbuildbot_config: Add debug-cidb option.
2018-02-28 dgarrett cbuildbot: Add --debug-cidb.
2018-02-08 ayatane Reland "Move sysmon to vpython"
2018-02-05 bmgordon cbuildbot_launch: Add post-build chroot cleanup stage
2018-02-23 laszio afdo: update the heuristic of profile selection
2018-02-27 briannorris cros tryjob: fixup --help suggestions for paladin names
2018-02-22 achuith [chrome_chromeos_lkgm]: Rename LGTM to LKGM.
2018-02-13 dgarrett commands: Add GenerateDebugTarball unittests.
2018-02-23 laszio afdo: enroll 14 boards to use field profiles

Created with:
  roll-dep src/third_party/chromite

Bug: 762650
Change-Id: I3a8aaca6d850b54605a9e0d323677d0aa70f938c
Reviewed-on: https://chromium-review.googlesource.com/959424Reviewed-by: default avatarGreg Levin <glevin@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542654}
      48497d5c
    • Scott Violet's avatar
      chromeos: provide ability to supply event for rewriting · c8c4c686
      Scott Violet authored 
      EventRewriters don't honor the target, and so generally expect the
root_location and location to be the same. This patch changes EventSource::SendEventToSink()
to create a new Event if the existing has differing locations (and a target).

BUG=817112
TEST=covered by tests

Change-Id: Iaabe019fed4350610306576a054b7d395def92ff
Reviewed-on: https://chromium-review.googlesource.com/956925Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542653}
      c8c4c686
    • Tom Sepez's avatar
      Re-land "Don't share PDF plugins across origin boundaries." · ff34ad77
      Tom Sepez authored 
      This reverts commit 5ff974fc.

Original CL was https://chromium-review.googlesource.com/953979
This CL differs from the original in that in the test framework,
PDFs are loaded into separate tabs, instead of on top of each
other. Under slow test infrastructure (e.g. MSAN), the plugin
processes would exit before we could complete the loads and
count them. This fixes the test (and the shipping code is unchanged
from the original).

TBR=jam@chromium.org

Bug: 809614
Change-Id: Id13a97023a60d86fb72c47d580c001b737bf17bf
Reviewed-on: https://chromium-review.googlesource.com/959236
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542652}
      ff34ad77
    • Andrii Shyshkalov's avatar
      LUCI migration: remove LUCI Webkit Mac (dbg) builder/tester. · 70e94f29
      Andrii Shyshkalov authored 
      We decided not to migrate master.chromium.webkit builders.

R=dpranke@chromium.org

Bug: 790322, 790325
Change-Id: I0bb3547b62fd2c51b6edbaddf8767960e6682d5a
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/958231Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542651}
      70e94f29
    • Wez's avatar
      Reland "Add missing message-received expectation to IPCMojoBootstrapTest." · 3fe9c089
      Wez authored 
      This is a reland of cdcb0262, which was
reverted pending a fix for an underlying Mojo message-loss issue on
channel shutdown.

Original change's description:
> Add missing message-received expectation to IPCMojoBootstrapTest.
>
> Some of these tests expected a message from the child process, and would
> verify that it was valid/invalid as expected, but would still pass if
> no message were received at all.
>
> Bug: 816620
> Change-Id: Ie8acf85086f4416c7023118673c40d00a2e190d7
> Reviewed-on: https://chromium-review.googlesource.com/955554
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542296}

TBR: rockot
Bug: 816620
Change-Id: Ifdf10581091be31a6c9d1aa53542f2ed6c2ccbfa
Reviewed-on: https://chromium-review.googlesource.com/958016Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542650}
      3fe9c089
    • Chris Nardi's avatar
      Upstream registerProperty tests to WPT · 26dfae3a
      Chris Nardi authored 
      Many tests of CSS.registerProperty were written, but none have been
upstreamed to WPT. Upstream these tests to ensure interoperability.

Bug: 641877
Change-Id: I8272b14c78cb75bb6f5f3cedb770091cbcba522a
Reviewed-on: https://chromium-review.googlesource.com/959422Reviewed-by: default avatarRobert Ma <robertma@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542649}
      26dfae3a
    • CrystalFaith's avatar
      [Chrome API Documentation]Storage API · c78d12f5
      CrystalFaith authored 
      Included additional code samples for local and sync.

Bug: 229359
Change-Id: I9d503ba83241ca717b7684afd41e431d09f45b92
Reviewed-on: https://chromium-review.googlesource.com/953377
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542648}
      c78d12f5
    • catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com's avatar
      Roll src/third_party/catapult/ 6eaec901b..4b356c746 (1 commit) · 7d7291d4
      catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com authored 
      https://chromium.googlesource.com/catapult.git/+log/6eaec901b986..4b356c746683

$ git log 6eaec901b..4b356c746 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 simonhatch Dashboard - Missing comma in api whitelist.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Id2ab20886e54fa8938f106da04234d6537c04a5c
Reviewed-on: https://chromium-review.googlesource.com/959581
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: default avatarcatapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542647}
      7d7291d4
    • Thomas Guilbert's avatar
      Add GetMediaController to PresentationService · 42b46656
      Thomas Guilbert authored 
      This CL adds the ability to get a MediaControllerBridge from a
presentation ID. The presentation ID is first converted to a route ID,
before being sent to the MediaRouterAndroid.

The MediaControllerBridge allows native code to forward commands to a
Java MediaController. Currently, only RemotePlayback will use this
path, and the Java MediaController interface is only implemented by
the RemoteMediaPlayerWrapper.

Bug: 790766
Change-Id: Ie089aff905fffd2521053620f79fe739ab6eb3a1
Reviewed-on: https://chromium-review.googlesource.com/930472Reviewed-by: default avatarNick Carter <nick@chromium.org>
Reviewed-by: default avatarDerek Cheng <imcheng@chromium.org>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarTakumi Fujimoto <takumif@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542646}
      42b46656
    • Balazs Engedy's avatar
      Let `about:blank#ref` also be classified as initial empty document. · c8a7cccf
      Balazs Engedy authored 
      Before this CL, content::FrameTreeNode used to classify only the literal
`about:blank` as the URL corresponding to the initial empty document.

However, navigations from the initial empty document to URLs such as
`about:blank#ref` are same-document and therefore re-use the initial
empty document, so committing any such same-document navigations should
not be considered "real loads" by FrameTreeNode (given they are not
considered "real loads" by Blink).

This CL changes FrameTreeNode::SetCurrentURL() to use !IsAboutBlank() to
determine whether the first real load is currently taking place in a
frame, that is, whether it is a first time a URL is being committed that
is not the initial empty document (modulo an optional #fragment).

Bug: 821022, 729021
Change-Id: I040a11f58bf27174e0c450377f8cd81a7abeac70
Reviewed-on: https://chromium-review.googlesource.com/958925Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542645}
      c8a7cccf
    • Peter Boström's avatar
      Focus inactive bubbles in pane-cycle command · 242f4a44
      Peter Boström authored 
      Makes unfocused popover dialogs keyboard accessible on non-MacOS where
F6 is used to cycle between different panes.

Follow-ups changes that are necessary are:

* Choose and utilize a different (non-function key) on MacOS.
* Update keyboard shortcut help documentation so users who search the
  web for "chrome dialog keyboard shortcut" has a chance of finding it.

This intentionally locks user focus inside the inactive bubble instead
of adding it to the pane cycle. Users who intend to use pane cycling
will need to accept or dismiss the dialog (normally using ESC) before
continuing pane cycling.

Bug: chromium:764918
Change-Id: Ib0144c9f914b63758f23454547c26907747f5939
Reviewed-on: https://chromium-review.googlesource.com/956528Reviewed-by: default avatarNektarios Paisios <nektar@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542644}
      242f4a44
    • Lukasz Anforowicz's avatar
      Refactoring: Move mime type calculations closer to the point of 1st use. · 76916d1b
      Lukasz Anforowicz authored 
      This CL moves the call to
  canonical_mime_type_ =
      network::CrossOriginReadBlocking::GetCanonicalMimeType(mime_type);
closer to the point where the value of the |canonical_mime_type_| field
is needed for the 1st time.

The move helps with the following:
- Makes unit tests more robust against shuffling of chucks inside
  ShouldBlockBasedOnHeaders (some shuffling will be needed when
  moving some checks into //services/network).
- Makes the code of ShouldBlockBasedOnHeaders closer to the promise to
  perform less expensive checks first (the GetCanonicalMimeType has
  medium cost - it has to compare the mime type against multiple
  hardcoded strings).

The move necessitates some small follow-up tweaks in unit tests.

Bug: 792546
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib21add69443dd0748aafd57da89a3cc16ffcdec1
Reviewed-on: https://chromium-review.googlesource.com/957804Reviewed-by: default avatarNick Carter <nick@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542643}
      76916d1b