- 27 Oct, 2020 40 commits
-
-
Aaron Colwell authored
Enabling test to see if it is still flaky on Windows. Bug: 980446 Change-Id: I6f1b0dce68cce9bd359ebe315ee8782b26888c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498957 Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#821188}
-
Henrique Ferreiro authored
On Ozone/Wayland, the cursor bitmap as obtained by CursorLoader already matches the device scale factor, after selecting the most appropriate asset (100P, 200P, etc.). The Wayland surface needs to know about this scale, so that it doesn't scale it further in some cases (e.g. HiDPI). On Linux, this was previously working in HiDPI displays because of a bug in mutter: https://gitlab.gnome.org/GNOME/mutter/-/issues/1215, where cursor surfaces aren't scaled. The issue was present on Lacros though, but resulted in cursors being blurry instead of too big, because, when Chrome was launched, the initial display configuration wasn't being passed to CursorLoader. This meant that the 1.0 default scale was used, so that the 100P cursor image assets were loaded and then scaled by the compositor. A fix for the latter issue landed in https://crrev.com/c/2443610. Bug: 1127962, 1141426 Change-Id: I1511fe9fc24f85db77e1bcc66ebbb720a8ce3375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470626 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821187}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests. Change-Id: I901403863794308619bec161354884808988b2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497386Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#821186}
-
Mario Sanchez Prada authored
As a followup to the migration of PageMsg_SetRendererPrefs to mojo, this CL continues now the process of moving more parts into Blink by changing the ownership of blink::RendererPreferences from RenderViewImpl into WebViewImpl. It also gets rid of render_view_linux.cc and render_view_fuchsia.cc since that logic has now moved to Blink, into web_view_impl.cc. We can't get rid of all the code in render_view_win.cc yet, though, because of the dependency that RenderViewImpl::UpdateThemePrefs() has on //content/child's WebThemeEngineDefault class, but that's a small part really, so this CL removes that file and moves the 5 lines we still need into RenderViewImpl::DidUpdateRendererPreferences(). Bug: 1102442 Change-Id: Iff8de455b3204e48649337b34fc24f215a4e5226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490047 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821185}
-
Rushan Suleymanov authored
Added experiment: InvalidateBookmarkSyncMetadataIfClientTagMissing. Bug: None Change-Id: Ib72d022f5292ec8fc9a10cdb73d92ff37391f74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494880Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#821184}
-
dpapad authored
- Add new resource_path_prefix option to generate_grd(), which makes it possible to generate grdp files in subfolders of the parent grd file. - Move preprocess_grit() for cr_elements/ under cr_elements/BUILD.gn - Add new generate_grd() target in cr_elements/ - Remove now obsolete alias in shared_resources_data_source.cc. Bug: 1132403 Change-Id: Ia1920b2eb799bcce325bf0087c9f3450b153b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494781 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821183}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=karandeepb@chromium.org Bug: 1142671 Change-Id: I8c2164e9841f1470aba590d8b8a3e4e1c2d116c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500211 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821182}
-
Rune Lillesveen authored
We optimized away the fetch of CSS image resources for display:none and display:contents. When an image is inherited from a display:contents into a rendered element, we did not do LoadPendingResources. This caused a crash trying to paint a pending image. Instead of loading explicitly inherited pending images, remove the optimization for display:contents. Bug: 1105850 Change-Id: Id0d45c78a86daecd2e2cb5f0d20accb6b73f1207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494947 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821181}
-
Hidehiko Abe authored
Currently, there are two issues. - Delegate method is called after resetting preedit cursor so the passed value is always -1. - According to the protocol definition, it is the byte-offset, but we need to convert it to the string16's offset. Bug: 1140536 Test: Ran manually with Lacros. Change-Id: I06b018b7e945208f9f1f166ecf0dcf36d882a2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486010Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821180}
-
Henrique Ferreiro authored
In renderer to browser messages, this field isn't used and, because WTF::String supports nullability, the value was serialized as null. In addition, this CL adds and fixes some of the checks done in the DragData Mojo type mapping. Bug: 1136901 Change-Id: Ifc9f9343817d2e06d734470573ce3785cbe885d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489897 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821179}
-
David Roger authored
This reverts commit cf5951dd. Reason for revert: Likely culprit for GeolocationServiceUnitTest.UrlWithApiKey flakiness on Mac Original change's description: > Separate Core Location flag into 2 flags for backend and permission UI > > The Permission UI for getting location permission from mac is completely > separate from the actual Core Location backend. Furthermore, once we > have location permission from macOS our Network Location Provider works > as intended. This CL separates those 2 independent workflows and allows > the Network Location Provider to monitor permission and act accordingly. > > Bug: 1112630 > Change-Id: I4e3141f756eadcb3d7ecc66c347fc24148505edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454307 > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821050} TBR=reillyg@chromium.org,jameshollyer@chromium.org Change-Id: Icf38bfb889a62ee4e6d70eff0bc1adc2316d9ed6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502368Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#821178}
-
Richard Knoll authored
- Android.[BTS].ExactTaskCreated: Extended until M91 as this is part of the metrics for Notification Triggers currently running as an OT. - Android.[BTS].MigrationToProto: Expired as the migration is now pretty much over and we don't look at this metric anymore. Bug: 1140008 Change-Id: Iafffbcdcc6904d0d0214e40004d7fb0c6872a2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491364Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821177}
-
nohe@chromium.org authored
This implements an append option so we can append images to an existing clipboard data object. This allows us to preserve existing clipboard metadata and copy images to the system clipboard. Bug: 827333 Change-Id: I89062055d21f252274c6a77cc72cfaf2eed3598a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463851Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#821176}
-
henrika authored
Initial work in this area landed in https://chromium-review.googlesource.com/c/chromium/src/+/2440055 This CL adds two new UMA histograms: 1) Media.Audio.Capture.Win.DefaultEffectType 2) Media.Audio.Capture.Win.RawEffectType Each histogram can contain 17 different values and they indicate support of different audio effect components such as AEC, NS, AGC etc. The idea is to monitor how common each of these audio effects are. There is one histogram for each audio processing mode: Default and Raw. The CL changes no real-time functionality but it uses Windows UWP APIs to enumerate the supported and active capture effects when opening audio input streams on Windows. Bug: 1133643 Change-Id: I3d866b96a5d240cf8fcbaa299f8f318615f6be0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450195Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#821175}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I85e269707a7579c8894a25ab1d8dc7da71009906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494766 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#821174}
-
Caitlin Fischer authored
Bug: 1126640, 1024661 Change-Id: I1243ce07f422d95b85df81bc68962c1443868f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500702Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#821173}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 1142671 Change-Id: I7d3e1a64045a53d85d3358916d87fda0ec01323e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500608 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50d43b33bba6..011cbddc5cdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: droger@google.com Change-Id: Ibb7cf90d6eb9d1bc950587177dafcccaa7604fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501661Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821171}
-
arthursonzogni authored
Check an url::Origin always survives the conversion through a blink::SecurityOrigin. This is typically what is done during some browser process <-> renderer process IPC. For instance, in https://crbug.com/901489, the origin sent from the browser process didn't survived the conversion. The host in url::Origin is percent encoded, while in the blink::SecurityOrigin, it used not to. SecurityOrigin::CreateFromString(...) is called with untrusted input by several components. This patch is mostly added by curiosity, to make me comfortable with: https://chromium-review.googlesource.com/c/chromium/src/+/2464363 Fixed: 490074 Bug: None Change-Id: Icec738475e888569ad99520f45afa5bcc6a7bbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491360Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6f694fa61b8fc8b0c836d2b4c502ab8899097a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821169}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e353801f6411..f6c1edff2f42 2020-10-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3aee62b34a8c5e02c916b1ba2a65eed1d592d24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501367Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I92783790da0f2e7a33c289280c64ea26ce32c427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500712Reviewed-by:
-
David Roger authored
This reverts commit b227bf9d. Reason for revert: breaks compare_build_artifacts https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/17383 Original change's description: > [updater] pass build dir to tests. > > Also changes test case superclass to typ.TestCase. > > Bug: 1141577 > Change-Id: I0d9b4b38543d1cd904808d9f85b6aa27ab973c5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496180 > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Commit-Queue: Anjali Doneria <adoneria@google.com> > Cr-Commit-Position: refs/heads/master@{#820849} TBR=sorin@chromium.org,waffles@chromium.org,adoneria@google.com Change-Id: I81e2ec26e7b68f8de2ac7ceb304dcfbc11e90a97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502022Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=dfried@chromium.org Bug: 1142671 Change-Id: Id7832e9b11000805ac8a535311254d6dda104d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500491 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#821165}
-
David Roger authored
TBR=qinmin Bug: 1141278 Change-Id: I1c13730e0dea15b9bbbd6cef75a4926c58bcadf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501741Reviewed-by:
-
Lei Zhang authored
Update some tests with modern base::Value API calls, in preparation for changing Results::Create() in generated code to return base::Value instead of std::unique_ptr<base::ListValue>. Bug: 1139221 Change-Id: I0995549e54c06aa11bf0af676442c2ce808eb965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496039Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#821163}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=dfried@chromium.org Bug: 1142671 Change-Id: I82eea21d4c053616fcc5434ddecd2d04e6c15026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500570 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
sauski authored
To provide greater insight into user actions w.r.t. site data, the PrivacyElementInteractions enum is extended to include user initiated deletions of site data. Bug: 1101675 Change-Id: I0d125409985fe01a5a9eeef9c7e363fdabd41714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494945 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#821161}
-
Austin Tankiang authored
This banner will be shown the first three times the user runs Files App and navigates to Drive (as opposed to the first three times the user sees the banner). Bug: 1129778 Change-Id: I0073d7dd6b6f1cdf9494e621f0edfccbcc380238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417741Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#821160}
-
Luciano Pacheco authored
Update TestDataSource (chrome://test/) to be able to load chai.js from //third_party/. Change chai_assert.js to import chai.js and add assertArrayEquals() because it used in several tests in WebUI and Files app. Nits addressed for array_data_model_test.js: - Add type check. - Remove "#export" markup. - Use Object.assign() to export test functions to global scope. Bug: 1133198 Change-Id: I816fa4d11365ce1adbe769e2cab6993368821e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497960 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d474b8943c9..7737a5bd2510 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb66fa41a163 to c1839ee3cedd (1 revision) 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 29ca7186a688 to 98c5ff6b49b3 (14 revisions) 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d37162e0 to 6d5913ce (399 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Test: Test: Test: angle_perftests --gtest_filter="*fate_grand_order*" Change-Id: I90194ef70eeb5dfbdf53f65916ce746b808ec184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501264Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e641c3d8..ea929126 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic165d964073fa3ae59e56611cb191b6b6b0c9eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499982Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821157}
-
Dana Fried authored
This reverts commit 91b01545. Reason for revert: called wrong method, enabling arrow key traversal globally instead of locally Bug: 1142343 Original change's description: > Keyboard accessibility for extensions menu. > > This change switches the extensions menu to enable focus traversal at > the focus manager level, allowing both right/left and up/down key > traversal. > > It also removes > BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is > only used in one other place - in favor of > FocusManager::set_arrow_key_traversal_enabled(), which also supports > left/right arrows and pre-exists the bubble dialog method. > > These changes mean that when the scroll pane is active in either dialog, > up and down will scroll the pane but left and right arrow keys will > still allow the user to traverse the dialog (at least on Windows and > Linux; on Mac, up/down may still work within the pane). > > Bug: 1140632 > Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904 > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820456} TBR=dmazzoni@chromium.org,sky@chromium.org,pbos@chromium.org,dfried@chromium.org,corising@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140632 Change-Id: I4c1d30602c132bdd3f06ab95f0215e5909373ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501074 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
Bug: 1060940 Change-Id: I922c5711383d340425bab3682f79923b049d8cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497452 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821155}
-
Daniel Cheng authored
Replace usage with base::UmaHistogramSparse() since I/O should end up dominating on this control path anyway. Bug: 1047547 Change-Id: I28dcf9d323ceff6db26ada6d4fee4c4a76e592e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500263Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821154}
-
Daniel Cheng authored
Historically, LocalFrameClientImpl/WebRemoteFrameImpl lived in the web layer, alongside RemoteFrameClientImpl/WebLocalFrameImpl. When removing the web layer, some frame-related files were moved to core/exported, while the rest were moved to core/frame. This was related to some questions about whether or not it would be appropriate to have a controller layer between Blink core and the Blink embedder. Ultimately, no one pursued the controller layer, and the difference only adds confusion now. Note that this CL does not attempt to address any preexisting presubmit errors to simplify the file move. Bug: none No-Presubmit: true Change-Id: Iadf3e45d2d8c102080c53bc21f9dea70bf6e0992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495610 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Daniel Libby authored
Pre-CAP, there is code that adjusts the transform property nodes of the global root scroller's scrollbars to point to the visual viewport's overscroll elasticity transform node. This ensures that the overscroll elasticity effect and page scale don't affect the root scroller's scrollbars. This adjustment was done at the compositing step in CompositingLayerPropertyUpdater::Update. In CAP, instead of doing this adjustment after the fact, we instead modify the paint chunk's transform node when painting the scrollbars. Additionally, we'll paint them in the overlay overflow controls paint phase, which happens at the end of painting a layer, as otherwise they are painted before child layers, which causes the PaintArtifactCompositor to have them be layered underneath child layer contents. There are many test updates - most of these just reflect the change in ordering. However there are a couple of notable changes. Two tests involving an outline that extends outside the viewport result in root layers that no longer are considered opaque. outline-change-vertical-rl-expected.txt outline-change-scrollable-expected.txt The root scrollbar used to be painted between the background and foreground paint phases, which caused the outline to be in a separate chunk. Since content outside the drawable rect is not considered for detecting opaque content, PaintChunker::IncrementDisplayItem set the last_chunk_known_to_be_opaque_region_ to the viewport size, but that does not match the chunk bounds in PaintChunker::FinalizeLastChunkProperties. Invalidation rects now match the non-CAP expectations for the following tests: invalidation-after-opacity-change-subtree-expected.txt window-resize-vertical-writing-mode-expected.txt Additionally, abspos-shift-image-incorrect-repaint-expected.txt has changed, but I haven't yet got to the bottom of why there are invalidation changes (probably related to how paint chunks are produced). R=pdr@chromium.org, wangxianzhu@chromium.org Bug: 1106550 Change-Id: I00ff0538d02d42adc3d26c849aafbbe2ca8e6d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395078 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821152}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/abe2eff36f3c..34ae8a475754 2020-10-26 greg@lunarg.com Fix bounds check instrumentation to handle 16-bit values (#3983) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I8d3ec7d16f9dd7b412112ddab48ac03487640b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500709Reviewed-by:
-
Hirokazu Honda authored
This CL enables VideoFrameFileWriter to save 10bits color depth VideoFrame to the disk. Since gfx::PNGCodec doesn't support 10 bits RGBA, YUV format must be specified for 10 bits depth VideoFrame. Bug: 1115112 Test: video_decode_accelerator_tests --use_vd --output_frames=all --output_format=yuv Change-Id: Id06c3d200ac672028be2f36d00f2d434b1e6607d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462911 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#821150}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I28bba1e2e38aa6f870545566262fa3df686a427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501601Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821149}
-
