- 29 Oct, 2018 40 commits
-
-
Miguel Casas authored
These tests where marked as Fail: ToT crashed when running e.g. [1] with chrome://flags/#enable-experimental-web-platform-features. - Pixel_CanvasUnacceleratedLowLatency2D: is kept disabled on Android because software compositing doesn't work at all; this test is changed from Fail() to Skip() and bundled with similar expectations. Other similar android-sw-compositor expectations are updated and gathered in the same area for better reference (there are no plans whatsoever to make this compositor mode work on Android) - Pixel_CanvasLowLatency2D: I landed a fix recently for a crash (crrev.com/c/1297469), with that the test works but produces a sliiiightly different output (see e.g. the first row of [2]), so we have to rebaseline the reference images. For that, the first step is to mark the test as disabled for all platforms. [1] http://htmlpreview.github.io/?https://github.com/chromium/chromium/blob/HEAD/content/test/data/gpu/pixel_canvas_low_latency_2d.html [2] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry Bug: 865957 Change-Id: I45ccbc0a674cb6eb51f622d7c7af039162a2c071 Reviewed-on: https://chromium-review.googlesource.com/c/1294870Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603677}
-
Qiyu Hu authored
We should not send out cached devices in the first place. Double bugs involve here: At the beginning of human history: We call SendCachedDevicesFound() whenever we start discovery. However, SendDevice() doesn't really send cached devices, until I fix it in crrev.com/c/1105559...... But the problem is, in the first place, cached (inactive) devices are not supposed to be reported in a discovery session. Also note that DeviceFound() is completely independent from LEDeviceFound(). If bluetooth service doesn't give an implementation for DeviceFound() (which is not likely), it could still provide an implementation for LEDeviceFound(), and LEDeviceFound() should still be called in this case. BUG=chromium:885339 TEST=manual test Change-Id: Id97acd40fad19e4ee5a3ed64792a0598dce46ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1303253Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#603676}
-
Paul Miller authored
NOTRY=true TBR=perezju@chromium.org CC=perezju@chromium.org BUG=899856 Change-Id: Idc6765a377b206722600f42b8127665bd524be51 Reviewed-on: https://chromium-review.googlesource.com/c/1306775Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#603675}
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org Bug: chromium:595206 Change-Id: Ic1088699d040b64e41a37360442d9765ec1f39ea Reviewed-on: https://chromium-review.googlesource.com/c/1304488Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603674}
-
Mark Pearson authored
It was overlooked in https://chromium.googlesource.com/chromium/src.git/+/4805b078411fc13ae107bcfd01a77c2abf929033 This change remedies that. Also, revises histograms.xml entry for this. The entry previously had some copied text referring to changes in Session.TotalDuration in earlier milestones. These changes don't apply to the Max1Day metric, as it was only implemented for M-69. Bug: 856467 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2a011801f4e67dff72b018a0c0537962c77932df Reviewed-on: https://chromium-review.googlesource.com/c/1298479Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603673}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 641877 Change-Id: I52878c9bca16765d3b32127b5637a7ec521e76dc Reviewed-on: https://chromium-review.googlesource.com/c/1304416 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#603672}
-
Philip Rogers authored
If a LayoutObject is removed we need to ensure the link highlight layers are cleared. This may not set geometry_needs_update_ so we need to check for this condition in LinkHighlightImpl::UpdateGeometry. Bug: 899099 Change-Id: I306ae5b14e8d84e06b77794e6f5df93460193fc2 Reviewed-on: https://chromium-review.googlesource.com/c/1303398 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603671}
-
Ria Jiang authored
gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAFloatTexture and gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAUint8Texture are flaky on Android Release (Nexus 5X). TBR=kbr@chromium.org Bug: 899748 Change-Id: I0c69c45f563b6eada65ea586a30bb8aa0d813d1b Reviewed-on: https://chromium-review.googlesource.com/c/1306215Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
-
Charles Zhao authored
Since the finch params are constant during the whole chrome session, we get nothing by reading it in real time. Instead we only need to read it once in the constructor. Bug: 871674 Change-Id: Id88f295028f2f52f17229ce685eb40548977e5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1304041 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603669}
-
Luum Habtemariam authored
Allowed key_value_pair_delimeter to be any arbitrary substring rather than limited to just a char. Functionality of current function upheld and rewritten in terms of the new, more general one. Test: Current and newly added tests pass Bug: chromium:894274 Change-Id: I6b487dfeb0c4a38e94526f3931d15c8e1b83db66 Reviewed-on: https://chromium-review.googlesource.com/c/1302498Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#603668}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/25da2e8be18d..36a23a7b2851 git log 25da2e8be18d..36a23a7b2851 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 dtu@chromium.org Revert "Pinpoint - Merge bugs with same root cause." Created with: gclient setdep -r src/third_party/catapult@36a23a7b2851 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:840872 TBR=sullivan@chromium.org Change-Id: Ic1e0dfc5fa3f3e02e81654c4f7bf52a3b53eb2bf Reviewed-on: https://chromium-review.googlesource.com/c/1306213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603667}
-
Tommy C. Li authored
This CL consolidates ToolbarFieldTrials into OmniboxFieldTrials. This was enabled by the recent move of everything in the toolbar component into the omnibox component. Bug: 898347 Change-Id: Ie879a9adc28b2b56fe30d1a86d42f78a846551a4 Reviewed-on: https://chromium-review.googlesource.com/c/1303019 Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603666}
-
Johannes Henkel authored
These changes affect the headless shell also, and similar to this, C++ code elsewhere which is generated from the .pdl file, e.g. client code, may be affected. However since the wire format isn't changing, such code continues to work if it sticks with string (and continues to encode/decode base64 manually). Relevant prereqs: Supporting binary in .pdl files: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1285695 Rolled into Chromium / v8. Add protocol::content::Binary to protocol_string{.h,.cc}. https://chromium-review.googlesource.com/c/chromium/src/+/1280555 https://chromium-review.googlesource.com/c/chromium/src/+/1281166 [DevTools] Add blink::protocol::Binary to v8_inspector_string{.cc,.h}. https://chromium-review.googlesource.com/c/chromium/src/+/1280210 Bug: chromium:891377 Change-Id: Ie959e251730b68929440385be24075fb430bcb0b Reviewed-on: https://chromium-review.googlesource.com/c/1303410 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG=839751 Change-Id: Iaaa73898f05263cbf70bdf0f6c71f302959d151f Reviewed-on: https://chromium-review.googlesource.com/c/1305955Reviewed-by:
Troy Hildebrandt <thildebr@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#603664}
-
Theresa authored
BUG=899660 Change-Id: Ifa94f6d473d7075259395fbce4b5789864f97d9c Reviewed-on: https://chromium-review.googlesource.com/c/1305398Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#603663}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c09dc8ac723f..71652e2a09b7 git log c09dc8ac723f..71652e2a09b7 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 khushalsagar@chromium.org gpu: Dump GrTextBlobCache stats in memory dumps. 2018-10-29 brianosman@google.com Remove another GrColor helper function 2018-10-29 caryclark@skia.org fix const order in docs Created with: gclient setdep -r src/third_party/skia@71652e2a09b7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:898910 TBR=herb@chromium.org Change-Id: I1b06544e357085b89ef37f60926f636f596e9319 Reviewed-on: https://chromium-review.googlesource.com/c/1306115Reviewed-by:
-
Antoine Labour authored
Currently, in particular on Mac, CreateGpuMemoryBuffer can fail, in which case we can't rasterize the corresponding tile in ZeroCopyRasterBufferImpl, and we just create a GL texture without binding anything to it, which ends up showing black when we display. This is somewhat problematic to emulate with SharedImage where it is not a valid state (SharedImages must have well-defined dimensions and format). Instead, we handle the failure by not creating a texture at all, keeping a zero mailbox, and falling back to OOM rendering mode (checkerboarding) for the corresponding tile. Bug: 882513, 554541 Change-Id: Iffd29a660f655c2dee8179fd90baa2a15ae42bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1303393 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#603661}
-
Daniele Castagna authored
crrev.com/c/1300235 introduced the option to lower the quality of backdrop filters. This CL lowers the quality of the backdrop blur one the shelf and the applist shield. In this way the texture allocations needed to apply the filter by cc will be significantly smaller/faster and applying the filter itself will also be faster on the GPU. Bug: 897369 Change-Id: I57be9434c02b77b38315e0f998d23eda5d277e43 Reviewed-on: https://chromium-review.googlesource.com/c/1306234Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#603660}
-
Nate Chapin authored
Bug: 879306 Change-Id: I54d55e06ee6634cb7db9621c9c242001efd29137 Reviewed-on: https://chromium-review.googlesource.com/c/1303073 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603659}
-
Jordan Demeulenaere authored
Screenshot: https://screenshot.googleplex.com/80KUNU90ea7.png Change-Id: Ida044559836c50ee693307567bc484ee1a4d2f01 Reviewed-on: https://chromium-review.googlesource.com/c/1304486Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#603658}
-
Christopher Thompson authored
This adds a new summary and sets the explanation for non-secure form edits on HTTP pages in the DevTools security panel. This fixes a bug where HTTP pages downgraded to the DANGEROUS security level (under the HTTP-Really-Bad changes) would get treated as broken HTTPS instead. Bug: 816184 Change-Id: I9440a20f970ff4daffd9c3a11a6a5a86a0b39160 Reviewed-on: https://chromium-review.googlesource.com/c/1277650Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#603657}
-
Jakob Ivarsson authored
Bug: 896684 Change-Id: I833b99b0ae3c2162765cd8e0b16e6b729745cbba Reviewed-on: https://chromium-review.googlesource.com/c/1304417Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603656}
-
Matthew Jones authored
This is a speculative fix for the app menu appearing off-screen. The idea is that in some cases the bottom toolbar is initialized before the app menu handler is (thus the flag to show from the bottom is never set). This patch sets the value in both places so the order doesn't matter. Bug: 894555 Change-Id: I1faac37492e187896fff519ea7f1bf737605c8ae Reviewed-on: https://chromium-review.googlesource.com/c/1306493Reviewed-by:
-
Daniel Bratell authored
common_export.h was kept out of public since it was not to be directly included by users of blink's public API but that made dependency tracking unnecessarily complicated and it was included indirectly anyway since many public headers included it. This patch moves the header to blink's public/common. It's still not to be include by external blink API users, but there is also no reason for them to do it. This allows us to remove the dependency hacks and makes dependency checks easier. Bug: 800764 Change-Id: I834f389f9c1871a5e1e66b2fa69477b7eb40e0a0 Reviewed-on: https://chromium-review.googlesource.com/c/1301467 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603654}
-
Xiaoqian Dai authored
Like a mouse device, a touchpad device should have the same effect on the ui mode, i.e., connecting a touchpad device should exit tablet mode and enter clamshell mode. Bug: b/118515248 Change-Id: I8529a79015779e2e4d52c2a429b8e0ccf68db463 Reviewed-on: https://chromium-review.googlesource.com/c/1306235Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
1) Use blink::DevToolsAgent in WorkerInspectorController. This replaces the ad-hoc interface for communicating with worker's debugger with a mojo interface used for frames and shared/service worker's shadow pages. 2) Create WorkerDevToolsAgentHost. This is similar to other agent hosts, keeps itself alive while the corresponding worker is alive, and reuses DevToolsSession machinery for inspection. 3) Report dedicated workers to the browser process when auto attach is on. mojom::DevToolsAgentHost is now notified about child workers and gets their DevToolsAgent interfaces to debug in the future. 4) Add TargetHandler to service/shared/dedicated worker sessions, to handle communication with nested dedicated workers. 5) Retire WorkerInspectorProxy and ExecutionContextWorkerRegistry. These are covered by DevToolsAgent now, which reports to it's host. 6) Retire InspectorWorkerAgent, which is replaced by WorkerDevToolsAgentHost on the browser side. The benefits are: - unified interface for inspecting any entity including workers; - workers now support flatten mode of operations; - all inspection targets are now listed on the browser side and represented with DevToolsAgentHost, which allows for further simplification; - less abstractions - we can even get rid of InspectorSession now. Bug: 775132 Change-Id: Ib4f58677a81ce48d4c2382f05d1166f730a2e2c3 Reviewed-on: https://chromium-review.googlesource.com/c/1183589 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603652}
-
Etienne Bergeron authored
This CL is adding events from the following CL to the whitelist. https://chromium-review.googlesource.com/c/chromium/src/+/1302865 TRACE_EVENT1("ui", "QueryLinkedFontsFromRegistry", "results", logging_str); TRACE_EVENT1("ui", "CachedFontLinkSettings::GetLinkedFonts", "font_name", font_name); R=oysteine@chromium.org Bug: 867931 Change-Id: I89b62a35036a67d1f0f5bf1f490ad476f0586ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1302816Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603651}
-
Mason Freed authored
Test made flaky by --enable-display-compositor-pixel-dump NOTRY=true TBR=dmazzoni@chromium.org BUG=895912,899458,899548 Change-Id: I49448b807c1fe6b06d8c2b7ce92253b7662b36de Reviewed-on: https://chromium-review.googlesource.com/c/1306633Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#603650}
-
Daniele Castagna authored
Computing background blur at full resolution as a backdrop filter turned out not to be cheap. This patch adds a backdrop_filter_quality float to cc::Layer that can be used to reduce the size of the offscreen canvas used to compute the blur. Currently this float is not exposed on the web and can be used only from Chrome UI. Bug: 897369 Change-Id: Ia070772ba576b37a8ee399c3c70b3e2308397e41 Reviewed-on: https://chromium-review.googlesource.com/c/1300235 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#603649}
-
Theresa authored
* Move publisher line to the top * Increase leading * Increase sheet half height from 65% to 75% of screen height BUG=896950 Change-Id: I2530151064545ac89ad38b859fffdee7285f8ae3 Reviewed-on: https://chromium-review.googlesource.com/c/1302332 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603648}
-
Koji Ishii authored
One suspect for issue 896456 is where ShapingLineBreaker fails to move offset forward. If this occurs, NGLineBreaker is likely to keep adding NGInlineItemResult of zero-length until all the memory is consumed. This patch turns DCHECK to CHECK to see if it is happening. Change-Id: I8a7355ec32e823e7ab517d2a3754c2fcc2104b3a Bug: 896456 Reviewed-on: https://chromium-review.googlesource.com/c/1304182Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603647}
-
Robert Ogden authored
Makes one reusable macro for disabling the tests on Windows and Mac, instead of having to define a new one each time. Bug: 894854 Change-Id: Ic01ec8e6bea07b76a3e0dceec62084b5c6321256 Reviewed-on: https://chromium-review.googlesource.com/c/1306398Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#603646}
-
Koji Ishii authored
This patch updates |start_index_| when there are no runs, because it is generally done when a new run is inserted. This is a speculative fix. While I hit a DCHECK because of uninitialized |start_index_| once, I cannot reproduce consistently, nor in unit tests using the string I hit in the debugger on http://switchsoku.com/soft/splatoon2/28757 . Bug: 896456 Change-Id: I6b1f65e770ebe7e8d2156a9056d7e57666d61d31 Reviewed-on: https://chromium-review.googlesource.com/c/1304276Reviewed-by:
-
Scott Violet authored
EventInjector::InjectEventNoAck() goes through EventRewriters (which is what happens when the event is received from the system). Accessibility code needs to send events in such a way that they do *not* go through rewriters. This patch adds such a function. BUG=876043 TEST=covered by tests Change-Id: I041d433ea5114420f1f98718d9d542947c11dedd Reviewed-on: https://chromium-review.googlesource.com/c/1302867Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Mike Dougherty authored
The native console methods must be called in order for messages to be logged to Safari Developer Tools. Bug: 899851 Change-Id: I3c1222ad890d490cb6b2212dc6783dcadc1da7f6 Reviewed-on: https://chromium-review.googlesource.com/c/1306114Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603643}
-
Koji Ishii authored
This patch fixes line-height quirks mode to include strut for close tags only when the end-side of the inline box is not empty. It used to include when |needs_box_fragment|, which is set under many more conditions. Normally, when the emptiness (and thus the strut) matters, open and close are in the same line. <span><br></span> or <span><div></div></span> can make this situation. It involved two more changes: 1. NGInlineItem.IsEmptyItem is used to determine the block emptiness, while NGLineBreaker had another code to determine line emptiness, using slightly different conditions. The two logics were merged, stored in NGInlineItem. 2. It revealed a problem in 'vertical-align' where it does not include inline boxes for 'top' and 'bottom' align. This is fixed in this CL. Bug: 636993 Change-Id: I2d609580c96371e702dd365737e8d704b0fcccd8 Reviewed-on: https://chromium-review.googlesource.com/c/1302173Reviewed-by:
-
Brian Osman authored
Change-Id: Iee063790e4d30b87550ee75fc0a51fa86daaff57 Reviewed-on: https://chromium-review.googlesource.com/c/1305499Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#603641}
-
Stephen Martinis authored
I was reading through the file, and I re-read this comment I know I wrote in the past, and was a bit confused. Re-write the comment to be a bit clearer. Change-Id: I71c97cddf2e4520d00aff045bc18006432b02ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1302098Reviewed-by:
-
Robert Sesek authored
An errant or malicious process could send Mach messages with extra descriptors. While the message wouldn't be processed, it would cause the rights to leak in the browser. When handling a request, add additional checks for the msgh_id and msgh_size. If the message does not pass muster, or it is from a process that is not expected, ensure any rights contained within are destroyed. Change-Id: If333372c72cb20d99713c78d5451c04a3321113f Reviewed-on: https://chromium-review.googlesource.com/c/1305394 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#603639}
-
dpapad authored
Previously content was pushed outside of the toast's boundaries. Bug: 899147 Change-Id: I0f235ff6cff1c52b3505f6ffd9c5dc5e7bfb0a68 Reviewed-on: https://chromium-review.googlesource.com/c/1305212Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603638}
-
