- 06 Sep, 2019 40 commits
-
-
Avery Musbach authored
The present CL addresses what happens in tablet mode if you switch away from a virtual desk where (1) There is one window snapped in split view, (2) There is at least one overview window, and (3) There is no overview window that can be snapped in split view. BEFORE: The cannot snap toast appears. If you switch back, you will find that split view has been ended, and the snapped window became maximized. AFTER: The cannot snap toast does not appear. You can switch back and find split view as you left it. Test: ash_unittests TabletModeDesksTest.SnappedStateRetainedOnSwitchingDesksWithOverviewFullOfUnsnappableWindows Bug: 996002 Change-Id: I232d8b4a977a51728a61e835c8cbc135b418e37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780954 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#694306}
-
arthursonzogni authored
A lot of things happened during the last few weeks. A lot of tests are now passing. The filters can be removed. TBR: lowell@chromium.org Bug: 999850, 990354 Change-Id: I3c09ff2df036a89efe8bb14ca3b40824fe482f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789314Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694305}
-
danakj authored
This IPC was used for tests to synchronize with the renderer from the browser process. The RenderFrameSubmissionObserver does this job for us instead now and does not rely on legacy mojo or test-only IPCs. This CL converts the 3 test cases relying on the old IPC over to use the RenderFrameSubmissionObserver utility instead. R=avi@chromium.org, rouslan@chromium.org Bug: 419087 Change-Id: I61d3cf37f55bfbbf97e73f8523605613d4e9be39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787406Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#694304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/208e343dafad..b3b46a268903 git log 208e343dafad..b3b46a268903 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 brucedawson@chromium.org Have autoninja use -d stats when NINJA_SUMMARIZE_BUILD=1 Created with: gclient setdep -r src/third_party/depot_tools@b3b46a268903 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I389c33af9a0b74b72e4c0016a284a223929c9d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694303}
-
Jeremy Roman authored
The bindings layer implicitly converts thrown exceptions in promise-returning functions to promise rejections, and using ExceptionState makes this more similar to ordinarily throwing exceptions, notably by including the auto- generated exception context that makes it easier to see what IDL operation caused an exception to be thrown. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1001114 Change-Id: I6126a5183b44f492dd91a2f74a07b063e87ca0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787351 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694302}
-
Askar Aitzhan authored
event_id is calculated by taking a hash from (event, context) pair. Both event and context are flat dictionaries, they contain only primitive types. Inside base::DictionaryValue is implemented with flat_map which stores keys in sorted vector. This gives a stable result when serializing to json string. Hash will be calculated from those stable json strings, which gives stable hashes. Bug: 996213 Change-Id: I2c88ab709bc78dd54471185e52e99a62054752de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783145 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#694301}
-
Ben Mason authored
Updating to the latest bundletool version which rolls the R8 version to fix dex fusing issues. Bug: 996658,1000653 Change-Id: Id635bfdf2d4e839ead74103c507ad80a9759a7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789178 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694300}
-
Ilia Samsonov authored
Not cleanning web_contents pointer can cause unit tests in the same batch to fail Bug: 1001181 Change-Id: I0b3178b9afe21302c1316faf34768d1a2856274f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783731Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#694299}
-
danakj authored
This is to differentiate it from the "frozen" state being applied to RenderView/Page for BFCache when the Page is navigated away from but the objects are kept alive. R=dcheng@chromium.org Bug: 419087 Change-Id: I6108792f03a3f5cf46acbcf9f113b63256342b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693169 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694298}
-
Mohamed Amir Yosef authored
This patch protects against downgrading login database coming from the future. This is relevant for use cases when using an old version of Chrome with a DB created with a new version. Change-Id: I9744387872bafae758e76de883c219990cbef8c6 Bug: 999514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787388 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694297}
-
Adam Langley authored
Authenticators may not include extensions in responses that were not requested by the platform. Change-Id: I24c33077b83f90e91cc9c5ccba31366b89be81ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788592Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#694296}
-
Eric Stevenson authored
Most of this CL was generated by //base/android/jni_generator/jni_refactorer.py. This CL was split out from a larger refactoring CL (crrev.com/c/1782676) because WebsitePreferenceBridge shadows are used in some unit tests. These now use proxy natives mocking TEST_HOOKS. Bug: 929661 Change-Id: Ia5d564074b987c0b440b2958635a8cb9fcef33a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784535Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694295}
-
Qingsi Wang authored
Bug: 1001371 Change-Id: I1bbf963db8f77ba122f47821e36b491e137dfb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788685Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
Askar Aitzhan authored
Currently ARC++ apps stored as protos defined in components/policy/proto/device_management_backend.proto, and are being uploaded to DMServer. In turn DMServer converts those reports to a proto format defined in google3/chrome/cros/reporting/proto/chrome_app_install_events.proto, appends serial_number and gaia_id and redirects those reports to Chrome Reporting API. Refactor AppInstall Reporting system to report directly to Chrome Reporting API. Bug: 996213 Change-Id: I32239e4713f3d2b804d9710fee60141ce39c0c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763421Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#694293}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2fb6e6107309..debe648a37fc git log 2fb6e6107309..debe648a37fc --date=short --no-merges --format='%ad %ae %s' 2019-09-06 fmayer@google.com Add bookkeeping test for empty callstack. Created with: gclient setdep -r src/third_party/perfetto@debe648a37fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I45f824b53264c2c6398b4bb82e30fb7244efa769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789781Reviewed-by:
-
Jenny Zhang authored
Bug: 999287 Change-Id: Ibaded6a03a8b84741c735a20228d84202581901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788515Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#694291}
-
Sebastien authored
The current header is being stripped out by GFE, and therefore doesn't affect the response from the server. Without this current change, we cannot conduct any server-side experiments based on the Finch parameter. Read more about the policy here: go/gfe-headers Server-side equivalent: cl/267619352 Bug: 1001537 Change-Id: I13b2a177bcc4527bb6dd294954da83cedae476b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789665 Commit-Queue: Sebastien Lalancette <seblalancette@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#694290}
-
Dominic Mazzoni authored
Bug: 1001538 Change-Id: I609e8c48e9ad5187a6befd4a1badfa631e665ecc Tbr: beaufort.francois@gmail.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789210Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694289}
-
Sven Zheng authored
This is needed for pixel tests which use goldctl. Bug: 958242 Change-Id: Iebb879f3d98ec7d7044e135a89248363c6e65ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788806 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694288}
-
Denis Kuznetsov authored
Bug: 998078 Change-Id: I771a38eb571455bfe11e41cdf9bc5d191b6e212e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782618 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#694287}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/gfx/animation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=flackr@chromium.org Bug: 891670 Change-Id: I17200daa5c08b5a98fa29314181483d370c59372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787073 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694286}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7285b9ab36f4..8b1435392e02 Created with: gclient setdep -r src-internal@8b1435392e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib9ea28c552b9ead5575703e2b04be29edf9f1730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694285}
-
Robert Liao authored
This change attempts to be a behavior preserving change at the views layer while allowing the Chrome Typography provider to specify colors for menu item text. The mapping of Native Color IDs to styles are as follows: kColorId_EnabledMenuItemForegroundColor = CONTEXT_MENU + STYLE_PRIMARY kColorId_SelectedMenuItemForegroundColor = CONTEXT_MENU + STYLE_SELECTED kColorId_DisabledMenuItemForegroundColor = CONTEXT_MENU + STYLE_DISABLED kColorId_TouchableMenuItemLabelColor = CONTEXT_TOUCH_MENU + STYLE_PRIMARY kColorId_MenuItemMinorTextColor = CONTEXT_MENU + STYLE_SECONDARY kColorId_HighlightedMenuItemForegroundColor = CONTEXT_MENU + STYLE_HIGHLIGHTED The resultant colors are as follows, with views representing the old colors. Light Mode Light Mode Default (Views) Chrome kColorId_EnabledMenuItemForegroundColor Black GG900 kColorId_SelectedMenuItemForegroundColor Black GG900 kColorId_DisabledMenuItemForegroundColor GG600 [1] 9e9e9e kColorId_TouchableMenuItemLabelColor GG900 GG900 kColorId_MenuItemMinorTextColor Black A:0x89 GG700 kColorId_HighlightedMenuItemForegroundColor GG900 GG900 * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255. [1] kDisabledTextColor Dark Mode Dark Mode Default (Views) Chrome kColorId_EnabledMenuItemForegroundColor GG200 White A:0xDD kColorId_SelectedMenuItemForegroundColor GG200 White A:0xDD kColorId_DisabledMenuItemForegroundColor GG600 GG600 [2] kColorId_TouchableMenuItemLabelColor GG900 White A:0xDD kColorId_MenuItemMinorTextColor Black A:0x89 GG500 kColorId_HighlightedMenuItemForegroundColor GG200 White A:0xDD * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255. [2] Was GG800 by default, but changed to GG600 to maintain previous contrast. We can consider merging the colors after this change. BUG=865318 Change-Id: Ie0c0b566637e752e9947c702e7fb8160d51a3558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767083 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694284}
-
Andrew Luo authored
Bug: 997309 Change-Id: I6f29983c9d5c18c6837a791c1a4abcf0d15ddfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779854 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694283}
-
Andrey Kosyakov authored
This is a reland of 67d9a27b Fixed win Headless.beginFrame tests that were the reason of revert by deferring call to issueExternalBeginFrame in HostContextFactoryPrivate till compositor is configured. TBR=ccameron@chromium.org,sky@chromium.org,dcheng@chromium.org,spang@chromium.org,johannes@chromium.org,sunnyps@chromium.org > Remove ExternalBeginFrameControllerClient interface > > > ... and replace it with a callback to IssueExternalBeginFrame. > > Also, deprecate Headless.needsBeginFrameChanged in the protocol -- > the client is supposed to always attempt to drive frames. > > Bug: 997946 > Change-Id: Idd0f773b80e027241960451b638427366b4b07c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768880 > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692688} Bug: 997946 Change-Id: I4d128e496ecb4b97715565dac1de5d6ec31a4542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788234Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Aran Gilman authored
Bug: 982354 Change-Id: I3a1ec863edb7f25ac968edae021b5549a2a768de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775159Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#694281}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d915f1866fa0..e2cd0bf51938 git log d915f1866fa0..e2cd0bf51938 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 jclinton@chromium.org Mark gale experimental due to http://b/140523449 Created with: gclient setdep -r src/third_party/chromite@e2cd0bf51938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I22f2fb54870e8de8de0eaabdbd253d3aafaccc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789777Reviewed-by:
-
Peter K. Lee authored
- Picked up current Safari/ and AppleWebKit/ version numbers from Safari User Agent. - Deleted version_map[] entries for iOS versions that Chrome no longer supports. This was last updated for iOS 12 in https://chromium-review.googlesource.com/c/chromium/src/+/1102485 Bug: 1001261 Change-Id: I337b736d279c86727302e7a5828602bd8bfae787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788504Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#694279}
-
chrome://flags/deprecatedchrome://flagsYann Dago authored
Flags Deprecated visual: http://screen/acUoJdkq6p6 Flags Visual: http://screen/95M6sZUb2n1 Bug: 982371 Change-Id: I48efdec4dc217ad11b27b0f20db9512894b51558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785518Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#694278}
-
Ian Clelland authored
Bug: 856601 Change-Id: Iebfdce6071ece01fb82d480139b2c92837467628 TBR: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789962Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#694277}
-
Jeremy Roman authored
Use [RaisesException] for immediate promise rejections in /third_party/blink/renderer/modules/serial. The bindings layer implicitly converts thrown exceptions in promise-returning functions to promise rejections, and using ExceptionState makes this more similar to ordinarily throwing exceptions, notably by including the auto- generated exception context that makes it easier to see what IDL operation caused an exception to be thrown. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1001114 Change-Id: I705359178d1e7c429d48f24f37ca11c28f750d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786934Reviewed-by:
-
Marc Treib authored
It wasn't used outside of tests. Bug: none Change-Id: Iefed7a4ee90ff0252210de425d102c47ed751c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789387 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#694275}
-
Denis Kuznetsov authored
Bug: 999477 Change-Id: Ifd9586437b8116beb9e61d893f936d8043ce254a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778544 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#694274}
-
Antonio Gomes authored
... from Blink. It is sitting unused in the tree. In fact, the whole third_party/blink/public/platform/modules/media_capabilities directory can later be moved down to renderer/platform. BUG=919392 R=haraken@chromium.org Change-Id: I41e4c9bf7e7f78153e404175e21b01a629f7b9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786097 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#694273}
-
Tommy Steimel authored
This CL adds the Global Media Controls IPH triggering logic and connects it with the frontend IPH bubble. Bug: 991585 Change-Id: I3c7b1e824ede5b620a87fa92306f6c9bdac1e348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783667Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
This reverts commit 2636d855. Reactivate FontSrcLocalMatching by default on Windows after bot testing stability has been restored. Bug: 999787 Change-Id: If897a8b8193d4ad398d15db421bebc3bb58043b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787287 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Tatiana Buldina authored
This particular test expects ChromeDriver to wait for an extension iframe to load. ChromeDriver has already been modified by r670576 to not automatically wait for iframe load, so this test is no longer valid. Bug: chromedriver:2965 Change-Id: I4f1227c0b2ad27c63f6e8b1614914be24a63528b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787167Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#694270}
-
Jeremy Roman authored
The bindings now provide an ExceptionState and automatically turn the result into a promise rejection (if an exception is thrown), so we don't need to duplicate this in the implementation of HTMLPortalElement::activate. Bug: 1001114 Change-Id: I69f9ffa0301f9d03bd221be5a81fee549f65b73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789822Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694269}
-
Ian Clelland authored
Bug: 998399 Change-Id: Ifccc12c536540c3f7cfe257a6f778034a5b07053 TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789686Reviewed-by:
-
Sam Maier authored
Change-Id: I231e5e1550655976bd81fc72d26aa07fa921a80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789743 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
