- 10 Sep, 2020 40 commits
-
-
Yoshifumi Inoue authored
This patch changes |ShapeResult::CountGraphemesInCluster()| not to crash when specified substring is empty by avoiding null reference of |CursorMovementIterator|. Note: This is a speculative patch because I could not reproduce locally. ClusterFuzz will check whether this patch is effective or not. Bug: 1071423 Change-Id: I6807ead3cb05f11d2ff663de8f5675aee524b5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402467 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805664}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbbf9587645f..29b1f07f4ab2 2020-09-10 syoussefi@chromium.org Vulkan: Boilerplate for vkCmdNextSubpass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I97acd800eba999bb448166ad6d378df07e09fad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805663}
-
Sami Kyöstilä authored
This reverts commit 1047b889. Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028 Original change's description: > OOR-CORS: Remove BlinkCORS supporting code outside Blink > > As OOR-CORS was fully launched, this patch removes BlinkCORS > supporting code that exists outside Blink. > > We still have some dead code in Blink, and subsequent cleanup > changes will remove them all. > > Bug: 1053866 > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805644} TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#805662}
-
Victor Hugo Vianna Silva authored
Disabling FastEnableDisableEnable (score of 433 in the flake portal) and DisableOneAtATime (score of 334). Bug: 1111227 Change-Id: Idf399ae2c76d7748c704952d38042e14187508ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401143Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#805661}
-
Omid Tourzan authored
Adds util method and integration test load time data entry to check feature in the Foreground page as well. Bug: 491043 Change-Id: Ia10eb456a982d2f8d8a4ce09d3c80d0b82f5e2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398598Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805660}
-
Peter E Conn authored
This will allow ExternalAuthUtils to be moved to a separate module. Change-Id: I03c3217ca22ad4a0aa6e0dbd33cbe56032aca48d Bug: 1104817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400622Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#805659}
-
Richard Knoll authored
After the Shutdown() method is called on a BCKS, the profile must not be used anymore. This CL cleans up current usages of the |profile_| during shutdown and adds DCHECKs where we're sure it it still valid. Bug: 1125056 Change-Id: I847bf7e6a96abefcc370bb5761f438ed3369c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400459Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805658}
-
Oleh Lamzin authored
Use new method ServiceConnection::FlushForTesting instead of RunUntilIdle. Change-Id: Idfa4a5fdd3eb8ab43be0d5ed527e334a6401c821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398624Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805657}
-
Miriam Polzer authored
Extending the validity of the rollback save and restore metrics as this feature is still not launched. Also changing the owners. Bug: 1089382 Change-Id: I81091696ced200c33df9ad229c297a72ed08cc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388284Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#805656}
-
Oleh Lamzin authored
Use new method ServiceConnection::FlushForTesting instead of RunUntilIdle. Change-Id: I032a428465ac661905ac3cfe466a898c4ca015bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398722Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805655}
-
Morten Stenshorne authored
This reverts commit 44326d9d. Reason for revert: Suspect in https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8371 Deterministic failure: TabSearchAppTest.All (status FAILURE) Original change's description: > Tab Search: Add last_active_time_ticks to tab_search.mojom.Tab > > last_active_time_ticks is used to sort recent tabs. > > Bug: 1099917 > Change-Id: If5c224729e39c20ceda48a3d81b6e171b92be731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382655 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805629} TBR=dcheng@chromium.org,tluk@chromium.org,yuhengh@chromium.org Change-Id: I9f1122dbb9cd1c6ecda5751744fceaaea742905c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402938Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805654}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 800764 Change-Id: Ic4dc91974aa32d01c4fb96ab934b8e1b1c3c51f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400411 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805653}
-
Yutaka Hirano authored
Handle the case where creating a v8::Promise::Resolver fails due to forcible worker shutdown. Bug: 1123468 Change-Id: Ifcdc90bc3d9cd6de878bf7d377fbefedb345f6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400795Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#805652}
-
wutao authored
Bug: b/163888215 Test: passed current tests Change-Id: I200f0f03d5ed71d6cdc317aecfd7698aa6f43472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399911 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805651}
-
Darren Shen authored
Wrapper.internal_request and Wrapper.internal_reply are the serialized bytes of closed-source protos. However, string is not a suitable type, as proto strings are designed for human readable strings and not bytes. The right type for this is actually 'bytes' as it represents binary data and not UTF-8 encoded human readable strings. [1] https://developers.google.com/protocol-buffers/docs/proto#scalar Bug: 1019541 Change-Id: I723c843acfb80eb14d63f7375cba1ddaf39a782c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397971Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#805650}
-
Yuki Yamada authored
Add FCForbiddenScope to forbid GC while modifying LinkedHashSet to avoid conflict between |value_to_index_| and |list_|. Bug: 1125952 Change-Id: I89ad7dc6c11dbee0194e1f7b5bea3b75ce3202dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402459Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805649}
-
Benoit Lize authored
On Windows, static local initialization calls into the runtime (more specifically, _Init_thread_header()), which then causes issues (see linked bug for details). To sidestep that, don't use local static variables to initialize the allocator, but write equivalent code "by hand". As the code is expected to perform as well as the current one, use it everywhere. Note that this is only done for the regular allocator, not the aligned one. If required, we can extend it to this one as well. This CL emulates `static base::NoDestructor<base::ThreadSafePartitionRoot>` by hand. Bug: 1126432 Change-Id: I2d019919befb4b4155bc61645da5f0efa5d4d2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401024Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805648}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eedd5bcc37d4..e6cf96585524 2020-09-10 treehugger-gerrit@google.com Merge "Add a smoothness flag to per-frame state." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idbdf1cf5e47607bb326a01a48f1cc24dc5171831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805647}
-
Viktor Semeniuk authored
PasswordManager.BulkCheck.UserAction should be recorded only if password is compromised. Bug: 1126415 Change-Id: I1a77e85f419735c59f8ee9ab3d42c58368b96097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400984Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#805646}
-
My Nguyen authored
Code and tests are mostly carried over from settings/languages_page, with small change to Retry button aria-label. Will add other components in following CLs. Current view: http://screen/35HsGe5kNDds66q View when spell check is disabled: http://screen/3maPBnjn24GPJaj Note: All strings are not finalised so they are translateable false and no screenshots required. Minor changes to jsdoc. Bug: 1113439 Change-Id: I998e65f02c2452c41fddb75ca6ade74de0c3e049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359972 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805645}
-
Takashi Toyoshima authored
As OOR-CORS was fully launched, this patch removes BlinkCORS supporting code that exists outside Blink. We still have some dead code in Blink, and subsequent cleanup changes will remove them all. Bug: 1053866 Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805644}
-
En-Shuo Hsu authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/fd5a98f6204f..f7f147bf051c $ git log fd5a98f62..f7f147bf0 --date=short --no-merges --format='%ad %ae %s' 2020-09-07 enshuo system_api: Add CRAS resend battery constant 2020-08-20 vpalatin modemfwd: clear LTE attach APN Created with: roll-dep src/third_party/cros_system_api Bug: b:166530001 Change-Id: Ib12a2bd7f17a9cbed45bc44e6d02488874d7fc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400649 Auto-Submit: En-Shuo Hsu <enshuo@chromium.org> Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805643}
-
mhasank authored
1. use base::UmaHistogramEnumeration in arc_optin_uma instead of macro 2. simplify the code in arc_session_manager for working with cloud dpc error 3. rename OptInCancelReason enum value to PROVISIONING_FAILED to indicate all kinds of failures BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow TEST=deploy android to dut with forced cloud dpc failure, enable playstore, verify uma histogram is present in chrome://histograms Change-Id: I0ec29e65c68ecb71551e200d06f31e990553d57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399881Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#805642}
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123993 Change-Id: I38a1ad092a6eb9229d5c6be27bc670c89f6ef6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391230Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#805641}
-
Sophie Chang authored
Bug: 1086227 Change-Id: Icc4b2b418d65545094ce0b047be8c31fcc197365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402187 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805640}
-
Kent Tamura authored
This CL fixes the following four errors: ================================================================ ERROR at //third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc:52:11: Include not allowed. ^------------------------------------------------------------------------ ... ___________________ ERROR at //third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc:53:11: Include not allowed. ^-------------------------------------------------------------------------- ... ___________________ ERROR at //third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc:54:11: Include not allowed. ^------------------------------------------------------------------------------------------- ... ___________________ ERROR at //third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc:55:11: Include not allowed. ^------------------------------------------------------------------------ ... ================================================================ This CL has no behavior changes. Bug: 800764 Change-Id: I420c3a1b758f08f8011d1cdc43ba66390ecd14ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400409 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805639}
-
Kuo-Hsin Yang authored
/proc/vmstat oom_kill is the system accumulated OOM kill count. Bug: 1124182 Change-Id: I88812c2b7c9802da4fec72df1e0838af4a1581de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395476 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805638}
-
nancylingwang authored
For extensions, add the LaunchPlatformAppWithFilePaths interface to launch the app by issuing an onLaunched event with the contents of file_paths. BUG=1090211 Change-Id: I92db10bac0d64e3c108d4aa67770a9b5f35d30f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264080Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805637}
-
Yoshisato Yanagisawa authored
Let me make Goma builders to use task service account so that we can easily distinguish. Bug: 1105814 Bug: b/166712857 Change-Id: I867bd9c133a97960839828dc2906d615b7450156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402582 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805636}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e262af9. With Chromium commits locally applied on WPT: 6e8ec7a9 "sensors: Drop tests for Sensor.start()/stop() return types." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I88dff05c63e50e5e4b350135e3d9c92f4251d88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401999Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805635}
-
nancylingwang authored
This CL adds 2 test cases to simulate the ARC app icon loading when the system start with 500 ARC apps. 1. The test case LoadLargeNumberIcons is used to verify adding 500 ARC apps with good icons, then the system restarts, re-loading 500 ARC app icons. 2. The test case LoadLargeNumberIconsWithBadIcon is used to verify adding 500 ARC apps with good icons, and 10 ARC apps with bad icons, then the system restarts, re-loading 510 ARC app icons. Start 20 try jobs below, they both run pass. BUG=1083331 Change-Id: I4d2f46757577e1db79d4aeb3d2aa497820dd0cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389800 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#805634}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2e2ffbda4ad0d149e0b755c049d965d43825bd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805633}
-
Nicholas Hollingum authored
For now these icons are only used by the installer. Going forward they will be used as a fallback icon in the event that a borealis app doesn't provide its own. These PNGs were optimized with: tools/resources/optimize-png-files.sh -o2 chrome/app/theme/borealis/ Bug: b/163431457 Change-Id: I4e95720093c137d3a5e64ddca8c9a17a905844ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377770 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#805632}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: None Change-Id: I5d02011af429c60c716f889921b36e0e78bbbe11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402283 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#805631}
-
Christopher Lam authored
This CL removes a testing hack which is no longer used. Bug: None Change-Id: I68f1d84593ddb6fe45df52500eaeb4fd0767dd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400651Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#805630}
-
Yuheng Huang authored
last_active_time_ticks is used to sort recent tabs. Bug: 1099917 Change-Id: If5c224729e39c20ceda48a3d81b6e171b92be731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382655Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805629}
-
Yoshisato Yanagisawa authored
All builders using lib/ci.star will use the task service account by default. All the task service accounts used for accessing Goma have already been granted. The CL should not cause crbug.com/1122461. Bug: crbug.com/1105814 Change-Id: Ibb925c3a7edaf123d9efc4ab1c0a3b112bee451e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380965 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805628}
-
Daniel Hosseinian authored
At 500px, hide sidenav, sidenav toggle, and fit button. At 420px, hide view buttons. At 200px, hide the entire toolbar. Fixed: 1119953 Change-Id: I3ffc07203380fc7259c5b162159d340854866b1d Bug: 1119953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393515Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805627}
-
Robbie McElrath authored
This CL works around a LayoutInflater bug in Android <N that caused all Dialogs in WebLayer's Site Settings UI to crash when opening. LayoutInflater creates Views by looking up their constructor from the class's name, and caches this name to constructor mapping as an optimization. This cache causes issues if a View is loaded multiple times with difference ClassLoaders. In Site Settings, some AndroidX classes get loaded early on with the embedding app's ClassLoader, which causes the constructor from that ClassLoader's version of the class to be cached. When the WebLayer implementation then tries to load the same class, it loads the version from the embedding app, rather than the WebLayer's version. This issue was fixed in Android N, but to work around it on earlier versions of Android, this CL registers Site Setting's fake FragmentActivity as the Factory2 for the implementation Context so it can intercept View loading, and loads Views manually to bypass the LayoutInflater cache. Bug: 1126647 Change-Id: Icaf81b2dd84dc5b82b28a4c8d92114a4b7a37598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402188 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805626}
-
Kuo Jen Wei authored
Set record button background to transparent in taking state for preventing it shown outside red dot area. Bug: 1125896 Test: Manually test record functionality on dragonair. Change-Id: Ib9260a5df1c7f47b82cb8f47dcbf8ea333ebc121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398029 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#805625}
-