GitLab

One minute was a completely ridiculous timeout length as this means that
Chrome will behave as if the device simply doesn't exist until the bad
transfer times out. If the device isn't responding in a couple seconds
it likely never will.

BUG=None

Review-Url: https://codereview.chromium.org/2849893003
Cr-Commit-Position: refs/heads/master@{#468221}

client_cached_cert_hashes to nullptr in default
QuicCompressedCertsCache::UncompressedCerts constructor.

BUG=716026

Review-Url: https://codereview.chromium.org/2848883006
Cr-Commit-Position: refs/heads/master@{#468220}

Very flaky on linux_android_rel_ng.

BUG=713895
TBR=wychen@chromium.org

Review-Url: https://codereview.chromium.org/2850853005
Cr-Commit-Position: refs/heads/master@{#468219}

This was previously fixed for seed processing in http://crrev.com/2612243003,
but was accidentally omitted for the simulation code.

BUG=716493
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2851703004
Cr-Commit-Position: refs/heads/master@{#468218}

Cr-Commit-Position: refs/heads/master@{#468217}

instead of waiting for it be be destroyed.

Add tests for the cases where a connection is close before a StreamRequest
completes (both sync and async).

BUG=716563

Review-Url: https://codereview.chromium.org/2854443003
Cr-Commit-Position: refs/heads/master@{#468216}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7d568a76..10b9a3e5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2853673002
Cr-Commit-Position: refs/heads/master@{#468215}

When this is statically known at compile time, there's no need to do
dynamic dispatch.

Bug: 709815
Change-Id: I8cdd314d306c3b5557951b6bf94911be24c73d7a
Reviewed-on: https://chromium-review.googlesource.com/489642Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468214}

This CL is *mostly* a refactor with no intended behavior change.

Previously, PlatformFileForTransit had the same semantics as SharedMemoryHandle,
so it was typedef-ed to SharedMemoryHandle. However, the semantics for
SharedMemoryHandle are changing, so it's no longer appropriate to do so.

This CL includes a small fix to ppb_nacl_private_impl.cc, which previously
leaked a HANDLE on Windows, but not on an fd on POSIX.

The leak was introduced by "Make PlatformFileForTransit a class on Windows."
[commit: 19e5f690]. Prior to that CL:
  On Windows, NaCl would duplicate the handle into the destination process
  [closing the original handle in the process], and then pass the result as a
  raw int.

  On POSIX, NaCl would duplicate the handle using Chrome IPC, using
  base::FileDescriptor.auto_close = true, which would cause the IPC subsystem
  to close the handle.

After that CL:
  On Windows, NaCl would let Chrome IPC transport the handle, but failed to
  call PlatformFileForTransit::SetOwnershipPassesToIPC(true) [the equivalent of
  base::FileDescriptor.auto_close]. This caused a leak of the handle in the
  browser process.

In this CL:
  PlatformFileForTransit is now its own class, with no auto_close parameter
  because the IPC subsystem always closes the handle in the source process.

BUG=713763

Review-Url: https://codereview.chromium.org/2846293002
Cr-Commit-Position: refs/heads/master@{#468213}

https://pdfium.googlesource.com/pdfium.git/+log/3b91290ba31e..ce8e51e6c444

$ git log 3b91290ba..ce8e51e6c --date=short --no-merges --format='%ad %ae %s'
2017-04-28 rbpotter Fix rotations
2017-04-28 thestig Clean up private methods in CBC_C40Encoder.
2017-04-28 tsepez Remove some more |new|s, part 4.
2017-04-28 thestig Limit recursion in CXML_Parser::ParseElement().
2017-04-28 thestig Disallow CPDF_FormField with deep node trees.

Created with:
  roll-dep src/third_party/pdfium
BUG=713197,716526


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I81ccbaaacbb34cc9923714ca87841f2c756d6b3c
Reviewed-on: https://chromium-review.googlesource.com/490699
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468212}

BUG=712416

Review-Url: https://codereview.chromium.org/2844143002
Cr-Commit-Position: refs/heads/master@{#468211}

The current situation is that using ScopedFeatureList resets to an
empty feature list and then enables/disables an explicit list of
features.

That's never what you want for browser tests (or other higher-level
tests) since it effectively overrides higher-level test configurations
(e.g. those in fieldtrial_testing_config.json, or a bot set up to
specifically test a feature).

In this patch:

1. Keep SFL::Init, SFL::InitWithFeatureList,
   SFL::InitFromCommandLine reset to empty list but add warning to
   remind developer should use them with care.
2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
   SFL::InitWithFeatures to not reset but override current FeatureList
   with given enables/disables.

We also add unit tests for ScopedFeatureList.

BUG=713390

Review-Url: https://codereview.chromium.org/2834583002
Cr-Commit-Position: refs/heads/master@{#468210}

BUG=656015

Review-Url: https://codereview.chromium.org/2816733002
Cr-Commit-Position: refs/heads/master@{#468209}

https://skia.googlesource.com/skia.git/+log/dc87c95382d5..135c90881287

$ git log dc87c9538..135c90881 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 fmalita Remove temporary_internal_describeTopLayer
2017-04-28 caryclark add drawString helper to canvas
2017-04-28 msarett Fix bitmap copy gms
2017-04-28 msarett Only store width and height on SkPixelRef (part 1)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I2f1508c7c5b7248931a3e58400d146f8fe266b2c
Reviewed-on: https://chromium-review.googlesource.com/490640Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468208}

This is a step towards supporting multicol in SPv2.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2844803007
Cr-Commit-Position: refs/heads/master@{#468207}

We had been looking in lib.stripped for the library when symbolizing
debuggerd traces. The libraries in lib.stripped are not the ones with
packed relocations, though, so the resulting symbolization was wrong.

This CL generates a wrapper script around the stack symbolization
script that points to the correct library to use for symbolization.
It also contains a few tests that intentionally crash in various ways.
These are all disabled by default and should only ever be run manually
for testing out instrumentation test crash tooling.

BUG=712265

Review-Url: https://codereview.chromium.org/2840193003
Cr-Commit-Position: refs/heads/master@{#468206}

Android Auto Exposure is always available, make the implementation
reflect that.

In blink, don't fill dictionary entries with empty arrays.

BUG=716636

Review-Url: https://codereview.chromium.org/2842103002
Cr-Commit-Position: refs/heads/master@{#468205}

Revert of MediaRecorder: enable encode acceleration for VP8 in Android (patchset #1 id:40001 of https://codereview.chromium.org/2852583002/ )

Reason for revert:
Speculatively reverting since WebRtcMediaRecorderTest.PeerConnection tests on Marshmallow 64 bit Tester have become flaky since the patch landed.

Original issue's description:
> MediaRecorder: enable encode acceleration for VP8 in Android
>
> This is a refry of https://crrev.com/2801803002 (as pointed out
> in https://crrev.com/2836013006) that enables only VP8
> hardware encoding in Android.
>
> Tested via webrtc_media_recorder_browsertest.cc [1]
>
> [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_recorder_browsertest.cc?q=webrtc+mediarecorder&sq=package:chromium&dr=CSs&l=27
>
> BUG=638664
>
> Review-Url: https://codereview.chromium.org/2852583002
> Cr-Commit-Position: refs/heads/master@{#467879}
> Committed: https://chromium.googlesource.com/chromium/src/+/6089c73618b3b5010bdb81441c6f5f58936f9e58

TBR=emircan@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638664

Review-Url: https://codereview.chromium.org/2846403002
Cr-Commit-Position: refs/heads/master@{#468204}

Refactored the way the dependency chain is going for the products
module. We now have a shared module that is bundled and can be used to
resolve things like frame and product for url.

We are also adding background coloring to network rows.

R=pfeldman
BUG=712876

Review-Url: https://codereview.chromium.org/2839273003
Cr-Commit-Position: refs/heads/master@{#468203}

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago.
The icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803

Review-Url: https://codereview.chromium.org/2849563004
Cr-Commit-Position: refs/heads/master@{#468202}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/632d0542..7d568a76

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2846373002
Cr-Commit-Position: refs/heads/master@{#468201}

This suppression is obsolete. I can't find the commit in which the
suppression was removed from the 1.0 suite.

BUG=473739,682036
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2848133002
Cr-Commit-Position: refs/heads/master@{#468200}

This CL changes how the embeddingOrigin is set on content exceptions.
This is now more like it was done in the old options, where the
embedding origin was not sent from JavaScript.

BUG=714584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848933003
Cr-Commit-Position: refs/heads/master@{#468199}

The binary glTF format enables us to deliver 3D models on a single file with minimal size.

Binary glTF Specification in: https://github.com/KhronosGroup/glTF/tree/master/extensions/Khronos/KHR_binary_glTF

BUG=644562

Review-Url: https://codereview.chromium.org/2852533004
Cr-Commit-Position: refs/heads/master@{#468198}

BUG=catapult:#3394

Review-Url: https://codereview.chromium.org/2847243004
Cr-Commit-Position: refs/heads/master@{#468197}

This patch ensures that we pass PaintImage with all of the proper flags
to PictureImageLayer.

R=khushalsagar@chromium.org, pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2835373003
Cr-Commit-Position: refs/heads/master@{#468196}

Changes in this patch as below:
1. Replace references to constants in ui/views/layout/layout_constants.h with their
   equivalents using ChromeLayoutProvider.

2. Changed the RequestFileSystemDialogView class to use a simpler FillLayout instead of
   a BoxLayout. This class now subclasses DialogDelegateView instead of DialogDelegate for
   simplicity. Removed the dependency on Extension and Volume datatypes from this class, which
   enables us to easily test the dialog. The extension name, volume label and id are passed in.
   We maintain the contract of invoking the cancel callback if the volume label is empty. That is
   done in the caller ConsentProviderDelegate::ShowDialog().

3. Added browser tests for displaying the TryChromeDialogView and RequestFileSystemDialogView dialogs.

4. Made the TryChromeDialogTest class a friend of the TryChromeDialogView class. This allows it to
   instantiate an instance of this class. The TryChromeDialogView class no longer puts up a modal
   dialog by default. This is controlled by the DialogType enum, which for chrome is always MODAL.
   For the browser tests we pass in MODELESS here, as the loop is run by the test. The ShowModal() method
   is renamed to ShowDialog(). It takes an additional enum UsageType which controls whether we are in testing
   mode. In this case we always want the dialog to be displayed.

BUG=691897
TEST=Covered by tests RequestFileSystemDialogTest.InvokeDialog_default and TryChromeDialogTest.InvokeDialog_default
TBR=grt

Review-Url: https://codereview.chromium.org/2816293002
Cr-Commit-Position: refs/heads/master@{#468195}

When the tab model switches, the bottom sheet content changes to
suit the normal or incognito tab. This can happen in the tab switcher
while the toolbar is transparent causing the toolbar to flash grey.
This change skips the transition animation if in tab switcher mode.

BUG=702717

Review-Url: https://codereview.chromium.org/2849993002
Cr-Commit-Position: refs/heads/master@{#468194}

Previously if you wanted to reset the starting point of the interval
(for measuring an idle timeout, for example) you had to construct a new
instance on the heap.

Now it's possible to keep a stack/member variable (potentially
base::Optional) and assign fresh values to it to reset it.

Review-Url: https://codereview.chromium.org/2851493004
Cr-Commit-Position: refs/heads/master@{#468193}

I ran check_gn_headers.py on linux and android full builds, merged the
missing header file lists, fed to fix_gn_headers.py (without
AddHeadersToSources), chose which matches to apply interactively, and
manually fixed the results.

Read more about the manual fixes in the Review-Url.

The number of missing header files on linux and android decreased by 9,
from 840 to 831.

None of the fixed files are included in the following spreadsheet:
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0

fix_gn_headers.py is from https://codereview.chromium.org/2790563003

BUG=661774

Review-Url: https://codereview.chromium.org/2846463002
Cr-Commit-Position: refs/heads/master@{#468192}

It's currently flaking on the NVIDIA Shield TV.

BUG=716564
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850973002
Cr-Commit-Position: refs/heads/master@{#468191}

After more testing on top-of-tree, it seems that the fix for Issue
713127 should have addressed all of these. Remove the suppressions in
order to show any remaining issues on the waterfall.

BUG=694359,715696
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852623003
Cr-Commit-Position: refs/heads/master@{#468190}

BUG=715972
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2847783002
Cr-Commit-Position: refs/heads/master@{#468189}

Atomics.wait is a blocking call, and is only allowed on certain workers. See
the new web platform tests here:
https://github.com/w3c/web-platform-tests/pull/5569

BUG=chromium:711809

Review-Url: https://codereview.chromium.org/2841003002
Cr-Commit-Position: refs/heads/master@{#468188}

https://pdfium.googlesource.com/pdfium.git/+log/60cd033adf6c..3b91290ba31e

$ git log 60cd033ad..3b91290ba --date=short --no-merges --format='%ad %ae %s'
2017-04-28 tsepez Remove more |new|s, part 3
2017-04-28 tsepez CXFA_FMStringExpression: int16_t is not a good type for a string index.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I74ec80e85a9540d9dcdf2b845b3739ddb8cb8f10
Reviewed-on: https://chromium-review.googlesource.com/490634
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468187}

This patch ensures that we don't even try to checker images that are
too big to fit into our cache.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2844273004
Cr-Commit-Position: refs/heads/master@{#468186}

Fixed bug where if a websocket frame was received it would sometimes
move the selected node in network panel to a new request.

Offending patch: https://codereview.chromium.org/2694103007

R=dgozman,caseq
BUG=714229

Review-Url: https://codereview.chromium.org/2838673003
Cr-Commit-Position: refs/heads/master@{#468185}

BUG=671152

Review-Url: https://codereview.chromium.org/2844243003
Cr-Commit-Position: refs/heads/master@{#468184}

BUG=716416
TBR=ben@chromium.org

Change-Id: I765d24506682167248dbc7d51c0d399cda41a741
Reviewed-on: https://chromium-review.googlesource.com/490613Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ben Goodger <ben@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468183}

The user-visible change here is that Select-to-speak on Chrome OS now
works on the virtual keyboard. It also makes it visible to ChromeVox
so we can make that work better too.

Three fixes were required:

* We need to always set the window property on the window for a
  RenderWidgetHostViewAura, whether that WebContents already has
  accessibility enabled or not. That's solved by moving the
  trigger for the window property to RenderViewReady and
  WebContentsImpl::NotifySwappedFromRenderManager.

* AXAuraObjCache needs to listen for newly-created windows,
  changes to window bounds, and window property changes.
  Otherwise the virtual keyboard window is created but no
  accessibility events fire allowing automation clients to
  find it.

* The bounds for a AXWindowObjWrapper should be global bounds and not
  local. This wasn't caught before because widget bounds were correct,
  but the virtual keyboard is directly in an aura Window, with no Widget
  and no Views.

BUG=699617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2803823002
Cr-Commit-Position: refs/heads/master@{#468182}