- 12 Oct, 2020 40 commits
-
-
Siyu An authored
Offer data will be server-only data, so I figure we don't need two clients integration tests. Bug: 1093057 Change-Id: I8afb57ed49b7ab6d57071c331ea679fdf1928260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453351 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816337}
-
Ben Joyce authored
reduces speed from 16438ms to 4656 ms Bug: 989569 Change-Id: Ide7b215a03df82d724f5e3639038734c2c574857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438779 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#816336}
-
Ben Joyce authored
Reduces test time from 34734ms to 5196ms Bug: 989569 Change-Id: I8f7b179c88c2ee46d964e07075ecca71ea4c4f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437784Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#816335}
-
Pavol Marko authored
When persisting credential fields in UIData to shill, distinguish between the cases 'no credential saved' (empty string will be written) and 'some credential saved' (kFakeCredential will be written). A comment mentions that this should be done, but it has not been done yet. With this in place, the network config UI displays empty password field if no credential has been saved or some number of asterisk if some credential has been saved. Also fix "Save identity and password" not being populated from SaveCredentials due to managedProperties.typeProperties.vpn.type being treated as having a sub-field 'value' while it's a plain enum. Bug: 1103234 Change-Id: I301ea1290785c3260c372d21b36b3aa08597b9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450274 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#816334}
-
Scott Violet authored
It should return AltTextContentData, not TextContentData. I've tagged this with bug 1087667 as a patch I'm working on for that bug triggers calling this. BUG=1087667 TEST=none Change-Id: I3e04f8689f3df5a17c94abeaacad05b5e6962a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466058Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#816333}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/933ae5eaad9d..c99c8ab390f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mahmadi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mahmadi@google.com Change-Id: I15ccbfce2e0baa9dd1088483dc53ce4d00b53b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816332}
-
Raymond Toy authored
The test offlineaudiocontext-detached-execution-context.tentative.html uses a sample rate of 3000 Hz, but the spec only mandates a minimum sample rate of 8000 Hz. Update the test to use a sample rate of 8 kHz. Bug: 1137014 Test: offlineaudiocontext-detached-execution-context.tentative.html Change-Id: I7fb2069e8c69f77224aad6f92a8acf9e02cba72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462233Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#816331}
-
Elly Fong-Jones authored
Now, the WidgetDelegate is separately created and configured by an instance method, but this class does not inherit from WidgetDelegate any more or override any of its methods. Bug: 1075649 Change-Id: I5c2a7f90b120c6fd7e757a537a97df040436f4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463992 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Mike Jackson authored
DesktopPWAsWithoutExtensions has shipped and tests have been migrated, so removing unused enums and functions. Bug: 1065748 Change-Id: I701e516ebf016e81487f684f535252135ff9119b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466169 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#816329}
-
Anders Hartvoll Ruud authored
This adds support for using :is inside :not, without expanding the capabilities of :not itself. (In other words, we still only accept a single simple selector when using non-nesting selectors directly within :not). For invalidation, we do need to traverse into the complex selectors nested (deep) inside :not(), for example to mark .b as invalidates- self for ".a :not(:is(.b))", but at the :not-boundary during feature extraction, we avoid propagating the features, such that .a is marked with whole-subtree recalc. We already have similar logic in ExtractInvalidationSetFeaturesFromCompound which prevents feature extraction for selectors held by :not directly. Note that CSSParserSelector::IsSimple() only has one call-site, and that's during parsing of :not(). Bug: 568705 Change-Id: Ic7cb421c4d8f6a6e85cfea30c987db2e0fed64fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463830 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#816328}
-
Sinan Sahin authored
This CL extracts ChromeContextMenuPopulator's native methods into a separate class, ChromeContextMenuNativeDelegate. This class implements an interface, ContextMenuNativeDelegate, that is referenced from other classes without depending on the populator. Bug: 1137469 Change-Id: If111e8e40af011566271040ca1ad3a18fc81c915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462047Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#816327}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c7b98f06001..a4b8d27d96b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5ca3fe6afadd06793cb29f98569899259ba5168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816326}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c7b98f06001..a4b8d27d96b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic9671ce4043a9ff946c7fb08947996920e824260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465870Reviewed-by:
-
Lei Zhang authored
Change-Id: I3c836543b97c9c807061608ceeff29ba09114145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464349Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816324}
-
Frank Li authored
This CL is to replace lpacAppServices with lpacInstrumentation for SandboxType::kMediaFoundationCdm. https://chromium-review.googlesource.com/c/chromium/src/+/2401506 has a mistake of using lpacAppServices. Windows Media Foundation needs lpacInstrumentation capability to access Windows Event Tracings and Telemetries. Bug: 999747 Change-Id: I68ba48b531dd9bb611db08073017a9bf562605f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462729Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Frank Li <frankli@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816323}
-
Tiancong Wang authored
For the efforts to use generalized names for Chrome OS, we will rename them to atom and bigcore. This patch will add the support for those two first, but not remove the old names. It's because we need those to pass uprev Chrome in Chrome OS first, and then make changes in Chrome OS to remove the old broadwell/airmont, and then we can clean it up. Bug: 1135245 Test: gclient sync Change-Id: I83c27e827d4950d43c37dc9c78b7bbe62ce62f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250820 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#816322}
-
Brian Sheedy authored
Refactors several sets of GPU expectation tags for clarity: 1. ANGLE backend tags now have an angle- prefix 2. Tags that only make sense in the context of Skia Renderer have been consolidated instead of having separate use/no-use tags for each version. Bug: 1011107, 1111876 Change-Id: I55d68444b4aa88116666d5464c470f7433dbc6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462222 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816321}
-
David Manouchehri authored
Bug: 1136327 Change-Id: I8ced300d7de0e2465e54d5111f915af425c66c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463708 Auto-Submit: David Manouchehri <david@davidmanouchehri.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#816320}
-
Bo Majewski authored
Bug: 1113981 Change-Id: I90081b67e4e1cc4313e8a9c441ac05fed7ba7320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437715Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#816319}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4aa4c6014d56..3637a44a3643 2020-10-12 mtklein@google.com update comments and rearrange SkVx.h 2020-10-12 egdaniel@google.com Update attachment unique key to handle format and protected. 2020-10-12 michaelludwig@google.com Take crop rect into account for input bounds/reverse filter bounds 2020-10-12 mtklein@google.com power up skvx::map 2020-10-12 bsalomon@google.com Revert "Revert "Use ManagedBackendTexture in place of TestUtils backend texture helpers."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I977022183f836d44307e59607298d631b2f8f090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465939Reviewed-by:
-
Xianzhu Wang authored
Change-Id: I84a1149e64d477ade11df1b114187feeea6757aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466384Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816317}
-
Antonio Gomes authored
This replaces the use of ash::TabletMode and ash::TabletModeObserver in BrowserNonClientFrameViewAsh. This corresponds to phase 2.6 on the design document [1]. Covered by existing tests, eg BrowserNonClientFrameViewAshTest.BrowserHeaderVisibilityInTabletModeTest HomeLauncherBrowserNonClientFrameViewAshTest.TabletModeBrowserCaptionButtonVisibility [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=sky@chromium.org Change-Id: I6a21ca44538e52a2712bbb936221aa24063daa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462560 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#816316}
-
rajendrant authored
Currently throttling is temporaily stopped, i.e., new requests will get throttled, on too much rebuffer events. This CL changes it to stop permanently. Bug: 1137505 Change-Id: Iae6453c3799229939415bac5205450b82c4a4ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466605Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#816315}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30127e006a5b..b49605bd62cd 2020-10-12 patrick.brosset@microsoft.com Track when custom properties are edited If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifd7696b78bc11639c6e8c27238bdde2d1fdd3e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466331Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602503558-f6db874387e2078784a354d0f7c8c59a21bebaa6.profdata to chrome-mac-master-1602525418-295b1a16e5c5eb1a611980e5afdf689a2be9286a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1c019a5b5153f9b13febc77377cc4eb1743f3bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466639Reviewed-by:
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Ic8080d5d61bb7b74a445f70240611aff5c4d9148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462080 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#816312}
-
Michael Irani authored
Add aria tags so that label and value for fields announced when in ChromeVox mode. Bug: 1034104 Change-Id: I47e7b98a01fb8ef694f179f26e120a67d4341859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464054Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Michael Irani <michaelirani@chromium.org> Auto-Submit: Michael Irani <michaelirani@chromium.org> Cr-Commit-Position: refs/heads/master@{#816311}
-
Nick Czajka authored
This change modifieds the behavior of night_light_controller.cc to selectively apply ambient color to only internal displays. It also restructures night_light_controller_unittest.cc to allow for multiple displays in AmbientEQTest. The two tests affected by this change are also moved from NightLightTest into AmbientEQTest. Bug: 1078901 Change-Id: Ie967698d99713026591b44ddeaee294f80e2df60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453904 Commit-Queue: Nick Czajka <czajka@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#816310}
-
Hiroki Nakagawa authored
These functions are declared in prerender_util.h, but not defined. - ReportPrerenderExternalURL() - ReportUnsupportedPrerenderScheme() According to the Git history, the definitions were removed by this CL: https://crrev.com/c/c2157903 Bug: 755921 Change-Id: Id070c760d5769be2f97b36213e4fd9360a01fd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465355 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#816309}
-
Hiroki Nakagawa authored
This directory contains only OWNERS file. Files existed there were moved into components/ for supporting NoStatePrefetch on WebLayer, for example, by https://crrev.com/c/2310329. Bug: 1096088 Change-Id: Ie22858163b75cfb825acaca8b01017a4a04b0afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463050Reviewed-by:
-
Gang Wu authored
1. Add a custom view for "Add to" menu item, which contains a divider line and an "Add to..." menu item. Also split "Add to Home screen" and "Install app" two menu items because of https://docs.google.com/presentation/d/1z9yWp7-qcP0BCLo9_3z-8X6xGntkH1tqRjbGP0lXyiw/edit#slide=id.g980eadd427_0_423 2. Using ModalDialogManager to create "Add to:" window. Bug:1135185 Change-Id: I707ac343d9de6f252e93ab97b1a8bc083d8f1138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446450 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
-
Tim Judkins authored
The nodefine property was added over 4 years ago when deprecating some Media Gallery APIs. This CL removes those deprecated APIs, along with the nodefine property. Bug: 1136659 Change-Id: Idf087287926903fbaa83ee13c2340320043fc038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462254Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#816306}
-
Collin Baker authored
This behavior broke in a recent change, causing stale thumbnails and a DCHECK in enabled builds. Fixed: 1137330 Bug: 1136247 Change-Id: I70bee4d25e2c0693bcf55fe95dc2744dfb354456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464785Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#816305}
-
Dana Fried authored
Capture was banned for current tab as a workaround for crbug.com/1112607, but a fix for the root cause has been submitted and is in M87. Now the workaround - a lesser of two evils - is causing trouble and no longer necessary (see attached bug). Bug: 1137133 Change-Id: If00ddacf3b55d7b17d28ab5064410bbc13b7779c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463871 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#816304}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602482293-b6c9af61d9b709e1e409c88a2a609d5546a5c2ce.profdata to chrome-win64-master-1602503558-c2e745b5a37c8ee5f138ede7ee7fff767428f64a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I739f37103933c59b09a08d939e8974b44133785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465771Reviewed-by:
-
Lucas Radaelli authored
The Fuchsia Semantics API changed, so this change converts the new added roles. Note that this change is not converting the added roles related to lists, which will be solved in a future change. Test: AXTreeConverterTest.ConvertRoles Bug: fuchsia:60180,1136536 Change-Id: I23e8b0dc02e2e9f85cae16be81c400744831905a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461954 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816302}
-
Elly Fong-Jones authored
Replace it with a vanilla WidgetDelegate using the default contents view. Bug: 1075649 Change-Id: Ia3beabd4bedc512452cc9430ed605d4b829c727e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461212Reviewed-by:
-
Alex Newcomer authored
If the profile being left had a folder, we kept a reference to that folder in AppListModel's ScopedObserverList. But when profiles are swapped, we delete everything in the AppListModel::top_level_item_list_. This means the folder is deleted. Remove the item from the ScopedObserverList if it is a folder. Bug: 1130901 Change-Id: I1d6ab268739f81904debcc4654e5663ddf768013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464151 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816300}
-
Anders Hartvoll Ruud authored
Having a separate copy-pasted codepath for selector matching is not acceptable for maintainability reasons. Instead we can lazily create an actual Element to represent the almost-featureless element described by the spec [1], and use this as the originating element during selector matching. The element has no ID, no classes, no attributes, no tag name, no namespace, no parent, no siblings; so it should be pretty hard to match against it. Longer term it would be nice to make the originating element actually featureless [2]. Bug: 1137349 TEST=external/wpt/webvtt/rendering/cues-with-video/processing-model/support/embedded_style_selectors.html [1] https://w3c.github.io/webvtt/#obtaining-css-boxes [2] https://github.com/w3c/webvtt/issues/477 Change-Id: I06d618546893be3942ea5406507a01bc508340d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462274 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716915427088..933ae5eaad9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mahmadi@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1133394,chromium:1137431 Tbr: mahmadi@google.com,gab@google.com Change-Id: Ib05920163f5725801ddd34b9907e4836b5ff80ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465514Reviewed-by:
-
