Commits · f9032755ef38bf62ede70bab84860c54dc892b7d · eriksson monteiro / tangled

23 May, 2012 18 commits

Revert 138418 - Fixes lack of forward declaration of GdkEvent in render_widget_host_view. · f9032755

pkotwicz@chromium.org authored May 23, 2012

This fixes bot redness caused by 10411086

Bug=None
Test=Bots go green

Review URL: https://chromiumcodereview.appspot.com/10421030

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10408083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138423 0039d316-1c4b-4281-b951-d872f2087c98

f9032755

Re-enable IndexedDBLayoutTest.BasicTests; expected output updated in WebKit. · 7d0c4aae

jsbell@chromium.org authored May 23, 2012

The test relies on a WebKit layout test. The test code was updated in
WebKit r117702 but basics-shared-workers-expected.txt was not updated as
that test is not run in WebKit. Expectation updated in WebKit r117800.

BUG=128959
TEST=browser_tests --gtest_filter='IndexedDBLayoutTest.BasicTests'

Review URL: https://chromiumcodereview.appspot.com/10417017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138421 0039d316-1c4b-4281-b951-d872f2087c98

7d0c4aae

Browser Plugin: Fix broken build windows build. · 22f17b3e

fsamuel@chromium.org authored May 23, 2012

Broken by http://codereview.chromium.org/9968097/

BUG=none
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10414068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138420 0039d316-1c4b-4281-b951-d872f2087c98

22f17b3e

Revert 138415 - Makes the browser send pixels to the GPU process where it should. · 0383fcc8

pkotwicz@chromium.org authored May 23, 2012

This patch fixes the places where we will be sending DIP to the GPU process but should be sending pixels instead to the GPU process once https://bugs.webkit.org/show_bug.cgi?id=86051 lands.
This patch reverts:
http://codereview.chromium.org/127553/
http://codereview.chromium.org/10332077/

Bug=127455, 114677
Test=Manual
SchedulePaintInRect is called with parameters in DIP

TBR=piman@chromium.org,sky@chromium.org,jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10411086

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138419 0039d316-1c4b-4281-b951-d872f2087c98

0383fcc8

Fixes lack of forward declaration of GdkEvent in render_widget_host_view. · deb96b4e

pkotwicz@chromium.org authored May 23, 2012

This fixes bot redness caused by 10411086

Bug=None
Test=Bots go green

Review URL: https://chromiumcodereview.appspot.com/10421030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138418 0039d316-1c4b-4281-b951-d872f2087c98

deb96b4e

Renderer-side changes for browser plugin · 468e4904

fsamuel@chromium.org authored May 23, 2012

Major Classes:

BrowserPluginChannelManager: Manages GuestToEmbedderChannels. It essentially wraps a map that is keyed on channel names.

GuestToEmbedderChannel: Is a Dispatcher. Receives/Sends Ppapi messages. Keeps track of all RenderViews that have an associated PP_Instance in a map (RenderViews that are guests). brettw@ might want to have a look here?

BrowserPluginRegistry: Wrapper around map that keeps track of Browser Plugin PluginModules keyed on the guest process id. This is similar to the PepperPluginRegistry but has a different key type.

BrowserPluginVarSerializationRules: Temporary do nothing class as suggested by brettw@

BrowserPlugin: Towards becoming a wrapper around a WebPluginContainerImpl that swaps out WebPluginImpl/WebViewPlugin on navigation. We get a blank WebViewPlugin (is this a best thing to do to get a blank placeholder?) if we have an empty src attribute or while we're navigating for the first time. Otherwise, on cross-process navigations, we substitute one WebPluginImpl for another WebPluginImpl. TODO: BrowserPlugin should track the lifetime of WebPluginContainerImpl, but right now it lives forever which is bad. Will fix this in a subsequent patch. This requires some WebKit changes first.

BUG=117897
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/9968097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138416 0039d316-1c4b-4281-b951-d872f2087c98

468e4904

Makes the browser send pixels to the GPU process where it should. · 28599f48

pkotwicz@chromium.org authored May 23, 2012

This patch fixes the places where we will be sending DIP to the GPU process but should be sending pixels instead to the GPU process once https://bugs.webkit.org/show_bug.cgi?id=86051 lands.
This patch reverts:
http://codereview.chromium.org/127553/
http://codereview.chromium.org/10332077/

Bug=127455, 114677
Test=Manual
SchedulePaintInRect is called with parameters in DIP

TBR=piman@chromium.org,sky@chromium.org,jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10411086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138415 0039d316-1c4b-4281-b951-d872f2087c98

28599f48

Add BGRA output format support to qcms · 8ca4c955

estade@chromium.org authored May 23, 2012

Define QCMS_OUTPUT_BGRX and add qcms_transform_data_type() api to output
BGR or BGRA format for GRAY, GRAYA, RGB, and RGBA input data.

Update all color transform functions with an output format argument, use
that to select RGBX (the default) or BGRX output format.

Add google.patch: patch of the BGRA output changes against upstream qcms
and add README.chromium details about google.patch. TODO: send the patch
to qcms if accepted for review upstream.

Disable Visual Studio warnings when needed.

BUG=143
TEST=None
AUTHOR=noel@chromium.org
original review = http://codereview.chromium.org/10387099/

Review URL: https://chromiumcodereview.appspot.com/10407113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138414 0039d316-1c4b-4281-b951-d872f2087c98

8ca4c955

[net] Switch TestURLRequestContext and other tests to use... · d5a4dd65

szym@chromium.org authored May 23, 2012

[net] Switch TestURLRequestContext and other tests to use MockCachingHostResolver or MockHostResolver.

Make explicit when HostResolver::Resolve is expected to never complete in tests.
Clean up TestURLRequestContext API.

BUG=126016,128745
TEST=net_unittests; jingle_unittests; sync_unit_tests

Review URL: https://chromiumcodereview.appspot.com/10408067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138413 0039d316-1c4b-4281-b951-d872f2087c98

d5a4dd65

layers: Consolidate the ownership of layers in views::View and aura::Window. · 222c84bf

sadrul@chromium.org authored May 23, 2012

BUG=none
TEST=aura_unittests, views_unittests.

Review URL: https://chromiumcodereview.appspot.com/10412044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138412 0039d316-1c4b-4281-b951-d872f2087c98

222c84bf

Disable FileWriterDelegateTest.WritesWithQuotaAndOffset, which has · 11c50f80

wtc@chromium.org authored May 23, 2012

been flaky on Windows. 

[ RUN      ] FileWriterDelegateTest.WritesWithQuotaAndOffset
..\webkit\fileapi\file_writer_delegate_unittest.cc(367): error: Value of: test_helper_.GetCachedOriginUsage()
  Actual: 45
Expected: ComputeCurrentOriginUsage()
Which is: 0
[  FAILED  ] FileWriterDelegateTest.WritesWithQuotaAndOffset (16 ms)

TBR=kinuko@chromium.org 
BUG=129264
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10411084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138411 0039d316-1c4b-4281-b951-d872f2087c98

11c50f80

[Chromoting] Fix full version marker in Keystone postflight.sh script. · 9fdf91f3

garykac@chromium.org authored May 23, 2012

BUG=129273
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10399138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138410 0039d316-1c4b-4281-b951-d872f2087c98

9fdf91f3

Have Zygote fork a init-like process if required · 4cbc5788

jln@chromium.org authored May 23, 2012

When we use the setuid sandbox, Zygote may get launched in a new PID
namespace, with pid == 1. In that case we need to act as a init
process and reap zombies.

BUG=125821,109944
TEST=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10417019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138409 0039d316-1c4b-4281-b951-d872f2087c98

4cbc5788

Run base_unittests_apk on the test try bot for realz. · 7b56f187

nileshagrawal@chromium.org authored May 23, 2012

This will make the android_test bot red when apk tests fail.

The ANDROID_APK_TEST_TARGET flag is required while we transition from executable to APK tests.
 - Executable tests need the DIR_CACHE override as the default path comes from the java side.

BUG=125059

Review URL: https://chromiumcodereview.appspot.com/10332230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138407 0039d316-1c4b-4281-b951-d872f2087c98

7b56f187

[Chromoting] Use the full version when registering with Keystone. · fdc9d6c5

garykac@chromium.org authored May 23, 2012

BUG=129273
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10417042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138406 0039d316-1c4b-4281-b951-d872f2087c98

fdc9d6c5

Remove obsolete image cursor file · a0d84ea7

oshima@chromium.org authored May 23, 2012

TBR=sky@chromium.org, varunjain@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10412048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138403 0039d316-1c4b-4281-b951-d872f2087c98

a0d84ea7

Disable FileWriterDelegateTest.WriteSuccessWithoutQuotaLimitConcurrent, which... · 1aa13e51

vandebo@chromium.org authored May 23, 2012

Disable FileWriterDelegateTest.WriteSuccessWithoutQuotaLimitConcurrent, which has been flaky on Windows.

TBR=kinuko@chromium.org
BUG=129264
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/10383295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138402 0039d316-1c4b-4281-b951-d872f2087c98

1aa13e51

[Chromoting] Simple script to print out installed mac version info. · 9f4bd34d

garykac@chromium.org authored May 23, 2012

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10332303

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138401 0039d316-1c4b-4281-b951-d872f2087c98

9f4bd34d

22 May, 2012 22 commits

browser: Rename message_box_handler.* to javascript_dialog_creator.* · 82194b5f

tfarina@chromium.org authored May 22, 2012

So the filename matches much more with the free function names used in the
header file and with the class name used in the source file.

R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10389228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138398 0039d316-1c4b-4281-b951-d872f2087c98

82194b5f

fix checkperms for windows-only .py files (in remoting/) · c0b4b941

scottmg@google.com authored May 22, 2012

TBR=vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10408079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138397 0039d316-1c4b-4281-b951-d872f2087c98

c0b4b941

ntp: fix CWS footer link wrapping · 913c44e7

estade@chromium.org authored May 22, 2012

BUG=none
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/10417039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138396 0039d316-1c4b-4281-b951-d872f2087c98

913c44e7

Disable tests broken by WK r118001 · bf43a38e

jsbell@chromium.org authored May 22, 2012

BUG=129235
R=vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10414060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138395 0039d316-1c4b-4281-b951-d872f2087c98

bf43a38e

gdata: Fix a bug that caused histograms on gdata files to be skewed. · ddf061b2

satorux@chromium.org authored May 22, 2012

We shouldn't record the histograms when processing delta feeds.

BUG=129248
TEST=manually confirmed by chrome://histograms

Review URL: https://chromiumcodereview.appspot.com/10416049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138394 0039d316-1c4b-4281-b951-d872f2087c98

ddf061b2

Make ExtensionTtsPlatformImplWin a leaky singleton to avoid a crash in the destructor. · e2a23785

dmazzoni@chromium.org authored May 22, 2012

BUG=122026
TEST=Does not crash on shutdown on XP. Speech still stops if you load TTS Demo and exit in the middle of a long sentence.

Review URL: https://chromiumcodereview.appspot.com/10413054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138393 0039d316-1c4b-4281-b951-d872f2087c98

e2a23785

Move remoting dark/candle/light steps to external script · b7b5d64a

scottmg@chromium.org authored May 22, 2012

This avoids the need to chain the output of gyp rules, which is not supported
across generators.

See also https://chromiumcodereview.appspot.com/10381103/ and https://groups.google.com/forum/?fromgroups#!topic/gyp-developer/f_oCV-Lavpw

R=alexeypa@chromium.org
BUG=127444
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10392172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138392 0039d316-1c4b-4281-b951-d872f2087c98

b7b5d64a

Update a comment to remove a reference to BrowserList::GetLastActive which was obsolete. · 7e2a3998

ben@chromium.org authored May 22, 2012

http://crbug.com/129187
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10407109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138385 0039d316-1c4b-4281-b951-d872f2087c98

7e2a3998

Remove content::URLFetcherDelegate · 15fb2aad

akalin@chromium.org authored May 22, 2012

Change all references to net::URLFetcherDelegate.

Change some instances of content::URLFetcher to net::URLFetcher as
needed.

Remove unused files auth_response_handler.*.

BUG=118220
TEST=
TBR=sky@chromium.org,joi@chromium.org,mnissler@chromium.org,rlp@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10392192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138384 0039d316-1c4b-4281-b951-d872f2087c98

15fb2aad

cros: Maybe fix recent failures on trunk. · 3d6dfd5d

erg@google.com authored May 22, 2012

BUG=129075
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10399134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138381 0039d316-1c4b-4281-b951-d872f2087c98

3d6dfd5d

Remove BrowserList::GetLastActive usage in TaskManager. Just use browser::Navigate() instead. · c3e6420a

ben@chromium.org authored May 22, 2012

http://crbug.com/129187
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10414054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138380 0039d316-1c4b-4281-b951-d872f2087c98

c3e6420a

Remove BrowserList usage from autofill CC infobar delegate, replacing it with... · 1a0ebdac

ben@chromium.org authored May 22, 2012

Remove BrowserList usage from autofill CC infobar delegate, replacing it with using content api directly to open a tab in the relevant context. This also allows us to remove some cruft from Browser.

http://crbug.com/129187
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10417036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138379 0039d316-1c4b-4281-b951-d872f2087c98

1a0ebdac

[Chromoting] Add a filter that will stop the host sending unnecessary... · ff3761a1

simonmorris@chromium.org authored May 22, 2012

[Chromoting] Add a filter that will stop the host sending unnecessary clipboard events to the client.

The host does not yet send any clipboard events to the client. A follow-up CL will make that happen.

BUG=117473

Review URL: https://chromiumcodereview.appspot.com/10399052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138377 0039d316-1c4b-4281-b951-d872f2087c98

ff3761a1

Browser Plugin: Fixed silly typo in PpapiCommandBufferProxy. · b44a986e

fsamuel@chromium.org authored May 22, 2012

Accidiently had the wrong number of brackets which did not produce the desired
behavior while iterating over previous issue 10387182. This change makes it do
the right thing.

BUG=none
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10421007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138374 0039d316-1c4b-4281-b951-d872f2087c98

b44a986e

Browser Plugin: WebContnets should notify when it's restored · 375fa1b1

fsamuel@chromium.org authored May 22, 2012

Renamed NOTIFICATION_WEB_CONTENTS_HIDDEN to NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED and
updated all appropriate places. We check for the detail false if we meant to check if the
WebContents is hidden. This matches the behavior of RenderWidget's
NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED.

Added a WasRestored method to WebContents public interface.
Call WasRestored from WebContents::ShowContents

BUG=128814
TEST=did not break existing autofill popup browser test

Review URL: https://chromiumcodereview.appspot.com/10411033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138372 0039d316-1c4b-4281-b951-d872f2087c98

375fa1b1

Validates service state file and ask user to update information if necessarily. · 666b38db

vitalybuka@chromium.org authored May 22, 2012

Connects to Google servers to get authentication tokens.

BUG=125026
TEST=service_state_unittest.cc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138294

Review URL: https://chromiumcodereview.appspot.com/10414020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138371 0039d316-1c4b-4281-b951-d872f2087c98

666b38db

Remove obsolete png files Add custom cursors to touch.grd file · 8d1597c7

oshima@chromium.org authored May 22, 2012

TBR=sky@chromium.org
BUG=110394
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10413059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138370 0039d316-1c4b-4281-b951-d872f2087c98

8d1597c7

Get rid of the need of ViewType::VIEW_TYPE_INTERSTITIAL_PAGE in content. There... · ba45bfdb

jam@chromium.org authored May 22, 2012

Get rid of the need of ViewType::VIEW_TYPE_INTERSTITIAL_PAGE in content. There are no ViewType values left in content, so in the next change I'll move this whole concept out of content and into chrome. That allows us to get rid of RenderViewHostDelegate::GetRenderViewType which is the last remaining need for RVHD in chrome.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10383292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138369 0039d316-1c4b-4281-b951-d872f2087c98

ba45bfdb

gdata: Fix a crash when adding a new file to a new but deleted directory. · ba5771c7

satorux@chromium.org authored May 22, 2012

FindDirectoryForNewEntry() was crashing when:
1) a new file is added to a new directory in the same delta feed
2) but the new directory entry is marked "deleted" (moved to trash)

BUG=127495
TEST=added a unit test for the fix

Review URL: https://chromiumcodereview.appspot.com/10408071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138368 0039d316-1c4b-4281-b951-d872f2087c98

ba5771c7

[Coverity] Fix uninitialized member, pass-by-val. · 2b206813

groby@chromium.org authored May 22, 2012

CID=104035,104037
TBR=sehr@google.com

R=jhawkins@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10408051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138366 0039d316-1c4b-4281-b951-d872f2087c98

2b206813

Revert 137754 - Disable cloud print connector policy checking on Windows. · 4abf3698

scottbyer@chromium.org authored May 22, 2012

While the real cause of crbug.com/128541 is being investigated, temporarily
disable the policy checking which seems to precipitate the crash. This fix is
speculative and the next canary will be watched to be sure this helps.

This will be reverted once a proper fix/workaround is found.

BUG=128541

Review URL: https://chromiumcodereview.appspot.com/10377189

TBR=scottbyer@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138365 0039d316-1c4b-4281-b951-d872f2087c98

4abf3698

Show fixed arrow for uber tray bubble if shelf alignment is vertical. · 2aa4095d

jennyz@google.com authored May 22, 2012

BUG=127577
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/10417013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138360 0039d316-1c4b-4281-b951-d872f2087c98

2aa4095d