- 13 Jul, 2018 40 commits
-
-
Patti authored
r574073 updated the all sites page to use an iron-list, which allows parts of the DOM to be re-used as the user scrolls down the page and loads additional all sites items. However, since the expandable list in each site-entry is stored separately (i.e. not in the iron-list item), this value can get stale when an already expanded entry is re-used in an ungrouped site-entry, resulting in a site-entry with a single origin listed getting stuck in an opened state. To fix, check when the site-entry changes iron-list items and close the expandable list if the iron-list item is ungrouped. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2bb33b60623e2fb12487e730ec122391a1d76660 Reviewed-on: https://chromium-review.googlesource.com/1134644 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#574839}
-
Peter Kasting authored
Bug: 850573 Test: Open a popup window (e.g. using popuptest.com); double-clicking the window icon should close the window Change-Id: Iec6b2d192502557f1e95ade99c204a6db58dfff6 Reviewed-on: https://chromium-review.googlesource.com/1136059 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#574838}
-
Ryan Cui authored
Bug: 826476 Change-Id: Id24d14cd5dc0ac31fac4e865f71047aa75c8a786 Reviewed-on: https://chromium-review.googlesource.com/1130819 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574837}
-
Douglas Creager authored
Per https://github.com/w3c/reporting/issues/41, we're supposed to send a CORS preflight request before uploading reports, if the origin of the reports is different than the origin of the collector. There is existing CORS preflight code in both Blink and the Network Service. Code in //net isn't allowed to depend on either of those; instead of using a delegate to handle the inverted dependency, we just send out the preflight request by hand, just like the Expect-CT code does. Bug: 860802 Change-Id: Ib20db54d3d2597d9fbacfe356e61cc6d3bc9d5fc Reviewed-on: https://chromium-review.googlesource.com/1128600 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#574836}
-
Jinsuk Kim authored
Removing myself from watchlist for changes to ContentViewCore classes as they're gone. Change-Id: I72aa9902ce0c704a650168dfd97307b5c7f5aad8 Reviewed-on: https://chromium-review.googlesource.com/1133600Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#574835}
-
Christopher Cameron authored
The call to hb_buffer_add_utf16 will read up to 5 characters adjacent to the specified range. This context is only used in the function arabic_joining. We can get much better caching if we don't include this context in our keys. Arabic is an RTL language, so we can omit this context in the key for all non-RTL languages. Bug: 860612, 862773 Change-Id: Icc11059886ab835032141ad25b966d358f7177b3 Reviewed-on: https://chromium-review.googlesource.com/1135723 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574834}
-
Peter Kasting authored
This fix applies solely to pre-refresh and corrects a regression in previous refactoring I did in https://crrev.com/555249 . Bug: 840338 Test: Launch chrome in Material (not Refresh) mode; maximized the window and open enough tabs to fill the strip. The new tab button should not be near-touching the profile avatar button. Change-Id: I60598a1e7bcf45e039d19424c8639958094b7658 Reviewed-on: https://chromium-review.googlesource.com/1136065 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#574833}
-
Chih-Yu Huang authored
When VEA negotiates the input size, the driver might adjust the size for buffer alignment. In this case, we should verify whether the encoded video has the original size. BUG=b:79551489 TEST=Pass VEA unittest on kevin device with QCIF video $ ./video_encode_accelerator_unittest --test_stream_data=foreman_qcif.yuv:176:144:1:out1.h264:1000000:30 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia6e5de20cdd6fcbcdb043edfaa09150229b3c3ba Reviewed-on: https://chromium-review.googlesource.com/1062987 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#574832}
-
Scott Chen authored
Bug: 861685 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib84715313698d8ded12cc7ecedfae719e15e917e Reviewed-on: https://chromium-review.googlesource.com/1135758Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574831}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2af75f76f0e6..589fda45ed12 git log 2af75f76f0e6..589fda45ed12 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 oysteine@google.com Build protozero libraries as source_sets instead of static libraries in component builds Created with: gclient setdep -r src/third_party/perfetto@589fda45ed12 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:78791178 TBR=perfetto-bugs@google.com Change-Id: Idce6841215e7962bd4fbc27b1b5bedf26cee9627 Reviewed-on: https://chromium-review.googlesource.com/1135495 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574830}
-
Darren Shen authored
Currently, when we cycle through results in find in page, we ensure that the current result is visible by scrolling if the result is off-screen. We currently use the layout viewport as an indication of what's visible on the screen. However, layout viewport does not include the virtual keyboard on ChromeOS. This means that on a tablet, the current result may be hidden by the virtual keyboard. We change find in page to use the visual viewport instead, which takes into account region occluded by the virtual keyboard, so the current result is always visible even when the virtual keyboard is up. Bug: 862842 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I10e52091fb54617ae3d0222130cd1c22699117f5 Reviewed-on: https://chromium-review.googlesource.com/1134722Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#574829}
-
Peter Wen authored
Reflects the change from --full to --fast. Bug: 620034 Change-Id: Id88f4f3e00cc1f6fcdc4878786cc342d8717537d Reviewed-on: https://chromium-review.googlesource.com/1135530 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574828}
-
Giovanni Ortuño Urquidi authored
FindMatchingUrlHandler checks if the Chrome app supports offline and if not returns no matching URL handlers. This is done in order to avoid redirecting links to apps that don't support offline. Unfortunately, this offline check causes problems for Desktop PWAs. Desktop PWAs use FindMatchingUrlHandler to decide if a URL belongs to an app. Because of the check in FindMatchingUrlHandler, it seems as if no URLs belong to the app. To solve the issue, we introduce separate methods to be used by Bookmark Apps and Platform Apps. The Platform Apps method checks for offline and the Bookmark Apps one does not. Bug: 850626 Change-Id: If5642d342b558098c7bfe1c251912504cad1d957 Reviewed-on: https://chromium-review.googlesource.com/1124075Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#574827}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13ac194dbf99..9cdbf1942de5 git log 13ac194dbf99..9cdbf1942de5 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-13 bsalomon@google.com Remove texel buffer support. Created with: gclient setdep -r src/third_party/skia@9cdbf1942de5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I7e535dcbb3290cfa43f819f862c6f9a37dfd960f Reviewed-on: https://chromium-review.googlesource.com/1135673Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574826}
-
Taiju Tsuiki authored
This reverts commit 37061f87. Reason for revert: The layout tests added by this CL is failing on the CL: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 Original change's description: > Correctly initialize and test SnapContainerData in cc. > > This patch initializes the rect_ field in SnapContainerData in copy > constructor and move constructor. Fixing a snapping issue in the > composited pages. > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > test suite so that they are tested with the composited cases. > > snap-at-user-scroll-end-manual-automation.js calls > mouseClickInTarget() of pointerevent_common_input.js. That method > invokes programmatic scrolls. The test was written before programmatic > scroll snapping was implemented so it worked at that time. However, > with programmatic scroll snapping implemented, it will always snap > in mouseClickIntarget() and cannot test whether the user scroll snaps. > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > to avoid invoking programmatic scrolls in the test. > > This patch also checks nullptr for layout_box in > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > Reviewed-on: https://chromium-review.googlesource.com/1132386 > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574781} TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1136171Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574825}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Idbeb132167cb747f2b3a432c21ad861864587a35 Reviewed-on: https://chromium-review.googlesource.com/1136032Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574824}
-
Taiju Tsuiki authored
This reverts commit 51181f47. Reason for revert: Speculatively revert for resolving the bot failure on the CI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041 Original change's description: > Increase the UI paint timeout to 5 seconds. > > This fixes the first browser window appearing blank for a moment. In > general, it's better to block than to show the UI in an inconsistent > state. Web content should *not* wait this long. > > Bug: 849762 > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73 > Reviewed-on: https://chromium-review.googlesource.com/1135119 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574731} TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849762 Reviewed-on: https://chromium-review.googlesource.com/1136131Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574823}
-
Maajid authored
This reverts commit e2cee66e. Reason for revert: broke tree Original change's description: > Record to UMA when starting an ARC++ app from the launcher. > > Bug: 854542 > Test: chrome://histograms > Change-Id: I635aa0522ebb2cac70f056937508ff5ef183d244 > Reviewed-on: https://chromium-review.googlesource.com/1112891 > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Maajid <maajid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574819} TBR=stevenjb@chromium.org,rkaplow@chromium.org,khmel@chromium.org,maajid@chromium.org Change-Id: I48cd080e2b59f5bad5ea7a12ca1e50da7cb3cbad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854542 Reviewed-on: https://chromium-review.googlesource.com/1136111Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#574822}
-
Derek Cheng authored
To ensure MediaRouter's route list is updated when a DIAL launch app fails, we will need to invoke erase the route from the list of records before notifying DialMediaRouteProvider of the route list update. Bug: 808720 Change-Id: I65c925dc74a57a1c2d80dc1366f8be3ccbf40ce5 Reviewed-on: https://chromium-review.googlesource.com/1134867Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574821}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/security/setDomainRelaxationForbiddenForURLScheme.html indicates that on many builders (probably all those without DCHECK on) this test passes. Bug: 699347, 686118 Change-Id: I7496ce45d0ce5c196073acba954f8cd48c7f1f3b Reviewed-on: https://chromium-review.googlesource.com/1135661Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574820}
-
Maajid authored
Bug: 854542 Test: chrome://histograms Change-Id: I635aa0522ebb2cac70f056937508ff5ef183d244 Reviewed-on: https://chromium-review.googlesource.com/1112891Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#574819}
-
Tim Zheng authored
This change removes from the shelf all Crostini spinners when one Crostini app is starting in a window but fails to uniquely identify app ID. BUG=chromium:854911 TEST=Manually tested on an even device. Change-Id: I2924e33ac5f0e0b0bd34d4ed05307d3aa0512cdf Reviewed-on: https://chromium-review.googlesource.com/1135837Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574818}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5bc4fc8f3f26..13ac194dbf99 git log 5bc4fc8f3f26..13ac194dbf99 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 fmalita@chromium.org [skottie] Fix matrix parenting for default/static values 2018-07-12 caryclark@skia.org fix include generation 2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-12 bungeman@google.com Remove SkRefCnt_SafeAssign. 2018-07-12 bungeman@google.com Remove SkSafeSetNull. 2018-07-12 herb@google.com Move to using pointers in simplifyDraw* 2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c9c259cccb2e..1617e69e3883 (5 commits) 2018-07-12 brianosman@google.com Replace nearly all kRespect with kIgnore Created with: gclient setdep -r src/third_party/skia@13ac194dbf99 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Icd0d4fe7cb01295422218ef08a860a681010beab Reviewed-on: https://chromium-review.googlesource.com/1135621Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574817}
-
James Darpinian authored
Second try after revert 6df2efa5. Original at https://crrev.com/c/1105505 Automatically grow the transfer buffer when it is full and shrink it when the full capacity is not being used. Start at a smaller size. Before we would only grow it when a single transfer request was larger than the whole buffer; requests smaller than the whole buffer would just block if the buffer was full. Also we would not ever shrink the buffer until someone called Free() manually. Bug: 850271, 835353, 828363, 856347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id1223267d0ab444afe18f62f45ae5f365131e18c Reviewed-on: https://chromium-review.googlesource.com/1125503Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#574816}
-
Jinsuk Kim authored
|ContentViewCoreImpl.initialize| is called to create various browser components in content layer when instantiating ContentViewCore. This CL moves the method to WebContents as a public API and let embedders call it instead of creating CVC. It leaves CVC empty, so deletes the class entirely. With CVC gone, null check against CVC object can be replaced with that against WebContents as embedders are already managing their references to them in sync (init/nulling out at the same time). Some methods with ContentViewCore in there names are updated as well to reflect what they really do after the change, such as s/createContentViewCore/initWebContents. Bug: 598880 Change-Id: Ic1ae53ec1addf74b56e2ae4c972b41889005a359 Reviewed-on: https://chromium-review.googlesource.com/989515 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574815}
-
Devlin Cronin authored
Point apps-related directories to //apps/OWNERS as the source of truth, and remove asargent (who's no longer on chrome) as an OWNER. Bug: None Change-Id: I631772b7bb05eaadcd8b5ac7153fa9b8d7b3ee41 Reviewed-on: https://chromium-review.googlesource.com/1135586Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574814}
-
bsheedy authored
Fixes gn gen failing on Android when incremental_apk_by_default is true due to not forwarding additional_apks for monochrome_public_test_ar_apk. Bug: 863102 Change-Id: If2c168e5e966f3464056131635be84ede8f568e3 Reviewed-on: https://chromium-review.googlesource.com/1135911 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574813}
-
wutao authored
This patch dismiss a notification when the close button is clicked. Bug: b/79493568 Test: manual. Change-Id: I3a17690f9e8f6a3e4178239ff2787618f6500c36 Reviewed-on: https://chromium-review.googlesource.com/1132376Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#574812}
-
Luciano Pacheco authored
DirectoryItem created without a specific NavigationModelItem defaults to SubDirectoryItem. Change DirectoryItem to check if entry has a NavigationModelItem to generate the appropriate derived "item" type from DirectoryItem. In particular, crostini will generate FakeItem. This fixes issue where crostini wouldn't mount because the trigger to mount is on FakeItem. Change FakeItem to have updateSharedStatusIcon as no-op, since it doesn't have a shared state. This fixes an error where DirectoryItem calls updateSharedStatusIcon on its sub-items, before FakeItem was used only as top-level so nobody was calling updateSharedStatusIcon. Change DirectoryTree to call EntryList to update its sub-directories since those sub-directories are usually volumes that need to update themselves. Add test createFolderNestedDownloads to check that EntryListItem call to updateSubDirectories doesn't have to be recursive. Change SubDirectoryItem to add "volume-type-for-testing" in test to fix tests using this selector when running with My Files enabled if the item is a volume. Bug: 857335 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8a579b9c754143d9ba8322aba9014e82a3ac1757 Reviewed-on: https://chromium-review.googlesource.com/1133616 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574811}
-
James Darpinian authored
AMD's Linux driver crashes when calling glCopyTexImage2D with GL_PIXEL_UNPACK_BUFFER set to a buffer that hasn't been initialized yet. Bug: 859998, 850271 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I013892e39c02cfb3abc7079363ea4146915a2ac4 Reviewed-on: https://chromium-review.googlesource.com/1135848Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#574810}
-
Daniel Murphy authored
This allows the graceful downgrade of the session storage database from the new servicified database to the pre-servicification database. R=mek@chromium.org Bug: 859464,857464 Change-Id: I7049444a9c11b394c704b6a523c51c5b1ce47735 Reviewed-on: https://chromium-review.googlesource.com/1135894Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#574809}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc787be40f68..d464e6a80005 Created with: gclient setdep -r src-internal@d464e6a80005 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:857193 TBR=mmoss@chromium.org Change-Id: I19ceae1ab29c387475500c5269913be2f20633fe Reviewed-on: https://chromium-review.googlesource.com/1135620Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574808}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1617e69e3883..523c5e3122ed git log 1617e69e3883..523c5e3122ed --date=short --no-merges --format='%ad %ae %s' 2018-07-12 jmadill@chromium.org Vulkan: Suppress PointCoord test on Android. Created with: gclient setdep -r src/third_party/angle@523c5e3122ed The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I7c18581906dd8fec26de2735c6117d58ba3710c9 Reviewed-on: https://chromium-review.googlesource.com/1135221Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574807}
-
liberato@chromium.org authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I915cf5ef2ab6bd23ecbb8fdc31a818f3e4ddbcdc Reviewed-on: https://chromium-review.googlesource.com/1134436Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#574806}
-
edchin authored
Previously, the tab grid regular tabs panel was being obscured when the app is backgrounded. This is not correct behavior. This CL fixes the logic so that the app is only obscured when an incognito tab is shown (either in tab view or tab grid). Bug: 852353 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieb1355601515acd3869a03406b5d9d20ffb61ee3 Reviewed-on: https://chromium-review.googlesource.com/1131917 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574805}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html# testType=webkit_layout_tests& tests=fast%2Fevents%2Fwheel%2Fwheel-scroll-latching-on-scrollbar.html shows that this test mostly passes on ToT now. Bug: 526463 Change-Id: I1f8403bd36799e162dd090aece9f3662d0e0bd13 Reviewed-on: https://chromium-review.googlesource.com/1135431Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574804}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1133329 they are no-ops, so no behavior change. Parts of the CL generated by running git grep -l CORE_TEMPLATE_CLASS_EXPORT third_party/blink/renderer/ | xargs sed -i 's/CORE_TEMPLATE_CLASS_EXPORT//' Bug: 859989 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia398e2a4aa511d10577f5ab535c7f54bc3ac47c4 Reviewed-on: https://chromium-review.googlesource.com/1135293 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#574803}
-
Ned Nguyen authored
Bug: 771597 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I6c56cc352acf0b00bc526dd032d5f9af5bbc2cd2 Reviewed-on: https://chromium-review.googlesource.com/1135873Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#574802}
-
Khushal authored
R=asvitkine@chromium.org Bug: 863038 Change-Id: I520fac764e1cc1fda499a29a46aff3a663ad9ed1 Reviewed-on: https://chromium-review.googlesource.com/1135963 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#574801}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/ flakiness_dashboard.html#testType=webkit_layout_tests& tests=http/tests/origin_trials/sample-api-workers.html shows this has been passsing across all platforms for a long time. Bug: 711529 Change-Id: I7dc075e73c47c8f70347e8784aad563b01463118 Reviewed-on: https://chromium-review.googlesource.com/1135633Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574800}
-