GitLab

When a perf improvements for collapsing whitespace[1] landed,
following tests were adjusted to be 12x slower, to match to the test
without whitespace collapsing.

However, these tests then timeout on reference build.

This patch defers the adjust until the reference build is updated.

PerformanceTests/Layout/long-line-nowrap-collapse.html
PerformanceTests/Layout/long-line-nowrap-spans-collapse.html

[1] https://codereview.chromium.org/2285053002

BUG=642884

Review-Url: https://codereview.chromium.org/2323213002
Cr-Commit-Position: refs/heads/master@{#417557}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d961ec30c833..a2bac5f24b7e

$ git log d961ec30c..a2bac5f24 --date=short --no-merges --format='%ad %ae %s'
2016-09-09 petrcermak [tracing] Add <tr-v-ui-scalar-context-controller> element

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2324593006
Cr-Commit-Position: refs/heads/master@{#417556}

I think Node::shadowHost() is not a good name because it is unclear *which*
shadowHost would be returned by its name.

Node::ownerShadowHost() might be a better name than Node::shadowHost().
It is similar to Node::ownerDocument(), where it is clear that the owner would be
returned.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2327743002
Cr-Commit-Position: refs/heads/master@{#417555}

BUG=635846, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2323693002
Cr-Commit-Position: refs/heads/master@{#417554}

webrtc::RTCStats lives in the WebRTC repo and can't be directly
accessed from Blink. In content we implement blink::WebRTCStats and
friends to bridge this gap.

Work split up in smaller CLs. In a follow-up CL we will gather stats
in content's rtc_peer_connection_handler.cc using
webrtc::RTCStatsCollector and return the resulting stats to Blink
using [Web]RTCStats, this will include unittests.

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2319543002
Cr-Commit-Position: refs/heads/master@{#417553}

This patch adds support for enabling/disabling individual stories on individual
platforms using the same approaches as for benchmarks:

  1. Disabled/Enabled decorator:

     @decorators.Disabled('win')
     class Story(system_health_story.SystemHealthStory):
        ...

  2. ShouldDisable method:

     class Story(system_health_story.SystemHealthStory):
        ...

        @classmethod
        def ShouldDisable(cls, possible_browser):
          return possible_browser.platform.GetOSName() == 'win'

Note that this patch also enables search:portal:google on all desktop
platforms except for Windows.

BUG=634331
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2228103002
Cr-Commit-Position: refs/heads/master@{#417552}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d87b834b..9a9164a7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2328693003
Cr-Commit-Position: refs/heads/master@{#417551}

- Use EXPECT_.*() where possible instead of ASSERT_.*()
- Use the argument order of EXPECT_EQ(expected, actual)
- Remove unnecessary casts
- Replace EXPECT_EQ/NE(nullptr) with EXPECT_FALSE/TRUE()
- Replace EXPECT_STREQ() with EXPECT_EQ() using WTF::String comparison

BUG=none

Review-Url: https://codereview.chromium.org/2324103002
Cr-Commit-Position: refs/heads/master@{#417550}

In the current code, CPU adaptation does not work correctly. It should
scale to the adapted resolution, but it crops instead. The result looks
like zoomed in video. This bug was introduced in
https://codereview.chromium.org/2270723002/.

This CL fixes the cropping logic.

BUG=chromium:635592

Review-Url: https://codereview.chromium.org/2323573004
Cr-Commit-Position: refs/heads/master@{#417549}

This patch simplifies caret color calculation in |CaretBase::paintCaret()| by
using |LayoutObject::resolveColor()| for |CSSColorProperty| for specified
|Node| object rather than using parent element's layout object, since color
value for |Text| node and parent element are same.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2322193002
Cr-Commit-Position: refs/heads/master@{#417548}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/32bc6268f2a35e13241172d6ffcb221660853ef9 Cleanup unused recipe json. (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2321383002
Cr-Commit-Position: refs/heads/master@{#417547}

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Review-Url: https://codereview.chromium.org/2309403002
Cr-Original-Commit-Position: refs/heads/master@{#417452}
Cr-Commit-Position: refs/heads/master@{#417546}

To avoid circular dependency between NavigationController and
NavigationEntry, move RestoreType and ReloadType into a separate file.

This is a refactoring sub-change from crrev.com/2174293002.

BUG=612701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=sky@chromium.org, torne@chromium.org

Review-Url: https://codereview.chromium.org/2225343002
Cr-Commit-Position: refs/heads/master@{#417545}

Attempt to chase non-repoducible bug. CL crrev.com/2239383002 has
changed a command line for protoc and there are rare occasional
crashes on Win32. It could be because of some bug in protoc's parser.
This change restores a command line like before the suspecting CL
only for the most common case with only one proto file in a library.

BUG=644525

Review-Url: https://codereview.chromium.org/2324823002
Cr-Commit-Position: refs/heads/master@{#417544}

The fact that they are marked with childrenInline() doesn't matter if they have
no children.

BUG=635619

Review-Url: https://codereview.chromium.org/2320393002
Cr-Commit-Position: refs/heads/master@{#417543}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f chromium_tests: add an option to disable deapplying patch on some trybots (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=633617

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2325083002
Cr-Commit-Position: refs/heads/master@{#417542}

This patch contains implementations of SensorPollingStrategy interface, defining when sensor reading is updated from shared buffer.

Also it contains logic for Suspend/Resume mojo API calls based on the page visibility. For this purpose 'SensorProxy' inherits 'PageVisibilityObserver'.

Specification: https://w3c.github.io/sensors

BUG=606766

Review-Url: https://codereview.chromium.org/2323683002
Cr-Commit-Position: refs/heads/master@{#417541}

Added ASSERT_SIZE macro for checking size of size-sensitive classes,
which can be used with the SameSizeAs structs to give better compile
errors with both the expected and actual size values. Also added the
assert to the check for SameSizeAsCSSValue.

Patch written with help by timloh@.

BUG=486252

Review-Url: https://codereview.chromium.org/2231953003
Cr-Commit-Position: refs/heads/master@{#417540}

Before this CL, the fade-in transition would trigger inconsistently, maybe in 1 out of 10 cases. Now it triggers consistently, only when the tiles change, but not when the first set of tiles is shown.

BUG=645158
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2316423003
Cr-Commit-Position: refs/heads/master@{#417539}

Move collectGarbage* methods to ThreadState to indicate that these run GC for the current thread heap.

BUG=

Committed: https://crrev.com/89d83a49a6c126d91e25e2d3520cb398e8e1f7d5
Review-Url: https://codereview.chromium.org/2307003002
Cr-Original-Commit-Position: refs/heads/master@{#417269}
Cr-Commit-Position: refs/heads/master@{#417538}

Add two functions to enterprise_reporting.mojom without implementation
to unblock Android-side development. Chrome side implementation is blocked
on crbug.com/639372.

BUG=b/31084348

Review-Url: https://codereview.chromium.org/2312873002
Cr-Commit-Position: refs/heads/master@{#417537}

Now retrieving driver information with PnP Configuration Manager, which is much
faster than using Setup API.
With the new approach we are now able to fetch information from the actual
device driver, instead of the software interface on top which seems to be always
provided by Microsoft.

BUG=512433,642604
R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2318953002
Cr-Commit-Position: refs/heads/master@{#417536}

BUG=641995

Review-Url: https://codereview.chromium.org/2313523002
Cr-Commit-Position: refs/heads/master@{#417535}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff Remove old dartium_factory builders, clean up slaves.cfg files. (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319223005
Cr-Commit-Position: refs/heads/master@{#417534}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=mmenke@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2319513003
Cr-Commit-Position: refs/heads/master@{#417533}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259823002
Cr-Commit-Position: refs/heads/master@{#417532}

This is a preparation to erase animations_ data stored in ElementAnimation.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2322693003
Cr-Commit-Position: refs/heads/master@{#417531}

This removes maxEffectRect(), determineMaximumEffectRect() and the
associated state (m_maxEffectRect) from FilterEffect. The replacement is
the new method absoluteBounds() that computes bounds for the node in
question using the filter primitive (sub)region and the filter region.
This should match what determineMaximumEffectRect() was computing for
use from SVGFilterPainter.

BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2319293004
Cr-Commit-Position: refs/heads/master@{#417530}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9202514fa25ad6f5c113e9f111c6af35254d5b5e Allow more max fail fallback tasks in perf builder (shinyak@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=606987

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2323233002
Cr-Commit-Position: refs/heads/master@{#417529}

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2313353003
Cr-Commit-Position: refs/heads/master@{#417528}

This replaces key_exchange_info with key_exchange_group at all layers
but net::SSLInfo, fixing key_exchange_info's type issues. Then we route
it over to DevTools as an optional new field "Key Exchange Group".

Later work, once the TLS 1.3 draft 15 negotiation is implemented, will
make the DevTools able to handle missing key_exchange. In 1.3, what
DevTools currently calls a "Key Exchange" isn't really meaningful and
is just described by the group. (https://crbug.com/639495)

Screenshots:
https://drive.google.com/folderview?id=0Bz14lOW5Hke4VFlBVXJOY0Z0cUU&usp=sharing

(Note: the TLS 1.3 picture is a mock of how it will look when the
new cipher suite negotiation is implemented and a second change made.)

BUG=639421,618035

Review-Url: https://codereview.chromium.org/2272603003
Cr-Commit-Position: refs/heads/master@{#417527}

R=rjkroege@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2317913003
Cr-Commit-Position: refs/heads/master@{#417526}

TBR=haraken@chromium.org,oilpan-reviews@chromium.org
BUG=645253

Review-Url: https://codereview.chromium.org/2322123003
Cr-Commit-Position: refs/heads/master@{#417525}

BUG=644510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2326773002
Cr-Commit-Position: refs/heads/master@{#417524}

Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7 id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it works with a headset connected with 3.5 mm connectors, and with a USB headset. Another nice thing with  his approach is that we should be able to easily find if a webcam has a built-in mic, since in this case the webcam and mic will typically be connected via the same USB port.
>
> BUG=636300
>
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300

Review-Url: https://codereview.chromium.org/2322083003
Cr-Commit-Position: refs/heads/master@{#417523}

Add a CHECK() to crash the browser if a destruction order problem is
encountered.

This will be reverted once the information is collected.

BUG=641013

Review-Url: https://codereview.chromium.org/2315213002
Cr-Commit-Position: refs/heads/master@{#417522}

This patch moves |m_caretVisibility| from |CaretBase| class to |FrameCaret|
since |m_caretVisibility| is used only in |FramreCaret| class for improving code
health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2325933002
Cr-Commit-Position: refs/heads/master@{#417521}

Previously we invalidate paint (which will also cause raster invalidation)
of the subtree if z-index, transform changed on an object which will not
be composited. This requires logic to precisely predict compositing status
which is fragile and causes unnecessary paint invalidations.

We don't need to invalidate paint of object which just changes z-index,
transform etc. We can invalidate raster if needed after painting.

If a cached display item is moved out of the original chunk, invalidate
raster for it on both the old chunk and the new chunk.

If a cached display item is moved within the chunk behind any other
cached display item, invalidate raster for it.

Otherwise we don't invalidate raster.

BUG=526191
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2307623002
Cr-Commit-Position: refs/heads/master@{#417520}

BUG=627008
TBR=jsbell

Review-Url: https://codereview.chromium.org/2320963003
Cr-Commit-Position: refs/heads/master@{#417519}

There is still only a single Blimp tab, and the logic is for now very
simple: If there is already a blimp tab available, a new tab will be
WebContents based. If there are no blimp tabs, a blimp-based tab will
be created.

Also, when tabs are closed, it takes a while before the tab is really
destroyed, in case the user wants to undo the action. This feature
stays, but if the user selects "New Tab" or clicks the new tab button,
all the pending closures are first committed, ensuring that the tab
to be created might become a blimp tab, even if the current blimp tab
was pending closure.

Before this CL, the value 0 was always used fro the tab ID. This meant
that there would be a mixup between tabs that are closed and new tabs
that are created. This CL changes this so that each BlimpContentsImpl
gets its own unique ID, created client-side, and transferred to the
engine to be used for all communication regarding that tab, by an
update to the TabControlFeature to now include the ID.

The NavigationFeature is also updated to support receiving messages
after BlimpContentsImpl has been destroyed, which may happen, and
it now just logs those errors.

To ensure that this is visible in the tab switcher as well, a
workaround is added to ensure that the theme color is always shown,
even when on the new tab page. This is important in case where there
are many new tab pages, and one can not see which one is the blimp
tab, since the theme color is only updated when the tab navigates
away from the NTP.

To support the multiple IDs on the engine side, the Tab class is now
the implementor of the
EngineRenderWidgetFeature::RenderWidgetMessageDelegate instead of the
BlimpEngineSession. IME and compositor protos use the ID of the current
tab for their messages.

BUG=644467, 644774

Review-Url: https://codereview.chromium.org/2325893002
Cr-Commit-Position: refs/heads/master@{#417518}