GitLab

GAIA auth extension use special manifest file for Hotrod Enrollment case.
This manifest also needs incognito:split to work on login screen.

BUG=453448
TEST=manual

Review URL: https://codereview.chromium.org/900473007

Cr-Commit-Position: refs/heads/master@{#314539}

Previously, ListThumbnailLoader preloaded images at the top of list when it preloaded to the end of list. However, especially high priority range is at the end of list, the benefit of preloading top images is small.

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/877513003

Cr-Commit-Position: refs/heads/master@{#314538}

Revert of Start moving ownership of SyncNotificationController to SyncController. (patchset #3 id:40001 of https://codereview.chromium.org/889723002/)

Reason for revert:
Broke downstream builds

Original issue's description:
> Start moving ownership of SyncNotificationController to SyncController.
>
> GoogleServicesNotificationController is modified to work
> the way most other singleton classes work, so that it is
> not necessary to pass into the SyncNotificationController
> constructor (and thus, into SyncController in the future).
>
> SyncController gets a temporary setter method so that SNC
> can be constructed downstream and passed in until all its
> dependencies are upstream.
>
> BUG=428882
>
> Committed: https://crrev.com/deaa0fe6ca3e0428a85fc22b019819437d84120b
> Cr-Commit-Position: refs/heads/master@{#314515}

TBR=nyquist@chromium.org,maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428882

Review URL: https://codereview.chromium.org/895373002

Cr-Commit-Position: refs/heads/master@{#314537}

All arm platforms support V4L2 SVDA by default and use_v4l2_codec also governs V4L2 VDA/VEA now.
Generates libv4l2 stub in GN file.

BUG=449883
TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks,
and panther_freon

Review URL: https://codereview.chromium.org/828063009

Cr-Commit-Position: refs/heads/master@{#314536}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2340dcb..d3780c5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/893403002

Cr-Commit-Position: refs/heads/master@{#314535}

BUG=454457

Review URL: https://codereview.chromium.org/896823002

Cr-Commit-Position: refs/heads/master@{#314534}

This CL generalizes upload_network_service.py to support uploading other
services (currently, html_viewer). html_viewer.mojo is not zipped before being
uploaded so that it can be accessed dynamically by mojo_shell.

Review URL: https://codereview.chromium.org/879233006

Cr-Commit-Position: refs/heads/master@{#314533}

Before: while UserManager and UserManagerBase were componentized to user_manager namespace, FakeUserManager was staying at chromeos namespace.

After: UserManager Chrome OS-related interface moved to a separate class ChromeUserManagerInterface. Mixing it to UserManagerBase and FakeUserManager we're getting chrome OS versions of them. That allows us to move UserManagerBase and FakeUserManager into component user_manager.

Main changes are located at .*user_manager.* files. Such as chrome_user_manager, chrome_user_manager_interface, fake_chrome_user_manager, user_manager_base etc.
Other files (mostly tests) were changed due to changes in include paths and FakeUserManager class renaming.

BUG=443119

Review URL: https://codereview.chromium.org/824683002

Cr-Commit-Position: refs/heads/master@{#314532}

Previously the test does not wait dialog hiding unintentinally.

BUG=452723
TEST=DefaultActionDialog/FileManagerBrowserTest

Review URL: https://codereview.chromium.org/897863002

Cr-Commit-Position: refs/heads/master@{#314531}

This test calls chdir() which corrupts subsequent tests like
NamespaceSandboxTest.

TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/902533002

Cr-Commit-Position: refs/heads/master@{#314530}

This CL has some minor clean up.
- In IsFileSystemAccessDenied, now we check "/" instead of "/proc/self/exe".
- Remove SetuidSandboxClient::CreateInitProcessReaper.
  Now contents uses sandbox::CreateInitProcessReaper directly
  and noone uses the method.
- Clean up include directives in the header.
This is also the preparation of enabling Layer-one sandbox
(suid sandbox) on nacl_helper_nonsfi.

TEST=Ran trybots.
BUG=455087

Review URL: https://codereview.chromium.org/885673007

Cr-Commit-Position: refs/heads/master@{#314529}

New icons used for indication of kids accounts on sign-in screen. Icons for supervised accounts returned.

BUG=450795

Review URL: https://codereview.chromium.org/899663003

Cr-Commit-Position: refs/heads/master@{#314528}

Revert of Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #1 id:1 of https://codereview.chromium.org/892373006/)

Reason for revert:
The code in this change is not linked into any binary.

Test is flaky:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=device_unittests&tests=SerialConnectionTest.Cancel

The likely cause of the test failure is https://chromium.googlesource.com/chromium/src/+/bc78a2320b50eba4fe397f1f838a82ad30b16cd6. The author has been informed and the test will be fixed soon.

Original issue's description:
> Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #4 id:60001 of https://codereview.chromium.org/900433003/)
>
> Reason for revert:
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575
> Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems.
>
> Original issue's description:
> > Add Mojo interfaces for out-of-process proxy resolver.
> >
> > See:
> > https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit#
> >
> > BUG=11746
> >
> > Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561
> > Cr-Commit-Position: refs/heads/master@{#314509}
>
> TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,amistry@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=11746
>
> Committed: https://crrev.com/7d4ec1aa24e79406d29e0cafbb531a3fabfe815f
> Cr-Commit-Position: refs/heads/master@{#314519}

TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,noel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=11746

Review URL: https://codereview.chromium.org/882173005

Cr-Commit-Position: refs/heads/master@{#314527}

BUG=405700

Review URL: https://codereview.chromium.org/887393002

Cr-Commit-Position: refs/heads/master@{#314526}

loadAsDataUrl loads thumbnail as data url instead of attaching it to a box. While loadAsDataUrl does not fit image to the box, it returns dataUrl of thumbnail which transform is applied when it is necessary.

BUG=438050
TEST=out/Release --gtest_filter=FileManagerJsTest.ThumbnailLoader

Review URL: https://codereview.chromium.org/902513002

Cr-Commit-Position: refs/heads/master@{#314525}

Revert of Remove Client= from device/serial/data_stream.mojom. (patchset #1 id:20001 of https://codereview.chromium.org/889283002/)

Reason for revert:
Switching to two pipes broke FIFO assumption, causing DataSinkTest.CancelDuringError and SerialConnectionTest.Cancel to become flaky

Original issue's description:
> Remove Client= from device/serial/data_stream.mojom.
>
> BUG=451321
>
> Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6
> Cr-Commit-Position: refs/heads/master@{#314231}

TBR=rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451321

Review URL: https://codereview.chromium.org/873293006

Cr-Commit-Position: refs/heads/master@{#314524}

This CL fixes an issue where a speech query in the app list, that was
interrupted by the app list closing, would complete when the app list
was reopened.

BUG=440061

Review URL: https://codereview.chromium.org/886353004

Cr-Commit-Position: refs/heads/master@{#314523}

We are going to remove Timeline domain from the remote debugging protocol soon. This CL fixes remaining usages of timeline commands.

BUG=448318

Review URL: https://codereview.chromium.org/895043002

Cr-Commit-Position: refs/heads/master@{#314522}

Cr-Commit-Position: refs/heads/master@{#314521}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fe3f260..2340dcb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/896123002

Cr-Commit-Position: refs/heads/master@{#314520}

Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #4 id:60001 of https://codereview.chromium.org/900433003/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575
Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems.

Original issue's description:
> Add Mojo interfaces for out-of-process proxy resolver.
>
> See:
> https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit#
>
> BUG=11746
>
> Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561
> Cr-Commit-Position: refs/heads/master@{#314509}

TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,amistry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=11746

Review URL: https://codereview.chromium.org/892373006

Cr-Commit-Position: refs/heads/master@{#314519}

BUG=454995

Review URL: https://codereview.chromium.org/895233002

Cr-Commit-Position: refs/heads/master@{#314518}

If <webview> attempts to navigate to a URL that is invalid or it cannot
access, it will fire a loadabort message. However, a loadstop will not fire
and <webview> may remain in an unnavigated state despite having a set src
attribute. This causes various APIs such as executeScript to fail.

This CL navigates <webview> to about:blank in the case of a bad navigation.
This puts <webview> back to a sane state.

BUG=450125

Review URL: https://codereview.chromium.org/888563003

Cr-Commit-Position: refs/heads/master@{#314517}

BUG=429391

Review URL: https://codereview.chromium.org/891953003

Cr-Commit-Position: refs/heads/master@{#314516}

GoogleServicesNotificationController is modified to work
the way most other singleton classes work, so that it is
not necessary to pass into the SyncNotificationController
constructor (and thus, into SyncController in the future).

SyncController gets a temporary setter method so that SNC
can be constructed downstream and passed in until all its
dependencies are upstream.

BUG=428882

Review URL: https://codereview.chromium.org/889723002

Cr-Commit-Position: refs/heads/master@{#314515}

The claiming registration will fetch all registrations from
DB and comparing them with existing provider hosts. If it
has the longest match, it will start controlling the
provider host.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-claim

(1/3): https://codereview.chromium.org/868463004/
(2/3): This
(3/3): https://codereview.chromium.org/872593002/

BUG=450106
TEST=https://codereview.chromium.org/872593002/

Review URL: https://codereview.chromium.org/871853002

Cr-Commit-Position: refs/heads/master@{#314514}

IDC_CONTENT_CONTEXT_SAVEAVAS case added for giving accelerator key.

BUG=449029

Review URL: https://codereview.chromium.org/825873003

Cr-Commit-Position: refs/heads/master@{#314513}

It provides metadata obtained from the content in SharedWorker.

BUG=410766
TEST=FileManagerJsTest.ContentMetadataProvider

Review URL: https://codereview.chromium.org/894883003

Cr-Commit-Position: refs/heads/master@{#314512}

This CL adds a shadow border to the experimental app list's search box
view. Several changes were necessary to make this happen.

- The search box's actual content is now inside a container view so that
the shadow border will paint in the correct order.
- A custom event targeter has been placed on the search box widget to
allow clicks on the shadow area to pass through to the content beneath.
- The search box widget's position has to account for the extra space
due to the shadow border. The search box is still manipulated in terms
of its main content area and the border offsets are calculated and
applied when the widget's bounds are set.

BUG=453653

Review URL: https://codereview.chromium.org/894203004

Cr-Commit-Position: refs/heads/master@{#314511}

Previously the test waits for destruction of render view host to check if the
dialog has been closed or not. But test log shows there is a race and we cannot
ensure the extension dialog has been closed even if its render view host is
closed.

The CL let the test wait for SelectionFileDialog::Listener's call instead, where
we can ensure the dialog has been closed.

BUG=453613
TEST=SelectFileDialogExtensionBrowserTest.SelectFileAndCancel

Review URL: https://codereview.chromium.org/902493002

Cr-Commit-Position: refs/heads/master@{#314510}

See:
https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit#

BUG=11746

Review URL: https://codereview.chromium.org/900433003

Cr-Commit-Position: refs/heads/master@{#314509}

It provides metadata from fileManagerPrivate.getEntriesProperty.

BUG=453242
TEST=FileManagerJsTest.ExternalMetadataProvider

Review URL: https://codereview.chromium.org/895873002

Cr-Commit-Position: refs/heads/master@{#314508}

In the dialog footer, we have a combobox to select a file type. Previously we
have 'any file type' at the top of the list and it is selected by default.

The CL moves it to the end of the list so that the first type is selected by
default.

BUG=454418
TEST=None

Review URL: https://codereview.chromium.org/898853002

Cr-Commit-Position: refs/heads/master@{#314507}

Instead of using the id of the worker-thread to keep track of the thread to
run the fileapi callbacks on, use the task-runner of the thread instead.

BUG=none
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/893233002

Cr-Commit-Position: refs/heads/master@{#314506}

Add multiple device/os filtering and a config file.

BUG=

Review URL: https://codereview.chromium.org/891423002

Cr-Commit-Position: refs/heads/master@{#314505}

This CL makes the app list start page doodle clickable by implementing
the necessary methods on the StartPageWebContentsDelegate and adding
the appropriate JS in the start page WebUI.

BUG=453205

Review URL: https://codereview.chromium.org/887853003

Cr-Commit-Position: refs/heads/master@{#314504}

SyncFileSystem stuff hits DCHECK or NOTREACHED on shutdown phase. That
is due to failing PostTask() SequencedWorkerPool.
This CL relaxes several assertions in the case.

* Disable TaskToken tracking if SequencedWorkerPool is being shut down.
* Leak SyncWorker if SequencedWorkerPool is being shut down, instead of
  deleting it in the other thread.

BUG=453226

Review URL: https://codereview.chromium.org/881203003

Cr-Commit-Position: refs/heads/master@{#314503}

The colour produced when highlighting the filename or the page number is a rather jarring orange.
Now it is a lighter shade of blue.

BUG=110020

Review URL: https://codereview.chromium.org/872963006

Cr-Commit-Position: refs/heads/master@{#314502}

The X specification allows the OS to grab the mouse when a mouse button is
pressed. The OS grab was causing XGrabPointer() in
DesktopWindowTreeHostX11::SetCapture() to fail.

BUG=426380
TEST=Manual

Review URL: https://codereview.chromium.org/749063003

Cr-Commit-Position: refs/heads/master@{#314501}

TBR=sammc@chromium.org, hansmuller@chromium.org
BUG=431213
NOTRY=true

Review URL: https://codereview.chromium.org/891463005

Cr-Commit-Position: refs/heads/master@{#314500}