- 13 Oct, 2020 40 commits
-
-
Samuel Huang authored
This reverts commit 3b99bb24. Reason for revert: Suspected of causing TraceEventDataSourceTest.StartupTracingTimeout failure in services_unittests on Builder Linux CFI. Original change's description: > Reland "[tracing] Remove special handling of task execution and log events" > > This reverts commit 989724c3. > > Reason for revert: > Fixing test failures. The msan failures were due to hash operator trying > to hash uninitialized padded bytes of the struct. Fix the struct to not > have any padding. > > Original change's description: > > Revert "[tracing] Remove special handling of task execution and log events" > > > > This reverts commit f79b1513. > > > > Reason for revert: Breaks WebKit Linux MSAN > > > > The following tests started failing since this landed: > > > > * http/tests/devtools/tracing.js > > * http/tests/devtools/tracing/decode-resize.js > > * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js > > * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js > > * http/tests/devtools/tracing/tracing-record-input-events.js > > * http/tests/devtools/tracing/user-timing.js > > * http/tests/devtools/tracing/worker-events.js > > * http/tests/devtools/tracing/worker-js-frames.js > > * inspector-protocol/sessions/tracing-start.js > > * inspector-protocol/timeline/tracing-proto-format.js > > > > First run that failed, also the run where the CL landed: > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830 > > > > Original change's description: > > > [tracing] Remove special handling of task execution and log events > > > > > > The task execution and log events are handled specially for writing > > > proto arguments because we did not have the support for typed events in > > > base and interning support for the event macros. Now these events can > > > use the new client library API. > > > The events have to be migrated together because the source location > > > interning index is common for all events in the API and does not > > > account for the special handling in event sink. > > > > > > BUG=1136635 > > > TBR=chirantan@chromium.org > > > > > > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636 > > > Reviewed-by: ssid <ssid@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Reviewed-by: danakj <danakj@chromium.org> > > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > > Commit-Queue: ssid <ssid@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#815911} > > > > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1136635 > > Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816069} > > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1136635 > Change-Id: Ia659185ebeb265dc47ff6c2ef47bd9d8cc43dd65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466507 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816620} TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org Change-Id: Ib19224f57b12b423dfbf40f51ebfcc946be061ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468503Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#816764}
-
Dave Tapuska authored
The frame could be null, ensure if it is we return early. BUG=1130991 Change-Id: I8ced1223f4beb281adcb06c99d9b0fc4b761333e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468237Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#816763}
-
Siyu An authored
AutofillEnableStickyBubbleAndUpdatedLogging" Change was reverted in crrev.com/c/2438609. Reason was that for upload save card bubble we need to explicitly enable flag features::kAutofillUpstream. Bug: 1070799 Change-Id: Ib2d2cb35306b2d855a6223942249b3d7a4f4b5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464203 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#816762}
-
Wenbin Zhang authored
Removing ANGLE test from WIN 7 test builder. Bug: chromium:1137628 Change-Id: Ib234e8351716b77261bf9a4efb4ab9804f0424f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466621Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#816761}
-
Vadim Shtayura authored
The 5% experiment appears to be fine (based on server logs). R=gbeaty@chromium.org BUG=1136313 Change-Id: I716c2e9554eef0f9ee8d6b20fcea95dcc9a0bba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468793Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816760}
-
Nico Weber authored
A follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2467360 android-official is no longer timing out with that change ( https://ci.chromium.org/p/chromium/builders/ci/android-official/2242 https://ci.chromium.org/p/chromium/builders/ci/android-official/2243 ), but builds are still much slower than before. Try doubling number of tasks and see what that does. I suppose the thinlto cache means that concurrent links save some time for each other -- even if the cpus are oversubscribed, every running link can do work that the other links do. The CrOS ebuild set link parallelism to 1, so explicitly do this if goma lto is on, so that we don't increase the load on goma from lto tasks. Bug: 1132930,1137812 Change-Id: If2b451fa3dc69f7ecde05e581ddb46addc901118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468740 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816759}
-
Toby Huang authored
Sometimes ProvideCurrentSessionData() gets called at a bad time when the user has finished logging in but the user profile has not finished loading. This scenario causes a DCHECK failure. This CL returns prematurely if the user profile has not finished loading, and retrieves the primary profile manually. Bug: 1136561 Change-Id: Ibd4845b92c3284bd856f0a152618bb7abe5c44bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462632Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#816758}
-
Charlene Yan authored
Bug: 1116118 Change-Id: I64a0743be4a37f72eeec24ad29ac3fa65948b22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466208Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816757}
-
Dave Tapuska authored
Create a SimTest that initializes the MainFrame as a remote and port the test over so that it is inside blink. Delete render_widget_unittest.cc since no tests exist anymore in there. BUG=1097816 Change-Id: I1268d1045a246d7756a3ba34f508963031feb997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462221 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816756}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602590170-73bf0c77e912d9411bc2ad0c01b4d803226ee02b.profdata to chrome-mac-master-1602611974-a7265b2715cbc4cd86dbab6cb07ce46a3b6949bc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2169627879cc85c178ba6a36196c1b0aee00e2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816755}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602536311-64e797cbe41fbbe11cccf8259e756a8b7f11c663.profdata to chrome-win64-master-1602590170-40f871c7cd5f95ac04c91a2fc42fd5651e0714b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I13183e334001dc65e2aab7d70797739c5050c4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466725Reviewed-by:
-
Dave Tapuska authored
The WebFrameWidget can be retrieved via the WebView. Move one test that was accessing the LayerTreeHost to blink. BUG=1097816 Change-Id: I373d6ed7ff97a3669a7d303b86944c001f5e9eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464027 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816753}
-
danakj authored
R=nasko@chromium.org Bug: 1125106 Change-Id: If05f064715add137e16118a08da153d1d5ed0e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465809Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816752}
-
Joel Hockey authored
Files in the local downloads volume are moved to .Trash rather than being deleted. These files can be viewed in FilesApp by selecting 'Show hidden files (Ctrl+.)'. Some updates in mock_entry for functions needed in unit tests. Bug: 953310 Change-Id: Ia583439339ad359d4646a374bbf02f7e1fd29a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461427 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816751}
-
Xianzhu Wang authored
With unified PaintController, the single PaintController will include display items and paint chunks from visual viewport, overlays, etc. which are not interesting to most unit tests. Add ContentDisplayItems() and ContentPaintChunks() to exclude them. Also make CAP and pre-CAP consistent about viewport scroll layer. Previously CAP didn't output viewport scroll layer to avoid change of unit tests. Bug: 1132717 Change-Id: I45c441bbd349ca97a7082dc348bcf963b1af7fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464950Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816750}
-
Dale Curtis authored
Since default device is always matched as an empty string, we would sometimes reconnect to a stream which was configured for the wrong device. R=guidou Bug: 1091894 Change-Id: Ia3a33d8f91d984de5ceffbcbb4ddd96efed355e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468302 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#816749}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602590170-c380e8ad768b677fecdbe9d455856c6615b604e4.profdata to chrome-linux-master-1602611974-f7262751d1dc906200528d84bf62f89d4908c5e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I769dd9262827350671550955cca8e9210dbda5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468310Reviewed-by:
-
Garrett Beaty authored
In order to limit the introduction of issues when creating new milestone buckets or making modifications in the presence of milestone buckets, the creation of the buckets and setting module level defaults was abstracted into functions so that files could be copied to the new milestone directory and only having to add a milestone vars file. With the removal of milestone buckets, these functions only introduce an unnecessary level of indirection. Change-Id: Iececeb1a9e122f2f8e862697d453ee731ffdeb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467547Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#816747}
-
Adam Langley authored
When WebSocket connections pass through our frontend infrastructure their frames can be fragmented, causing clients to see continuation frames. Just accept these as data frames; we already handle the |final| flag so defragmentation already works. BUG=1002262 Change-Id: I17bea4ddc0a3cd07c558b3d1ca686b449bb9a3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463809 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#816746}
-
David Trainor authored
1. Add the ability for clients to specify a string to announce when users cluck on an action in a snackbar view. 2. Add Downloads Home download deletion / undo as the first client. Skip-Translation-Screenshots-Check: True Bug: 1090969 Change-Id: I97fb23a471542bbaa141ea0696e7ac3d60269e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431455 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816745}
-
Eric Orth authored
Just the parameter and the logic to set it properly for now (and the MockDnsTransaction support used to test that HostResolverManager is properly setting the param). Logic to implement for real TODO for next CL. Also some minor comment cleanups that were intended for crrev.com/c/2446526, but I missed. Bug: 1109792 Change-Id: I6a5baeff51852d9a92c65f7d594d35c8d4cbd0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450732Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#816744}
-
Alexander Surkov authored
properties Extend the properties call format to allow to indicate an object the property should be called for. For example, :1.AXDOMIdentifier to call AXDOMIdentifier property on an object placed on the first line of a generated tree. Bug: 1136957 Change-Id: Icf9c1467ed9c97d632a3dbcc80af6d1817d9e466 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462839 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816743}
-
Olga Sharonova authored
Bug: 1132225 Change-Id: I48fbea94bcaf267e778fc787729ed5b3e20d73c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468096 Auto-Submit: Olga Sharonova <olka@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#816742}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602536311-b12e3fd5e65df9379666839aba71278f41868f97.profdata to chrome-win32-master-1602567235-326c7abc194f22112a72664d7e7a2c66cfd57197.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3675a28b886f348d54fec9d35b0e9ed571400a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467540Reviewed-by:
-
Klaus Weidner authored
Add a new DISABLED_BY_DEFAULT trace category "xr.debug", and use that for some timing traces that are useful when debugging scheduling issues but a bit verbose otherwise. Change-Id: Id72c0b6c8f7a7fab2e7428adcffa095915a61f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468277 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#816740}
-
Nicolás Peña Moreno authored
This CL adds Q3 progress as well as Q4 objectives for 2020. Change-Id: If63b62e91685d8139ea72231a9f58867b272cf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461803 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816739}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c89a7ee628db..01b93eabe25b 2020-10-13 michaelludwig@google.com Add SkImageFilters::Blend rename for Xfermode filter 2020-10-13 brianosman@google.com Remove two uses of setModifiersHandle 2020-10-13 adlai@google.com Migrate flush & misc methods to GrDirectContext 2020-10-13 ethannicholas@google.com moved SkSL Section data into IRNode 2020-10-13 johnstiles@google.com Improve performance of determineFinalTypes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I60bd9a5368071a3e521ff8ff49562470174d8d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466928Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/320cf8513172..0ca259e28639 2020-10-13 tvanderlippe@chromium.org Typecheck extensions/ExtensionView.js with TypeScript 2020-10-13 sigurds@chromium.org [ts] Type-check console/ConsoleViewMessage.js with TypeScript 2020-10-13 tvanderlippe@chromium.org Typecheck extensions/ExtensionTraceProvider.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9fc394eaf51717487f8cd2064b277436cb605553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468280Reviewed-by:
-
Collin Baker authored
Adds support for keyboard accelerators to the FeaturePromoController + FeaturePromoRegistry system. ui::Accelerators can't be used directly since they are fetched from BrowserView. Instead, IPHs specify the command ID and the correct accelerator is retrieved at runtime. Bug: 11333016 Change-Id: I69420c3e1d753df7d67933f9a00c479b39ee963b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468957 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816736}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I508a2d22b7bcd39be8dca7779bf760c9929d4d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468677Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#816735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0568abaca2d..81325a08e059 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC marshallk@google.com,huangs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1081791,chromium:1137752 Tbr: marshallk@google.com,huangs@google.com Change-Id: I3d323e5cafe49c202cd9512c16ed9128b95e0214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468258Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816734}
-
Jeffrey Young authored
After 3 consecutive failures to load an image, notify observers of failure. BUG=b:169591750 TEST=ash_unittests --gtest_filter=AmbientBackendModelTest* Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I7a9302e65fc58d3272a0da31f13c6a44efe1cc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449937 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#816733}
-
spdonghao authored
#testSetIncognitoDescriptionVisibilityAndClickListener on L. Bug: 1135286 Change-Id: Ie487c5f8b6f311668872b3761717f05e4da6f467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451576Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#816732}
-
Amanda Baker authored
This change adds a new display mode, "window-controls-overlay" which is only valid when used as a display_override. The majority of the changes fix build breaks caused by the new display mode. Testing: - Verify that window-controls-overlay is NOT a valid "display" mode: https://amandabaker.github.io/pwa/displayWCO-notInstallable/index.html should NOT be installable - Verify that window-controls-overlay is NOT a valid "display_override" when the WCO runtime flag is disabled. Launch with: `chrome.exe --enable-features=WebAppManifestDisplayOverride` and https://amandabaker.github.io/pwa/windowControlsOverlay/index.html SHOULD be installable - Verify that window-controls-overlay IS a valid "display_override" when the WCO runtime flag is enabled. Launch with: `chrome.exe --enable-features=WebAppManifestDisplayOverride --enable-blink-features=WebAppWindowControlsOverlay` and https://amandabaker.github.io/pwa/windowControlsOverlay/index.html should NOT be installable Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ Bug: 937121 Change-Id: Id1144d323b6c9af4bb49fa0669583177b4cdd77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375597Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Amanda Baker <ambake@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816731}
-
Caitlin Fischer authored
Bug: 1094303 Change-Id: I7471695cb8b1248fe0d3005635ed7310a9ac8296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462247 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
Pete Williamson authored
It is no longer required now that we have concluded the experiment. We are also enabling the feature unconditionally in this change. The build flag was introduced by the following change: https://chromium-review.googlesource.com/c/chromium/src/+/1994668 The current change is undoing everything the change above did. Bug: 1137561 Change-Id: I96aee0778c224fd81be70a011ff27be0f2310314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466355Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#816729}
-
Patrick Monette authored
This CLs plumbs the viewport intersection to the FrameNode, which will allow the tracking of the visibility of each frame. Bug: 1077217 Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#816728}
-
Zach Trudo authored
Previously the Event message for MEET_DEVICE_TELEMETRY was not formed correctly. This CL forms it correctly and adds some comments to make it easier to understand. Bug: chromium:1078512 b:169427520 Change-Id: Ic6af71cebaf15c37f43dea54f9b4eff9d6ba1e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468836 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816727}
-
James Vecore authored
Nearby Share requires using the scan response in BLE advertising due to the size of the data required. Previously using the scan response was not possible in ChromeOS. These changes added some limited and temporary support for a new d-bus property to specify the scan response data: https://crrev.com/c/2458306 https://crrev.com/c/2459250. This CL changes the adapter mojom interface to allow specifying that the service data should be added the scan response and not the original advertisement data when registering an advertisement. Due to the limited and temporary Platform support (AD type 0x16 only), we kept the api change as simple as possible. This change will likely be reverted or modified depending on the shape of the final scan response API in upstream bluez. Tracking that here: https://crbug.com/1136920 Bug: 1135699 Change-Id: I0513197efb1ab62cb75a2151fc738b89b5e9ec67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465132Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#816726}
-
Peter Kasting authored
Bug: none Change-Id: I970d78bdcece269f0d62895df79b7455399676a2 Tbr: rdevlin.cronin Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468700Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#816725}
-
