- 01 Feb, 2019 40 commits
-
-
Maksim Moskvitin authored
The READING_LIST type is registered only on iOS, while the APPS type is never registered on iOS. This means that storing READING_LIST in the APPS prefs group does nothing. Bug: 906611 Change-Id: I423b87f466605b39b7893cfe0549ee2fe01f42ba Reviewed-on: https://chromium-review.googlesource.com/c/1448168Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#628286}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibc6b7c034df895e8dffb6c485967148f164ffe14 Reviewed-on: https://chromium-review.googlesource.com/c/1449030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628285}
-
Mario Sanchez Prada authored
Use IdentityManager and AccountsMutator instead to remove the dependency. Bug: 912150 Change-Id: Ia0b678feceeaf9d39898a5a82a2c997bfb63b9cf Reviewed-on: https://chromium-review.googlesource.com/c/1415410Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#628284}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I95cc236ef92cf63a30b94d899bc8d04b661d41d8 Reviewed-on: https://chromium-review.googlesource.com/c/1449514Reviewed-by:
-
Clemens Hammacher authored
Error messages will change with this V8 change: https://crrev.com/c/1445897 Hence disable the tests for now until that change rolled into chromium. R=ulan@chromium.org Bug: chromium:926311 Change-Id: I7bf2ff4b1897f8736d3f471b3ebcead1c8062b44 Reviewed-on: https://chromium-review.googlesource.com/c/1448327 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628282}
-
Abhijeet Kandalkar authored
As a step to make to use IdentityManager, this CL replace use of ATS with IdentityManager in user_session_manager.cc Bug: 922748 Change-Id: I1ce8988502ed32345d7f9c70478c5a48a1fd3a70 Reviewed-on: https://chromium-review.googlesource.com/c/1438977 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#628281}
-
Rakina Zata Amni authored
This CL makes FindBuffer able to filter out non-whole-word find results if needed. So on the text "foo foobar", there is only 1 match for "foo" and 0 match for "bar". Bug: 868227 Change-Id: Iaf31fb71c4b345a71061e6957ecd60f302de930e Reviewed-on: https://chromium-review.googlesource.com/c/1445354 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628280}
-
Daniel Bratell authored
Compiling the safe_browsing code is currently about 1% of the total build effort in a jumbo build, and most of that effort can be eliminated by adding support for jumbo in the safe_browsing code. The gain would be a little bit bigger if the code hadn't been split into a lot of 1-2 file targets. Those are not made jumbo since the gain from merging just 2 files is limited, and merging just one file makes no sense. Bug: 927338 Change-Id: I0e8f57bdb1b39fc2f85a8adb4b00b3790d59d987 Reviewed-on: https://chromium-review.googlesource.com/c/1448455Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#628279}
-
Fredrik Söderquist authored
Folds the "border-image version" of GraphicsContext::DrawTiledImage into NinePieceImagePainter. This should hopefully allow for better control of tiling computations, and also seems like a better place from a layering perspective. The computation of <scale, phase, spacing> is refactored into a new function ComputeTileParameters. Switch from using Image::TileRule to using ENinePieceImageRule (the style type), and remove the former since it is no longer used. Bug: 614125 Change-Id: Ia7433f871bb0bc6f7f963a14ae49b898559860d2 Reviewed-on: https://chromium-review.googlesource.com/c/1448612 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#628278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2012b3540bcf..50870b52cc76 Created with: gclient setdep -r src-internal@50870b52cc76 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie56161073fce119749fb4a8d9f8ca15da7d117a1 Reviewed-on: https://chromium-review.googlesource.com/c/1449029Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628277}
-
Hirokazu Honda authored
GbmWrapper creates one file descriptor for each plane (crrev.com/c/1437036). Therefore, GbmBuffer::GetFdCount() is unnecessary as GbmBuffer::GetNumPlanes() can be used alternatively. Furthermore, NativePixmap::GetDmaBufFdCount() is only for NativePixmap whose backend is GbmBuffer (i.e. GbmPixmap). NativePixmap::GetDmaBuFdCount() is no longer nececessary either. Bug: 911370 Test: VDA unittest and VEA unittest on eve, hana and kevin Test: Play video on eve w/o HW aceleration on eve, hana and kevin Test: gfx_unittests Change-Id: I1010d427833377f19dc7e98ce59809a5cf5206ff Reviewed-on: https://chromium-review.googlesource.com/c/1445352 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#628276}
-
Matt Falkenhagen authored
Part of an effort to simplify service_worker_context_client.cc. Bug: 927149 Change-Id: Icf60ce930465cd222c33c55e9ff02b267113fc2d Reviewed-on: https://chromium-review.googlesource.com/c/1449474 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628275}
-
Keishi Hattori authored
This reverts commit 4047b618. Reason for revert: CFI errors crbug.com/927659 Original change's description: > Add StreamStartAlgorithm type > > StartAlgorithms are different from other promise-returning algorithms in > the streams standard in that they can throw an exception. Add a new > StreamStartAlgorithm base class to represent them, and a > CreateStartAlgorithm() function to create ones from JavaScript. > > Design doc: > https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit > > BUG=902633 > > Change-Id: I0995aa21bbec51ab206a4affc54d861b2c325db4 > Reviewed-on: https://chromium-review.googlesource.com/c/1445342 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627877} TBR=ricea@chromium.org,yhirano@chromium.org Change-Id: I1a9882e1d33236c95ac953a1a1021b9431c4ddca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902633 Reviewed-on: https://chromium-review.googlesource.com/c/1449478Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628274}
-
David Jean authored
Add an url_loading_service (and factory) that will handle all url loading and will pass on UI actions to a delegate (here implemented in BrowserCoordinator, which in turn passes it on to BVC) This will make chipping at URLLoader much easier. The delegate api will change drastically in upcoming CL, as for now, it just reflects the current url load data structure and existing methods. Bug: 907527 Change-Id: I6c72ad307d9e80249cac909149129dc593f9cbd1 Reviewed-on: https://chromium-review.googlesource.com/c/1442715 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#628273}
-
Antonio Gomes authored
... into the components/signin/core/browser:browser target. Additionally, the CL also removes needless includes to signin_internals_util.h from signin_manager* and identity_manager.h BUG=927308 Change-Id: I39d34969a565f6d357903cfe88cde634c4600380 Reviewed-on: https://chromium-review.googlesource.com/c/1448493Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/925f6ab9b18a..ae64f52786b3 git log 925f6ab9b18a..ae64f52786b3 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5d360ebe..10b73e92 (473 commits) 2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ebe5f7fad064..debaacab10b5 (1 commits) Created with: gclient setdep -r src/third_party/skia@ae64f52786b3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I3889531c183c7d7a44ee9f4e639431636bf17842 Reviewed-on: https://chromium-review.googlesource.com/c/1449027Reviewed-by:
-
Keishi Hattori authored
This reverts commit 7cf254c3. Reason for revert: Suspected cause of test failure crbug.com/927647 Original change's description: > Do not call 'navigation committed' callback if there was no pending item to commit. > > GetPendingItem can return null inside webView:didCommitNavigation: > This is due to crbug.com/925304, which allows to discard pending items > by another navigations prematurely. > > If pending item is null, it means that Navigation Manager will not commit > that item and WebStateObservers can crash because they expect to have at > least one committed item. > > This CL leaves navigation as "uncommitted" if there was no pending item > inside webView:didCommitNavigation: > > Bug: 925304 > Change-Id: If9bedd0f74a428946a9026d142da7fc360fd7138 > Reviewed-on: https://chromium-review.googlesource.com/c/1448683 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628224} TBR=justincohen@chromium.org,eugenebut@chromium.org Change-Id: I44d5b313616a6deb05a9ad254314181df11a059e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925304 Reviewed-on: https://chromium-review.googlesource.com/c/1449438Reviewed-by:
-
Mario Sanchez Prada authored
This dependency is not really used and can be simply removed. Bug: 927259 Change-Id: I5ed3062476071f8c94f8952a90c5c1832b0ea8cf Reviewed-on: https://chromium-review.googlesource.com/c/1448211Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#628269}
-
Sylvain Defresne authored
The plan is to have client code keep instance of CoreAccountInfo instead of keeping only one of the three components (account_id, gaia or email) and then querying the IdentityManager for the other. As is_under_advanced_protection is not a valid key for an account, it does not fit in CoreAccountInfo, so move it back to AccountInfo. The few locations that need it during the initialization will have to fetch the extended account information from IdentityManager. Bug: 926204 Change-Id: I4a36e2464098ef18760507acc5d5cf3ce51c2fc6 Reviewed-on: https://chromium-review.googlesource.com/c/1448321 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This are no longer used and can be safely removed. Bug: 927328 Change-Id: I2716aa665cc0d4179bd3ff8b78393b72ded634a6 Reviewed-on: https://chromium-review.googlesource.com/c/1448414Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#628267}
-
Adam Rice authored
In some cases |headers_text| in WebSocketHandshakeResponse would not match |headers|. Ensure that they always match. BUG=924972 Change-Id: I4ad2f45dd4aed4f6dc0cceb656f736e663046827 Reviewed-on: https://chromium-review.googlesource.com/c/1442350Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#628266}
-
Maksim Sisov authored
If a previous browsing session is empty, WindowSizer calculates default window bounds by calling GetDisplayMatching with empty bounds. Previously, WaylandScreen returned an invalid display, which resulted in extremely small windows. Now, instead of returning an invalid display, the nearest display to the match rect is returned. Also, if the match rect does not intersect with any of the displays, a primary display is returned. We are doing the same as ScreenBase::GetDisplayMatching now. Bug: 927274, 875161 Change-Id: I567cba549fb90b9d5db58b3af3bed04598848cdb Reviewed-on: https://chromium-review.googlesource.com/c/1448172Reviewed-by:
-
Maksim Sisov authored
Wayland does not provide either location of surfaces in global space coordinate system or location of a pointer. Instead, only locations of mouse/touch events are known. Given that Chromium assumes top-level windows are located at origin, always provide a cursor point in regards to surfaces' location. If a pointer is located in any of the existing wayland windows, return the last known cursor position. Otherwise, return such a point, which is not contained by any of the windows. Bug: 875161 Change-Id: If4de9936502efb6c49a50fe125f3fd6f5c59a4d0 Reviewed-on: https://chromium-review.googlesource.com/c/1273295 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Keishi Hattori authored
When no threshold is specified in FieldTrialParam, the default theshold was suppose to be 10% of system RAM, but actually it was set to 10 bytes. blink_workload_threshold's unit is bytes. Bug: 927599 Change-Id: I211347bdee5938b85ff27e29c694bf27906de6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1448006Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628263}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b1368c196a9..2012b3540bcf Created with: gclient setdep -r src-internal@2012b3540bcf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69be5f710e7577c9bc785e2dafcc2a6cd87a1797 Reviewed-on: https://chromium-review.googlesource.com/c/1449028Reviewed-by:
-
Matt Falkenhagen authored
This moves the WebServiceWorkerNetworkProviderImpl for service workers to its own file for clarity and to simplify service_worker_context_client.cc. The other implementations, WebServiceWorkerNetworkProviderImplFor{Frame,Worker}, will be renamed in another patch to match this simplified naming. Bug: 927149 Change-Id: I1d331d09f394b84ef2dfc8c5c955f27534a0ddda Reviewed-on: https://chromium-review.googlesource.com/c/1449434 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#628261}
-
Vlad Tsyrklevich authored
This is a reland of a692ce8d, I forgot to update a length test from kMaxStackFrames to kMaxPackedTraceLength in the original change. Original change's description: > GWP-ASan: Pack stack traces to save space > > Make use of the stack trace packing from https://crrev.com/627865 to > reduce memory usage to store stacks on 64-bit systems by ~60% percent. A > GWP-ASan microbenchmark did not show this change to noticably regress > performance. > > Bug: 896019, 921237 > Change-Id: Iad6e803f18ff12e5fd3079b9821d11bc0918bead > Reviewed-on: https://chromium-review.googlesource.com/c/1448522 > Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628034} Bug: 896019, 921237, 927488 Change-Id: I3160735a22e197b18911874e3667504f759552ee Reviewed-on: https://chromium-review.googlesource.com/c/1449105Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#628260}
-
Koji Ishii authored
Following bot results are included. 14400 14408 14417 14428 14433 14439 14448 14451 14456 14468 14476 14490 14498 14504 14516 14518 14521 14530 14550 14558 14564 14568 2 lines were removed and 4 lines were deflaked by consecutive results since 14476. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099, 927467 Change-Id: Iee80eef8910fa56d0f8caeb903a4c9a658dce4f5 Reviewed-on: https://chromium-review.googlesource.com/c/1443371 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#628259}
-
Adam Rice authored
See design doc at https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit BUG=902633 Change-Id: I90b2f4e0791b382da6ed5803525e2e0c3ef4075e Reviewed-on: https://chromium-review.googlesource.com/c/1446267Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/831bd96138e9..4a2911fc50eb git log 831bd96138e9..4a2911fc50eb --date=short --no-merges --format='%ad %ae %s' 2019-02-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9963b4a7..ecc3b419 (628101:628213) Created with: gclient setdep -r src/third_party/webrtc@4a2911fc50eb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id50f96500aa615ab2026af807d4e9b8612d3ce08 Reviewed-on: https://chromium-review.googlesource.com/c/1449084Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a07524dce2e..cf9383ed325c git log 1a07524dce2e..cf9383ed325c --date=short --no-merges --format='%ad %ae %s' 2019-02-01 jmadill@chromium.org Optimize VertexArray::bindVertexBufferImpl. Created with: gclient setdep -r src/third_party/angle@cf9383ed325c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I229ff16d8b44365e77a81b1b5299a07cc265224d Reviewed-on: https://chromium-review.googlesource.com/c/1449085Reviewed-by:
-
Kent Tamura authored
- Move IsURLAttribute() check to ResolveURLIfNeeded() - Move HTML attribute code out to AppendAttributeAsHTML() - Move code for XML attribute without namespace handling out to AppendAttributeAsXMLWithoutNamespace() - Move code for XML attribute with namespace handling out to AppendAttributeAsXMLWithNamespace() - Make ShouldAddNamespaceAttribute() static. This CL has no behavior changes. Change-Id: I13815716e78aa08ccee73457d5331180a8dc7d3c Bug: 927166 Reviewed-on: https://chromium-review.googlesource.com/c/1448007Reviewed-by:
-
Alexandre Courbot authored
We can (and should) use std::move wherever we can. Such is the case here since ret.second is never accessed afterwards. Bug: None Test: Run VDA unittest on Hana. Change-Id: I2d3f42628072954d49cb3001bb137c02a81a71da Reviewed-on: https://chromium-review.googlesource.com/c/1448002 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#628254}
-
Alexey Baskakov authored
"Create Shortcut" button may implicitly promote already opened tabs within the navigation scope to WebApp tab instances. "Remove from Chrome" in chrome://apps may demote already opened tabs within the navigation scope to regular web sites. Set or reset app_id using ExtensionRegistryObserver subscription. Bug: 915034 Change-Id: I0bd3b8dc910f2ef3d516e64a0e6a628741a50fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1426247 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#628253}
-
Alexey Baskakov authored
DidFinishNavigation doesn't happen if WebApp tab is closed and than restored (Ctrl+W, Ctrl+Shift+T) Restore it using |restore_url| (no serialization of app_id needed). Bug: 915034 Change-Id: I1d591ba81e28d2e1c0ec84f70421b8ccf4ccc995 Reviewed-on: https://chromium-review.googlesource.com/c/1425847Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baff0d095ac5..7b1368c196a9 Created with: gclient setdep -r src-internal@7b1368c196a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I68cfb89d2df1ba4a321a0a8f9a459c3d131d8b22 Reviewed-on: https://chromium-review.googlesource.com/c/1449086Reviewed-by:
-
Brandon Maslen authored
Audio and video element requests typically involve custom headers and range requests that are more complicated and nuanced than other resource requests. As a result, despite potentially being preloaded, audio/video resources do not typically hit the preload cache. In order to rectify this issue the Fetch spec needs to specify how the preload/media cache should behave and implementors need to adopt this behaviour. This is tracked here: https://github.com/w3c/preload/issues/97 While the preload spec does describe preloading media resources (as=audio/video), and the current behaviour does match the spec, the behaviour is misleading for developers given that indications are the resource is preloaded and yet the video element typically will re-fetch the resource. This can cause unintended behaviour and potentially even double downloads. In order to mitigate the current cache behaviour and send a clear signal to developers about how their page will behave the current thought is to remove the audio and video "as" declarations from the preload implementation until the Fetch spec issue is resolved. This change removes the audio/video ResourceTypes as a valid preload types. In addition the upstream W3C preload tests have had exceptions added to specify the newly expected behaviour. As this is likely to revert in the future and not result in a preload spec change the original tests have been left as-is. A new test has also been added to the web_tests preload test suite to validate that audio/video types are indeed not preloaded. Intent to Temporarily Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QnwPuiiYuQE Bug: 735014 Change-Id: I82ad3200d486ce531795dd42f89e6683087047a2 Reviewed-on: https://chromium-review.googlesource.com/c/1440522 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e2a76c334ce..baff0d095ac5 Created with: gclient setdep -r src-internal@baff0d095ac5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f5ac4f662ee310c044d964b8cb52d6695f67e5c Reviewed-on: https://chromium-review.googlesource.com/c/1449083Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ceab6936. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 2376792a "Enable analyser tests to run with Chrome" f62d379c "Revert "Enable analyser tests to run with Chrome"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I27e2eb760d48f958ec32fd4b3c4e056d2770d1f0 Reviewed-on: https://chromium-review.googlesource.com/c/1449319Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628248}
-
tzik authored
SecurityOrigin used to use |this| pointer value to identify opaque unique origins, which does not work well with IsolatedCopy(). After this CL, the nonce value of the unique origin is involved for the comparison, so that the return value of IsolatedCopy() equals to the original one. Change-Id: I54bc49ead8b711b40902503656e3356e9a5c75f3 Reviewed-on: https://chromium-review.googlesource.com/c/1445034Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#628247}
-
