- 03 Oct, 2018 40 commits
-
-
Fady Samuel authored
This CL enables throttling of child synchronization events. In a child- initiated synchronization, the child's frame will likely activate before the dependent parent's CompositorFrame arrives. Upon activation, the child will see that the new surface does not cause any damage to the display (because it's not embedded by any parent yet) and calls the draw callback immediately, thereby sending back a DidReceiveCompositorFrameAck to the client immediately. This, in turn, results in the client sending another CompositorFrame to Viz, and another and so on, letting the child get further and further ahead of the parent. This results in a lot of wasted work because the child's surface will not be shown on screen until the parent embeds it and so multiple child initiated synchronization events are pointless. This CL throttles DidReceiveCompositorFrameAck of the child on child-initiated synchronization events until the parent references the child. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I62416d87f8d871b32f4caad565cff515a9c55445 Bug: 672962, 879207 Reviewed-on: https://chromium-review.googlesource.com/1236931 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596300}
-
erikchen authored
The shift modifier is *almost* always incorrect to use for menu items -- it is instead appropriate to apply the shift modifier directly to the keyEquivalent. Bug: 882166 Change-Id: I6507a2a8981241cb1b80a8737213c5ac45fdab2e Reviewed-on: https://chromium-review.googlesource.com/1259362Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596299}
-
erikchen authored
In vietnamese layout, cmd + [vkeycode=18] does not print any characters. This should still be correctly interpretted as a hotkey for cmd + '1'. Previously, the logic for cr_firesForKeyEvent would early exit when charactersIgnoringModifiers had 0 length. Subsequent logic would use characters in place of charactersIgnoringModifiers. This CL moves the latter logic before the former logic so that if charactersIgnoringModifiers has 0 length, we'll instead check characters. Change-Id: I3fcc45579c7697ca843ef3472fa294fa2da02262 Bug: 889424 Reviewed-on: https://chromium-review.googlesource.com/1259342 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Chris Palmer authored
`SlowPathAlloc` has 3 tactics for getting new memory. Of these, only the 1st (calling `PartitionDirectMap`) seems to most obviously get a fresh, zeroed page from the OS. I think it is safe to optimize in that branch. It might be safe on some platforms to optimize in the other 2 branches, but it's less obviously safe, and we've had trouble on at least macOS. This CL enables the 1st branch but turns off the optimization in the 2nd 2 branches. Bug: 890752 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Change-Id: Ibd9ff599ba78aeab47c2369c472af71a4f71d600 Reviewed-on: https://chromium-review.googlesource.com/1256211Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596297}
-
Mikel Astiz authored
We've seen an increase in Memory.Browser.PrivateMemoryFootprint that is suspected to be caused by leveldb use for sync purposes, which is more common the more datatypes are migrated to USS. In order to tune leveldb's memory usage and confirm that recent regressions are caused by sync, various feature toggles are introduced. By default, there is no behavioral differences. Bug: 887068 Change-Id: Idada6be78a39db7ef04ee582ca01b8ed0c427838 Reviewed-on: https://chromium-review.googlesource.com/1257912Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#596296}
-
Wenzhao Zang authored
Bug: 850250 Change-Id: I1a7af66367665bcb1577b5c6efc3f2e5d2748113 Reviewed-on: https://chromium-review.googlesource.com/1171801Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596295}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49fdd7ad1875..f1709049243e git log 49fdd7ad1875..f1709049243e --date=short --no-merges --format='%ad %ae %s' 2018-10-03 bsalomon@google.com Move integer rect checks from GrRenderTarget::drawTexture to GrTextureOp 2018-10-03 mtklein@google.com Revert "Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN."" Created with: gclient setdep -r src/third_party/skia@f1709049243e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:862144 TBR=mtklein@chromium.org Change-Id: I072cdf9b67cfb8174017bb2c145d4c0d2ec94976 Reviewed-on: https://chromium-review.googlesource.com/1259263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596294}
-
Torne (Richard Coles) authored
Android O's WebView zygote code doesn't handle split APKs correctly when preloading the code for the current WebView implementation, creating an incorrect entry in the Java classloader cache. This causes a crash when the renderer process initializes, since it tries to load the native library into two different classloaders as a result, which is not permitted. We're hoping to work around this using reflection to correct the cache entry during the zygote preloading phase, so that when the renderer starts up, it correctly reuses the preloaded classloader instead of creating a new one. However, we're not sure if this reflection will work on all devices due to vendor changes. To validate that the reflection works, this CL will attempt the reflection but not actually change anything - if the reflection fails due to a framework change, it will catch the exception instead of crashing, and simply record that in a static variable which can later be logged with UMA. Bug: 891452 Change-Id: I41dabb9c4cb4151676229a07abd37c803dbc3967 Reviewed-on: https://chromium-review.googlesource.com/1255388 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596293}
-
Reilly Grant authored
This is a follow-up to r556547 and updates the unit tests for SiteDataCountingHelper to use the network::mojom::CookieManager interface. Bug: 823297 Change-Id: I41914390a0efc33e5ee9a2fdeca628ff1a1c5f84 Reviewed-on: https://chromium-review.googlesource.com/1258246Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596292}
-
Robbie McElrath authored
This migrates WaitForNetworkCallbackHelper from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 887056 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I70cc4863630ffbbd808ed91f5b4cee7dcc003296 Reviewed-on: https://chromium-review.googlesource.com/1239261Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#596291}
-
Robert Ma authored
Builders don't (and shouldn't) have global git user name/email configured, and the recipe only configures git user in the Chromium checkout (the recipe doesn't know about the tmp WPT checkout). When git user cannot be found (neither in the repo or globally), `git commit` will fail. (Previously, we didn't notice the issue on BuildBot because the bot had some leftover global configurations from an earlier version of the recipe.) To make sure we always have a git user configured, this change explicitly sets git user name & email in the tmp WPT checkout to the bot account. It is still safe to run the script manually because GitHub allows committers to be different from the uploader. Besides, remove an unnecessary pair of quotes in a format string for `git show`; we don't use shell to start subprocesses so spaces don't need to be quoted. Bug: 803111 Change-Id: Ife020c8a18120ff607b8802c32cf9539bf6a36c9 Reviewed-on: https://chromium-review.googlesource.com/1258977 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#596290}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f9d38f2e4e5d..7988589e4858 git log f9d38f2e4e5d..7988589e4858 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 benwright@webrtc.org Add missing headers to new objective-c API. 2018-10-03 steveanton@webrtc.org Add jeroendb@ and shampson@ as media/sctp/ OWNERS 2018-10-03 peah@webrtc.org Hooked up the control of the adaptive AGC2 mode in audioproc_f 2018-10-03 danilchap@webrtc.org Set public visibility for rtp_rtcp and video_coding targets Created with: gclient setdep -r src/third_party/webrtc@7988589e4858 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8527696381db4210640cea3564b271995dadb30a Reviewed-on: https://chromium-review.googlesource.com/1257721Reviewed-by:
-
erikchen authored
This results in more intuitive behavior of Chrome with respect to tab switching shortcuts. Bug: 889424 Change-Id: I1ccba5141a3ddbfd2391d2d40e0d5884b50a382f Reviewed-on: https://chromium-review.googlesource.com/1259244Reviewed-by:
-
Gabriel Marin authored
Original CL: - https://codereview.chromium.org/1410353005 Add generic.total_physical_bytes property to MallocExtension The actual physical memory usage of tcmalloc cannot be obtained by GetNumericProperty. This accounts for the current_allocated_bytes, fragmentation and malloc metadata, and excludes the unmapped memory regions. This helps the user to understand how much memory is actually being used for the allocations that were made. This change is done only in chromium tree since the metadata_unmapped_bytes is added only in the chromium's tcmalloc in CL: www.crrev.com/10499004. This is to be used by malloc dump provider for tracing. BUG=546491 Committed: https://crrev.com/0752ec9c6adf641985db1a3a224bf9b8e32e4ac8 Cr-Commit-Position: refs/heads/master@{#357155} BUG=724399,b:70905156 Change-Id: I68ae586aacf2f2c1ab09721716b9093d402d649c Reviewed-on: https://chromium-review.googlesource.com/1130803Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#596287}
-
Tatiana Buldina authored
Bug: chromedriver:1408 Change-Id: Ia317f5e00e2b55092c2423f836eb5d04debfedb2 Reviewed-on: https://chromium-review.googlesource.com/1258086Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#596286}
-
Koji Ishii authored
Some override functions in LayoutNGMixin are not to be overridden further. This patch marks them as 'final' so that calling them from inside of LayoutNGMixin or its subclasses can make non-virtual calls. No behavior changes. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I97e65d70cbe34b6757ab129c62e37bdaddcda72e Reviewed-on: https://chromium-review.googlesource.com/1258664Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596285}
-
Wenzhao Zang authored
The timer was added for the fear that the wallpaper animation completion is never received. In fact, it's guaranteed to be received. In case there's a decoder issue (more info in the bug) that wallpaper decoding takes more than 5 sec: 1) If keeping the timer, the user pods will be shown on top of the white boot splash screen, which looks buggy. 2) If removing the timer, the user pods will show together with the wallpaper. The boot experience feels slow but still smooth. So IMO the best solution is to remove the timer as well as trying to fix the decoder issue. Bug: 890935 Change-Id: I685a0065acae99ebccd2734dcebd9dce2f563dbb Reviewed-on: https://chromium-review.googlesource.com/1255903Reviewed-by:
-
Christian Biesinger authored
Added in https://crrev.com/c/1259122 and https://crrev.com/c/1259125 Change-Id: I7122d66620dd04ba3f14036177a180bd4a26315d Reviewed-on: https://chromium-review.googlesource.com/1259162Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#596283}
-
Yves Gerey authored
We were relying on brittle transitive #include. Bug: webrtc:8311 Change-Id: Ib67aef5ebead73cc7b9783c1bbc48fb53c332f3e Reviewed-on: https://chromium-review.googlesource.com/1258912 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596282}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c3bef3e7b028..c2116cd3af9f git log c3bef3e7b028..c2116cd3af9f --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Vulkan: Update pipeline barrier interface. Created with: gclient setdep -r src/third_party/angle@c2116cd3af9f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Idcd29fe0d40b4bcdde37947b2b0d10523a79dd31 Reviewed-on: https://chromium-review.googlesource.com/1259104Reviewed-by:
-
erikchen authored
NSViews in Views need to implement pasteAndMatchStyle:. The IDS_PASTE_MATCH_STYLE_MAC main menu item had the wrong key equivalent. Bug: 882166 Change-Id: I0ba029afddaab8e155d5cfadaccadf2c231a3e79 Reviewed-on: https://chromium-review.googlesource.com/1255864 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Christian Biesinger authored
R=eae@chromium.org, kojii@chromium.org Change-Id: I78bda450dd122b256495b33489dc8bfb7b39fb15 Reviewed-on: https://chromium-review.googlesource.com/1259125Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#596279}
-
Peter Kasting authored
Bug: none Change-Id: I1968359861e40606e6c7336ad7a80371224da76e Reviewed-on: https://chromium-review.googlesource.com/1255632 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#596278}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb18-31.html BUG=412078 TBR=jschuh@chromium.org Change-Id: If664b6a520360177c8cdfd25dd0025eaf8664ec3 Reviewed-on: https://chromium-review.googlesource.com/1259204Reviewed-by:
-
Katie D authored
This will allow us to pass more AccessibilityNodeInfoDatas even if they belong to different windows, which is part of the upgrade path planned for mapping ARC++ windows to Chrome OS. See go/a11y-arc++-window-mapping > Upgrade path for more. Bug: 891483 Change-Id: Ic7a1654691cec6d4229898d7d7aaeb3947953234 Reviewed-on: https://chromium-review.googlesource.com/1258207 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596276}
-
Dana Fried authored
Also fixes a bug where tooltips in Hindi and other languages that use custom font sizes would revert when the window DPI changes. Bug: 888788 Change-Id: I490a425d7bf142ef385462837680dfb34f5ff544 Reviewed-on: https://chromium-review.googlesource.com/1250211Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#596275}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api/braille_display_private. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=aboxhall@chromium.org Bug: 874080 Change-Id: I3f749884b51d34136fff66d253ef71e2be34a335 Reviewed-on: https://chromium-review.googlesource.com/1191233Reviewed-by:Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#596274}
-
braveyao authored
To support the implementation of getDisplayMedia() API in chromium, it's required to stop screensharing when screen is locked on desktop platforms. This cl is to add an interface to observe the screen lock event into content/browser and let VideoCaptureManager stop desktopCapture sessions on screenlock event. Note: It's done on Win/OSX/CrOS at present. Still tring to find a solid way on Linux. Bug: 887585 Change-Id: Ibe65d51c68e07f632a851f22d2ba6777a527204d Reviewed-on: https://chromium-review.googlesource.com/1241160Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596273}
-
Fabio Tirelo authored
Screenshots can be found in the bug. Bug: 891369 Change-Id: I206d89a1118cad0f65c17ba3cafee81998e3198c Reviewed-on: https://chromium-review.googlesource.com/1258046Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596272}
-
Marek Haranczyk authored
MANUAL_CommonMeasureFinalization and MANUAL_CommonInitialize tests reseted global registry on exit without initializing it again causing random test flakes on tests that operated on manifests that happen to run after those two tests (they passed on retry). Change-Id: I2b4297d33441c72d9cdd099106abad68921c2f6a Reviewed-on: https://chromium-review.googlesource.com/1259046 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596271}
-
Christian Biesinger authored
With names "blink_perf.parser_layout_ng" and "blink_perf.paint_layout_ng" This is useful for running manually and a precondition for running the paint test suite on the bot. R=eae@chromium.org, kojii@chromium.org Change-Id: I6437113221a591e2c244efe0f8780b6e29923be7 Reviewed-on: https://chromium-review.googlesource.com/1259122 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Min Qin authored
When running network service without launching full browser process, ChromeContentBrowserClient::OnNetworkServiceCreated() will be called without g_browser_process. This CL allows us to create SystemNetworkContextManager on demand and services depending on the network service can call SystemNetworkContextManager::GetInstance() to access it. BUG=866028 Change-Id: I9a557921e1bb164ecd62c766dd698137498c0a47 Reviewed-on: https://chromium-review.googlesource.com/1256207 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596269}
-
Hector Carmona authored
Bug: 874118 Change-Id: Id5e57c2667e1b7c1b8f11a132a51c1ecc377a444 Reviewed-on: https://chromium-review.googlesource.com/1246153Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#596268}
-
Stephen Martinis authored
This reverts commit cc86e6e5. Reason for revert: https://crbug.com/891729, didn't account for strange step names. Original change's description: > rebaseline_cl.py: Set step_name when retrieving results > > Layout test results are now uploaded into a directory indicating which > step name they were run as. This is to allow for without patch runs to > be recorded for analytics. This CL changes rebaseline_cl to pass the > step name when retrieving resuls. > > Bug: 882946 > Change-Id: Iad18ca54cc8804fff76f059ceab49d8c69fadd3e > Reviewed-on: https://chromium-review.googlesource.com/1244598 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595949} TBR=qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,robertma@chromium.org Change-Id: Ib5a73d70e234f73312bb32db7189ea9cdd43c185 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882946, 891729 Reviewed-on: https://chromium-review.googlesource.com/1259282Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#596267}
-
Meilin Wang authored
Add SetNightLightEnabled function in mojom::DeviceActions. Call this function in assistant_manager_service_impl.cc to enable/disable Night Light mode when query comes. Test: local compile and manually test. Bug: b:112698292 Change-Id: Id4ae0ed07fc2bc1197c0b702fd14c46284d1ba33 Reviewed-on: https://chromium-review.googlesource.com/1256216 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596266}
-
Rayan Kanso authored
Background Fetch notifications should always show the origin in the notification. In order to not break the behavior of other download notifications, a flag was added to OfflineItem to show the origin. Bug: 774612 Change-Id: I2f08e7e7d71a6520d02443a0961733d173242372 Reviewed-on: https://chromium-review.googlesource.com/1259011Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596265}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55aea84baa53..49fdd7ad1875 git log 55aea84baa53..49fdd7ad1875 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jvanverth@google.com Bundle shared SkImage_Gpu methods. 2018-10-03 caryclark@google.com fix bookmaker nightly 2018-10-03 reed@google.com play with animated gif 2018-10-03 bsalomon@google.com Remove unused macro SK_DONT_DROP_UNNECESSARY_AA_IN_TEXTURE_OP 2018-10-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 607f907d47b0..c3bef3e7b028 (1 commits) Created with: gclient setdep -r src/third_party/skia@49fdd7ad1875 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Id35569ef3781394f4c5f08697ceb040fb8866b25 Reviewed-on: https://chromium-review.googlesource.com/1257717Reviewed-by:
-
Ryan Hansberry authored
When SoftwareFeatures were changed to be stored in prefs as strings instead of as ints [1], CryptAuthDeviceManagerImpl failed to also migrate old int prefs to the new string representation when the prefs were desrialized. This caused all devices migrating from M69 to a newer release to believe none of their synced devices had any SoftwareFeatures until another sync occurred. 1) https://chromium-review.googlesource.com/c/chromium/src/+/1145588 Bug: 888031 Change-Id: Icd666106d6ebd4db5620cfab0dac459ef67df23e Reviewed-on: https://chromium-review.googlesource.com/1258515Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596263}
-
Rayan Kanso authored
The origin will be displayed in the status section of the notification. Very long origins will be elided to display the eTLD+1. Screenshots: https://lh3.googleusercontent.com/-eFfCFlWJf3Y/W7NlhkLY07I/AAAAAAAABMw/_RhaEe6jlnM1X-xXfsIoZ7uyJOnfd6JngCL0BGAYYCw/h48/desktoporigin1.png https://lh3.googleusercontent.com/-TiCAYHS9hfg/W7Nlep2HgkI/AAAAAAAABMk/cG6uFKK8sBcc8P-cmy9HtqEZHTp_2S2hgCL0BGAYYCw/h50/desktoporiginevil.png Bug: 774612 Change-Id: Iacd874b5fd03f3e6e37c204e9df9e4cbaba67435 Reviewed-on: https://chromium-review.googlesource.com/1256943Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596262}
-
Yeonwoo Jo authored
This patch simplifies conditions around the code in content/. Bug: 875665 Change-Id: I52e639adce40a86e20304ee64c52d3b399c39841 Reviewed-on: https://chromium-review.googlesource.com/1215147Reviewed-by:
-
