- 23 Oct, 2019 40 commits
-
-
Mikel Astiz authored
Prior to this patch, DataTypeManagerImpl::Restart() used IsPassphraseRequired() as the way to determine whether encrypted datatypes should enter the crypto-error state. This patch generalizes the concept to accomodate the trusted-vault-keys case, which doesn't have a corresponding API to IsPassphraseRequired(). To achieve this without poluting the public APIs, DataTypeEncryptionHandler is decoupled from SyncUserSettings. Bug: 1010189 Change-Id: Ia75f30d11d0c9077c301d6245ac51b5a810b5a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873753 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#708622}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a72e422c. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 707870e6 "CSS: WPT tests property values are supported." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jfernandez@igalia.com: external/wpt/css/css-align kojii@chromium.org: external/wpt/css/css-scoping nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I22511fbb2084293f2d65bc6550470813294493ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876368Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708621}
-
Lan Wei authored
for Mac 10.13 The wpt test pointerevent_coalesced_events_attributes.html is flaky on Mac10.13 Tests bot, because its running result is different from the default expectation file. Changing third_party/blink/web_tests/platform/ mac/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-expected.txt which is used by Mac 10.13 bot. https://test-results.appspot.com/data/layout_results/mac-rel/216117/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html Bug: 1015254 Change-Id: I3f774c84e20e30244ce45bc5ab295e1d6260f597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873382Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#708620}
-
Peter Kasting authored
Bug: 82078 Change-Id: I4ccfdc803686da1842954cbf136fb3e33466f53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870047 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708619}
-
Lukasz Anforowicz authored
This CL tweaks the GetOriginForURLLoaderFactory function so that for about:blank it uses the navigation initiator (rather than falling back to the process lock). This means that GetOriginForURLLoaderFactory always returns an origin (and never base::nullopt). Bug: 888079 Change-Id: Ic47720904507d3acc976636d7ebc677a1453b48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672176 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708618}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/faebe62aa330..3c660b0e0c31 git log faebe62aa330..3c660b0e0c31 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 ilkos@google.com Merge "Fix gen_bazel for new plugin" Created with: gclient setdep -r src/third_party/perfetto@3c660b0e0c31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idc8d99c6f4a9a1eec8ca11fbd78b60f44e827b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708617}
-
Emily Stark authored
Per chromium-dev thread (linked in CL), named namespaces are discouraged in top-level embedders like chrome/ and ios/chrome, but I don't think we have this written down anywhere official, making it difficult to cite in code reviews. Change-Id: Ib8ff004af004daebc308407e60bcf6c5add09b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874226Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708616}
-
Sam Zackrisson authored
This flag allows testing and subsequent enabling of the multi channel support of the WebRTC audio processing module. The feature is initially disabled. tested=Verified aecdump content with/without flag via chrome://flags Bug: chromium:1016708 Change-Id: I6c9476dd41a769db4c36fd1c54335f614af955c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872007Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#708615}
-
Alex Ilin authored
This reverts commit ef605722. Reason for revert: the test consistently fails on Android N Original change's description: > Add multi-window behavior test for GTS > > This CL adds a class for testing mult-window related operations in GTS. > It only contains one test case so far for GTS without group enabled. > Will add group related tests in a later patch. > > Bug: 983170 > Change-Id: I36761705effba417abbcb715c8e4bbb6c2b266dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857604 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707949} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983170, 1017141 Change-Id: I736a4e0649f462a6f3325c16209242cd31525067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876388Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708614}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d81a04e7b288..4f178d08de67 git log d81a04e7b288..4f178d08de67 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 nisse@webrtc.org Fix gtk color-space conversion in peerconnection_client Created with: gclient setdep -r src/third_party/webrtc@4f178d08de67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I58037c8d26dd36060234486b646db72906aef31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875310Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: I3e0b819ad060806f13991b504cc95d516b5142ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872987 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708612}
-
Maks Orlovich authored
We will restrict cookies from 3rd party contexts when they don't explicitly grant such access, and require those accessible there to be secure, so some tests need updated to mark their partiness correctly, and to not try to use insecure 3rd-party accessible cookies. Bug: 1016512 Change-Id: I2f357bfd0aaefc873b926a6fe82bca98464d444b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872652Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#708611}
-
Julian Pastarmov authored
These tools are often handled in conjuction with other refactorings or additions to the policy handling pipeline and the expertise is usually in the same group of people. Any changes reaching further into gret will still go through the core grit OWNERS. BUG=none Change-Id: If098dccba8fa1291ab42a253328e048e82da85d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871562Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708610}
-
Dmitry Gozman authored
The only usage of this is left in CommitFailedNavigationInternal, where we commit error page and send "DidFailProvisionalLoadWithError" immediately before. - At this time we have already moved the navigation from "pending" to "committing" state, so there should be no pending entry to discard. - This also does not make sense when committing cross-process error page, because the new RenderFrame/RenderFrameHost does not have any pending navigation going at all - it was just created to commit error page. This CL also introduced NavigationSimulator::AbortFromRenderer to simulate abort path in unit tests. Bug: 855189, 963806 Change-Id: Id60f704803080fb677ef0aee191a3e21bfde1421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808214 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Avery Musbach authored
split_view_controller.h creates the impression that certain functions are not from aura::WindowObserver. It is also not consistent with the order of function definitions in split_view_controller.cc, and the order in window_observer.h. Change-Id: Idd5cc02169985a542e620da3ca1de2fed79827c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873161Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#708608}
-
Lily Chen authored
This took me a while to completely figure out, so I'm adding an overly lengthy comment explaining how it works. Bug: None Change-Id: I73c511e690b044a938bb3bb0f154ad8982bcfd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872424Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#708607}
-
Christian Dullweber authored
The test is failing on linux and windows. ChromeOS seems fine. Tbr: thestig@chromium.org Bug: 978948 Change-Id: Ia1d3f6077f3da1e6ba8ec15c111e8b6019c0e56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876411Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708606}
-
Martin Robinson authored
Make the conversion between an AtkRole and the string representation a bit more robust and share it between all accessibility formatters. Bug: 1017106 Change-Id: Idfd77b4b2687fcbbcb2d4c8266115f68ba7bd041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875096Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#708605}
-
Sophie Chang authored
Bug: 969558 Change-Id: I842006ad992bec31b814205b6fae6ddb0f698414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856662Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708604}
-
Robert Kaplow authored
Bug: 1016906 Change-Id: Ibf0bce1a5528b6e9495413342b84128687d5ba7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872477Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#708603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4aff1dc..1c5bed7f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2b1dc1d39260418db52b085ba4001053f567b003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708602}
-
Avery Musbach authored
Change-Id: I52750f7838d3d7f043ca83de02c274168bdb4a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874716Reviewed-by:
-
Max Li authored
Bug: 923594 Change-Id: I44f33f94538bcb7a52a889377523bb9048e4d266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874591 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#708600}
-
Nasko Oskov authored
The HasWrongProcessForURL method on SiteInstanceImpl is a bit awkward to read and returns negative of what we usually want to ask. The real question this method answers is whether the input URL parameter is one that can be hosted in the SiteInstance. As such a better name for this would be IsSuitableForURL. TBR=halliwell@chromium.org Bug: 1015882 Change-Id: I4957b6fa62e1a5d81b3b6b67b64a45c20e452ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869810Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708599}
-
Fergus Dall authored
BUG=none TEST=none Change-Id: I2a5c89498267c28320c1af04d4167564712333c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868565 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#708598}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c833c0c59253..1f6c8c4d5495 git log c833c0c59253..1f6c8c4d5495 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 cwallez@chromium.org Make dawn_native use the webgpu.h header Created with: gclient setdep -r src/third_party/dawn@1f6c8c4d5495 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9720ac99133dd1996e8d9313b2312f69cef193f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876188Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/27c293665e3a..d81a04e7b288 git log 27c293665e3a..d81a04e7b288 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c0cca6e4..6dc3a51e (708426:708537) 2019-10-23 cz.theng@gmail.com Add multipleTouchEnabled for subview of RTCMTLVideoView and RTCEAGLVideoView Created with: gclient setdep -r src/third_party/webrtc@d81a04e7b288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ifcbdf13e82584e8873e0bfd845589efc7a234837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876189Reviewed-by:
-
Aaron Leventhal authored
Link to I2E: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hxV0yjyS8_4 Bug: 1006767 Change-Id: I26e453bcc5eb21e38388a4f152e85134a22d1531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873886 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708595}
-
Alex Ilin authored
This reverts commit 1e252fbf. Reason for revert: this change broke the internal build https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/b8898843520461106640 Also, TabTestUtils.setIsShowingErrorPage() isn't defined as static, so the error couldn't be fixed in 1 internal CL. Original change's description: > Android: Private-package Tab.setIsShowingErroPage > > The method is called by a class in chrome.browser.tab package > in production code. Makes it a private-package method. > > Bug: 995903 > Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708466} TBR=dtrainor@chromium.org,jinsukkim@chromium.org Change-Id: Ieed0cf2e34f59cf4f7e68a4eb44dea0ea2f561aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876389Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9c790bc02512..faebe62aa330 git log 9c790bc02512..faebe62aa330 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 hjd@google.com Merge "trace_processor: fix initialization of eof_ field" 2019-10-23 rslawik@google.com Merge "Execute queries from file even with run-metrics" 2019-10-23 hjd@google.com Merge "Remove std::sto* from Perfetto code base" Created with: gclient setdep -r src/third_party/perfetto@faebe62aa330 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic1a1909a0a8c2d9a0d60c1704a485b05a5f65711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876190Reviewed-by:
-
Greg Thompson authored
This test is flaking/failing on Win10 Tests x64 1803 for some reason. In this change, we switch to using a gMock matcher for the failing assertion so that we can see the actual and expected values. BUG=1001597 Change-Id: Ie4ace9c741c352da675564b167de406e3db2aa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875249 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708592}
-
Christian Dullweber authored
The test is flaky on Linux and ChromeOS Tbr: arthursonzogni@chromium.org Bug: 796135 Change-Id: I39b8d47740a4c22fbd6118dba58fa87cf8d49fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876328Reviewed-by:
-
Thomas Tangl authored
Screenshots: https://drive.google.com/file/d/15byLhToggWs-whPy7-fxJxIcJpMMbNkO/view?usp=sharing https://drive.google.com/file/d/1VWQuo6TPG7R6mUid_UtJ9P-LzxZ3UXdU/view?usp=sharing https://drive.google.com/file/d/1xUccQH98t4GY4tuf-nXrDfBAOz_RxXg8/view?usp=sharing Bug: 1016915 Change-Id: I00c9cf3094e4d3a870a0bba8cc9413dd14428462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874466 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#708590}
-
Sophie Chang authored
This will basically only affect painful page loads since we would taint the data but made the method more general since logic is in the keyed service. Bug: 1001194 Change-Id: Ib19113a08251a17346697ef860a0270d5d8f6457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856439 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
This is a regression after the old parser removal. PasswordManager::ShowManualFallbackForSaving uses the result of the old parser. This CL makes using the result of the new parser. Bug: 1011732 Change-Id: I0537b472984e029aa2b002ee4d79717ac3f86765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875102 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#708588}
-
Miguel Casas authored
This CL adds a flag to explicitly enable using the HDR monitor(s) EDID-provided transfer function, if present at all. By default this flag is disabled because blindly using an HDR transfer makes HDR content look great and SDR content look faded (naive SDR-HDR mixing). The idea is to enable the flag for development. Bug: 1012846 Change-Id: I4d21aafa0a2b6114f68dc6a3615f72674dc0979c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872794Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#708587}
-
Ehimare Okoyomon authored
Populate NIK for websocket requests to provide a TopFrameOrigin for cookie access checks. Bug: 989067 Change-Id: Ic3bceee832a33abea84d2f0fc5ab0291c5f30336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859986Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
Christian Dullweber authored
This reverts commit 283a0491. Reason for revert: Suspected to cause failures on Mac https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/15082 and ChromeOS https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/14943 Original change's description: > Mark some blink testing targets testonly > > This forbids production code depending on these targets, and enables > these targets to depend on other testonly targets in the future. > > The only dependency prevented core:testing from being testonly was > from BlinkLeakDetector. > Add Page::SetInternalSettingsPrepareForLeakDetectionCallback() > to reverse the dependency. > > Change-Id: I64cba73f0c4d1383a192e468220f3d55e926a8f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864720 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708516} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: I26980f1a48f56e75f167a99437a33a4967e464dd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875733Reviewed-by:
-
Christian Dullweber authored
The test wasn't renamed to Maybe_* Tbr: avi@chromium.org Bug: 954217, 1017102 Change-Id: I38eff297b3adacc8b88873140c77ebeb62785508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876028Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: I681414f063900b5bd60ea95a97f4ba589df005b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871251 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708583}
-
