- 20 Aug, 2020 40 commits
-
-
Patrick Monette authored
Bug: 993029 Change-Id: I898a87e8ea515778f1edcb518ada06ddf3d8e8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355089Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#800352}
-
Orin Jaworski authored
This CL adds minor triggering improvements for Pedals. Bug: 893183 Change-Id: I3f1700cc1a3da7a3bdb6264c3fed8cd162a46aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367801 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800351}
-
Richard Knoll authored
This starts sending the actual payloads via NearbyConnectionsManager. It is now only missing the connection to the PayloadTracker. Bug: 1085067 Change-Id: I9c9ee61264799c62df13417c908bdaba82d1de3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366746 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#800350}
-
Tina Wang authored
Enabled the two poilcies above for manual test. Change-Id: Ie81620966a25e1886ad3ed2a1dc5cfb4e5a3f8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367644Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800349}
-
Himanshu Jaju authored
Implements the payload tracker class which is responsible for relaying progress updates in percent and maintaining status of incoming payloads. Also ensures that connection is closed when a terminal status is reached. Bug: 1085068 Change-Id: I329674a3e27784860955e25280024de678f49b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362896Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#800348}
-
chinsenj authored
When a user alt-tabs they can only navigate the window cycle list using the keyboard. To make this feature more interactive, this CL adds mouse behaviour to the window cycle list. This CL makes it so when a user hovers over an item, the focus ring follows the mouse. Also when a user presses on an item, it closes the window cycle list and activates the corresponding window. Test: WindowCycleControllerTest.MouseHoverAndSelect Bug: 1067327 Change-Id: I293d0416fbf764ddfb0116f65a33c17f288f646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357329Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800347}
-
Zhenyao Mo authored
Forgot to actually call an anonymous function. Surprised compiler didn't complain. BUG=1117185 R=sunnyps@chromium.org TEST=manual Change-Id: I17a7501c319253dd01a82fc587e03c18e3dc2997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367793Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#800346}
-
Olivier Yiptong authored
Replaces web_tests with WPT tests to ensure cross-browser compatibility in the future. Bug: 535764 Change-Id: Ice3b2bd0589a8aff83a0f50f7bcd2d2ff6938989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365332 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#800345}
-
Tiancong Wang authored
In Chrome OS, we need to enable call-graph-profile-sort for most of the use cases, except when we are generating orderfiles. Thus we have to use a flag to enable call-graph-profile-sort, when it's needed. Hopefully this flag can also be useful when other platforms find it useful to enable call-graph-profile-sort. BUG=chromium:1117564 TEST=Tested locally for chromeos Change-Id: I045cbeae058889f2b4f20fbfcd1994d45179bb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364753 Commit-Queue: Tiancong Wang <tcwang@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#800344}
-
Erik Chen authored
It's no longer necessary as cras is now functional with Lacros. Change-Id: I28e35a9d2f9865cec30847d5aec44de007120d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367797 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#800343}
-
Charlene Yan authored
MediaRouterIntegrationOneUABrowserTest.Basic MediaRouterIntegrationOneUABrowserTest.ReconnectSessionSameTab TBR=takumif@chromium.org Bug: 822231, 1119958 Change-Id: I2a14c52e5cd5ba737c6710aa36e25318f9fdaffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367781Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800342}
-
Alex Moshchuk authored
This will make test failures involving SiteInfo comparisons more readable, and it will also include the process lock and origin-keyed information in site URL crash keys logged on renderer kills. Similarly to https://crrev.com/c/2364816, the process lock URL is appended only when it's different from site URL, since the two are the same in the common case. A common use of different site and lock URLs is hosted apps, where the site URL is of form chrome-extension://<32-char-id>/. With that in mind, the SiteInfo crash keys are increased in length from 64 to 256, since 64 isn't enough to cover the 52-char chrome-extension site URL together with a lock URL. Bug: 1105994, 1067389 Change-Id: Ic747a9ca9244e4da2eebbeacbd499f7a8a439748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364579 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#800341}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e592b36b32d8..b6bb943fc2f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1064151,chromium:1115567,chromium:1118191 Tbr: xialinyan@google.com,mohsen@google.com Change-Id: I2a19c6602620ba2485a84b5b4ac4e4e5b4d32875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800340}
-
Thomas Lukaszewicz authored
This re-enabled SetCustomMask() on NativeViewHostAura for Windows as the layer related scaling bug has since been fixed. Bug: 843250, 863268 Change-Id: If7b9e61e6913143e415f0af20e05d7dab91ef665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366153Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#800339}
-
Olivier Yiptong authored
This implements Font Enumeration and Data Access for Windows. The implementation uses DirectWrite APIs that will work on Windows 7 with Platform Update KB2670838 and above. Furthermore, the enumeration data is cached in the browser process and shared with renderers using Read Only Shared Memory. Font Data Access is implemented using the backend for @font-face src: local() matching. Fixed: 1103400, 1113876 Change-Id: I31a16a90e980cd50b16a8f99a1633c1954555e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364009Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#800338}
-
Alex Newcomer authored
see go/render-html-multipaste for the design doc. This is the first CL to render HTML in multipaste. New objects: ClipboardHistoryResourceManager [stub]ClipboardHistoryImageModelFactory/Impl - The next CL will include implementation of FactoryImpl. Changes: - ClipboardHistory now has observers which are notified on things added/removed from history. - ClipboardData is wrapped by ClipboardHistoryItem - This has an ID to identify different ClipboardHistoryItems quickly. - ClipboardHistoryHelper -> ClipboardHistoryResourceManager. - CHResourceManager serves as a cache for ImageModels which will be rendered by ClipboardImageModelFactory. Bug: 1117230 Change-Id: Ia73d284eb3481525bc04bb04622801eda3c7a8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363023 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#800337}
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/5e8c30a1e0e0..0324bd3ef1af $ git log 5e8c30a1e..0324bd3ef --date=short --no-merges --format='%ad %ae %s' 2020-08-19 huangdarwin Amalgamations for release 3.33.0 2020-08-14 drh Version 3.33.0 2020-08-13 dan Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory. 2020-08-12 drh Improvement on the previous fix. 2020-08-12 drh Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. 2020-08-11 drh Fix harmless USAN warnings from gcc9. 2020-08-11 drh New test cases for the use of the ieee754 and decimal extensions in the CLI. 2020-08-11 dan Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. 2020-08-11 drh Minor comment fixes. No changes to code. 2020-08-11 drh Remove an unused #define from sqliteInt.h. 2020-08-10 drh Simplify #ifdefs associated with Parse.eParseMode. Fix an #ifdef error associated with SQLITE_OMIT_AUTOVACUUM. 2020-08-10 dan Fix a problem causing test failures in corruptL.test for some permutations. 2020-08-10 dan Fix a problem building fts3 separately from the amalgamation. 2020-08-10 dan Fix a shell tool build error caused by some combinations of options. 2020-08-10 drh Fix harmless compiler warnings that surface in newer versions of GCC. 2020-08-10 dan Fix another test script problem in walvfs.test. 2020-08-10 dan Fix minor test script problems. 2020-08-09 drh Fix a harmless compiler warning. 2020-08-08 drh Fix the check-in at [41474548ef3f7454] so that it computes the pointer in time for error checking at the end of the routine in the case of a non-OOM error. 2020-08-08 dan Fix test script busy2.test so that it works with the inmemory-journal permutation. 2020-08-08 dan Changes to busy2.test, corruptL.test and fkey5.test so that new test cases pass with all test permutations. 2020-08-08 dan Fix a test script problem causing an error for SQLITE_ENABLE_OVERSIZE_CELL_CHECK builds in corruptL.test. 2020-08-08 drh Move a pointer computation until after OOM checks to avoid a nuisance USAN warning. 2020-08-08 dan Change the name of sqlite3SelectTrace to sqlite3_unsupported_selecttrace. 2020-08-08 drh Update requirement marks due to wording improvements in the documentation. 2020-08-08 drh Reorder declarations in the decimal extension for C89. 2020-08-07 drh Do the oversize-WAL corruption test before the size hint is issued. 2020-08-07 dan Fix a file-descriptor leak in test script corruptL.test. 2020-08-07 dan Return an SQLITE_CORRUPT error if the final expected size of the database when checkpointing is not reasonable - where reasonable is defined (basically) as the sum of the sizes of the database and wal files. 2020-08-07 drh Add the --checkpoint option to speedtest1. 2020-08-06 drh Fix the columnar output modes in the CLI so that they work with parameters. See [https://sqlite.org/forum/forumpost/17ba6aac24] for details of the problem fixed. 2020-08-04 mistachkin Fix compilation issues with MSVC. 2020-07-31 drh Back out a NEVER() that turns out to be reachable. 2020-07-31 drh Remove an ALWAYS() that turns out to be reachable. 2020-07-30 drh Test for schema corruption is reachable after all. 2020-07-30 drh Provide an alternative "guaranteed-safe" method for overwriting the WAL index on recovery, in case some platform is found for which memcpy() cannot do this safely. 2020-07-30 drh Fix compiler warnings in MSVC. 2020-07-30 drh Fix unreachable branches. 2020-07-29 drh Fix signed/unsigned compiler warnings. 2020-07-28 drh Earlier detection of out-of-range page numbers in the btree layer. 2020-07-28 drh Add an sqlite3FaultSim() to make an OOM case more accessible and remove the ALWAYS() on the conditional that is false when the OOM actually occurs. 2020-07-27 drh On recovery, always overwrite the old with the new, even if they are the same. Add ALWAYS() macros on branches currently thought to be unreachable, pending additional testing. 2020-07-27 dan Fix a couple of test scripts to match the new wal recovery behaviour on this branch. 2020-07-27 drh Improved error reporting if walLockExclusive() fails. 2020-07-25 dan Allow a wal mode recovery to proceed even if there are readers. 2020-07-24 drh Remove a surplus space from a comment 2020-07-24 drh Fix other potentiall pointer aliasing problems associated with subclassing of the sqlite3_file object for various VFS implementations. 2020-07-24 drh Fix pointer aliasing problem in the in-memory journal code. Ref: [https://sqlite.org/forum/forumpost/d44eb2fc44|forum post d44eb2fc44] 2020-07-23 drh Add the OMIT_ZLIB compile-time option to sessionfuzz.c. (Originally checked into the wrong branch.) 2020-07-23 drh Fix a typo in an error message. (...) 2020-06-10 dan Ensure that the "push-down" optimization does not push constraints down into compound queries if any of the component queries uses window functions. 2020-06-10 drh Disable AggInfo consistency checks when unwinding after an OOM. 2020-06-09 drh Mark an always-true conditional with ALWAYS(). 2020-06-09 dan Ensure that aggregate functions that (a) are part of SELECT statements with no FROM clause and (b) have one or more scalar sub-selects as arguments are assigned to the correct aggregate context. 2020-06-09 dan Modify a test file to avoid causing Tcl to allocate too much memory. 2020-06-09 drh Give the expression pointer fields of AggInfo distinctive names in order to simplify tracking of all their uses. 2020-06-09 drh Improved tree-view debugging output for aggregate functions. 2020-06-08 dan Fix a case where a corrupted fts3 record could cause an assert() failure, or spurious SQLITE_NOMEM error in builds with assert() disabled. 2020-06-07 drh Fix minor OOM problems. 2020-06-07 drh AggInfo objects might be referenced even after the sqlite3Select() function that created them has exited. So AggInfo cannot be a stack variable. And it must not be freed until the Parse object is destroyed. 2020-06-07 drh Alternative fix to ticket [c8d3b9f0a750a529]: Prior to deleting or modifying an Expr not that is referenced by an AggInfo, modify the AggInfo to get its own copy of the original Expr. 2020-06-05 drh In the debugging treeview output, change the name of "SELECT-expr" expression nodes to be "subquery-expr", so as to not confuse them with actual SELECT nodes. 2020-06-05 drh Always use ?...? to indicate optional arguments in the output of ".help" in the CLI. Change ".mode column" so that it automatically activates ".headers on" if headers have not been previously turned on or off. 2020-06-04 drh Add support for "box" mode in the CLI: Like "table" except that it uses unicode box-drawing characters instead of ascii-art. 2020-06-04 drh Improved display of ".mode table" output for empty result sets. 2020-06-04 dan Use __has_extension(c_atomic) instead of __has_feature(c_atomic) to detect support for atomic load and store operations with clang. 2020-06-04 dan Use AtomicStore() to set values in the wal-index hash table. 2020-06-04 drh Work around a bug in clang-11.0.0. 2020-06-03 drh Fix for ticket [810dc8038872e212]. Thank to user "Maxulite" for tracking down the problem! 2020-06-03 drh Simplification to the interrupt handling logic in sqlite3VdbeExec() saves a few bytes of code space. 2020-06-03 drh Improve the query planner so that it is better able to find full index scan plan when there is an INDEXED BY clause. 2020-05-30 drh Draw the dashes below the headers in "explain" mode in the CLI. 2020-05-30 drh Improved VDBE comments on the ANALYZE code generator. This change also fixes a harmless use of an uninitialized integer variable as an input to the %d format on a VDBE comment. 2020-05-29 mistachkin Enhancements to the incremental build support for MSVC. 2020-05-29 drh Remove a stray "&" character in the CLI, detected by a clang warning. 2020-05-29 drh Add the "shelltest" target to the MSVC makefile as well. 2020-05-29 drh Fix the ".import" command of the CLI to clean up better after errors. Add the new "shelltest" makefile target on unix platforms. 2020-05-29 drh Improvements to help text for the CLI. 2020-05-29 drh Fix a memory leak in the CLI when an unknown or unrecognized argument is given to the ".dump" command. 2020-05-29 drh Improvements to columnar output in the CLI. Columns automatically expand to contain the largest row. 2020-05-29 drh Space to hold the ".width" of columns in the CLI is now obtained from malloc() and hence is not limited in the number of columns supported. 2020-05-29 drh Incremental improvements to tabular output modes in the CLI. The "markdown" and "table" modes no have headers turned on by default. 2020-05-29 dan Expand upon a comment in os_unix.c. No changes to code. 2020-05-29 drh In the json output mode of the CLI, do correct quoting of escape characters. Also, show BLOBs as JSON strings, possibly with embedded \u0000 bytes. 2020-05-28 drh Progress toward adding new output modes to the CLI: json, table, and markdown. 2020-05-28 drh Enhance the ".quote" mode in the shell so that it honors .separator. 2020-05-28 drh When the sqlite_stat1 data is missing for some indexes of a table but is present for the table itself or for other indexes in the same table, then do not let the estimated number of rows in that table get too small, as doing so can deceive the query planner into ignoring a perfectly good index. 2020-05-27 drh Small performance improvement and size reduction in the expression code generator. 2020-05-27 drh Change a datatype from i16 to int to appease Converity and help eliminate a false-positive. 2020-05-26 drh Fix the cksumvfs extension so that it will not register itself more than once. 2020-05-26 drh Performance optimization in the transfer of error messages from statements to connections. 2020-05-26 drh Increase the version number to 3.33.0 to begin the next release cycle. 2020-05-26 drh Innocuous changes to help Coverity avoid false-positives. 2020-05-25 drh Attempt to work around a false-positive warning in the CGo compiler. 2020-05-01 dan Fix problems with UPDATE...FROM statements that modify rowid or primary-key values. 2020-04-30 dan Add OOM tests for the new code on this branch. 2020-04-30 dan Report an error if an UPDATE...FROM statement has an ORDER BY but no LIMIT clause. Add tests for multi-column primary keys. 2020-04-29 dan Fix problems with using LIMIT and FROM clauses as part of single UPDATE statement. 2020-04-29 dan Fix various bugs in new feature on this branch. 2020-04-27 dan Allow a FROM clause in UPDATE statements. Created with: roll-dep src/third_party/sqlite/src Bug: 1117367 Change-Id: Ie37ce39b80489b01ea8569eafea79e5bf8c54d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364964 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#800336}
-
Andres Calderon Jaramillo authored
This CL renews the "show-overdraw-feedback" until M88. The flag will likely become obsolete once SkiaRenderer is launched in all platforms, so no need to mark it as never-expire. Bug: None. Test: None. Change-Id: I4398ec4bb8f941529218a93947c99f7f52dd938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367450Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800335}
-
Mohsen Izadi authored
TBR=solomonkinard@chromium.org,rdevlin.cronin@chromium.org Bug: 1119846 Change-Id: I7075bd76983f165fb0588d4ed22cd7caffa0d1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367874Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800334}
-
Tanya Gupta authored
simplify the addition of a new feature. Change-Id: Ie0fdde88c4e48af19d4679d19eb3c11807382a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343218 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#800333}
-
Russ Hamilton authored
Add a "SurfaceTracker" to IdentifiabilityStudyState to keep track of surfaces that have been previously reported for each source. This is used for deduplication and to limit the number of metrics sent in each UKM report. Bug: 1112787 Change-Id: I00eb2360849ea6772fbfdcc9b1cf91680f8c6173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363398Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#800332}
-
Omar Morsi authored
This CL does the following. 1) Renames KeyPermissions to KeyPermissionsManager and 2) Creates KeyPermissionsManagerUserService which is a keyed-service. Bug: 1117010 Change-Id: I9cfaa94a29cf934cc2b9d9a91e3633908c37ffce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362729 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#800331}
-
Guillaume Jenkins authored
Enables CBCM at 100% on Beta on iOS (in addition to the existing command-line switch, which can enable CBCM in any channel). To paraphrase the comment in the code, CBCM must either be enabled at 100% or 0% because the Finch infrastructure isn't ready by the time CBCM must decide whether to initialize. Because of additional requirements explained in the following 1-pager (Google only), CBCM is required on Beta, which means CBCM will be enabled at 100% on Beta and 0% on all other channels: go/ios-cbcm-rollout-1pager. Bug: 1066495 Change-Id: I1449f5314ea592297d79ec7acbbb0991d31bed5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364912 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#800330}
-
Peter Wen authored
And one SupportAnnotationUsage misplaced annotation. Tbr: Just removing/moving annotations to be more correct. Bug: 1116130 Change-Id: I88c2e0df485a8fc263ac4958cc72ee171741fa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367636 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#800329}
-
Yu Han authored
This previously had no use counter. I'm adding NOTRY here because branch day seems to be an impossible day to land changes to enums.xml. Hopefully this sails through. Feel free to revert if this breaks something. NOTRY=true Bug: 869308 Change-Id: Ic81d9620f34b8fe0998f8f6e7cb9d209b028e6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367474 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#800328}
-
Anastasia Helfinstein authored
A recent change to TrayBubbleView caused the Switch Access back button to no longer display. This happened because the back button is explicitly drawn in OnPaint(). This change restores the previous behavior of the back button. TBR=jennyz@chromium.org AX-Relnotes: n/a. Bug: 1118201 Change-Id: Iae5e43ed1714997b062406a6bc9a8ac0a473bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367787 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#800327}
-
Adam Langley authored
The QR standard says that the mask should be auto-selected, not fixed to three, and specifies a fitness function for choosing the best mask for each QR code. This change adds support for that and lets the caller specify a mask if it really wants … say if it wanted to cycle through a series of QR codes for the same data with a dancing dinosaur on top. Change-Id: Ief4dedce236aa2ae13cc94b2248a17a0488f88ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365222 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#800326}
-
Emily Stark authored
Localhost URLs are highly unlikely to be phishing/social engineering, and it's especially useful for developers using localhost to be able to see port and path by default. Bug: 1112816 Change-Id: I245cbb5cacffebdb04cbb7840629c0ab68702883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367802Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#800325}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: Ia9fcf42d6394755cf1042e0d51f4352185e8a972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366593 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800324}
-
Daniel Rubery authored
This CL finishes preparing the V4 database code for the upcoming split of Safe Browsing NetworkContexts by profile. It starts using the browser-wide network contexts for all requests, and removes cookies from the V4UpdateProtocolManager. Bug: 1049833 Change-Id: I3f1c9819846ed35497a8c0d3ec32a8254c92fa0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365296 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800323}
-
Matt Menard authored
This complements the existing user policy and adds print servers defined by device policy. The device policy has its own corresponding whitelist and if there is existing print servers in user policy also in device policy, then the user policy print servers take precedence (which is only for the purpose of the print server names currently). Also changed to using shared url loader factory since the SystemNetworkContext is non-unit-testable. Bug: 1100777 Change-Id: I0e45597437b59b5eb940c4fbf5fb63596b8504dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293178Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#800322}
-
Ethan Jimenez authored
1. https://chromium-review.googlesource.com/2171436 introduced a change to how `AXPlatformNodeBase::IsLeaf` works; previously, a node would start by querying `AXPlatformNodeBase::GetChildCount` (which relies on `BrowserAccessibility::PlatformChildCount`) to check whether the node has no children (which would make it a leaf by definition). After CL 2171436, `AXPlatformNodeBase::IsLeaf` is delegated to `BrowserAccessibility::PlatformIsLeaf`, but the case of an '<iframe>' is mishandled since now we don't check if the node has a child tree. Fixing `BrowserAccessibility::IsLeaf` to check for the child tree of a node; this will allow several `BrowserAccessibilityPosition`'s methods to correctly traverse into '<iframe>' elements. 2. Introducing a content browser test to validate that methods from `BrowserAccessibilityPosition` can navigate into iframes. 3. Rebaselining `DumpAccessibilityTreeTest.AccessibilityIframe` which incorrectly expected '<iframe>' nodes to be treated as leaves. Bug: 1101480 Change-Id: Ib364ee78a39ef6b7854fc41985bd059dfced8a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364049Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#800321}
-
Juliet Levesque authored
Updated variable names in ShareTargetDiscoveryCallback and TransferUpdateCallback to be consistent with C++ style guide. Change-Id: I92d7994630dfee0d80f78ebeddbcb2d6d627b145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361844 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800320}
-
mhasank authored
In order to better understand the feedback reports, adding logging in key events of arc provisioning process. BUG=b:162221783 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: Ie6cd8a4dd9b89353a0a3fa1dcc656496f62bfb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365997Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#800319}
-
Miguel Casas authored
Just adding a DCHECK and using a stringify function in a log. No functionality change intended. Bug: b:162962069 Change-Id: Ie7f7520fe769405342bc21a15c810bb9c35eef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367444 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800318}
-
Elly Fong-Jones authored
This is a reland of 4e425ce4 Original change's description: > mac: introduce system infobar > > This infobar will be used (via field trials) to display updated info > about current OS support and provide users with a link to more info. > The infobar receives both activation info (which configs to show for) > and the actual strings to display via field trials, so it can be updated > for deployed Chrome instances without an update cycle. > > This change adds: > * The infobar itself > * A feature MacSystemInfobar that controls whether the feature is > enabled and if so which configs (Arm or Rosetta) it's enabled in > * A switch --force-mac-system-infobar which causes the infobar to act as > though it was running on a specified system, for both manual and > automatic tests > * A variety of IDS_MAC_SYSTEM_INFOBAR_* constants to customize the > infobar's message, link, and link text > * Unit tests for the logic to interpret the feature and the > enable/disable configs > > Bug: 1116578 > Change-Id: Ie7fd6e772a0112a17e794d1b8fcb009c57ebed4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360479 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799615} Bug: 1116578 Change-Id: Ie98bc3a18fc4f952819b3ee40a1c49953e8c63ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364893 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#800317}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie36b7fb24ee930592df6dfe1b94ff2428d4e3f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800316}
-
Andres Calderon Jaramillo authored
This CL renews the "enable-vaapi-jpeg-image-decode-acceleration" and "enable-vaapi-webp-image-decode-acceleration" flags which are still useful to experiment with the JPEG and WebP hardware decode path in Chrome OS (not launched yet). Bug: None. Test: None. Change-Id: Id314de274805667c05c5d340a58c0e0ad254be25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367733Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800315}
-
Lan Wei authored
We have replaced ContinuousMouseScrollBy with gpubenchmarking.smoothscrollbyXY to simulate scroll actions, now we can remove it from eventsender. Bug: 1047176 Change-Id: I770c2ba9a8a79f875d46be379ceec533b65e837d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361184Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800314}
-
Russ Hamilton authored
Instrument RTCIceCandidate.{address,candidate,port,relatedAddress,relatedPort} for web Identifiability study. Bug: 973801 Change-Id: If0783bc203c996cf7603b47395e1f628905ac9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359735 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#800313}
-